145205 2015-05-19 22:51:24 -0700 Add some assertions about the CFG in the loop pre-header creation phase 2015-05-20 11:41:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 145204 1 fpizlo fpizlo barraclough basile_clement benjamin ggaren mark.lam mhahnenb mmirman msaboff nrotem oliver saam sam oldest_to_newest 1096182 0 fpizlo 2015-05-19 22:51:24 -0700 If any of these properties turned out to be false, it would just lead to a bizarre failure elsewhere (like the LICM phase), so we might as well assert these things here. 1096185 1 253429 fpizlo 2015-05-19 22:55:55 -0700 Created attachment 253429 the patch 1096293 2 253429 ggaren 2015-05-20 11:10:30 -0700 Comment on attachment 253429 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=253429&action=review r=me > Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:133 > + // We should validate the pre-header. If we places forExit origins on nodes only if places => placed > Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:135 > + // has a forExit. We should disable hoisting to pre-headers that don't validate. has => had 1096306 3 fpizlo 2015-05-20 11:41:07 -0700 Landed in http://trac.webkit.org/changeset/184646 253429 2015-05-19 22:55:55 -0700 2015-05-20 11:10:30 -0700 the patch blah.patch text/plain 4074 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NjE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE1LTA1LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QWRkIHNvbWUgYXNzZXJ0aW9ucyBhYm91dCB0aGUgQ0ZHIGluIHRoZSBsb29wIHByZS1oZWFkZXIg Y3JlYXRpb24gcGhhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NTIwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgKiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlND OjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpjdXJyZW50Tm9kZU9yaWdpbik6IEFkZCBhIEZJWE1FLgor ICAgICAgICAqIGRmZy9ERkdMSUNNUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkxJQ01Q aGFzZTo6cnVuKTogQWRkIGEgRklYTUUuCisgICAgICAgICogZGZnL0RGR0xvb3BQcmVIZWFkZXJD cmVhdGlvblBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpMb29wUHJlSGVhZGVyQ3JlYXRp b25QaGFzZTo6cnVuKTogQWRkIHRoZSBhc3NlcnRpb25zLgorCiAyMDE1LTA1LTE5ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBTcGVlZCB1cCBVUkwg ZW5jb2RlL2RlY29kZSBieSB1c2luZyBiaXRtYXBzIGluc3RlYWQgb2Ygc3RyY2hyKCkuCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAko cmV2aXNpb24gMTg0NjE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29k ZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwNyw2ICs2MDcsOCBAQCBwcml2YXRlOgog CiAgICAgTm9kZU9yaWdpbiBjdXJyZW50Tm9kZU9yaWdpbigpCiAgICAgeworICAgICAgICAvLyBG SVhNRTogV2Ugc2hvdWxkIHNldCB0aGUgZm9yRXhpdCBvcmlnaW4gb25seSBvbiB0aG9zZSBub2Rl cyB0aGF0IGNhbiBleGl0LgorICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ1MjA0CiAgICAgICAgIGlmIChtX2N1cnJlbnRTZW1hbnRpY09yaWdpbi5p c1NldCgpKQogICAgICAgICAgICAgcmV0dXJuIE5vZGVPcmlnaW4obV9jdXJyZW50U2VtYW50aWNP cmlnaW4sIGN1cnJlbnRDb2RlT3JpZ2luKCkpOwogICAgICAgICByZXR1cm4gTm9kZU9yaWdpbihj dXJyZW50Q29kZU9yaWdpbigpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH TElDTVBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0xJQ01QaGFzZS5jcHAJKHJldmlzaW9uIDE4NDYxNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHTElDTVBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMwLDYgKzEzMCwxMiBA QCBwdWJsaWM6CiAgICAgICAgICAgICAKICAgICAgICAgICAgIERGR19BU1NFUlQobV9ncmFwaCwg cHJlSGVhZGVyLT50ZXJtaW5hbCgpLCBwcmVIZWFkZXItPnRlcm1pbmFsKCktPm9wKCkgPT0gSnVt cCk7CiAgICAgICAgICAgICAKKyAgICAgICAgICAgIC8vIFdlIHNob3VsZCB2YWxpZGF0ZSB0aGUg cHJlLWhlYWRlci4gSWYgd2UgcGxhY2VzIGZvckV4aXQgb3JpZ2lucyBvbiBub2RlcyBvbmx5IGlm CisgICAgICAgICAgICAvLyBhdCB0aGUgdG9wIG9mIHRoYXQgbm9kZSBpdCBpcyBsZWdhbCB0byBl eGl0LCB0aGVuIHdlIHdvdWxkIHNpbXBseSBjaGVjayBpZiBKdW1wCisgICAgICAgICAgICAvLyBo YXMgYSBmb3JFeGl0LiBXZSBzaG91bGQgZGlzYWJsZSBob2lzdGluZyB0byBwcmUtaGVhZGVycyB0 aGF0IGRvbid0IHZhbGlkYXRlLgorICAgICAgICAgICAgLy8gT3IsIHdlIGNvdWxkIG9ubHkgYWxs b3cgaG9pc3Rpbmcgb2YgdGhpbmdzIHRoYXQgZGVmaW5pdGVseSBkb24ndCBleGl0LgorICAgICAg ICAgICAgLy8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDUyMDQKKyAgICAgICAgICAgIAogICAgICAgICAgICAgZGF0YS5wcmVIZWFkZXIgPSBwcmVIZWFk ZXI7CiAgICAgICAgIH0KICAgICAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0xvb3BQcmVIZWFkZXJDcmVhdGlvblBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0xvb3BQcmVIZWFkZXJDcmVhdGlvblBoYXNlLmNwcAkocmV2 aXNpb24gMTg0NjE0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdMb29wUHJlSGVh ZGVyQ3JlYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4LDExICs4OCwyMyBAQCBw dWJsaWM6CiAgICAgICAgICAgICAgICAgICAgIGV4aXN0aW5nUHJlSGVhZGVyID0gcHJlZGVjZXNz b3I7CiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIH0KLSAg ICAgICAgICAgICAgICBpZiAoZXhpc3RpbmdQcmVIZWFkZXIgPT0gcHJlZGVjZXNzb3IpCi0gICAg ICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIC8vIFdlIHdvbid0IGhh dmUgZHVwbGljYXRlIGVudHJpZXMgaW4gdGhlIHByZWRlY2Vzc29ycyBsaXN0LgorICAgICAgICAg ICAgICAgIERGR19BU1NFUlQobV9ncmFwaCwgbnVsbHB0ciwgZXhpc3RpbmdQcmVIZWFkZXIgIT0g cHJlZGVjZXNzb3IpOwogICAgICAgICAgICAgICAgIG5lZWRzTmV3UHJlSGVhZGVyID0gdHJ1ZTsK ICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAg ICAgICAgICAgLy8gVGhpcyBwaGFzZSBzaG91bGQgb25seSBiZSBydW4gb24gYSBERkcgd2hlcmUg dW5yZWFjaGFibGUgYmxvY2tzIGhhdmUgYmVlbiBwcnVuZWQuCisgICAgICAgICAgICAvLyBXZSBh bHNvIGRvbid0IGFsbG93IGxvb3BzIGJhY2sgdG8gcm9vdC4gVGhpcyBtZWFucyB0aGF0IGV2ZXJ5 IGxvb3AgaGVhZGVyIGhhcyBnb3QKKyAgICAgICAgICAgIC8vIHRvIGhhdmUgYSBwcmUtaGVhZGVy LgorICAgICAgICAgICAgREZHX0FTU0VSVChtX2dyYXBoLCBudWxscHRyLCBleGlzdGluZ1ByZUhl YWRlcik7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIC8vIFdlIGFyZSBsb29raW5nIGF0IHRo ZSBwcmVkZWNlc3NvcnMgb2YgYSBsb29wIGhlYWRlci4gQSBsb29wIGhlYWRlciBoYXMgdG8gaGF2 ZQorICAgICAgICAgICAgLy8gc29tZSBwcmVkZWNlc3NvciBvdGhlciB0aGFuIHRoZSBwcmUtaGVh ZGVyLiBXZSBtdXN0IGhhdmUgYnJva2VuIGNyaXRpY2FsIGVkZ2VzCisgICAgICAgICAgICAvLyBi ZWNhdXNlIHRoYXQgaXMgdGhlIERGRyBTU0EgY29udmVudGlvbi4gVGhlcmVmb3JlLCBlYWNoIHBy ZWRlY2Vzc29yIG9mIHRoZSBsb29wCisgICAgICAgICAgICAvLyBoZWFkZXIgbXVzdCBoYXZlIG9u bHkgb25lIHN1Y2Nlc3Nvci4KKyAgICAgICAgICAgIERGR19BU1NFUlQobV9ncmFwaCwgbnVsbHB0 ciwgZXhpc3RpbmdQcmVIZWFkZXItPnRlcm1pbmFsKCktPm9wKCkgPT0gSnVtcCk7CisgICAgICAg ICAgICAKICAgICAgICAgICAgIGlmICghbmVlZHNOZXdQcmVIZWFkZXIpCiAgICAgICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgICAgICAK