145186 2015-05-19 14:39:20 -0700 Crash under WebCore::invalidateStyleRecursively 2015-05-19 22:29:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned kling oldest_to_newest 1096054 0 koivisto 2015-05-19 14:39:20 -0700 There are reports about crashes where we run out of stack under invalidateStyleRecursively. 1096063 1 253406 koivisto 2015-05-19 14:59:10 -0700 Created attachment 253406 patch 1096071 2 koivisto 2015-05-19 15:16:43 -0700 rdar://problem/19736838 1096153 3 253406 kling 2015-05-19 21:12:32 -0700 Comment on attachment 253406 patch View in context: https://bugs.webkit.org/attachment.cgi?id=253406&action=review r=me > Source/WebCore/css/StyleInvalidationAnalysis.cpp:120 > + Vector<Element*> parentStack; I'd slap some inline capacity on this Vector. 1096176 4 koivisto 2015-05-19 22:29:07 -0700 https://trac.webkit.org/r184615 253406 2015-05-19 14:59:10 -0700 2015-05-19 21:12:32 -0700 patch styleinvalidationanalysis-iterative.patch text/plain 4410 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDU5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTA1LTE5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJDb3Jl OjppbnZhbGlkYXRlU3R5bGVSZWN1cnNpdmVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2ZSBzZWVuIGNyYXNoZXMgd2hlcmUgd2UgcnVuIG91 dCBvZiBzdGFjayB1bmRlciBpbnZhbGlkYXRlU3R5bGVSZWN1cnNpdmVseSBpbiBTdHlsZUludmFs aWRhdGlvbkFuYWx5c2lzCisgICAgICAgIG9uIHNvbWUgZGV2aWNlcy4KKworICAgICAgICBTd2l0 Y2ggdG8gaXRlcmF0aXZlIGFsZ29yaXRobS4KKworICAgICAgICAqIGNzcy9TdHlsZUludmFsaWRh dGlvbkFuYWx5c2lzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlSW52YWxpZGF0aW9uQW5h bHlzaXM6OlN0eWxlSW52YWxpZGF0aW9uQW5hbHlzaXMpOgorICAgICAgICAoV2ViQ29yZTo6aW52 YWxpZGF0ZUlmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OmludmFsaWRhdGVTdHlsZUZvclRy ZWUpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVJbnZhbGlkYXRpb25BbmFseXNpczo6aW52YWxp ZGF0ZVN0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OmludmFsaWRhdGVTdHlsZVJlY3Vyc2l2ZWx5 KTogRGVsZXRlZC4KKwogMjAxNS0wNS0xOSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBTY3JvbGwtc25hcCBhbmltYXRpb25zIHNob3VsZCBub3Qgc3RhcnQg b24gYXhlcyB3aXRoIHplcm8tZGVsdGEKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZUlu dmFsaWRhdGlvbkFuYWx5c2lzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVJbnZhbGlkYXRpb25BbmFseXNpcy5jcHAJKHJldmlzaW9uIDE4NDU3OSkKKysrIFNvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZUludmFsaWRhdGlvbkFuYWx5c2lzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODgsMjYgKzg4LDY1IEBAIFN0eWxlSW52YWxpZGF0aW9uQW5hbHlzaXM6OlN0eWxlSW52 YWxpZGEKICAgICAgICAgbV9kaXJ0aWVzQWxsU3R5bGUgPSB0cnVlOwogfQogCi1zdGF0aWMgdm9p ZCBpbnZhbGlkYXRlU3R5bGVSZWN1cnNpdmVseShFbGVtZW50JiBlbGVtZW50LCBTZWxlY3RvckZp bHRlciYgZmlsdGVyLCBjb25zdCBEb2N1bWVudFJ1bGVTZXRzJiBydWxlU2V0cykKK2VudW0gY2xh c3MgQ2hlY2tEZXNjZW5kYW50cyB7IFllcywgTm8gfTsKK3N0YXRpYyBDaGVja0Rlc2NlbmRhbnRz IGludmFsaWRhdGVJZk5lZWRlZChFbGVtZW50JiBlbGVtZW50LCBTZWxlY3RvckZpbHRlciYgZmls dGVyLCBjb25zdCBEb2N1bWVudFJ1bGVTZXRzJiBydWxlU2V0cykKIHsKLSAgICBpZiAoZWxlbWVu dC5zdHlsZUNoYW5nZVR5cGUoKSA+IElubGluZVN0eWxlQ2hhbmdlKQotICAgICAgICByZXR1cm47 Ci0gICAgaWYgKGVsZW1lbnQuc3R5bGVDaGFuZ2VUeXBlKCkgPT0gTm9TdHlsZUNoYW5nZSkgewor ICAgIHN3aXRjaCAoZWxlbWVudC5zdHlsZUNoYW5nZVR5cGUoKSkgeworICAgIGNhc2UgTm9TdHls ZUNoYW5nZTogewogICAgICAgICBFbGVtZW50UnVsZUNvbGxlY3RvciBydWxlQ29sbGVjdG9yKGVs ZW1lbnQsIG51bGxwdHIsIHJ1bGVTZXRzLCBmaWx0ZXIpOwogICAgICAgICBydWxlQ29sbGVjdG9y LnNldE1vZGUoU2VsZWN0b3JDaGVja2VyOjpNb2RlOjpDb2xsZWN0aW5nUnVsZXNJZ25vcmluZ1Zp cnR1YWxQc2V1ZG9FbGVtZW50cyk7CiAgICAgICAgIHJ1bGVDb2xsZWN0b3IubWF0Y2hBdXRob3JS dWxlcyhmYWxzZSk7CiAKICAgICAgICAgaWYgKHJ1bGVDb2xsZWN0b3IuaGFzTWF0Y2hlZFJ1bGVz KCkpCiAgICAgICAgICAgICBlbGVtZW50LnNldE5lZWRzU3R5bGVSZWNhbGMoSW5saW5lU3R5bGVD aGFuZ2UpOworICAgICAgICByZXR1cm4gQ2hlY2tEZXNjZW5kYW50czo6WWVzOworICAgIH0KKyAg ICBjYXNlIElubGluZVN0eWxlQ2hhbmdlOgorICAgICAgICByZXR1cm4gQ2hlY2tEZXNjZW5kYW50 czo6WWVzOworICAgIGNhc2UgRnVsbFN0eWxlQ2hhbmdlOgorICAgIGNhc2UgU3ludGhldGljU3R5 bGVDaGFuZ2U6CisgICAgY2FzZSBSZWNvbnN0cnVjdFJlbmRlclRyZWU6CisgICAgICAgIHJldHVy biBDaGVja0Rlc2NlbmRhbnRzOjpObzsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CisgICAgcmV0dXJuIENoZWNrRGVzY2VuZGFudHM6OlllczsKK30KIAotICAgIGF1dG8gY2hpbGRy ZW4gPSBjaGlsZHJlbk9mVHlwZTxFbGVtZW50PihlbGVtZW50KTsKLSAgICBpZiAoIWNoaWxkcmVu LmZpcnN0KCkpCitzdGF0aWMgdm9pZCBpbnZhbGlkYXRlU3R5bGVGb3JUcmVlKEVsZW1lbnQmIHJv b3QsIFNlbGVjdG9yRmlsdGVyJiBmaWx0ZXIsIGNvbnN0IERvY3VtZW50UnVsZVNldHMmIHJ1bGVT ZXRzKQoreworICAgIGlmIChpbnZhbGlkYXRlSWZOZWVkZWQocm9vdCwgZmlsdGVyLCBydWxlU2V0 cykgPT0gQ2hlY2tEZXNjZW5kYW50czo6Tm8pCiAgICAgICAgIHJldHVybjsKLSAgICBmaWx0ZXIu cHVzaFBhcmVudCgmZWxlbWVudCk7Ci0gICAgZm9yIChhdXRvJiBjaGlsZCA6IGNoaWxkcmVuKQot ICAgICAgICBpbnZhbGlkYXRlU3R5bGVSZWN1cnNpdmVseShjaGlsZCwgZmlsdGVyLCBydWxlU2V0 cyk7Ci0gICAgZmlsdGVyLnBvcFBhcmVudCgpOworCisgICAgVmVjdG9yPEVsZW1lbnQqPiBwYXJl bnRTdGFjazsKKyAgICBFbGVtZW50KiBwcmV2aW91c0VsZW1lbnQgPSAmcm9vdDsKKyAgICBhdXRv IGRlc2NlbmRhbnRzID0gZGVzY2VuZGFudHNPZlR5cGU8RWxlbWVudD4ocm9vdCk7CisgICAgZm9y IChhdXRvIGl0ID0gZGVzY2VuZGFudHMuYmVnaW4oKSwgZW5kID0gZGVzY2VuZGFudHMuZW5kKCk7 IGl0ICE9IGVuZDspIHsKKyAgICAgICAgYXV0byYgZGVzY2VuZGFudCA9ICppdDsKKyAgICAgICAg YXV0byogcGFyZW50ID0gZGVzY2VuZGFudC5wYXJlbnRFbGVtZW50KCk7CisgICAgICAgIGlmIChw YXJlbnRTdGFjay5pc0VtcHR5KCkgfHwgcGFyZW50U3RhY2subGFzdCgpICE9IHBhcmVudCkgewor ICAgICAgICAgICAgaWYgKHBhcmVudCA9PSBwcmV2aW91c0VsZW1lbnQpIHsKKyAgICAgICAgICAg ICAgICBwYXJlbnRTdGFjay5hcHBlbmQocGFyZW50KTsKKyAgICAgICAgICAgICAgICBmaWx0ZXIu cHVzaFBhcmVudChwYXJlbnQpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAg ICB3aGlsZSAocGFyZW50U3RhY2subGFzdCgpICE9IHBhcmVudCkgeworICAgICAgICAgICAgICAg ICAgICBwYXJlbnRTdGFjay5yZW1vdmVMYXN0KCk7CisgICAgICAgICAgICAgICAgICAgIGZpbHRl ci5wb3BQYXJlbnQoKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAg IH0KKworICAgICAgICBwcmV2aW91c0VsZW1lbnQgPSAmZGVzY2VuZGFudDsKKworICAgICAgICBp ZiAoaW52YWxpZGF0ZUlmTmVlZGVkKGRlc2NlbmRhbnQsIGZpbHRlciwgcnVsZVNldHMpID09IENo ZWNrRGVzY2VuZGFudHM6OlllcykKKyAgICAgICAgICAgIGl0LnRyYXZlcnNlTmV4dCgpOworICAg ICAgICBlbHNlCisgICAgICAgICAgICBpdC50cmF2ZXJzZU5leHRTa2lwcGluZ0NoaWxkcmVuKCk7 CisgICAgfQorCisgICAgd2hpbGUgKCFwYXJlbnRTdGFjay5pc0VtcHR5KCkpIHsKKyAgICAgICAg cGFyZW50U3RhY2sucmVtb3ZlTGFzdCgpOworICAgICAgICBmaWx0ZXIucG9wUGFyZW50KCk7Cisg ICAgfQogfQogCiB2b2lkIFN0eWxlSW52YWxpZGF0aW9uQW5hbHlzaXM6OmludmFsaWRhdGVTdHls ZShEb2N1bWVudCYgZG9jdW1lbnQpCkBAIC0xMjIsNyArMTYxLDcgQEAgdm9pZCBTdHlsZUludmFs aWRhdGlvbkFuYWx5c2lzOjppbnZhbGlkYQogCiAgICAgU2VsZWN0b3JGaWx0ZXIgZmlsdGVyOwog ICAgIGZpbHRlci5zZXR1cFBhcmVudFN0YWNrKGRvY3VtZW50RWxlbWVudCk7Ci0gICAgaW52YWxp ZGF0ZVN0eWxlUmVjdXJzaXZlbHkoKmRvY3VtZW50RWxlbWVudCwgZmlsdGVyLCBtX3J1bGVTZXRz KTsKKyAgICBpbnZhbGlkYXRlU3R5bGVGb3JUcmVlKCpkb2N1bWVudEVsZW1lbnQsIGZpbHRlciwg bV9ydWxlU2V0cyk7CiB9CiAKIH0K