145177 2015-05-19 13:28:45 -0700 Web Inspector: Improve Preview for NodeList / array like collections 2015-05-19 17:36:05 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev rmondello timothy webkit-bug-importer oldest_to_newest 1096016 0 joepeck 2015-05-19 13:28:45 -0700 * SUMMARY Improve Preview for NodeList / array like collections * ACTUAL js> document.querySelectorAll("nothing") <- ▶︎ [item: function] (0) = $1 * EXPECTED js> document.querySelectorAll("nothing") <- NodeList [] (0) = $1 * NOTES - Show just indices. Previously we only skipped "length" and "constructor". Now for any "array" subtype, just get indices. - I think we should show the Array type name (e.g. NodeList) next to the array, to show this is not an actual "Array" Array - For simplicity, I think we should aim for making these lossless even if there are non-index properties. I don't have a good counter-example yet. The closest I've seen in Int8Array and other TypedArrays where you might want to allow expansion to see the arrayBuffer, etc. Worst case, console.dir() will allow expanding in that case, or a large list. 1096017 1 joepeck 2015-05-19 13:29:00 -0700 <rdar://problem/20537340> 1096019 2 253393 joepeck 2015-05-19 13:35:07 -0700 Created attachment 253393 [PATCH] Proposed Fix 1096022 3 253393 joepeck 2015-05-19 13:38:39 -0700 Comment on attachment 253393 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253393&action=review > Source/JavaScriptCore/inspector/InjectedScriptSource.js:1058 > + // For arrays, only allow indexes. > + if (this.subtype === "array" && !isUInt32(name)) > continue; This is what we may want to change to be something like: if (this.subtype === "array" && !isUInt32(name)) { if (name !== "length" && "value" in descriptor && typeof descriptor.value !== "function") preview.lossless = false; continue; } Which would mean "if there is an array type and it has a value property that is not a function allow it to be expanded". I'm on the fence about this. 1096077 4 253393 joepeck 2015-05-19 15:51:37 -0700 Comment on attachment 253393 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253393&action=review >> Source/JavaScriptCore/inspector/InjectedScriptSource.js:1058 >> continue; > > This is what we may want to change to be something like: > > if (this.subtype === "array" && !isUInt32(name)) { > if (name !== "length" && "value" in descriptor && typeof descriptor.value !== "function") > preview.lossless = false; > continue; > } > > Which would mean "if there is an array type and it has a value property that is not a function allow it to be expanded". > > I'm on the fence about this. Given we can't even see non-index properties in ObjectTreeViews at all I'm no longer on the fence. We should address non-index property handling in bug 145190. I've expanded on this in that description. 1096090 5 253393 timothy 2015-05-19 16:47:14 -0700 Comment on attachment 253393 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253393&action=review >>> Source/JavaScriptCore/inspector/InjectedScriptSource.js:1058 >>> continue; >> >> This is what we may want to change to be something like: >> >> if (this.subtype === "array" && !isUInt32(name)) { >> if (name !== "length" && "value" in descriptor && typeof descriptor.value !== "function") >> preview.lossless = false; >> continue; >> } >> >> Which would mean "if there is an array type and it has a value property that is not a function allow it to be expanded". >> >> I'm on the fence about this. > > Given we can't even see non-index properties in ObjectTreeViews at all I'm no longer on the fence. > > We should address non-index property handling in bug 145190. I've expanded on this in that description. Makes sense to me. I think we should have a way to see these properties on expand, which bug 145190 covers. 1096100 6 253393 commit-queue 2015-05-19 17:36:00 -0700 Comment on attachment 253393 [PATCH] Proposed Fix Clearing flags on attachment: 253393 Committed r184602: <http://trac.webkit.org/changeset/184602> 1096101 7 commit-queue 2015-05-19 17:36:05 -0700 All reviewed patches have been landed. Closing bug. 253393 2015-05-19 13:35:07 -0700 2015-05-19 17:36:00 -0700 [PATCH] Proposed Fix node-list-fix.patch text/plain 7674 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MDJkZmU0Li5hYTZhOWUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDUt MTkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBJbXByb3ZlIFByZXZpZXcgZm9yIE5vZGVMaXN0IC8gYXJyYXkgbGlrZSBjb2xs ZWN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ1MTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQ6CisKIDIwMTUtMDUt MTkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBNZXJnZWQgYW5v bnltb3VzIGJsb2NrcyBzaG91bGQgaW52YWxpZGF0ZSBzaW1wbGUgbGluZSBsYXlvdXQgcGF0aC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0LWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9tb2RlbC9yZW1vdGUtb2JqZWN0LWV4 cGVjdGVkLnR4dAppbmRleCBmNzhiMDFhLi40NWJiNzI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvbW9kZWwvcmVtb3RlLW9iamVjdC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL21vZGVsL3JlbW90ZS1vYmplY3QtZXhwZWN0ZWQudHh0CkBAIC0xNTc4 LDcgKzE1NzgsNyBAQCBFWFBSRVNTSU9OOiBuZXcgSW50MzJBcnJheShuZXcgQXJyYXlCdWZmZXIo MTYpKQogICAgICJfdHlwZSI6ICJvYmplY3QiLAogICAgICJfc3VidHlwZSI6ICJhcnJheSIsCiAg ICAgIl9kZXNjcmlwdGlvbiI6ICJJbnQzMkFycmF5IiwKLSAgICAiX2xvc3NsZXNzIjogZmFsc2Us CisgICAgIl9sb3NzbGVzcyI6IHRydWUsCiAgICAgIl9vdmVyZmxvdyI6IGZhbHNlLAogICAgICJf c2l6ZSI6IDQsCiAgICAgIl9wcm9wZXJ0aWVzIjogWwpAQCAtMTYwMSwyMSArMTYwMSw2IEBAIEVY UFJFU1NJT046IG5ldyBJbnQzMkFycmF5KG5ldyBBcnJheUJ1ZmZlcigxNikpCiAgICAgICAgICJf bmFtZSI6ICIzIiwKICAgICAgICAgIl90eXBlIjogIm51bWJlciIsCiAgICAgICAgICJfdmFsdWUi OiAiMCIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJieXRlT2Zmc2V0IiwK LSAgICAgICAgIl90eXBlIjogIm51bWJlciIsCi0gICAgICAgICJfdmFsdWUiOiAiMCIKLSAgICAg IH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFtZSI6ICJieXRlTGVuZ3RoIiwKLSAgICAgICAgIl90 eXBlIjogIm51bWJlciIsCi0gICAgICAgICJfdmFsdWUiOiAiMTYiCi0gICAgICB9LAotICAgICAg ewotICAgICAgICAiX25hbWUiOiAiYnVmZmVyIiwKLSAgICAgICAgIl90eXBlIjogIm9iamVjdCIs Ci0gICAgICAgICJfdmFsdWUiOiAiQXJyYXlCdWZmZXIiCiAgICAgICB9CiAgICAgXSwKICAgICAi X2VudHJpZXMiOiBudWxsCkBAIC0xNjM0LDcgKzE2MTksNyBAQCBFWFBSRVNTSU9OOiB2YXIgaW50 QXJyYXkgPSBuZXcgSW50MzJBcnJheShuZXcgQXJyYXlCdWZmZXIoMTYpKTsgZm9yICh2YXIgaSA9 IDA7CiAgICAgIl90eXBlIjogIm9iamVjdCIsCiAgICAgIl9zdWJ0eXBlIjogImFycmF5IiwKICAg ICAiX2Rlc2NyaXB0aW9uIjogIkludDMyQXJyYXkiLAotICAgICJfbG9zc2xlc3MiOiBmYWxzZSwK KyAgICAiX2xvc3NsZXNzIjogdHJ1ZSwKICAgICAiX292ZXJmbG93IjogZmFsc2UsCiAgICAgIl9z aXplIjogNCwKICAgICAiX3Byb3BlcnRpZXMiOiBbCkBAIC0xNjU3LDIxICsxNjQyLDYgQEAgRVhQ UkVTU0lPTjogdmFyIGludEFycmF5ID0gbmV3IEludDMyQXJyYXkobmV3IEFycmF5QnVmZmVyKDE2 KSk7IGZvciAodmFyIGkgPSAwOwogICAgICAgICAiX25hbWUiOiAiMyIsCiAgICAgICAgICJfdHlw ZSI6ICJudW1iZXIiLAogICAgICAgICAiX3ZhbHVlIjogIjMiCi0gICAgICB9LAotICAgICAgewot ICAgICAgICAiX25hbWUiOiAiYnl0ZU9mZnNldCIsCi0gICAgICAgICJfdHlwZSI6ICJudW1iZXIi LAotICAgICAgICAiX3ZhbHVlIjogIjAiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAiX25h bWUiOiAiYnl0ZUxlbmd0aCIsCi0gICAgICAgICJfdHlwZSI6ICJudW1iZXIiLAotICAgICAgICAi X3ZhbHVlIjogIjE2IgotICAgICAgfSwKLSAgICAgIHsKLSAgICAgICAgIl9uYW1lIjogImJ1ZmZl ciIsCi0gICAgICAgICJfdHlwZSI6ICJvYmplY3QiLAotICAgICAgICAiX3ZhbHVlIjogIkFycmF5 QnVmZmVyIgogICAgICAgfQogICAgIF0sCiAgICAgIl9lbnRyaWVzIjogbnVsbApAQCAtMjI5Nywx NiArMjI2Nyw2IEBAIEVYUFJFU1NJT046IGRvY3VtZW50LmhlYWQuY2hpbGRyZW4KICAgICAgICAg Il90eXBlIjogIm9iamVjdCIsCiAgICAgICAgICJfc3VidHlwZSI6ICJub2RlIiwKICAgICAgICAg Il92YWx1ZSI6ICJzY3JpcHQiCi0gICAgICB9LAotICAgICAgewotICAgICAgICAiX25hbWUiOiAi aXRlbSIsCi0gICAgICAgICJfdHlwZSI6ICJmdW5jdGlvbiIsCi0gICAgICAgICJfdmFsdWUiOiAi IgotICAgICAgfSwKLSAgICAgIHsKLSAgICAgICAgIl9uYW1lIjogIm5hbWVkSXRlbSIsCi0gICAg ICAgICJfdHlwZSI6ICJmdW5jdGlvbiIsCi0gICAgICAgICJfdmFsdWUiOiAiIgogICAgICAgfQog ICAgIF0sCiAgICAgIl9lbnRyaWVzIjogbnVsbApAQCAtMjM0NiwxNiArMjMwNiw2IEBAIEVYUFJF U1NJT046IGRvY3VtZW50LmdldEVsZW1lbnRzQnlDbGFzc05hbWUoJ215LXRlc3QnKQogICAgICAg ICAiX3R5cGUiOiAib2JqZWN0IiwKICAgICAgICAgIl9zdWJ0eXBlIjogIm5vZGUiLAogICAgICAg ICAiX3ZhbHVlIjogInAubXktdGVzdCIKLSAgICAgIH0sCi0gICAgICB7Ci0gICAgICAgICJfbmFt ZSI6ICJjb25zdHJ1Y3RvciIsCi0gICAgICAgICJfdHlwZSI6ICJvYmplY3QiLAotICAgICAgICAi X3ZhbHVlIjogIk5vZGVMaXN0Q29uc3RydWN0b3IiCi0gICAgICB9LAotICAgICAgewotICAgICAg ICAiX25hbWUiOiAiaXRlbSIsCi0gICAgICAgICJfdHlwZSI6ICJmdW5jdGlvbiIsCi0gICAgICAg ICJfdmFsdWUiOiAiIgogICAgICAgfQogICAgIF0sCiAgICAgIl9lbnRyaWVzIjogbnVsbApAQCAt MjM5NSwxNiArMjM0NSw2IEBAIEVYUFJFU1NJT046IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwo Jy5teS10ZXN0JykKICAgICAgICAgIl90eXBlIjogIm9iamVjdCIsCiAgICAgICAgICJfc3VidHlw ZSI6ICJub2RlIiwKICAgICAgICAgIl92YWx1ZSI6ICJwLm15LXRlc3QiCi0gICAgICB9LAotICAg ICAgewotICAgICAgICAiX25hbWUiOiAiY29uc3RydWN0b3IiLAotICAgICAgICAiX3R5cGUiOiAi b2JqZWN0IiwKLSAgICAgICAgIl92YWx1ZSI6ICJOb2RlTGlzdENvbnN0cnVjdG9yIgotICAgICAg fSwKLSAgICAgIHsKLSAgICAgICAgIl9uYW1lIjogIml0ZW0iLAotICAgICAgICAiX3R5cGUiOiAi ZnVuY3Rpb24iLAotICAgICAgICAiX3ZhbHVlIjogIiIKICAgICAgIH0KICAgICBdLAogICAgICJf ZW50cmllcyI6IG51bGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDA1MmQxZWUuLmE5ZjIx YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTE5 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogSW1wcm92ZSBQcmV2aWV3IGZvciBOb2RlTGlzdCAvIGFycmF5IGxpa2UgY29sbGVj dGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NTE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3Jp cHQuUmVtb3RlT2JqZWN0LnByb3RvdHlwZS5fYXBwZW5kUHJvcGVydHlQcmV2aWV3cyk6CisgICAg ICAgIEZvciAiYXJyYXkiIGxpa2Ugb2JqZWN0IHByZXZpZXdzIHNraXAgb3ZlciBub24taW5kZXgg cHJvcGVydGllcy4KKyAgICAgICAgV2UgYXJlIG5vdCBtYXJraW5nIHRoZSBvYmplY3QgYXMgbG9z c2xlc3MgYnkgY2hvaWNlLCBidXQgd2UKKyAgICAgICAgbWF5IHJldHVybiB0byB0aGlzIGRlY2lz aW9uIGxhdGVyLgorCiAyMDE1LTA1LTE5ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KIAogICAgICAgICBHaXZlIEpTU3RyaW5nIGEgU3RyaW5nVmlldyBnZXR0ZXIgYW5kIHN0YXJ0 IHVzaW5nIGl0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9J bmplY3RlZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv SW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKaW5kZXggMWRiNWY1NS4uMDAyYTBjMyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5q cworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291 cmNlLmpzCkBAIC0xMDUzLDEyICsxMDUzLDEyIEBAIEluamVjdGVkU2NyaXB0LlJlbW90ZU9iamVj dC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAobmFtZSA9PT0gIl9fcHJvdG9fXyIpCiAg ICAgICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgICAgIC8vIERvIG5vdCBzaG93ICJs ZW5ndGgiIG9uIGFycmF5IGxpa2Ugb2JqZWN0cyBpbiBwcmV2aWV3LgotICAgICAgICAgICAgaWYg KHRoaXMuc3VidHlwZSA9PT0gImFycmF5IiAmJiBuYW1lID09PSAibGVuZ3RoIikKKyAgICAgICAg ICAgIC8vIEZvciBhcnJheXMsIG9ubHkgYWxsb3cgaW5kZXhlcy4KKyAgICAgICAgICAgIGlmICh0 aGlzLnN1YnR5cGUgPT09ICJhcnJheSIgJiYgIWlzVUludDMyKG5hbWUpKQogICAgICAgICAgICAg ICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICAvLyBEbyBub3Qgc2hvdyBub24tZW51bWVyYWJs ZSBub24tb3duIHByb3BlcnRpZXMuIFNwZWNpYWwgY2FzZSB0byBhbGxvdyBhcnJheSBpbmRleGVz IHRoYXQgbWF5IGJlIG9uIHRoZSBwcm90b3R5cGUuCi0gICAgICAgICAgICBpZiAoIWRlc2NyaXB0 b3IuZW51bWVyYWJsZSAmJiAhZGVzY3JpcHRvci5pc093biAmJiAhKHRoaXMuc3VidHlwZSA9PT0g ImFycmF5IiAmJiBpc1VJbnQzMihuYW1lKSkpCisgICAgICAgICAgICBpZiAoIWRlc2NyaXB0b3Iu ZW51bWVyYWJsZSAmJiAhZGVzY3JpcHRvci5pc093biAmJiB0aGlzLnN1YnR5cGUgIT09ICJhcnJh eSIpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgICAgIC8vIElmIHdlIGhh dmUgYSBmaWx0ZXIsIG9ubHkgc2hvdyBwcm9wZXJ0aWVzIGluIHRoZSBmaWx0ZXIuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwppbmRleCA5ODY2OTBmLi5jMjgyYjRmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNS0xOSAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcHJvdmUgUHJldmll dyBmb3IgTm9kZUxpc3QgLyBhcnJheSBsaWtlIGNvbGxlY3Rpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxNzcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT2Jq ZWN0UHJldmlld1ZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0UHJldmlld1Zp ZXcucHJvdG90eXBlLl9hcHBlbmRQcmV2aWV3KToKKyAgICAgICAgU2hvdyB0aGUgY2xhc3MgbmFt ZSBmb3IgYSBub24tYmFzaWMtQXJyYXksIGJ1dCBzdGlsbCBoaWRlCisgICAgICAgIGl0IGZvciBh IGJhc2ljIEFycmF5LgorCiAyMDE1LTA1LTE5ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZA YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnZlcnQgc3RhY2tUcmFjZSBm cm9tIHJhdyBwYXlsb2FkIGRhdGEgdG8gYW4gYXJyYXkgb2YgQ2FsbEZyYW1lcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT2JqZWN0UHJldmll d1ZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmpl Y3RQcmV2aWV3Vmlldy5qcwppbmRleCA0OTBlZmFhLi4yZDMyZmE0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQcmV2aWV3Vmlldy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9PYmplY3RQ cmV2aWV3Vmlldy5qcwpAQCAtMTI1LDggKzEyNSw4IEBAIFdlYkluc3BlY3Rvci5PYmplY3RQcmV2 aWV3VmlldyA9IGNsYXNzIE9iamVjdFByZXZpZXdWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9i CiAgICAgICAgICAgICBpZiAocHJldmlldy5zdWJ0eXBlID09PSAicmVnZXhwIiB8fCBwcmV2aWV3 LnN1YnR5cGUgPT09ICJudWxsIikgewogICAgICAgICAgICAgICAgIC8vIERpc3BsYXkgbnVsbCAv IHJlZ2V4cHMgYXMgc2ltcGxlIGZvcm1hdHRlZCB2YWx1ZXMuCiAgICAgICAgICAgICAgICAgZGlz cGxheU9iamVjdEFzVmFsdWUgPSB0cnVlOwotICAgICAgICAgICAgfSAgZWxzZSBpZiAocHJldmll dy5zdWJ0eXBlICE9PSAiYXJyYXkiICYmIHByZXZpZXcuZGVzY3JpcHRpb24gIT09ICJPYmplY3Qi KSB7Ci0gICAgICAgICAgICAgICAgLy8gQ2xhc3MgbmFtZXMgZm9yIG90aGVyIG5vbi1hcnJheSAv IG5vbi1iYXNpYy1PYmplY3QgdHlwZXMuCisgICAgICAgICAgICB9IGVsc2UgaWYgKChwcmV2aWV3 LnN1YnR5cGUgPT09ICJhcnJheSIgJiYgcHJldmlldy5kZXNjcmlwdGlvbiAhPT0gIkFycmF5Iikg fHwgKHByZXZpZXcuc3VidHlwZSAhPT0gImFycmF5IiAmJiBwcmV2aWV3LmRlc2NyaXB0aW9uICE9 PSAiT2JqZWN0IikpIHsKKyAgICAgICAgICAgICAgICAvLyBDbGFzcyBuYW1lcyBmb3Igb3RoZXIg bm9uLWJhc2ljLUFycmF5IC8gbm9uLWJhc2ljLU9iamVjdCB0eXBlcy4KICAgICAgICAgICAgICAg ICB2YXIgbmFtZUVsZW1lbnQgPSBlbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVs ZW1lbnQoInNwYW4iKSk7CiAgICAgICAgICAgICAgICAgbmFtZUVsZW1lbnQuY2xhc3NOYW1lID0g Im9iamVjdC1wcmV2aWV3LW5hbWUiOwogICAgICAgICAgICAgICAgIG5hbWVFbGVtZW50LnRleHRD b250ZW50ID0gcHJldmlldy5kZXNjcmlwdGlvbiArICIgIjsK