145174 2015-05-19 06:45:15 -0700 REGRESSION(r184420): [GTK] webkit_dom_html_element_get_children has been removed 2015-05-20 00:55:42 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand svillar oldest_to_newest 1095921 0 cgarcia 2015-05-19 06:45:15 -0700 Missing API (API break!) detected in GObject DOM bindings WebKitDOMHTMLCollection* webkit_dom_html_element_get_children(WebKitDOMHTMLElement*) children property has been moved to Element, Document and DocumentFragment to match the spec, so we need to expose the new get_children and bring back webkit_dom_html_element_get_children() as deprecated. 1096205 1 253433 cgarcia 2015-05-20 00:38:21 -0700 Created attachment 253433 Patch 1096208 2 cgarcia 2015-05-20 00:55:42 -0700 Committed r184623: <http://trac.webkit.org/changeset/184623> 253433 2015-05-20 00:38:21 -0700 2015-05-20 00:49:54 -0700 Patch wkdom-children.diff text/plain 4356 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZTAxOWY1Li42Njc4NjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTUtMDUtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4NDQyMCk6IFtHVEtdIHdlYmtpdF9kb21faHRtbF9l bGVtZW50X2dldF9jaGlsZHJlbiBoYXMgYmVlbiByZW1vdmVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxNzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGlsZHJlbiBwcm9wZXJ0eSBoYXMgYmVlbiBt b3ZlZCB0byBFbGVtZW50LCBEb2N1bWVudCBhbmQKKyAgICAgICAgRG9jdW1lbnRGcmFnbWVudCB0 byBtYXRjaCB0aGUgc3BlYywgc28gd2UgbmVlZCB0byBleHBvc2UgdGhlIG5ldworICAgICAgICBn ZXRfY2hpbGRyZW4gYW5kIGJyaW5nIGJhY2sgd2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0X2No aWxkcmVuKCkKKyAgICAgICAgYXMgZGVwcmVjYXRlZC4KKworICAgICAgICAqIGJpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5jcHA6CisgICAgICAgICh3ZWJraXRfZG9tX2h0bWxf ZWxlbWVudF9nZXRfY2hpbGRyZW4pOgorICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0 RE9NRGVwcmVjYXRlZC5oOgorICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVw cmVjYXRlZC5zeW1ib2xzOgorICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3Qvd2Via2l0ZG9tLnN5 bWJvbHM6CisKIDIwMTUtMDUtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBOZXR3b3JrIENhY2hlOiBJbXBsZW1lbnQgU2hhcmVh YmxlUmVzb3VyY2UgZm9yIFNvdXAgYW5kIGVuYWJsZSBpdCBmb3IgR1RLIHBsYXRmb3JtCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURlcHJlY2F0 ZWQuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01EZXByZWNh dGVkLmNwcAppbmRleCAyMTExYTRkLi45NDQ4ZmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURlcHJlY2F0ZWQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRlZC5jcHAKQEAgLTQ0LDMg KzQ0LDkgQEAgdm9pZCB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9zZXRfb3V0ZXJfaHRtbChXZWJL aXRET01IVE1MRWxlbWVudCogc2VsZiwgY29uc3QgZ2MKICAgICBnX3JldHVybl9pZl9mYWlsKFdF QktJVF9ET01fSVNfSFRNTF9FTEVNRU5UKHNlbGYpKTsKICAgICB3ZWJraXRfZG9tX2VsZW1lbnRf c2V0X291dGVyX2h0bWwoV0VCS0lUX0RPTV9FTEVNRU5UKHNlbGYpLCBjb250ZW50cywgZXJyb3Ip OwogfQorCitXZWJLaXRET01IVE1MQ29sbGVjdGlvbiogd2Via2l0X2RvbV9odG1sX2VsZW1lbnRf Z2V0X2NoaWxkcmVuKFdlYktpdERPTUhUTUxFbGVtZW50KiBzZWxmKQoreworICAgIGdfcmV0dXJu X3ZhbF9pZl9mYWlsKFdFQktJVF9ET01fSVNfSFRNTF9FTEVNRU5UKHNlbGYpLCBudWxscHRyKTsK KyAgICByZXR1cm4gd2Via2l0X2RvbV9lbGVtZW50X2dldF9jaGlsZHJlbihXRUJLSVRfRE9NX0VM RU1FTlQoc2VsZikpOworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01EZXByZWNhdGVkLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2Jq ZWN0L1dlYktpdERPTURlcHJlY2F0ZWQuaAppbmRleCBhNmI1NWFiLi41NDQzZWU3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURlcHJlY2F0ZWQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTURlcHJlY2F0 ZWQuaApAQCAtNzAsNiArNzAsMTcgQEAgd2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0X291dGVy X2h0bWwoV2ViS2l0RE9NSFRNTEVsZW1lbnQqIHNlbGYpOwogV0VCS0lUX0RFUFJFQ0FURURfRk9S KHdlYmtpdF9kb21fZWxlbWVudF9zZXRfb3V0ZXJfaHRtbCkgdm9pZAogd2Via2l0X2RvbV9odG1s X2VsZW1lbnRfc2V0X291dGVyX2h0bWwoV2ViS2l0RE9NSFRNTEVsZW1lbnQqIHNlbGYsIGNvbnN0 IGdjaGFyKiBjb250ZW50cywgR0Vycm9yKiogZXJyb3IpOwogCisvKioKKyAqIHdlYmtpdF9kb21f aHRtbF9lbGVtZW50X2dldF9jaGlsZHJlbjoKKyAqIEBzZWxmOiBBICNXZWJLaXRET01IVE1MRWxl bWVudAorICoKKyAqIFJldHVybnM6ICh0cmFuc2ZlciBmdWxsKTogQSAjV2ViS2l0RE9NSFRNTENv bGxlY3Rpb24KKyAqCisgKiBEZXByZWNhdGVkOiAyLjEwOiBVc2Ugd2Via2l0X2RvbV9lbGVtZW50 X2dldF9jaGlsZHJlbigpIGluc3RlYWQuCisgKi8KK1dFQktJVF9ERVBSRUNBVEVEX0ZPUih3ZWJr aXRfZG9tX2VsZW1lbnRfZ2V0X2NoaWxkcmVuKSBXZWJLaXRET01IVE1MQ29sbGVjdGlvbioKK3dl YmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jaGlsZHJlbihXZWJLaXRET01IVE1MRWxlbWVudCog c2VsZik7CisKIEdfRU5EX0RFQ0xTCiAKICNlbmRpZiAvKiBXRUJLSVRfRElTQUJMRV9ERVBSRUNB VEVEICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktp dERPTURlcHJlY2F0ZWQuc3ltYm9scyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3Qv V2ViS2l0RE9NRGVwcmVjYXRlZC5zeW1ib2xzCmluZGV4IDA2NDdmMDguLjYwMWVkMTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NRGVwcmVjYXRl ZC5zeW1ib2xzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9N RGVwcmVjYXRlZC5zeW1ib2xzCkBAIC0yLDMgKzIsNCBAQCB2b2lkIHdlYmtpdF9kb21faHRtbF9l bGVtZW50X3NldF9pbm5lcl9odG1sKFdlYktpdERPTUhUTUxFbGVtZW50KiwgY29uc3QgZ2NoYXIq LAogZ2NoYXIqIHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9vdXRlcl9odG1sKFdlYktpdERP TUhUTUxFbGVtZW50KikKIGdjaGFyKiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9nZXRfaW5uZXJf aHRtbChXZWJLaXRET01IVE1MRWxlbWVudCopCiB2b2lkIHdlYmtpdF9kb21faHRtbF9lbGVtZW50 X3NldF9vdXRlcl9odG1sKFdlYktpdERPTUhUTUxFbGVtZW50KiwgY29uc3QgZ2NoYXIqLCBHRXJy b3IqKikKK1dlYktpdERPTUhUTUxDb2xsZWN0aW9uKiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9n ZXRfY2hpbGRyZW4oV2ViS2l0RE9NSFRNTEVsZW1lbnQqKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvZ29iamVjdC93ZWJraXRkb20uc3ltYm9scyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2dvYmplY3Qvd2Via2l0ZG9tLnN5bWJvbHMKaW5kZXggY2IyMjQwYS4uMzQwNGRi NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC93ZWJraXRkb20u c3ltYm9scworKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L3dlYmtpdGRvbS5z eW1ib2xzCkBAIC0xMzIsNiArMTMyLDcgQEAgZ2RvdWJsZSB3ZWJraXRfZG9tX2VsZW1lbnRfZ2V0 X2NsaWVudF90b3AoV2ViS2l0RE9NRWxlbWVudCopCiBnZG91YmxlIHdlYmtpdF9kb21fZWxlbWVu dF9nZXRfY2xpZW50X2xlZnQoV2ViS2l0RE9NRWxlbWVudCopCiBnZG91YmxlIHdlYmtpdF9kb21f ZWxlbWVudF9nZXRfY2xpZW50X2hlaWdodChXZWJLaXRET01FbGVtZW50KikKIGdkb3VibGUgd2Vi a2l0X2RvbV9lbGVtZW50X2dldF9jbGllbnRfd2lkdGgoV2ViS2l0RE9NRWxlbWVudCopCitXZWJL aXRET01IVE1MQ29sbGVjdGlvbiogd2Via2l0X2RvbV9lbGVtZW50X2dldF9jaGlsZHJlbihXZWJL aXRET01FbGVtZW50KilAMi4xMAogZ2Jvb2xlYW4gd2Via2l0X2RvbV9lbGVtZW50X2hhc19hdHRy aWJ1dGVzKFdlYktpdERPTUVsZW1lbnQqKQogZ2Jvb2xlYW4gd2Via2l0X2RvbV9lbGVtZW50X2hh c19hdHRyaWJ1dGUoV2ViS2l0RE9NRWxlbWVudCosIGNvbnN0IGdjaGFyKikKIGdib29sZWFuIHdl YmtpdF9kb21fZWxlbWVudF9oYXNfYXR0cmlidXRlX25zKFdlYktpdERPTUVsZW1lbnQqLCBjb25z dCBnY2hhciosIGNvbnN0IGdjaGFyKikK