<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>145172</bug_id>
          
          <creation_ts>2015-05-19 05:07:56 -0700</creation_ts>
          <short_desc>[SOUP] Network Cache: Disable network cache efficacy logging</short_desc>
          <delta_ts>2015-05-19 23:29:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Soup</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cdumez</cc>
    
    <cc>koivisto</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1095912</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 05:07:56 -0700</bug_when>
    <thetext>Disable it by default.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095913</commentid>
    <comment_count>1</comment_count>
      <attachid>253380</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 05:09:38 -0700</bug_when>
    <thetext>Created attachment 253380
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095922</commentid>
    <comment_count>2</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-05-19 06:55:33 -0700</bug_when>
    <thetext>Why is this required?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095930</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 08:15:07 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Why is this required?

Because we are not using it for anything, I think apple guys used this to collect some data, but also disabled it recently because they have enough info, Antti or Chris could confirm that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095932</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2015-05-19 08:17:10 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; Why is this required?
&gt; 
&gt; Because we are not using it for anything, I think apple guys used this to
&gt; collect some data, but also disabled it recently because they have enough
&gt; info, Antti or Chris could confirm that.

Might be worth putting a small bit in the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1096197</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 23:29:28 -0700</bug_when>
    <thetext>Committed r184619: &lt;http://trac.webkit.org/changeset/184619&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>253380</attachid>
            <date>2015-05-19 05:09:38 -0700</date>
            <delta_ts>2015-05-19 08:17:18 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-cache-efficacy-logging.diff</filename>
            <type>text/plain</type>
            <size>1422</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA0ZDhjZTQ2Li41NWUwMzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTUtMDUtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgorCisgICAgICAgIFtTT1VQXSBOZXR3b3JrIENhY2hlOiBEaXNhYmxlIG5ldHdvcmsgY2FjaGUg
ZWZmaWNhY3kgbG9nZ2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTQ1MTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgRGlzYWJsZSBuZXR3b3JrIGNhY2hlIGVmZmljYWN5IGxvZ2dpbmcgYnkgZGVmYXVs
dC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29sU291cC5jcHA6Cisg
ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVOZXR3b3Jr
UHJvY2Vzcyk6CisKIDIwMTUtMDUtMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K
IAogICAgICAgICBNYXJrIHN0YXRpYyB2YXJpYWJsZXMgYXMgY29uc3Qgd2hlbiBwb3NzaWJsZQpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Bvb2xT
b3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29sU291
cC5jcHAKaW5kZXggMTZiNmQ4Ny4uYzNkYjBhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Bvb2xTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3Mvc291cC9XZWJQcm9jZXNzUG9vbFNvdXAuY3BwCkBAIC00MSw2ICs0MSw5IEBA
IHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKE5l
dHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhCiAgICAgcGFyYW1ldGVycy5pZ25vcmVUTFNFcnJvcnMg
PSBtX2lnbm9yZVRMU0Vycm9yczsKICAgICBwYXJhbWV0ZXJzLmxhbmd1YWdlcyA9IFdlYkNvcmU6
OnVzZXJQcmVmZXJyZWRMYW5ndWFnZXMoKTsKICAgICBwYXJhbWV0ZXJzLnVybFNjaGVtZXNSZWdp
c3RlcmVkRm9yQ3VzdG9tUHJvdG9jb2xzID0gc3VwcGxlbWVudDxXZWJTb3VwQ3VzdG9tUHJvdG9j
b2xSZXF1ZXN0TWFuYWdlcj4oKS0+cmVnaXN0ZXJlZFNjaGVtZXNGb3JDdXN0b21Qcm90b2NvbHMo
KTsKKyNpZiBFTkFCTEUoTkVUV09SS19DQUNIRSkKKyAgICBwYXJhbWV0ZXJzLnNob3VsZEVuYWJs
ZU5ldHdvcmtDYWNoZUVmZmljYWN5TG9nZ2luZyA9IGZhbHNlOworI2VuZGlmCiB9CiAKIH0K
</data>
<flag name="review"
          id="278283"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>