145164 2015-05-19 01:55:37 -0700 AudioContext suspend/resume/close should resolve promises immediately when state is already suspended/active/closed 2015-05-20 10:02:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin jer.noble sam oldest_to_newest 1095887 0 youennf 2015-05-19 01:55:37 -0700 This is a split from https://bugs.webkit.org/show_bug.cgi?id=145064. AudioContext suspend/resume/close methods return promises. In some cases, they can immediately resolve/reject promises. The current implementation is doing the resolve/reject of promises asynchronously using postTask. This may cause some inconsistencies in the order which promises callbacks are actually executed. 1095892 1 253376 youennf 2015-05-19 02:30:02 -0700 Created attachment 253376 Patch 1095910 2 253376 youennf 2015-05-19 04:52:17 -0700 Comment on attachment 253376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253376&action=review > Source/WebCore/ChangeLog:8 > + Test: webaudio/audiocontext-promise.html Tried this test on Google Chrome and it actually fails. It seems that pure JS promise callbacks are resolved first in Chrome. I did a test mixing AudioContext and ReadableStreamReader promises on WebKit. As expected, the execution order does not seem right, AudioContext callbacks being always called after ReadableStream callbacks. We should be consistent in our various promise-based APIs, at least align ReadableStream and AudioContext. 1095931 3 jer.noble 2015-05-19 08:16:20 -0700 The spec is actually ambiguous on a couple of these cases. And even the meaning of "immediately" is ambiguous. We should push the WG to adopt unambiguous language, e.g. resume(): "If the context is already running, return a resolved promise().", "If the context is closed, return a rejected promise().", etc. 1095934 4 jer.noble 2015-05-19 08:28:10 -0700 I filed a spec bug: <https://github.com/WebAudio/web-audio-api/issues/535> 1095936 5 youennf 2015-05-19 08:30:37 -0700 (In reply to comment #4) > I filed a spec bug: <https://github.com/WebAudio/web-audio-api/issues/535> Great! Let's continue the discussion there. 1095960 6 darin 2015-05-19 09:16:39 -0700 My review on the other bug does not mean I approve this change. It’s Jer and Sam who should be discussing this change to how promises work with audio in a WebKit context. I don’t know enough about it. 1096266 7 youennf 2015-05-20 09:50:03 -0700 It seems the discussion in https://github.com/WebAudio/web-audio-api/issues/535 is converging towards making the change. Time to review the patch? 1096267 8 253376 jer.noble 2015-05-20 09:50:41 -0700 Comment on attachment 253376 Patch Yes indeed. r=me. 1096271 9 253376 commit-queue 2015-05-20 10:02:33 -0700 Comment on attachment 253376 Patch Clearing flags on attachment: 253376 Committed r184641: <http://trac.webkit.org/changeset/184641> 1096272 10 commit-queue 2015-05-20 10:02:39 -0700 All reviewed patches have been landed. Closing bug. 253376 2015-05-19 02:30:02 -0700 2015-05-20 10:02:33 -0700 Patch bug-145164-20150519112959.patch text/plain 5641 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM0Nzk1ZWVjNTBlZmUw ZGE5MGJkNzAxYTBmZWQyYzZiNTc2ZTk4ZC4uZmY5OGVmMDc3NmNiZWIzZDkzODZjMDk5OGI3M2Zi ZDRkN2FkZWUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTE5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgQXVkaW9D b250ZXh0IHN1c3BlbmQvcmVzdW1lL2Nsb3NlIHNob3VsZCByZXNvbHZlIHByb21pc2VzIGltbWVk aWF0ZWx5IHdoZW4gc3RhdGUgaXMgYWxyZWFkeSBzdXNwZW5kZWQvYWN0aXZlL2Nsb3NlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MTY0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogd2ViYXVk aW8vYXVkaW9jb250ZXh0LXByb21pc2UuaHRtbAorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRp by9BdWRpb0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0OjpzdXNw ZW5kQ29udGV4dCk6IEltbWVkaWF0bHkgY2FsbCBjYWxsYmFja3Mgd2hlbmV2ZXIgcG9zc2libGUg dG8gcmVzb2x2ZS9yZWplY3QgcHJvbWlzZXMuCisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRl eHQ6OnJlc3VtZUNvbnRleHQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4 dDo6Y2xvc2VDb250ZXh0KTogRGl0dG8KKwogMjAxNS0wNS0xNyAgTWFudWVsIFJlZ28gQ2FzYXNu b3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBBZGQg c2Nyb2xsYmFyIHdpZHRoIGluIGludHJpbnNpYyBsb2dpY2FsIHdpZHRocyBjb21wdXRhdGlvbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmlu ZGV4IGQyM2I1MTBmZTUyYTM4MTE2ODNmZDdjMWNjOGUyOTEyZjFmYTAxNTEuLmQ4M2Q0YzllY2Ri NDJhYmM4YmQ4Nzg2MGUyMzAxN2FhMzg1MTdiYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAKQEAgLTExMTIsMTIgKzExMTIsMTIgQEAg dm9pZCBBdWRpb0NvbnRleHQ6OnN1c3BlbmRDb250ZXh0KHN0ZDo6ZnVuY3Rpb248dm9pZCgpPiBz dWNjZXNzQ2FsbGJhY2ssIHN0ZDo6ZnUKICAgICB9CiAKICAgICBpZiAobV9zdGF0ZSA9PSBTdGF0 ZTo6U3VzcGVuZGVkKSB7Ci0gICAgICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKS0+cG9zdFRh c2soc3VjY2Vzc0NhbGxiYWNrKTsKKyAgICAgICAgc3VjY2Vzc0NhbGxiYWNrKCk7CiAgICAgICAg IHJldHVybjsKICAgICB9CiAKICAgICBpZiAobV9zdGF0ZSA9PSBTdGF0ZTo6Q2xvc2VkIHx8IG1f c3RhdGUgPT0gU3RhdGU6OkludGVycnVwdGVkIHx8ICFtX2Rlc3RpbmF0aW9uTm9kZSkgewotICAg ICAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnBvc3RUYXNrKGZhaWx1cmVDYWxsYmFjayk7 CisgICAgICAgIGZhaWx1cmVDYWxsYmFjaygpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkBA IC0xMTQ1LDEyICsxMTQ1LDEyIEBAIHZvaWQgQXVkaW9Db250ZXh0OjpyZXN1bWVDb250ZXh0KHN0 ZDo6ZnVuY3Rpb248dm9pZCgpPiBzdWNjZXNzQ2FsbGJhY2ssIHN0ZDo6ZnVuCiAgICAgfQogCiAg ICAgaWYgKG1fc3RhdGUgPT0gU3RhdGU6OlJ1bm5pbmcpIHsKLSAgICAgICAgc2NyaXB0RXhlY3V0 aW9uQ29udGV4dCgpLT5wb3N0VGFzayhzdWNjZXNzQ2FsbGJhY2spOworICAgICAgICBzdWNjZXNz Q2FsbGJhY2soKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIGlmIChtX3N0YXRlID09 IFN0YXRlOjpDbG9zZWQgfHwgIW1fZGVzdGluYXRpb25Ob2RlKSB7Ci0gICAgICAgIHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKS0+cG9zdFRhc2soZmFpbHVyZUNhbGxiYWNrKTsKKyAgICAgICAgZmFp bHVyZUNhbGxiYWNrKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTExNzcsNyArMTE3 Nyw3IEBAIHZvaWQgQXVkaW9Db250ZXh0OjpjbG9zZUNvbnRleHQoc3RkOjpmdW5jdGlvbjx2b2lk KCk+IHN1Y2Nlc3NDYWxsYmFjaywgc3RkOjpmdW5jCiAgICAgfQogCiAgICAgaWYgKG1fc3RhdGUg PT0gU3RhdGU6OkNsb3NlZCB8fCAhbV9kZXN0aW5hdGlvbk5vZGUpIHsKLSAgICAgICAgc2NyaXB0 RXhlY3V0aW9uQ29udGV4dCgpLT5wb3N0VGFzayhzdWNjZXNzQ2FsbGJhY2spOworICAgICAgICBz dWNjZXNzQ2FsbGJhY2soKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY2NTUz YjYyMDI4MzE3YmFlNTZkODZmNjc4ZjUyNWQyZDJmYjc2MjcuLjhmODFmOGMwYjJkYTFhOGNiZTRi Nzk1NTgxOGE5Y2FiMGUyMDhhZWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNS0wNS0xOSAg WW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCisgICAgICAgIEF1 ZGlvQ29udGV4dCBzdXNwZW5kL3Jlc3VtZS9jbG9zZSBzaG91bGQgcmVzb2x2ZSBwcm9taXNlcyBp bW1lZGlhdGVseSB3aGVuIHN0YXRlIGlzIGFscmVhZHkgc3VzcGVuZGVkL2FjdGl2ZS9jbG9zZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTE2NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViYXVk aW8vYXVkaW9jb250ZXh0LXByb21pc2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB3 ZWJhdWRpby9hdWRpb2NvbnRleHQtcHJvbWlzZS5odG1sOiBBZGRlZC4KKwogMjAxNS0wNS0xNyAg QmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0pTQ10g TWFrZSBTdHJpbmdSZWN1cnNpb25DaGVja2VyIGZhc3RlciBpbiB0aGUgc2ltcGxlIGNhc2VzIHdp dGhvdXQgYW55IHJlY3Vyc2lvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVk aW9jb250ZXh0LXByb21pc2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVk aW9jb250ZXh0LXByb21pc2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI4OGY2MDBiOGM0NjJj ZWY2NjlkMGNiZWRmMGI5NjRlYTIwNTQ4ZDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy93ZWJhdWRpby9hdWRpb2NvbnRleHQtcHJvbWlzZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwx MCBAQAorVGVzdHMgdGhhdCBBdWRpb0NvbnRleHQgc3VzcGVuZCBtZXRob2QgcmVzb2x2ZSBwcm9t aXNlcyBpbW1lZGlhdGVseSB3aGVuIGFscmVhZHkgc3VzcGVuZGVkLgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKK1BBU1MgY29udGV4dCByZXNvbHZlIGNhbGxiYWNrIGNhbGxlZAorUEFT UyBKUyBwcm9taXNlIGNhbGxiYWNrIGNhbGxlZCBhZnRlciBjb250ZXh0IGNhbGxiYWNrCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9jb250ZXh0LXByb21pc2UuaHRtbCBiL0xheW91 dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvY29udGV4dC1wcm9taXNlLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzBk MWQyNzkyNzFiZWViNzU1NTVlMWFmMjQ0NTBmOTgwYTZkNzY3NwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvY29udGV4dC1wcm9taXNlLmh0bWwKQEAgLTAsMCAr MSw1NyBAQAorPCFET0NUWVBFIGh0bWw+CisKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0i Li4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHk+ CisKKzxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rpdj4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2 PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgQXVkaW9Db250ZXh0IHN1c3Bl bmQgbWV0aG9kIHJlc29sdmUgcHJvbWlzZXMgaW1tZWRpYXRlbHkgd2hlbiBhbHJlYWR5IHN1c3Bl bmRlZC4iKTsKKworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5u ZXIpIHsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgICAgIHRlc3RSdW5u ZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0KKyAgICAKKyAgICB3aW5kb3cuanNUZXN0SXNBc3lu YyA9IHRydWU7CisKKyAgICBjb250ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgpOworCisg ICAgdmFyIGlzU3VzcGVuZGVkID0gZmFsc2U7CisgICAgY29udGV4dC5zdXNwZW5kKCkudGhlbihm dW5jdGlvbigpIHsKKyAgICAgICAgdGVzdFBhc3NlZCgnY29udGV4dCByZXNvbHZlIGNhbGxiYWNr IGNhbGxlZCcpOworICAgICAgICBpc1N1c3BlbmRlZCA9IHRydWU7CisgICAgfSwgZnVuY3Rpb24o KSB7CisgICAgICAgIHRlc3RGYWlsZWQoJ2NvbnRleHQgcmVqZWN0IGNhbGxiYWNrIGNhbGxlZCcp OworICAgIH0pOworCisgICAgaWYgKGlzU3VzcGVuZGVkKQorICAgICAgICB0ZXN0RmFpbGVkKCdj b250ZXh0IHJlc29sdmUgY2FsbGJhY2sgY2FsbGVkIHN5bmNocm9ub3VzbHknKTsKKyAKKyAgICB2 YXIgcmVzb2x2ZVByb21pc2U7CisgICAgdmFyIHByb21pc2UgPSBuZXcgUHJvbWlzZShmdW5jdGlv bihyZXNvbHZlLCByZWplY3QpIHsKKyAgICAgICAgcmVzb2x2ZVByb21pc2UgPSByZXNvbHZlOwor ICAgIH0pOworICAgIHByb21pc2UudGhlbihmdW5jdGlvbigpIHsKKyAgICAgICAgaWYgKGlzU3Vz cGVuZGVkKQorICAgICAgICAgICAgdGVzdFBhc3NlZCgnSlMgcHJvbWlzZSBjYWxsYmFjayBjYWxs ZWQgYWZ0ZXIgY29udGV4dCBjYWxsYmFjaycpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0 ZXN0RmFpbGVkKCdKUyBwcm9taXNlIGNhbGxiYWNrIGNhbGxlZCBiZWZvcmUgY29udGV4dCBjYWxs YmFjaycpOworICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICB9KTsKKyAgICByZXNvbHZlUHJv bWlzZSgpOworfQorCitydW5UZXN0KCk7CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4v cmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==