14516 2007-07-03 15:20:39 -0700 crash loading multipart/x-mixed-replace data on windows safari 2007-07-06 03:05:10 -0700 1 1 1 Unclassified WebKit Page Loading 523.x (Safari 3) PC Windows XP RESOLVED FIXED P1 Normal --- 0 tony webkit-unassigned ap oldest_to_newest 5636 0 tony 2007-07-03 15:20:39 -0700 When loading multipart/x-mixed-replace urls, if there's no data before the first boundary data, Safari on windows crashes (tested 3.0.2 and trunk r 5633 1 15377 tony 2007-07-03 15:21:36 -0700 Created attachment 15377 Crash on safari windows 5628 2 tony 2007-07-03 16:14:55 -0700 Hmm, it looks like my bug report got truncated. It should have said: Tested on trunk r23940. The crash is in ResourceLoader::clearResourceData() where it tries to clear m_resourceData which hasn't been initialized. This doesn't happen on Mac Safari because it first calls willStopBufferingData, which doesn't seem to be called at all by the windows resource handle. The simple fix seems to be to do a null check in clearResourceData(). 5631 3 15379 tony 2007-07-03 16:39:25 -0700 Created attachment 15379 null check m_resourceData 5623 4 ap 2007-07-04 02:26:08 -0700 This looks like a fix that really needs an automated test. 5585 5 15379 mjs 2007-07-04 16:29:20 -0700 Comment on attachment 15379 null check m_resourceData Good fix. Please add an http layout test (the tests in LayoutTests/http run on a local server, so you can generate multipart/x-mided-replace output). Also, please add an explanation of the bug being fixed to the ChangeLog entry. r- for now, please resubmit with these things fixed. 5489 6 15410 tony 2007-07-05 18:39:04 -0700 Created attachment 15410 null check m_resourceData and layout test 5481 7 15410 mjs 2007-07-05 19:26:19 -0700 Comment on attachment 15410 null check m_resourceData and layout test r=me 5407 8 mrowe 2007-07-06 03:05:10 -0700 Landed in r24053. Thanks for the patch! 15377 2007-07-03 15:21:36 -0700 2007-07-03 15:21:36 -0700 Crash on safari windows win-crash.php text/plain 183 tony PD9waHAKICAgICRib3VuZGFyeSA9ICJjdXRIZXJlIjsKICAgIGhlYWRlcigiQ29udGVudC1UeXBl OiBtdWx0aXBhcnQveC1taXhlZC1yZXBsYWNlOyBib3VuZGFyeT0kYm91bmRhcnkiKTsKICAgIGVj aG8oIiRib3VuZGFyeVxyXG4iKTsKICAgIGVjaG8oIkNvbnRlbnQtVHlwZTogaW1hZ2UvcG5nXHJc blxyXG4iKTsKPz4K 15379 2007-07-03 16:39:25 -0700 2007-07-05 18:39:04 -0700 null check m_resourceData resource-loader-crash.diff text/plain 1017 tony SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzk2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDctMDctMDMgIFRvbnkgQ2hhbmcgIDxpZGVhbGlzbXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdB Uk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgICogbG9hZGVy L1Jlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpj bGVhclJlc291cmNlRGF0YSk6CisKIDIwMDctMDctMDMgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IFdlYkNvcmUvbG9hZGVy L1Jlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9SZXNvdXJj ZUxvYWRlci5jcHAJKHJldmlzaW9uIDIzOTQwKQorKysgV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VM b2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjEsNyArMTYxLDggQEAgdm9pZCBSZXNvdXJj ZUxvYWRlcjo6YWRkRGF0YShjb25zdCBjaGFyKgogCiB2b2lkIFJlc291cmNlTG9hZGVyOjpjbGVh clJlc291cmNlRGF0YSgpCiB7Ci0gICAgbV9yZXNvdXJjZURhdGEtPmNsZWFyKCk7CisgICAgaWYg KG1fcmVzb3VyY2VEYXRhKQorICAgICAgICBtX3Jlc291cmNlRGF0YS0+Y2xlYXIoKTsKIH0KIAog dm9pZCBSZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgcmVx dWVzdCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSkK 15410 2007-07-05 18:39:04 -0700 2007-07-05 19:26:19 -0700 null check m_resourceData and layout test resource-loader-crash-2.diff text/plain 3836 tony SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDAzNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDctMDUgIFRvbnkgQ2hhbmcgIDxpZGVhbGlzbXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgTlVMTCBjaGVjayBtX3Jlc291cmNlRGF0YSB0byBwcmV2ZW50IGEgY3Jhc2ggaW4gU2Fm YXJpIG9uIFdpbmRvd3MuCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NTE2CisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OmNsZWFyUmVzb3VyY2VEYXRhKToKKwogMjAw Ny0wNy0wNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IEJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDIz OTQwKQorKysgV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNjEsNyArMTYxLDggQEAgdm9pZCBSZXNvdXJjZUxvYWRlcjo6YWRkRGF0YShjb25zdCBj aGFyKgogCiB2b2lkIFJlc291cmNlTG9hZGVyOjpjbGVhclJlc291cmNlRGF0YSgpCiB7Ci0gICAg bV9yZXNvdXJjZURhdGEtPmNsZWFyKCk7CisgICAgaWYgKG1fcmVzb3VyY2VEYXRhKQorICAgICAg ICBtX3Jlc291cmNlRGF0YS0+Y2xlYXIoKTsKIH0KIAogdm9pZCBSZXNvdXJjZUxvYWRlcjo6d2ls bFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgUmVzb3VyY2VSZXNw b25zZSYgcmVkaXJlY3RSZXNwb25zZSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0MDM1KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDct MDctMDUgIFRvbnkgQ2hhbmcgIDxpZGVhbGlzbXNAZ21haWwuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQnVnIDE0NTE2OiBjcmFz aCBsb2FkaW5nIG11bHRpcGFydC94LW1peGVkLXJlcGxhY2UgZGF0YSBvbiB3aW5kb3dzIHNhZmFy aQorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxNgor CisgICAgICAgICogaHR0cC90ZXN0cy9tdWx0aXBhcnQvcmVzb3VyY2VzL211bHRpcGFydC1ub2Rh c2hlcy5waHA6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbXVsdGlwYXJ0L3dpbi1ib3Vu ZGFyeS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvbXVs dGlwYXJ0L3dpbi1ib3VuZGFyeS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAwNy0wNy0wNSAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZvcmdvdCB0byBhZGQg dGhpcyBmaWxlIGZvciB0aGUgdGVzdCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzUzMDM1Njc+IFJFR1JF U1NJT046IApJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvd2luLWJvdW5k YXJ5LWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL211bHRpcGFydC93aW4tYm91bmRhcnktY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvd2luLWJvdW5kYXJ5LWNyYXNo LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxNiBjcmFzaCBsb2FkaW5nIG11 bHRpcGFydC94LW1peGVkLXJlcGxhY2UgZGF0YSBvbiB3aW5kb3dzIHNhZmFyaQorCitJZiBXZWJL aXQgZG9lcyBub3QgY3Jhc2ggd2hlbiBsb2FkaW5nIHRoaXMgaW1nLCB0aGVuIGl0IHBhc3NlZC4K KworCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL211bHRpcGFydC93aW4tYm91bmRhcnkt Y3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL211bHRpcGFy dC93aW4tYm91bmRhcnktY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbXVsdGlwYXJ0L3dpbi1ib3VuZGFyeS1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDE0IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1w QXNUZXh0KCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHA+VGVzdCBmb3IgPGk+PGEg aHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MTYiPmh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTE2PC9hPgorY3Jhc2ggbG9hZGlu ZyBtdWx0aXBhcnQveC1taXhlZC1yZXBsYWNlIGRhdGEgb24gd2luZG93cyBzYWZhcmk8L2k+PC9w PgorPHA+SWYgV2ViS2l0IGRvZXMgbm90IGNyYXNoIHdoZW4gbG9hZGluZyB0aGlzIGltZywgdGhl biBpdCBwYXNzZWQuPC9wPgorPGltZyBzcmM9InJlc291cmNlcy9tdWx0aXBhcnQtbm9kYXNoZXMu cGhwIiAvPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t dWx0aXBhcnQvcmVzb3VyY2VzL211bHRpcGFydC1ub2Rhc2hlcy5waHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tdWx0aXBhcnQvcmVzb3VyY2VzL211bHRpcGFydC1ub2Rh c2hlcy5waHAJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL211bHRpcGFy dC9yZXNvdXJjZXMvbXVsdGlwYXJ0LW5vZGFzaGVzLnBocAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxMCBAQAorPD9waHAKKyAgICAjIEdlbmVyYXRlcyBhIG11bHRpcGFydC94LW1peGVkLXJlcGxh Y2UgcmVzcG9uc2UgYnV0IGRvZXNuJ3QKKyAgICAjIGluY2x1ZGUgdGhlIC0tIGJlZm9yZSB0aGUg Ym91bmRhcnkuCisKKyAgICAkYm91bmRhcnkgPSAiY3V0SGVyZSI7CisgICAgaGVhZGVyKCJDb250 ZW50LVR5cGU6IG11bHRpcGFydC94LW1peGVkLXJlcGxhY2U7IGJvdW5kYXJ5PSRib3VuZGFyeSIp OworICAgIGVjaG8oIiRib3VuZGFyeVxyXG4iKTsKKyAgICBlY2hvKCJDb250ZW50LVR5cGU6IGlt YWdlL3BuZ1xyXG5cclxuIik7CisgICAgZWNobyhmaWxlX2dldF9jb250ZW50cygiZ3JlZW4tMTAw eDEwMC5wbmciKSk7Cis/Pgo=