145158 2015-05-18 20:50:29 -0700 WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals. 2015-05-19 12:57:04 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue jer.noble jonlee oldest_to_newest 1095804 0 jeremyj-wk 2015-05-18 20:50:29 -0700 WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals. 1095807 1 253360 jeremyj-wk 2015-05-18 20:52:25 -0700 Created attachment 253360 Patch 1095809 2 jeremyj-wk 2015-05-18 20:54:02 -0700 rdar://problem/20964171 1095854 3 253360 jonlee 2015-05-18 23:42:32 -0700 Comment on attachment 253360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253360&action=review > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000 ... so how much better does this work than the old way? Does it specifically improve on slower devices? 1095987 4 jeremyj-wk 2015-05-19 12:08:39 -0700 (In reply to comment #3) > Comment on attachment 253360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253360&action=review > > > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000 > > ... so how much better does this work than the old way? Does it specifically > improve on slower devices? It isn't about speed. It is about improving responsiveness while waiting on a fence, and decreasing likelihood of deadlocks between fences. 1096003 5 253360 commit-queue 2015-05-19 12:57:00 -0700 Comment on attachment 253360 Patch Clearing flags on attachment: 253360 Committed r184583: <http://trac.webkit.org/changeset/184583> 1096004 6 commit-queue 2015-05-19 12:57:04 -0700 All reviewed patches have been landed. Closing bug. 253360 2015-05-18 20:52:25 -0700 2015-05-19 12:57:00 -0700 Patch bug-145158-20150518205222.patch text/plain 2118 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDg4NGJlZGZmMWJjYTE5 NWE5NDc4YzljZmU0Mjk2NGNiNjhjNTQ4NS4uODc4Mzc1NDk3NDQwNTJmZDAwNTFhNGQ4YTM5NGRm NzE1YzkxY2ZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA1LTE4ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJWaWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyUHJveHkgaGFzIGluY29ycmVjdCBPU19WRVJTSU9OX01JTl9SRVFVSVJFRCBjb25k aXRpb25hbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDUxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5Lm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHk6OnNldFZpZGVvTGF5 ZXJGcmFtZSk6CisKIDIwMTUtMDUtMTEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBDaGlsZFByb2Nlc3Mgc2hvdWxkIHRha2UgYW4gb3NfYWN0aXZpdHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdl clByb3h5Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyUHJveHkubW0KaW5kZXggMmYzYmEyYjhhOWNkZWVmZWE1MWNjM2JkNGNkMzA4NmNk OGY5N2QyOC4uNDMxMDgwYWM1YmZkNWQ2NjExNWY4ZjFiY2ZiNjI3YzVkZDBhMjJhMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5h Z2VyUHJveHkubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJWaWRlb0Z1 bGxzY3JlZW5NYW5hZ2VyUHJveHkubW0KQEAgLTM4LDcgKzM4LDcgQEAKICNpbXBvcnQgPFdlYkNv cmUvVGltZVJhbmdlcy5oPgogI2ltcG9ydCA8V2ViS2l0U3lzdGVtSW50ZXJmYWNlLmg+CiAKLSNp ZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+IDkwMDAwCisjaWYgX19JUEhPTkVf T1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gOTAwMDAKICNpbXBvcnQgIkJhY2tCb2FyZFNlcnZp Y2VzU1BJLmgiCiAjZW5kaWYKIApAQCAtNDYsNyArNDYsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLSNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA8PSA4MDIwMCB8fCAhSEFWRShBVktJVCkKKyNpZiBfX0lQSE9ORV9PU19WRVJT SU9OX01JTl9SRVFVSVJFRCA8IDkwMDAwIHx8ICFIQVZFKEFWS0lUKQogCiBQYXNzUmVmUHRyPFdl YlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eT4gV2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclBy b3h5OjpjcmVhdGUoV2ViUGFnZVByb3h5JikKIHsKQEAgLTUxNiw3ICs1MTYsNyBAQCB2b2lkIFdl YlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eTo6ZGlkQ2xlYW51cEZ1bGxzY3JlZW4odWludDY0 X3QgY29udGV4dElkKQogdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHk6OnNldFZp ZGVvTGF5ZXJGcmFtZSh1aW50NjRfdCBjb250ZXh0SWQsIFdlYkNvcmU6OkZsb2F0UmVjdCBmcmFt ZSkKIHsKICAgICBAYXV0b3JlbGVhc2Vwb29sIHsKLSNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+IDkwMDAwCisjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQg Pj0gOTAwMDAKICAgICAgICAgQktTQW5pbWF0aW9uRmVuY2VIYW5kbGUqIHN5bmNocm9uaXphdGlv bkZlbmNlID0gW1VJV2luZG93IF9zeW5jaHJvbml6ZWREcmF3aW5nRmVuY2VdOwogICAgICAgICBt YWNoX3BvcnRfbmFtZV90IGZlbmNlUG9ydCA9IFtzeW5jaHJvbml6YXRpb25GZW5jZSBDQVBvcnRd OwogI2Vsc2UK