145151 2015-05-18 17:00:33 -0700 REGRESSION: v2 UI reports a higher memory usage 2015-05-18 17:24:24 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141237 1 rniwa rniwa oldest_to_newest 1095744 0 rniwa 2015-05-18 17:00:33 -0700 The v2 UI of the perf dashboard reports a higher memory usage compared to v1 UI. 1095746 1 253353 rniwa 2015-05-18 17:03:57 -0700 Created attachment 253353 Fixes the bug 1095751 2 253353 cdumez 2015-05-18 17:12:30 -0700 Comment on attachment 253353 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=253353&action=review > Websites/perf.webkit.org/public/v2/manifest.js:318 > + _formatByte: function (sigFig, alwaysShowSign) nit: _formatBytes ? 1095755 3 rniwa 2015-05-18 17:24:24 -0700 Committed r184531: <http://trac.webkit.org/changeset/184531> 253353 2015-05-18 17:03:57 -0700 2015-05-18 17:12:30 -0700 Fixes the bug bug-145151-20150518170355.patch text/plain 3146 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NTIxKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE1LTA1LTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT046IHYyIFVJIHJlcG9ydHMgYSBoaWdoZXIgbWVtb3J5IHVzYWdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUxNTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVn IHdhcyBjYXVzZWQgYnkgdjIgVUkgdXNpbmcgMTAwMCB0byBkaXZpZGUgdGhlIG51bWJlciBvZiBi eXRlcyBpbnN0ZWFkIG9mIGJ5IDEwMjQgYXMgZG9uZSBpbiB2MS4KKyAgICAgICAgRml4ZWQgdGhl IGJ1ZyBieSBtYW51YWxseSBpbXBsZW1lbnRpbmcgdGhlIGZvcm1hdHRlciBhcyBkb25lIGluIHYx LgorCisgICAgICAgICogcHVibGljL3YyL21hbmlmZXN0LmpzOgorICAgICAgICAoQXBwLk1hbmZp ZXN0Ll9mb3JtYXRCeXRlKTogQWRkZWQuCisgICAgICAgIChBcHAuTWFuaWZlc3QuX2Zvcm1hdEZl dGNoZWREYXRhKTogVXNlIF9mb3JtYXRCeXRlIGluc3RlYWQgb2YgZm9ybWF0KCdzJykuCisKIDIw MTUtMDUtMTEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBidWlsZCBmaXguIEFkZCAiRHVyYXRpb24iIGFzIGEgdGltZSBtZXRyaWMuCkluZGV4 OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL21hbmlmZXN0LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvbWFuaWZlc3QuanMJKHJl dmlzaW9uIDE4NDUyMSkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvbWFu aWZlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTMxNSwxNCArMzE1LDI4IEBAIEFwcC5NYW5pZmVz dCA9IEVtYmVyLkNvbnRyb2xsZXIuZXh0ZW5kKHsKICAgICAgICAgICAgIH07CiAgICAgICAgIH0p OwogICAgIH0sCisgICAgX2Zvcm1hdEJ5dGU6IGZ1bmN0aW9uIChzaWdGaWcsIGFsd2F5c1Nob3dT aWduKQorICAgIHsKKyAgICAgICAgdmFyIHVuaXRzID0gWycnLCAnSycsICdNJywgJ0cnLCAnVCcs ICdQJywgJ0UnXTsKKyAgICAgICAgdmFyIHRocmVzaG9sZCA9IHNpZ0ZpZyA+PSAzID8gMTAyNCA6 IDEwMi40OworICAgICAgICByZXR1cm4gZnVuY3Rpb24gKGJ5dGVzKSB7CisgICAgICAgICAgICB2 YXIgaTsKKyAgICAgICAgICAgIHZhciBzaWduID0gYnl0ZXMgPj0gMCA/IChhbHdheXNTaG93U2ln biA/ICcrJyA6ICcnKSA6ICctJzsKKyAgICAgICAgICAgIGJ5dGVzID0gTWF0aC5hYnMoYnl0ZXMp OworCisgICAgICAgICAgICBmb3IgKGkgPSAwOyBieXRlcyA+PSB0aHJlc2hvbGQ7IGkrKykKKyAg ICAgICAgICAgICAgICBieXRlcyAvPSAxMDI0OworICAgICAgICAgICAgcmV0dXJuIHNpZ24gKyBi eXRlcy50b1ByZWNpc2lvbihNYXRoLm1heCgyLCBzaWdGaWcpKSArIHVuaXRzW2ldOworICAgICAg ICB9CisgICAgfSwKICAgICBfZm9ybWF0RmV0Y2hlZERhdGE6IGZ1bmN0aW9uIChtZXRyaWNOYW1l LCBjb25maWd1cmF0aW9ucykKICAgICB7CiAgICAgICAgIHZhciB1bml0ID0gUnVuc0RhdGEudW5p dEZyb21NZXRyaWNOYW1lKG1ldHJpY05hbWUpOwogICAgICAgICB2YXIgc21hbGxlcklzQmV0dGVy ID0gUnVuc0RhdGEuaXNTbWFsbGVyQmV0dGVyKHVuaXQpOwogCi0gICAgICAgIHZhciB1c2VTSSA9 IHVuaXQgPT0gJ2J5dGVzJzsKKyAgICAgICAgdmFyIGlzQnl0ZXMgPSB1bml0ID09ICdieXRlcyc7 CiAgICAgICAgIHZhciB1bml0U3VmZml4ID0gdW5pdCA/ICcgJyArIHVuaXQgOiAnJzsKLSAgICAg ICAgdmFyIGRlbHRhRm9ybWF0dGVyV2l0aG91dFNpZ24gPSB1c2VTSSA/IGQzLmZvcm1hdCgnLjJz JykgOiBkMy5mb3JtYXQoJy4yZycpOworICAgICAgICB2YXIgZGVsdGFGb3JtYXR0ZXJXaXRob3V0 U2lnbiA9IGlzQnl0ZXMgPyB0aGlzLl9mb3JtYXRCeXRlKDIsIGZhbHNlKSA6IGQzLmZvcm1hdCgn LjJnJyk7CiAKICAgICAgICAgdmFyIGN1cnJlbnRUaW1lU2VyaWVzID0gY29uZmlndXJhdGlvbnMu Y3VycmVudC50aW1lU2VyaWVzQnlDb21taXRUaW1lKGZhbHNlKTsKICAgICAgICAgdmFyIGJhc2Vs aW5lVGltZVNlcmllcyA9IGNvbmZpZ3VyYXRpb25zLmJhc2VsaW5lID8gY29uZmlndXJhdGlvbnMu YmFzZWxpbmUudGltZVNlcmllc0J5Q29tbWl0VGltZShmYWxzZSkgOiBudWxsOwpAQCAtMzM5LDgg KzM1Myw4IEBAIEFwcC5NYW5pZmVzdCA9IEVtYmVyLkNvbnRyb2xsZXIuZXh0ZW5kKHsKICAgICAg ICAgICAgIHsKICAgICAgICAgICAgICAgICByZXR1cm4gdGhpcy5mb3JtYXR0ZXIodmFsdWUpICsg KGRlbHRhICYmICFpc05hTihkZWx0YSkgPyAnIFx1MDBiMSAnICsgZGVsdGFGb3JtYXR0ZXJXaXRo b3V0U2lnbihkZWx0YSkgOiAnJykgKyB1bml0U3VmZml4OwogICAgICAgICAgICAgfSwKLSAgICAg ICAgICAgIGZvcm1hdHRlcjogdXNlU0kgPyBkMy5mb3JtYXQoJy40cycpIDogZDMuZm9ybWF0KCcu NGcnKSwKLSAgICAgICAgICAgIGRlbHRhRm9ybWF0dGVyOiB1c2VTSSA/IGQzLmZvcm1hdCgnKy4y cycpIDogZDMuZm9ybWF0KCcrLjJnJyksCisgICAgICAgICAgICBmb3JtYXR0ZXI6IGlzQnl0ZXMg PyB0aGlzLl9mb3JtYXRCeXRlKDQsIGZhbHNlKSA6IGQzLmZvcm1hdCgnLjRnJyksCisgICAgICAg ICAgICBkZWx0YUZvcm1hdHRlcjogaXNCeXRlcyA/IHRoaXMuX2Zvcm1hdEJ5dGUoMiwgdHJ1ZSkg OiBkMy5mb3JtYXQoJysuMmcnKSwKICAgICAgICAgICAgIHNtYWxsZXJJc0JldHRlcjogc21hbGxl cklzQmV0dGVyLAogICAgICAgICAgICAgc2hvd091dGxpZXI6IGZ1bmN0aW9uIChzaG93KQogICAg ICAgICAgICAgewo=