145149 2015-05-18 16:00:50 -0700 [Mac] All font lookups are flakey 2015-05-21 10:34:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=145180 InRadar P2 Normal --- 1 mmaxfield mmaxfield cdumez commit-queue webkit-bug-importer oldest_to_newest 1095719 0 mmaxfield 2015-05-18 16:00:50 -0700 On all OSes. 1095720 1 253350 mmaxfield 2015-05-18 16:03:16 -0700 Created attachment 253350 Patch 1095767 2 253350 commit-queue 2015-05-18 18:00:40 -0700 Comment on attachment 253350 Patch Clearing flags on attachment: 253350 Committed r184532: <http://trac.webkit.org/changeset/184532> 1095768 3 commit-queue 2015-05-18 18:00:46 -0700 All reviewed patches have been landed. Closing bug. 1095769 4 mmaxfield 2015-05-18 18:02:04 -0700 Reopened for the root cause. 1095771 5 mmaxfield 2015-05-18 18:04:44 -0700 Fails when run after jquery/offset.html 1095778 6 mmaxfield 2015-05-18 18:21:25 -0700 Reduction of the font-weights test: <div style="font-family: HelveticaNeue-Light; font-weight: 100;">Font: HelveticaNeue-Light Weight: 100</div> 1095795 7 mmaxfield 2015-05-18 19:47:58 -0700 reduction of the offset test: <script> testRunner.waitUntilDone() window.setTimeout(function() { testRunner.notifyDone(); }, 13); </script> <h2 style="font-family: HelveticaNeue-Light;">asdf 1095796 8 mmaxfield 2015-05-18 20:03:02 -0700 Running the test alone uses HelveticaNeue-Light, while running the two together uses HelveticaNeue-UltraLight 1095798 9 mmaxfield 2015-05-18 20:33:08 -0700 This is because the desiredFamilyToAvailableFamilyDictionary() cache inside fontWithFamily() in FontCacheMac is incorrect. In particular, there are two exit points of this function. If our search item exists in the cache, we skip the first exit point, which may be the correct one to take. A previous font may have skipped over the first exit point because of external information (weight, traits, etc). Because of this, we will insert this name into the cache. However, when the second font comes around, its external information may mean that it should take the first exit point. However, we notice that the family name is in the cache and skip the first exit point. 1095799 10 mmaxfield 2015-05-18 20:37:37 -0700 See https://bugs.webkit.org/show_bug.cgi?id=137539 1095805 11 mmaxfield 2015-05-18 20:51:56 -0700 platform/mac/fast/text/font-weights.html is the test in question. 1095806 12 mmaxfield 2015-05-18 20:52:20 -0700 <rdar://problem/21012406> 1096605 13 mmaxfield 2015-05-21 10:34:44 -0700 Fixed in https://bugs.webkit.org/show_bug.cgi?id=145180 253350 2015-05-18 16:03:16 -0700 2015-05-18 18:00:40 -0700 Patch bug-145149-20150518160314.patch text/plain 1286 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NTE3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWNjYzg2YmNjZTc4ZjgxZTQ4M2Ri YzZkMDhmNGFlZmFhZDcwOGI1Ni4uMDcxNWY0MGI2NTRhNDI5ZmU0MjhmY2Y5NDc2OWU1ZDc5N2Y5 YjhkNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1LTE4ICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgcGxhdGZvcm0vbWFjL2Zhc3QvdGV4 dC9mb250LXdlaWdodHMuaHRtbCBpcyBmbGFrZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTE0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisK IDIwMTUtMDUtMTggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgYSBJbnQtb3ItQm9vbGVhbiBzcGVjdWxhdGlvbiB0byBCcmFuY2gKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYWE0MTg0NGRkYTRkYWMzMjllYjUyNDBm NjU3NjcwZTAxMTM4ZGNmZC4uNjlmMDk4YzAxMjUzOWU3N2UwMTBjN2NmY2Q0MzYyNzRmZDNjMmRi MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEyNjEs MyArMTI2MSw1IEBAIHdlYmtpdC5vcmcvYi8xNzAyMiBbIE1vdW50YWluTGlvbiBNYXZlcmlja3Mg XSBmYXN0L2ltYWdlcy9hbmltYXRlZC1wbmcuaHRtbCBbIFNrCiAjIE9TIFggMTAuMTAuMysgaGFz IHRoZSBuZWNlc3NhcnkgZ2x5cGhzLgogd2Via2l0Lm9yZy9iLzE0MjU0OCBbIFlvc2VtaXRlKyBd IGVkaXRpbmcvc2VsZWN0aW9uL2V4dGVuZC1ieS1jaGFyYWN0ZXItMDA3Lmh0bWwgWyBQYXNzIF0K IHdlYmtpdC5vcmcvYi8xNDE2NjEgWyBZb3NlbWl0ZSsgXSBmYXN0L3RleHQvZW1vamkuaHRtbCBb IFBhc3MgXQorCit3ZWJraXQub3JnL2IvMTQ1MTQ5IHBsYXRmb3JtL21hYy9mYXN0L3RleHQvZm9u dC13ZWlnaHRzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQo=