145147 2015-05-18 15:34:45 -0700 <rdar://problem/21003555> cloberrize() is wrong for ArithRound because it doesn't account for the arith mode 2015-05-18 20:39:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin fpizlo oldest_to_newest 1095711 0 benjamin 2015-05-18 15:34:45 -0700 <rdar://problem/21003555> cloberrize() is wrong for ArithRound because it doesn't account for the arith mode 1095712 1 253348 benjamin 2015-05-18 15:38:08 -0700 Created attachment 253348 Patch 1095800 2 253348 benjamin 2015-05-18 20:39:17 -0700 Comment on attachment 253348 Patch Clearing flags on attachment: 253348 Committed r184541: <http://trac.webkit.org/changeset/184541> 1095801 3 benjamin 2015-05-18 20:39:21 -0700 All reviewed patches have been landed. Closing bug. 253348 2015-05-18 15:38:08 -0700 2015-05-18 20:39:17 -0700 Patch bug-145147-20150518153806.patch text/plain 4389 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YWQ1MjY2YTU4MmJhZDgxZGIyYTRiN2Y4NDUzZTEyMWEyMTFjYzhjLi4yOGY2YTEwNzk4OTFhNzVj NjZlYWM3ZGE3YWVmNDFhODQ3MzMwZWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wNS0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjEwMDM1NTU+IGNsb2JlcnJpemUoKSBp cyB3cm9uZyBmb3IgQXJpdGhSb3VuZCBiZWNhdXNlIGl0IGRvZXNuJ3QgYWNjb3VudCBmb3IgdGhl IGFyaXRoIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NTE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlYWxseSBzdHVwaWQgYnVnOiBBcml0aFJvdW5kIG5vZGVzIHdpdGggZGlmZmVyZW50IHJv dW5kaW5nIG1vZGVzCisgICAgICAgIHdlcmUgbm90IGRpc3Rpbmd1aXNoZWQgYW5kIENTRSB3b3Vs ZCBoYXBwaWx5IHVuaWZ5IHdpdGggYSBub2RlIG9mCisgICAgICAgIGEgZGlmZmVyZW50IHJvdW5k aW5nIG1vZGUuCisKKyAgICAgICAgREZHOjpjbG9iYmVyaXplKCkgYWxyZWFkeSBzdXBwb3J0IGFk ZGl0aW9uYWwgZGF0YSBidXQgSSB3YXMgbm90IHVzaW5nIGl0LgorCisgICAgICAgICogZGZnL0RG R0Nsb2JiZXJpemUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpjbG9iYmVyaXplKToKKyAgICAgICAg KiB0ZXN0cy9zdHJlc3MvbWF0aC1yb3VuZC1hcml0aC1yb3VuZGluZy1tb2RlLmpzOiBBZGRlZC4K KyAgICAgICAgKGZpcnN0Q2FyZUFib3V0WmVyb1NlY29uZERvZXNOb3QpOgorICAgICAgICAoZmly c3REb05vdENhcmVBYm91dFplcm9TZWNvbmREb2VzKToKKyAgICAgICAgKHdhcm11cCk6CisgICAg ICAgICh2ZXJpZnlOZWdhdGl2ZVplcm9Jc1ByZXNlcnZlZCk6CisKIDIwMTUtMDUtMTggIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtKU0NdIFdoZW4g ZW50ZXJpbmcgYSBDaGVja1RpZXJVcCB3aXRob3V0IE9TUkVudHJ5LCBmb3JjZSB0aGUgQ2hlY2tU aWVyVXAgZm9yIHRoZSBvdXRlciBsb29wcyB3aXRoIE9TUiBFbnRyeQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDbG9iYmVyaXplLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAppbmRleCA3YTI1NTA2MTlhMmI1YjNkYWQ4MzQ5OTQ1 N2Y2YmVmZjU0MDdhMjVlLi41MjNkNzIzYjU3MGFjNTAwNmRlOGNhMDFkY2ExY2EwZjRkNGUzMzg2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Nsb2JiZXJpemUuaApAQCAtMTM0LDcg KzEzNCw2IEBAIHZvaWQgY2xvYmJlcml6ZShHcmFwaCYgZ3JhcGgsIE5vZGUqIG5vZGUsIGNvbnN0 IFJlYWRGdW5jdG9yJiByZWFkLCBjb25zdCBXcml0ZUZ1CiAgICAgY2FzZSBBcml0aFBvdzoKICAg ICBjYXNlIEFyaXRoU3FydDoKICAgICBjYXNlIEFyaXRoRlJvdW5kOgotICAgIGNhc2UgQXJpdGhS b3VuZDoKICAgICBjYXNlIEFyaXRoU2luOgogICAgIGNhc2UgQXJpdGhDb3M6CiAgICAgY2FzZSBB cml0aExvZzoKQEAgLTI1NSw3ICsyNTQsMTEgQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFw aCwgTm9kZSogbm9kZSwgY29uc3QgUmVhZEZ1bmN0b3ImIHJlYWQsIGNvbnN0IFdyaXRlRnUKICAg ICBjYXNlIFVJbnQzMlRvTnVtYmVyOgogICAgICAgICBkZWYoUHVyZVZhbHVlKG5vZGUsIG5vZGUt PmFyaXRoTW9kZSgpKSk7CiAgICAgICAgIHJldHVybjsKLSAgICAgICAgCisKKyAgICBjYXNlIEFy aXRoUm91bmQ6CisgICAgICAgIGRlZihQdXJlVmFsdWUobm9kZSwgc3RhdGljX2Nhc3Q8dWludHB0 cl90Pihub2RlLT5hcml0aFJvdW5kaW5nTW9kZSgpKSkpOworICAgICAgICByZXR1cm47CisKICAg ICBjYXNlIENoZWNrQ2VsbDoKICAgICAgICAgZGVmKFB1cmVWYWx1ZShDaGVja0NlbGwsIEFkamFj ZW5jeUxpc3QoQWRqYWNlbmN5TGlzdDo6Rml4ZWQsIG5vZGUtPmNoaWxkMSgpKSwgbm9kZS0+Y2Vs bE9wZXJhbmQoKSkpOwogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvdGVzdHMvc3RyZXNzL21hdGgtcm91bmQtYXJpdGgtcm91bmRpbmctbW9kZS5qcyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvbWF0aC1yb3VuZC1hcml0aC1yb3Vu ZGluZy1tb2RlLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA5YTI3NzIzYWE2YTVjMzAxNTJmNDVkNmM2MWI1OTE3 MjA1MDU3YjIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMv c3RyZXNzL21hdGgtcm91bmQtYXJpdGgtcm91bmRpbmctbW9kZS5qcwpAQCAtMCwwICsxLDQ0IEBA CitmdW5jdGlvbiBmaXJzdENhcmVBYm91dFplcm9TZWNvbmREb2VzTm90KGEpIHsKKyAgICB2YXIg cmVzdWx0QSA9IE1hdGgucm91bmQoYSk7CisgICAgdmFyIHJlc3VsdEIgPSBNYXRoLnJvdW5kKGEp fDA7CisgICAgcmV0dXJuIHsgcmVzdWx0QTpyZXN1bHRBLCByZXN1bHRCOnJlc3VsdEIgfTsKK30K K25vSW5saW5lKGZpcnN0Q2FyZUFib3V0WmVyb1NlY29uZERvZXNOb3QpOworCitmdW5jdGlvbiBm aXJzdERvTm90Q2FyZUFib3V0WmVyb1NlY29uZERvZXMoYSkgeworICAgIHZhciByZXN1bHRBID0g TWF0aC5yb3VuZChhKXwwOworICAgIHZhciByZXN1bHRCID0gTWF0aC5yb3VuZChhKTsKKyAgICBy ZXR1cm4geyByZXN1bHRBOnJlc3VsdEEsIHJlc3VsdEI6cmVzdWx0QiB9OworfQorbm9JbmxpbmUo Zmlyc3REb05vdENhcmVBYm91dFplcm9TZWNvbmREb2VzKTsKKworLy8gV2FybXVwIHdpdGggZG91 YmxlcywgYnV0IG5vdGhpbmcgdGhhdCB3b3VsZCByb3VuZCB0byAtMCB0byBlbnN1cmUgd2UgbmV2 ZXIKKy8vIHNlZSBhIGRvdWJsZSBhcyByZXN1bHQuIFRoZSByZXN1bHQgbXVzdCBiZSBpbnRlZ2Vy cywgdGhlIGlucHV0IGlzIGtlcHQgdG8gc21hbGwgdmFsdWVzLgorZnVuY3Rpb24gd2FybXVwKCkg eworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMWU0OyArK2kpIHsKKyAgICAgICAgZmlyc3RDYXJl QWJvdXRaZXJvU2Vjb25kRG9lc05vdCg0Mi42ICsgaSk7CisgICAgICAgIGZpcnN0RG9Ob3RDYXJl QWJvdXRaZXJvU2Vjb25kRG9lcyg0Mi40ICsgaSk7CisgICAgfQorfQord2FybXVwKCk7CisKK2Z1 bmN0aW9uIHZlcmlmeU5lZ2F0aXZlWmVyb0lzUHJlc2VydmVkKCkgeworICAgIGZvciAodmFyIGkg PSAwOyBpIDwgMWU0OyArK2kpIHsKKyAgICAgICAgdmFyIHJlc3VsdDEgPSBmaXJzdENhcmVBYm91 dFplcm9TZWNvbmREb2VzTm90KC0wLjEpOworICAgICAgICBpZiAoMSAvIHJlc3VsdDEucmVzdWx0 QSAhPT0gLUluZmluaXR5KSB7CisgICAgICAgICAgICB0aHJvdyAiRmFpbGVkIGZpcnN0Q2FyZUFi b3V0WmVyb1NlY29uZERvZXNOb3QoLTAuMSksIHJlc3VsdEEgPSAiICsgcmVzdWx0MS5yZXN1bHRB OworICAgICAgICB9CisgICAgICAgIGlmICgxIC8gcmVzdWx0MS5yZXN1bHRCICE9PSBJbmZpbml0 eSkgeworICAgICAgICAgICAgdGhyb3cgIkZhaWxlZCBmaXJzdENhcmVBYm91dFplcm9TZWNvbmRE b2VzTm90KC0wLjEpLCByZXN1bHRCID0gIiArIHJlc3VsdDEucmVzdWx0QjsKKyAgICAgICAgfQor ICAgICAgICB2YXIgcmVzdWx0MiA9IGZpcnN0RG9Ob3RDYXJlQWJvdXRaZXJvU2Vjb25kRG9lcygt MC4xKTsKKyAgICAgICAgaWYgKDEgLyByZXN1bHQyLnJlc3VsdEEgIT09IEluZmluaXR5KSB7Cisg ICAgICAgICAgICB0aHJvdyAiRmFpbGVkIGZpcnN0RG9Ob3RDYXJlQWJvdXRaZXJvU2Vjb25kRG9l cygtMC4xKSwgcmVzdWx0QSA9ICIgKyByZXN1bHQxLnJlc3VsdEE7CisgICAgICAgIH0KKyAgICAg ICAgaWYgKDEgLyByZXN1bHQyLnJlc3VsdEIgIT09IC1JbmZpbml0eSkgeworICAgICAgICAgICAg dGhyb3cgIkZhaWxlZCBmaXJzdERvTm90Q2FyZUFib3V0WmVyb1NlY29uZERvZXMoLTAuMSksIHJl c3VsdEIgPSAiICsgcmVzdWx0MS5yZXN1bHRCOworICAgICAgICB9CisKKyAgICB9Cit9Cit2ZXJp ZnlOZWdhdGl2ZVplcm9Jc1ByZXNlcnZlZCgpOwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK