145146 2015-05-18 15:20:51 -0700 Addressing post-review comments on r184353 2015-05-18 16:16:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield benjamin cmarcelo commit-queue darin esprehn+autocc glenn kondapallykalyan oldest_to_newest 1095702 0 mmaxfield 2015-05-18 15:20:51 -0700 Addressing post-review comments on r184353 1095704 1 253347 mmaxfield 2015-05-18 15:22:44 -0700 Created attachment 253347 Patch 1095706 2 253347 benjamin 2015-05-18 15:24:36 -0700 Comment on attachment 253347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253347&action=review > Source/WebCore/ChangeLog:10 > + No new tests because there is no behavior change. That's never an excuse :) 1095725 3 253347 commit-queue 2015-05-18 16:16:23 -0700 Comment on attachment 253347 Patch Clearing flags on attachment: 253347 Committed r184519: <http://trac.webkit.org/changeset/184519> 1095726 4 commit-queue 2015-05-18 16:16:29 -0700 All reviewed patches have been landed. Closing bug. 253347 2015-05-18 15:22:44 -0700 2015-05-18 16:16:23 -0700 Patch bug-145146-20150518152242.patch text/plain 6841 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDcxZDkxNjliOGEwZmM2OTU2MmY4MThm N2Q5YWU2NThiNGE2NDdkZjguLjU1NTRkNjg0NTliMzIwYWM5ZDFiODk5NDIyNDc0MzRlN2UyNzRl OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDUtMTggIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRyZXNzaW5nIHBvc3QtcmV2aWV3IGNv bW1lbnRzIG9uIHIxODQzNTMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0NTE0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENyZWF0ZSBhbiBvdmVybG9hZCBmb3IgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZSgp IGZvciBBdG9taWNTdHJpbmcgYW5kIHN0cmluZyBsaXRlcmFscy4KKworICAgICAgICAqIHd0Zi90 ZXh0L0F0b21pY1N0cmluZy5oOgorICAgICAgICAoV1RGOjplcXVhbElnbm9yaW5nQVNDSUlDYXNl KToKKwogMjAxNS0wNS0xNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgRG8gbm90IHVzZSBmYXN0TWFsbG9jR29vZFNpemUgYW55d2hlcmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA1YzQ3OTVlZWM1MGVmZTBkYTkwYmQ3MDFhMGZlZDJjNmI1NzZlOThkLi5lYTNmZWI0 NWE1NmYzYmUxZjIzM2Y5YTA4ZTNkMjViNjg4NzZiYWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MjAgQEAKKzIwMTUtMDUtMTggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNv bT4KKworICAgICAgICBBZGRyZXNzaW5nIHBvc3QtcmV2aWV3IGNvbW1lbnRzIG9uIHIxODQzNTMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTE0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlZSBwZXIt ZmlsZSBjb21tZW50cy4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9u dENhY2hlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6Zm9udFdpdGhGYW1pbHlTcGVjaWFsQ2Fz ZSk6IFVzZSBlcXVhbElnbm9yaW5nQVNDSUlDYXNlKCkgQXRvbWljU3RyaW5nIG92ZXJsb2FkLgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lTWFjOjp1cGRhdGVDYWNoZWRTeXN0ZW1Gb250RGVzY3JpcHRpb24pOiBJbXBs ZW1lbnQgQmVuJ3MgaWRlYXMgZm9yCisgICAgICAgIGNoZWFwbHkgY29uc3RydWN0aW5nIEF0b21p Y1N0cmluZ3Mgb25seSB3aGVuIG5lY2Vzc2FyeS4KKwogMjAxNS0wNS0xNyAgTWFudWVsIFJlZ28g Q2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0 XSBBZGQgc2Nyb2xsYmFyIHdpZHRoIGluIGludHJpbnNpYyBsb2dpY2FsIHdpZHRocyBjb21wdXRh dGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaCBiL1Nv dXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgKaW5kZXggY2JmZGM4OTQ3MzA4ZTcyMDgy N2E3OWI1MTg2NTY4ZWNjNTUzODE1Mi4uYTY4NWEzMWQwNzJiYTUwODljMzQ3YzljNGFmYzUwYmU2 ZWRmYWMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCkBAIC0yOTAsNiArMjkwLDkg QEAgaW5saW5lIGJvb2wgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShjb25zdCBBdG9taWNTdHJpbmcm IGEsIGNvbnN0IEF0b21pY1N0cmluZyYgYikKIGlubGluZSBib29sIGVxdWFsSWdub3JpbmdBU0NJ SUNhc2UoY29uc3QgQXRvbWljU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpIHsgcmV0dXJuIGVx dWFsSWdub3JpbmdBU0NJSUNhc2UoYS5pbXBsKCksIGIuaW1wbCgpKTsgfQogaW5saW5lIGJvb2wg ZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShjb25zdCBTdHJpbmcmIGEsIGNvbnN0IEF0b21pY1N0cmlu ZyYgYikgeyByZXR1cm4gZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShhLmltcGwoKSwgYi5pbXBsKCkp OyB9CiAKK3RlbXBsYXRlIDx1bnNpZ25lZCBjaGFyYWN0ZXJzQ291bnQ+CitpbmxpbmUgYm9vbCBl cXVhbElnbm9yaW5nQVNDSUlDYXNlKGNvbnN0IEF0b21pY1N0cmluZyYgYSwgY29uc3QgY2hhciAo JmIpW2NoYXJhY3RlcnNDb3VudF0pIHsgcmV0dXJuIGVxdWFsSWdub3JpbmdBU0NJSUNhc2U8Y2hh cmFjdGVyc0NvdW50PihhLmltcGwoKSwgYik7IH0KKwogLy8gRGVmaW5lIGV4dGVybmFsIGdsb2Jh bCB2YXJpYWJsZXMgZm9yIHRoZSBjb21tb25seSB1c2VkIGF0b21pYyBzdHJpbmdzLgogLy8gVGhl c2UgYXJlIG9ubHkgdXNhYmxlIGZyb20gdGhlIG1haW4gdGhyZWFkLgogI2lmbmRlZiBBVE9NSUNT VFJJTkdfSElERV9HTE9CQUxTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvRm9udENhY2hlTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL0ZvbnRDYWNoZU1hYy5tbQppbmRleCA2MzVhZGNiMzhhNGJjNjFlNDYxZThiZmJh MDliOGU2MjIzMDE2MTE3Li4yYTA3MTMyOWM5YTE4MGY5NmI5MjUxYWExNjY0NDgxMmNlZTVjZjMx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udENh Y2hlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250 Q2FjaGVNYWMubW0KQEAgLTIyNSw5ICsyMjUsOSBAQCBzdGF0aWMgQ0dGbG9hdCB0b05TRm9udFdl aWdodChGb250V2VpZ2h0IGZvbnRXZWlnaHQpCiAKIHN0YXRpYyBPcHRpb25hbDxOU0ZvbnQqPiBm b250V2l0aEZhbWlseVNwZWNpYWxDYXNlKGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5LCBGb250 V2VpZ2h0IHdlaWdodCwgZmxvYXQgc2l6ZSkKIHsKLSAgICBpZiAoZXF1YWxJZ25vcmluZ0FTQ0lJ Q2FzZShmYW1pbHkuc3RyaW5nKCksICItd2Via2l0LXN5c3RlbS1mb250IikKLSAgICAgICAgfHwg ZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShmYW1pbHkuc3RyaW5nKCksICItYXBwbGUtc3lzdGVtIikK LSAgICAgICAgfHwgZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShmYW1pbHkuc3RyaW5nKCksICItYXBw bGUtc3lzdGVtLWZvbnQiKSkgeworICAgIGlmIChlcXVhbElnbm9yaW5nQVNDSUlDYXNlKGZhbWls eSwgIi13ZWJraXQtc3lzdGVtLWZvbnQiKQorICAgICAgICB8fCBlcXVhbElnbm9yaW5nQVNDSUlD YXNlKGZhbWlseSwgIi1hcHBsZS1zeXN0ZW0iKQorICAgICAgICB8fCBlcXVhbElnbm9yaW5nQVND SUlDYXNlKGZhbWlseSwgIi1hcHBsZS1zeXN0ZW0tZm9udCIpKSB7CiAjaWYgX19NQUNfT1NfWF9W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEwMDAKICAgICAgICAgcmV0dXJuIFtOU0ZvbnQgc3lz dGVtRm9udE9mU2l6ZTpzaXplIHdlaWdodDp0b05TRm9udFdlaWdodCh3ZWlnaHQpXTsKICNlbHNl CkBAIC0yMzUsNyArMjM1LDcgQEAgc3RhdGljIE9wdGlvbmFsPE5TRm9udCo+IGZvbnRXaXRoRmFt aWx5U3BlY2lhbENhc2UoY29uc3QgQXRvbWljU3RyaW5nJiBmYW1pbHksIEYKICNlbmRpZgogICAg IH0KIAotICAgIGlmIChlcXVhbElnbm9yaW5nQVNDSUlDYXNlKGZhbWlseS5zdHJpbmcoKSwgIi1h cHBsZS1zeXN0ZW0tbW9ub3NwYWNlZC1udW1iZXJzIikpIHsKKyAgICBpZiAoZXF1YWxJZ25vcmlu Z0FTQ0lJQ2FzZShmYW1pbHksICItYXBwbGUtc3lzdGVtLW1vbm9zcGFjZWQtbnVtYmVycyIpKSB7 CiAgICAgICAgIE5TQXJyYXkgKmZlYXR1cmVBcnJheSA9IEBbIEB7IE5TRm9udEZlYXR1cmVUeXBl SWRlbnRpZmllcktleSA6IEAoa051bWJlclNwYWNpbmdUeXBlKSwKICAgICAgICAgICAgIE5TRm9u dEZlYXR1cmVTZWxlY3RvcklkZW50aWZpZXJLZXkgOiBAKGtNb25vc3BhY2VkTnVtYmVyc1NlbGVj dG9yKSB9IF07CiAKQEAgLTI0NCwxMCArMjQ0LDEwIEBAIHN0YXRpYyBPcHRpb25hbDxOU0ZvbnQq PiBmb250V2l0aEZhbWlseVNwZWNpYWxDYXNlKGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5LCBG CiAgICAgICAgIHJldHVybiBbTlNGb250IGZvbnRXaXRoRGVzY3JpcHRvcjpkZXNjIHNpemU6c2l6 ZV07CiAgICAgfQogCi0gICAgaWYgKGVxdWFsSWdub3JpbmdBU0NJSUNhc2UoZmFtaWx5LnN0cmlu ZygpLCAiLWFwcGxlLW1lbnUiKSkKKyAgICBpZiAoZXF1YWxJZ25vcmluZ0FTQ0lJQ2FzZShmYW1p bHksICItYXBwbGUtbWVudSIpKQogICAgICAgICByZXR1cm4gW05TRm9udCBtZW51Rm9udE9mU2l6 ZTpzaXplXTsKIAotICAgIGlmIChlcXVhbElnbm9yaW5nQVNDSUlDYXNlKGZhbWlseS5zdHJpbmco KSwgIi1hcHBsZS1zdGF0dXMtYmFyIikpCisgICAgaWYgKGVxdWFsSWdub3JpbmdBU0NJSUNhc2Uo ZmFtaWx5LCAiLWFwcGxlLXN0YXR1cy1iYXIiKSkKICAgICAgICAgcmV0dXJuIFtOU0ZvbnQgbGFi ZWxGb250T2ZTaXplOnNpemVdOwogCiAgICAgcmV0dXJuIE9wdGlvbmFsPE5TRm9udCo+KE51bGxv cHQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IDEx NDgxYjljNjk2N2IwOWRlYjcwNGM5NzExZDJiOTU0NGUxNmFkMmMuLjE0YThlZDYxZDEyMGM5MThl NGRkM2MzYjFlNjRmNjg3ZDlkNTU4N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVNYWMubW0KQEAgLTM1MCwxOCArMzUwLDE4IEBAIHZvaWQgUmVuZGVyVGhlbWVNYWM6 OnVwZGF0ZUNhY2hlZFN5c3RlbUZvbnREZXNjcmlwdGlvbihDU1NWYWx1ZUlEIGNzc1ZhbHVlSWQs IEZvCiAgICAgLy8gU3lzdGVtLWZvbnQtbmVzcyBjYW4ndCBiZSBlbmNhcHN1bGF0ZWQgYnkgc2lt cGx5IGEgZm9udCBuYW1lLiBJbnN0ZWFkLCB3ZSBtdXN0IHVzZSBhIHRva2VuCiAgICAgLy8gd2hp Y2ggRm9udENhY2hlIHdpbGwgbG9vayBmb3IuCiAgICAgLy8gTWFrZSBzdXJlIHdlIGtlZXAgdGhp cyBsaXN0IG9mIHBvc3NpYmxlIHRva2VucyBpbiBzeW5jIHdpdGggRm9udENhc2NhZGU6OnByaW1h cnlGb250SXNTeXN0ZW1Gb250KCkKLSAgICBTdHJpbmcgZm9udE5hbWUoQVNDSUlMaXRlcmFsKCIt YXBwbGUtc3lzdGVtIikpOworICAgIEF0b21pY1N0cmluZyBmb250TmFtZTsKICAgICBzd2l0Y2gg KGNzc1ZhbHVlSWQpIHsKICAgICAgICAgY2FzZSBDU1NWYWx1ZVNtYWxsQ2FwdGlvbjoKICAgICAg ICAgICAgIGZvbnQgPSBbTlNGb250IHN5c3RlbUZvbnRPZlNpemU6W05TRm9udCBzbWFsbFN5c3Rl bUZvbnRTaXplXV07CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NWYWx1ZU1l bnU6CiAgICAgICAgICAgICBmb250ID0gW05TRm9udCBtZW51Rm9udE9mU2l6ZTpbTlNGb250IHN5 c3RlbUZvbnRTaXplXV07Ci0gICAgICAgICAgICBmb250TmFtZSA9IFN0cmluZyhBU0NJSUxpdGVy YWwoIi1hcHBsZS1tZW51IikpOworICAgICAgICAgICAgZm9udE5hbWUgPSBBdG9taWNTdHJpbmco Ii1hcHBsZS1tZW51IiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7CiAgICAg ICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NWYWx1ZVN0YXR1c0JhcjoKICAgICAgICAg ICAgIGZvbnQgPSBbTlNGb250IGxhYmVsRm9udE9mU2l6ZTpbTlNGb250IGxhYmVsRm9udFNpemVd XTsKLSAgICAgICAgICAgIGZvbnROYW1lID0gU3RyaW5nKEFTQ0lJTGl0ZXJhbCgiLWFwcGxlLXN0 YXR1cy1iYXIiKSk7CisgICAgICAgICAgICBmb250TmFtZSA9IEF0b21pY1N0cmluZygiLWFwcGxl LXN0YXR1cy1iYXIiLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1ZhbHVlV2Via2l0TWluaUNvbnRyb2w6CiAg ICAgICAgICAgICBmb250ID0gW05TRm9udCBzeXN0ZW1Gb250T2ZTaXplOltOU0ZvbnQgc3lzdGVt Rm9udFNpemVGb3JDb250cm9sU2l6ZTpOU01pbmlDb250cm9sU2l6ZV1dOwpAQCAtMzc5LDYgKzM3 OSw5IEBAIHZvaWQgUmVuZGVyVGhlbWVNYWM6OnVwZGF0ZUNhY2hlZFN5c3RlbUZvbnREZXNjcmlw dGlvbihDU1NWYWx1ZUlEIGNzc1ZhbHVlSWQsIEZvCiAgICAgaWYgKCFmb250KQogICAgICAgICBy ZXR1cm47CiAKKyAgICBpZiAoZm9udE5hbWUuaXNOdWxsKCkpCisgICAgICAgIGZvbnROYW1lID0g QXRvbWljU3RyaW5nKCItYXBwbGUtc3lzdGVtIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9t TGl0ZXJhbCk7CisKICAgICBOU0ZvbnRNYW5hZ2VyICpmb250TWFuYWdlciA9IFtOU0ZvbnRNYW5h Z2VyIHNoYXJlZEZvbnRNYW5hZ2VyXTsKICAgICBmb250RGVzY3JpcHRpb24uc2V0SXNBYnNvbHV0 ZVNpemUodHJ1ZSk7CiAgICAgZm9udERlc2NyaXB0aW9uLnNldE9uZUZhbWlseShmb250TmFtZSk7 Cg==