145143 2015-05-18 14:27:40 -0700 Fix the build of universal binary with ARMv7k of JavaScriptCore. 2015-05-19 12:33:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo webkit-bug-importer oldest_to_newest 1095681 0 mark.lam 2015-05-18 14:27:40 -0700 Patch coming. 1095683 1 mark.lam 2015-05-18 14:29:49 -0700 <rdar://problem/20968297> 1095685 2 253344 mark.lam 2015-05-18 14:33:32 -0700 Created attachment 253344 the patch. 1095688 3 253344 ggaren 2015-05-18 14:42:11 -0700 Comment on attachment 253344 the patch. r=me Would be nice to include in this comment an explanation of exactly why "if X end" has any meaning whatsoever, since it usually has no meaning. 1095991 4 mark.lam 2015-05-19 12:33:52 -0700 Thanks for the review. I added an explanation of why this is needed to the ChangeLog. I also reversed the order of the armv7k and armv7s if statements in LowLevelInterpreter.asm to have them in alphabetical order. Landed in r184581: <http://trac.webkit.org/r184581>. 253344 2015-05-18 14:33:32 -0700 2015-05-18 14:42:11 -0700 the patch. bug-145143.patch text/plain 2285 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0NTExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTA1LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggdGhlIGJ1aWxkIG9mIGEgdW5pdmVyc2FsIGJpbmFyeSB3aXRoIEFSTXY3ayBvZiBKYXZhU2Ny aXB0Q29yZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTE0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbGxpbnQvTExJbnRPZmZsaW5lQXNtQ29uZmlnLmg6CisgICAgICAgICogbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlci5hc206CisKIDIwMTUtMDUtMTggIEJlbmphbWluIFBvdWxhaW4gIDxiZW5q YW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtKU0NdIFdoZW4gZW50ZXJpbmcgYSBDaGVja1Rp ZXJVcCB3aXRob3V0IE9TUkVudHJ5LCBmb3JjZSB0aGUgQ2hlY2tUaWVyVXAgZm9yIHRoZSBvdXRl ciBsb29wcyB3aXRoIE9TUiBFbnRyeQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xMSW50T2ZmbGluZUFzbUNvbmZpZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9MTEludE9mZmxpbmVBc21Db25maWcuaAkocmV2aXNpb24gMTg0NTEwKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50T2ZmbGluZUFzbUNvbmZpZy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiAjZGVmaW5lIE9GRkxJTkVfQVNNX0FSTTY0IDAK ICNkZWZpbmUgT0ZGTElORV9BU01fWDg2XzY0IDAKICNkZWZpbmUgT0ZGTElORV9BU01fWDg2XzY0 X1dJTiAwCisjZGVmaW5lIE9GRkxJTkVfQVNNX0FSTXY3ayAwCiAjZGVmaW5lIE9GRkxJTkVfQVNN X0FSTXY3cyAwCiAjZGVmaW5lIE9GRkxJTkVfQVNNX01JUFMgMAogI2RlZmluZSBPRkZMSU5FX0FT TV9TSDQgMApAQCAtNjAsNiArNjEsMTIgQEAKICNkZWZpbmUgT0ZGTElORV9BU01fWDg2X1dJTiAw CiAjZW5kaWYKIAorI2lmZGVmIF9fQVJNX0FSQ0hfN0tfXworI2RlZmluZSBPRkZMSU5FX0FTTV9B Uk12N2sgMQorI2Vsc2UKKyNkZWZpbmUgT0ZGTElORV9BU01fQVJNdjdrIDAKKyNlbmRpZgorCiAj aWZkZWYgX19BUk1fQVJDSF83U19fCiAjZGVmaW5lIE9GRkxJTkVfQVNNX0FSTXY3cyAxCiAjZWxz ZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIu YXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyLmFzbQkocmV2aXNpb24gMTg0NTEwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0yNCwxMSAr MjQsMTMgQEAKICMgRmlyc3QgY29tZSB0aGUgY29tbW9uIHByb3RvY29scyB0aGF0IGJvdGggaW50 ZXJwcmV0ZXJzIHVzZS4gTm90ZSB0aGF0IGVhY2gKICMgb2YgdGhlc2UgbXVzdCBoYXZlIGFuIEFT U0VSVCgpIGluIExMSW50RGF0YS5jcHAKIAotIyBXb3JrLWFyb3VuZCBmb3IgdGhlIGZhY3QgdGhh dCB0aGUgdG9vbGNoYWluJ3MgYXdhcmVuZXNzIG9mIGFybXY3cyByZXN1bHRzIGluCi0jIGEgc2Vw YXJhdGUgc2xhYiBpbiB0aGUgZmF0IGJpbmFyeSwgeWV0IHRoZSBvZmZsaW5lYXNtIGRvZXNuJ3Qg a25vdyB0byBleHBlY3QKLSMgaXQuCisjIFdvcmstYXJvdW5kIGZvciB0aGUgZmFjdCB0aGF0IHRo ZSB0b29sY2hhaW4ncyBhd2FyZW5lc3Mgb2YgYXJtdjdzIC8gYXJtdjdrCisjIHJlc3VsdHMgaW4g YSBzZXBhcmF0ZSBzbGFiIGluIHRoZSBmYXQgYmluYXJ5LCB5ZXQgdGhlIG9mZmxpbmVhc20gZG9l c24ndCBrbm93CisjIHRvIGV4cGVjdCBpdC4KIGlmIEFSTXY3cwogZW5kCitpZiBBUk12N2sKK2Vu ZAogCiAjIFRoZXNlIGRlY2xhcmF0aW9ucyBtdXN0IG1hdGNoIGludGVycHJldGVyL0pTU3RhY2su aC4KIAo=