145140 2015-05-18 14:18:52 -0700 REGRESSION(142590): Scroll-snap points are improperly snapping to earlier index values 2015-05-19 12:48:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 145175 1 bfulgham bfulgham bdakin bfulgham simon.fraser webkit-bug-importer oldest_to_newest 1095676 0 bfulgham 2015-05-18 14:18:52 -0700 My fix in Bug 142590 for resizing events introduced a snapping logic bug that causes some scroll-snap gestures to trigger the "nearestActiveSnapPoint" logic, throwing the scroll position back to the previous snap point. This must be fixed! 1095687 1 bfulgham 2015-05-18 14:35:56 -0700 The new "nearestActiveSnapPoint" logic is firing while scroll snap animations are running. We need to add an "isScrollSnapInProgress" predicate, much like the existing "isRubberBandInProgress" to avoid certain "fix-up" logic that we don't want running while we are in the process of moving to a new position. 1095690 2 bfulgham 2015-05-18 14:55:53 -0700 <rdar://problem/21006738> 1095691 3 253345 bfulgham 2015-05-18 14:56:33 -0700 Created attachment 253345 Patch 1095692 4 253345 bdakin 2015-05-18 14:58:37 -0700 Comment on attachment 253345 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253345&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.h:135 > + bool isRubberBandInProgress() const override; Did you mean to remove the "virtual" from isRubberBandInProgress()? 1095693 5 bfulgham 2015-05-18 14:59:52 -0700 (In reply to comment #4) > Comment on attachment 253345 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253345&action=review > > > Source/WebCore/platform/mac/ScrollAnimatorMac.h:135 > > + bool isRubberBandInProgress() const override; > > Did you mean to remove the "virtual" from isRubberBandInProgress()? I just switched to the new 'override' style guideline, where we don't also leave the 'virtual' declaration (it's implied by the 'override' keyword). 1095694 6 bfulgham 2015-05-18 15:01:27 -0700 Committed r184513: <http://trac.webkit.org/changeset/184513> 253345 2015-05-18 14:56:33 -0700 2015-05-18 14:58:37 -0700 Patch bug-145140-20150518145632.patch text/plain 5617 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDUxMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA1LTE4ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04oMTQyNTkw KTogU2Nyb2xsLXNuYXAgcG9pbnRzIGFyZSBpbXByb3Blcmx5IHNuYXBwaW5nIHRvIGVhcmxpZXIg aW5kZXggdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDUxNDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIxMDA2NzM4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBuZXcgIm5lYXJlc3RB Y3RpdmVTbmFwUG9pbnQiIGxvZ2ljIGlzIGZpcmluZyB3aGlsZSBzY3JvbGwgc25hcCBhbmltYXRp b25zIGFyZSBydW5uaW5nLiBXZSBuZWVkCisgICAgICAgIHRvIGFkZCBhbiAiaXNTY3JvbGxTbmFw SW5Qcm9ncmVzcyIgcHJlZGljYXRlLCBtdWNoIGxpa2UgdGhlIGV4aXN0aW5nICJpc1J1YmJlckJh bmRJblByb2dyZXNzIiB0byBhdm9pZAorICAgICAgICBjZXJ0YWluICJmaXgtdXAiIGxvZ2ljIHRo YXQgd2UgZG9uJ3Qgd2FudCBydW5uaW5nIHdoaWxlIHdlIGFyZSBpbiB0aGUgcHJvY2VzcyBvZiBt b3ZpbmcgdG8gYSBuZXcgcG9zaXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxBbmlt YXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3I6OlNjcm9sbEFuaW1hdG9y Ojppc1Njcm9sbFNuYXBJblByb2dyZXNzKTogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vU2Ny b2xsYWJsZUFyZWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6OnVwZGF0 ZVNjcm9sbFNuYXBTdGF0ZSk6IElmIHdlIGFyZSBpbiB0aGUgbWlkc3Qgb2YgYSBzY3JvbGwgc25h cCBvcGVyYXRpb24sCisgICAgICAgIGRvIG5vdCBhdHRlbXB0IHRvIHJlc2V0IHBvc2l0aW9uIHRv IHRoZSBjdXJyZW50IGFjdGl2ZSBzbmFwIHBvaW50LgorICAgICAgICAqIHBsYXRmb3JtL2NvY29h L1Njcm9sbENvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250 cm9sbGVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQ29udHJvbGxlcjo6aXNTY3JvbGxT bmFwSW5Qcm9ncmVzcyk6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmlt YXRvck1hYy5oOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9yTWFjOjppc1Njcm9sbFNuYXBJblByb2dy ZXNzKTogQWRkZWQuCisKIDIwMTUtMDUtMTcgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdv QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0gQWRkIHNjcm9sbGJhciB3 aWR0aCBpbiBpbnRyaW5zaWMgbG9naWNhbCB3aWR0aHMgY29tcHV0YXRpb24KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuaAkocmV2aXNpb24gMTg0NTA5KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3IuaAkod29ya2luZyBjb3B5KQpA QCAtMTE4LDYgKzExOCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5Q29udGVu dEFyZWFTY3JvbGxlZChjb25zdCBGbG9hdFNpemUmIGRlbHRhKSB7IFVOVVNFRF9QQVJBTShkZWx0 YSk7IH0KIAogICAgIHZpcnR1YWwgYm9vbCBpc1J1YmJlckJhbmRJblByb2dyZXNzKCkgY29uc3Qg eyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIGJvb2wgaXNTY3JvbGxTbmFwSW5Qcm9ncmVz cygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2b2lkIHNldFdoZWVsRXZlbnRUZXN0 VHJpZ2dlcihSZWZQdHI8V2hlZWxFdmVudFRlc3RUcmlnZ2VyPiYmIHRlc3RUcmlnZ2VyKSB7IG1f d2hlZWxFdmVudFRlc3RUcmlnZ2VyID0gdGVzdFRyaWdnZXI7IH0KICNpZiAoRU5BQkxFKENTU19T Q1JPTExfU05BUCkgfHwgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKSkgJiYgUExBVEZPUk0oTUFDKQpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGFibGVBcmVhLmNwcAkocmV2aXNp b24gMTg0NTA5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NTgsOCArNDU4LDExIEBAIEludFBvaW50IFNjcm9sbGFibGVB cmVhOjpuZWFyZXN0QWN0aXZlU24KIHZvaWQgU2Nyb2xsYWJsZUFyZWE6OnVwZGF0ZVNjcm9sbFNu YXBTdGF0ZSgpCiB7CiAjaWYgUExBVEZPUk0oTUFDKQotICAgIGlmIChTY3JvbGxBbmltYXRvciog c2Nyb2xsQW5pbWF0b3IgPSBleGlzdGluZ1Njcm9sbEFuaW1hdG9yKCkpCisgICAgaWYgKFNjcm9s bEFuaW1hdG9yKiBzY3JvbGxBbmltYXRvciA9IGV4aXN0aW5nU2Nyb2xsQW5pbWF0b3IoKSkgewog ICAgICAgICBzY3JvbGxBbmltYXRvci0+dXBkYXRlU2Nyb2xsQW5pbWF0b3JzQW5kVGltZXJzKCk7 CisgICAgICAgIGlmIChzY3JvbGxBbmltYXRvci0+aXNTY3JvbGxTbmFwSW5Qcm9ncmVzcygpKQor ICAgICAgICAgICAgcmV0dXJuOworICAgIH0KICNlbmRpZgogCiAgICAgSW50UG9pbnQgY3VycmVu dFBvc2l0aW9uID0gc2Nyb2xsUG9zaXRpb24oKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2NvY29hL1Njcm9sbENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jb2NvYS9TY3JvbGxDb250cm9sbGVyLmgJKHJldmlzaW9uIDE4NDUwOSkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRyb2xsZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTE0LDYgKzExNCw3IEBAIHB1YmxpYzoKICAgICBib29sIGhhbmRsZVdoZWVs RXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50Jik7CiAKICAgICBib29sIGlzUnViYmVyQmFu ZEluUHJvZ3Jlc3MoKSBjb25zdDsKKyAgICBib29sIGlzU2Nyb2xsU25hcEluUHJvZ3Jlc3MoKSBj b25zdDsKIAogI2lmIEVOQUJMRShDU1NfU0NST0xMX1NOQVApICYmIFBMQVRGT1JNKE1BQykKICAg ICBib29sIHByb2Nlc3NXaGVlbEV2ZW50Rm9yU2Nyb2xsU25hcChjb25zdCBQbGF0Zm9ybVdoZWVs RXZlbnQmKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL1Njcm9sbENvbnRy b2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvU2Ny b2xsQ29udHJvbGxlci5tbQkocmV2aXNpb24gMTg0NTA5KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vY29jb2EvU2Nyb2xsQ29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNDA0LDYg KzQwNCwxNSBAQCBib29sIFNjcm9sbENvbnRyb2xsZXI6OmlzUnViYmVyQmFuZEluUHJvCiAgICAg cmV0dXJuICFtX2NsaWVudC5zdHJldGNoQW1vdW50KCkuaXNaZXJvKCk7CiB9CiAKK2Jvb2wgU2Ny b2xsQ29udHJvbGxlcjo6aXNTY3JvbGxTbmFwSW5Qcm9ncmVzcygpIGNvbnN0Cit7CisjaWYgRU5B QkxFKENTU19TQ1JPTExfU05BUCkgJiYgUExBVEZPUk0oTUFDKQorICAgIGlmIChtX2luU2Nyb2xs R2VzdHVyZSB8fCBtX21vbWVudHVtU2Nyb2xsSW5Qcm9ncmVzcyB8fCBtX2hvcml6b250YWxTY3Jv bGxTbmFwVGltZXIuaXNBY3RpdmUoKSB8fCBtX3ZlcnRpY2FsU2Nyb2xsU25hcFRpbWVyLmlzQWN0 aXZlKCkpCisgICAgICAgIHJldHVybiB0cnVlOworI2VuZGlmCisgICAgcmV0dXJuIGZhbHNlOwor fQorCiB2b2lkIFNjcm9sbENvbnRyb2xsZXI6OnN0YXJ0U25hcFJ1YmJlcmJhbmRUaW1lcigpCiB7 CiAgICAgbV9jbGllbnQuc3RhcnRTbmFwUnViYmVyYmFuZFRpbWVyKCk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMuaAkocmV2aXNpb24g MTg0NTA5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj LmgJKHdvcmtpbmcgY29weSkKQEAgLTEzMiw3ICsxMzIsOCBAQCBwcml2YXRlOgogCiAgICAgdm9p ZCBpbW1lZGlhdGVTY3JvbGxUbyhjb25zdCBGbG9hdFBvaW50Jik7CiAKLSAgICB2aXJ0dWFsIGJv b2wgaXNSdWJiZXJCYW5kSW5Qcm9ncmVzcygpIGNvbnN0IG92ZXJyaWRlOworICAgIGJvb2wgaXNS dWJiZXJCYW5kSW5Qcm9ncmVzcygpIGNvbnN0IG92ZXJyaWRlOworICAgIGJvb2wgaXNTY3JvbGxT bmFwSW5Qcm9ncmVzcygpIGNvbnN0IG92ZXJyaWRlOwogCiAjaWYgRU5BQkxFKFJVQkJFUl9CQU5E SU5HKQogICAgIC8vLyBTY3JvbGxDb250cm9sbGVyQ2xpZW50IG1lbWJlciBmdW5jdGlvbnMuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj Lm1tCShyZXZpc2lvbiAxODQ1MDkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Ny b2xsQW5pbWF0b3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTc2OSw2ICs3NjksMTUgQEAgYm9v bCBTY3JvbGxBbmltYXRvck1hYzo6aXNSdWJiZXJCYW5kSW5QcgogI2VuZGlmCiB9CiAKK2Jvb2wg U2Nyb2xsQW5pbWF0b3JNYWM6OmlzU2Nyb2xsU25hcEluUHJvZ3Jlc3MoKSBjb25zdAoreworI2lm IEVOQUJMRShDU1NfU0NST0xMX1NOQVApCisgICAgcmV0dXJuIG1fc2Nyb2xsQ29udHJvbGxlci5p c1Njcm9sbFNuYXBJblByb2dyZXNzKCk7CisjZWxzZQorICAgIHJldHVybiBmYWxzZTsKKyNlbmRp ZgorfQorCiB2b2lkIFNjcm9sbEFuaW1hdG9yTWFjOjppbW1lZGlhdGVTY3JvbGxUb1BvaW50Rm9y U2Nyb2xsQW5pbWF0aW9uKGNvbnN0IEZsb2F0UG9pbnQmIG5ld1Bvc2l0aW9uKQogewogICAgIEFT U0VSVChtX3Njcm9sbEFuaW1hdGlvbkhlbHBlcik7Cg==