145139 2015-05-18 14:14:11 -0700 Web Inspector: Improve Reliability of Closing and Reopening Elements Tab 2015-05-18 16:31:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1095673 0 joepeck 2015-05-18 14:14:11 -0700 * SUMMARY Improve Reliability of Closing and Reopening Elements Tab. I was seeing an issue with an augmented DOM Agent, that closing and reopening the Elements Tab was not showing the DOM Tree child nodes of the root node. The issue seems to be that we don't show child nodes until the DOMTreeOutline is visible, but making the tree visible might not actually cause us to update and show the children again. Since we only make the tree visible once, update at that point so we are sure to add the children. It seems we luck out with web inspection through node restoration. I am not sure exactly why we work, or if it just happens to be due to lucky timing. 1095675 1 253341 joepeck 2015-05-18 14:16:34 -0700 Created attachment 253341 [PATCH] Proposed Fix 1095699 2 253341 commit-queue 2015-05-18 15:17:06 -0700 Comment on attachment 253341 [PATCH] Proposed Fix Clearing flags on attachment: 253341 Committed r184515: <http://trac.webkit.org/changeset/184515> 1095700 3 commit-queue 2015-05-18 15:17:11 -0700 All reviewed patches have been landed. Closing bug. 1095733 4 webkit-bug-importer 2015-05-18 16:31:25 -0700 <rdar://problem/21009123> 253341 2015-05-18 14:16:34 -0700 2015-05-18 15:17:06 -0700 [PATCH] Proposed Fix elements-tab.patch text/plain 6658 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZhZDBhMzIuLjY0NGRjNmViIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxNS0wNS0xOCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcHJv dmUgUmVsaWFiaWxpdHkgb2YgQ2xvc2luZyBhbmQgUmVvcGVuaW5nIEVsZW1lbnRzIFRhYgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MTM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRy ZWVFbGVtZW50LnByb3RvdHlwZS5oaWdobGlnaHRTZWFyY2hSZXN1bHRzKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUuaGlkZVNlYXJjaEhpZ2hsaWdodHMp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5lbXBoYXNp emVTZWFyY2hIaWdobGlnaHQuYW5pbWF0aW9uRW5kZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5lbXBoYXNpemVTZWFyY2hIaWdobGlnaHQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fdXBkYXRlQ2hpbGRy ZW4pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5hZGp1 c3RDb2xsYXBzZWRSYW5nZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQu cHJvdG90eXBlLl9zdGFydEVkaXRpbmdBc0hUTUwuZGlzcG9zZSk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zdGFydEVkaXRpbmdBc0hUTUwpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS51cGRhdGVUaXRsZSk6 CisgICAgICAgIFN0b3AgdXNpbmcgdGhlIGBkZWxldGVgIG9wZXJhdG9yLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01UcmVlT3V0bGluZS5wcm90b3R5cGUuc2V0VmlzaWJsZSk6CisgICAgICAgIFRyaWdn ZXIgYW4gdXBkYXRlIHdoZW4gdGhlIG91dGxpbmUgaXMgbWFkZSB2aXNpYmxlLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9GcmFtZURPTVRyZWVDb250ZW50Vmlldy5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5GcmFtZURPTVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUuX3Jvb3RE T01Ob2RlQXZhaWxhYmxlKToKKyAgICAgICAgUHJvdmlkZSBhIHJlYXNvbmFibGUgZGVmYXVsdCBz ZWxlY3Rpb24gaWYgdGhlcmUgaXMgbm8gYm9keSBvciBkb2N1bWVudCBlbGVtZW50LgorICAgICAg ICBGb3IgZXhhbXBsZSBpbiBhbiBhdWdtZW50ZWQgRE9NIHRyZWUuCisKIDIwMTUtMDUtMTUgIE1h dHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGVtcHR5IHRpbWVsaW5lIHNob3VsZCBub3QgdXNlIHByZXZpb3VzIHRpbWVsaW5lJ3Mgem9vbSBp bnRlcnZhbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRE9NVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcwppbmRleCA4ZWU1NTlmLi45MzkxZDg3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVl RWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9ET01UcmVlRWxlbWVudC5qcwpAQCAtNTIsNyArNTIsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJl ZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVl RWxlbQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX3NlYXJjaFF1ZXJ5ICE9PSBzZWFyY2hRdWVy eSkgewogICAgICAgICAgICAgdGhpcy5fdXBkYXRlU2VhcmNoSGlnaGxpZ2h0KGZhbHNlKTsKLSAg ICAgICAgICAgIGRlbGV0ZSB0aGlzLl9oaWdobGlnaHRSZXN1bHQ7IC8vIEEgbmV3IHNlYXJjaCBx dWVyeS4KKyAgICAgICAgICAgIHRoaXMuX2hpZ2hsaWdodFJlc3VsdCA9IHVuZGVmaW5lZDsgLy8g QSBuZXcgc2VhcmNoIHF1ZXJ5LgogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc2VhcmNoUXVl cnkgPSBzZWFyY2hRdWVyeTsKQEAgLTYyLDcgKzYyLDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVF bGVtZW50ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZUVs ZW0KIAogICAgIGhpZGVTZWFyY2hIaWdobGlnaHRzKCkKICAgICB7Ci0gICAgICAgIGRlbGV0ZSB0 aGlzLl9zZWFyY2hIaWdobGlnaHRzVmlzaWJsZTsKKyAgICAgICAgdGhpcy5fc2VhcmNoSGlnaGxp Z2h0c1Zpc2libGUgPSBmYWxzZTsKICAgICAgICAgdGhpcy5fdXBkYXRlU2VhcmNoSGlnaGxpZ2h0 KGZhbHNlKTsKICAgICB9CiAKQEAgLTkzLDcgKzkzLDcgQEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVF bGVtZW50ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZUVs ZW0KICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgIHRoaXMuX2JvdW5jeUhp Z2hsaWdodEVsZW1lbnQucmVtb3ZlKCk7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fYm91bmN5 SGlnaGxpZ2h0RWxlbWVudDsKKyAgICAgICAgICAgIHRoaXMuX2JvdW5jeUhpZ2hsaWdodEVsZW1l bnQgPSBudWxsOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fYm91bmN5SGlnaGxpZ2h0RWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCJ3ZWJraXRBbmltYXRpb25FbmQiLCBhbmltYXRpb25FbmRl ZC5iaW5kKHRoaXMpKTsKQEAgLTQwNyw3ICs0MDcsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUVs ZW1lbnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVlRWxl bQogICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lQ29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3Ag PSBvcmlnaW5hbFNjcm9sbFRvcDsKICAgICAgICAgfQogCi0gICAgICAgIGRlbGV0ZSB0aGlzLl91 cGRhdGVDaGlsZHJlbkluUHJvZ3Jlc3M7CisgICAgICAgIHRoaXMuX3VwZGF0ZUNoaWxkcmVuSW5Q cm9ncmVzcyA9IGZhbHNlOwogICAgIH0KIAogICAgIGFkanVzdENvbGxhcHNlZFJhbmdlKCkKQEAg LTQ0Nyw3ICs0NDcsNyBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01U cmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVlRWxlbQogCiAgICAgICAgICAgICB0 aGlzLmV4cGFuZEFsbEJ1dHRvbkVsZW1lbnQudGV4dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlNob3cgQWxsIE5vZGVzICglZCBNb3JlKSIpLmZvcm1hdChjaGlsZE5vZGVDb3VudCAt IGV4cGFuZGVkQ2hpbGRDb3VudCk7CiAgICAgICAgIH0gZWxzZSBpZiAodGhpcy5leHBhbmRBbGxC dXR0b25FbGVtZW50KQotICAgICAgICAgICAgZGVsZXRlIHRoaXMuZXhwYW5kQWxsQnV0dG9uRWxl bWVudDsKKyAgICAgICAgICAgIHRoaXMuZXhwYW5kQWxsQnV0dG9uRWxlbWVudCA9IG51bGw7CiAg ICAgfQogCiAgICAgaGFuZGxlTG9hZEFsbENoaWxkcmVuKCkKQEAgLTgzOSw3ICs4MzksNyBAQCBX ZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRz IFdlYkluc3BlY3Rvci5UcmVlRWxlbQogCiAgICAgICAgICAgICAvLyBSZW1vdmUgZWRpdG9yLgog ICAgICAgICAgICAgdGhpcy5saXN0SXRlbUVsZW1lbnQucmVtb3ZlQ2hpbGQodGhpcy5faHRtbEVk aXRFbGVtZW50KTsKLSAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9odG1sRWRpdEVsZW1lbnQ7Cisg ICAgICAgICAgICB0aGlzLl9odG1sRWRpdEVsZW1lbnQgPSBudWxsOwogICAgICAgICAgICAgLy8g VW5oaWRlIGNoaWxkcmVuIGl0ZW0uCiAgICAgICAgICAgICBpZiAodGhpcy5fY2hpbGRyZW5MaXN0 Tm9kZSkKICAgICAgICAgICAgICAgICB0aGlzLl9jaGlsZHJlbkxpc3ROb2RlLnN0eWxlLnJlbW92 ZVByb3BlcnR5KCJkaXNwbGF5Iik7CkBAIC0xMDMwLDEwICsxMDMwLDEwIEBAIFdlYkluc3BlY3Rv ci5ET01UcmVlRWxlbWVudCA9IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVj dG9yLlRyZWVFbGVtCiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICB0aGlzLnRpdGxlID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpOwogICAgICAgICAgICAgdGhpcy50aXRsZS5h cHBlbmRDaGlsZCh0aGlzLl9ub2RlVGl0bGVJbmZvKCkudGl0bGVET00pOwotICAgICAgICAgICAg ZGVsZXRlIHRoaXMuX2hpZ2hsaWdodFJlc3VsdDsKKyAgICAgICAgICAgIHRoaXMuX2hpZ2hsaWdo dFJlc3VsdCA9IHVuZGVmaW5lZDsKICAgICAgICAgfQogCi0gICAgICAgIGRlbGV0ZSB0aGlzLnNl bGVjdGlvbkVsZW1lbnQ7CisgICAgICAgIHRoaXMuc2VsZWN0aW9uRWxlbWVudCA9IG51bGw7CiAg ICAgICAgIHRoaXMudXBkYXRlU2VsZWN0aW9uKCk7CiAgICAgICAgIHRoaXMuX2hpZ2hsaWdodFNl YXJjaFJlc3VsdHMoKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlT3V0bGluZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCmluZGV4IDZjNjEzNTEu LmE1NzQ5NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVPdXRsaW5lLmpzCkBAIC04OSw4ICs4OSwxMSBAQCBXZWJJ bnNwZWN0b3IuRE9NVHJlZU91dGxpbmUgPSBjbGFzcyBET01UcmVlT3V0bGluZSBleHRlbmRzIFdl Ykluc3BlY3Rvci5UcmVlT3V0bAogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMu X3VwZGF0ZU1vZGlmaWVkTm9kZXMoKTsKKwogICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRET01O b2RlKQogICAgICAgICAgICAgdGhpcy5fcmV2ZWFsQW5kU2VsZWN0Tm9kZSh0aGlzLl9zZWxlY3Rl ZERPTU5vZGUsIG9taXRGb2N1cyk7CisKKyAgICAgICAgdGhpcy51cGRhdGUoKTsKICAgICB9CiAK ICAgICBnZXQgcm9vdERPTU5vZGUoKQpAQCAtMTc2LDcgKzE3OSw3IEBAIFdlYkluc3BlY3Rvci5E T01UcmVlT3V0bGluZSA9IGNsYXNzIERPTVRyZWVPdXRsaW5lIGV4dGVuZHMgV2ViSW5zcGVjdG9y LlRyZWVPdXRsCiAgICAgICAgICAgICAgICAgdHJlZUVsZW1lbnQuc2VsZWN0YWJsZSA9IHRoaXMu X3NlbGVjdEVuYWJsZWQ7CiAgICAgICAgICAgICAgICAgdGhpcy5hcHBlbmRDaGlsZCh0cmVlRWxl bWVudCk7CiAgICAgICAgICAgICAgICAgbm9kZSA9IG5vZGUubmV4dFNpYmxpbmc7Ci0gICAgICAg ICAgICAgICAgCisKICAgICAgICAgICAgICAgICBpZiAodHJlZUVsZW1lbnQuaGFzQ2hpbGRyZW4g JiYgIXRyZWVFbGVtZW50LmV4cGFuZGVkKQogICAgICAgICAgICAgICAgICAgICB0cmVlRWxlbWVu dC5leHBhbmQoKTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZyYW1lRE9NVHJlZUNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRnJhbWVET01UcmVlQ29udGVu dFZpZXcuanMKaW5kZXggZTQ5NmM2YS4uMDI2YjhkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRnJhbWVET01UcmVlQ29udGVudFZpZXcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRnJhbWVET01U cmVlQ29udGVudFZpZXcuanMKQEAgLTcyLDcgKzcyLDcgQEAgV2ViSW5zcGVjdG9yLkZyYW1lRE9N VHJlZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQogCi0gICAgICAgIHRoaXMuX3Jlc3RvcmVTZWxlY3RlZE5vZGVBZnRlclVwZGF0ZSh0aGlz Ll9kb21UcmVlLmZyYW1lLnVybCwgcm9vdERPTU5vZGUuYm9keSB8fCByb290RE9NTm9kZS5kb2N1 bWVudEVsZW1lbnQpOworICAgICAgICB0aGlzLl9yZXN0b3JlU2VsZWN0ZWROb2RlQWZ0ZXJVcGRh dGUodGhpcy5fZG9tVHJlZS5mcmFtZS51cmwsIHJvb3RET01Ob2RlLmJvZHkgfHwgcm9vdERPTU5v ZGUuZG9jdW1lbnRFbGVtZW50IHx8IHJvb3RET01Ob2RlLmZpcnN0Q2hpbGQpOwogICAgIH0sCiAK ICAgICBfcm9vdERPTU5vZGVJbnZhbGlkYXRlZDogZnVuY3Rpb24oZXZlbnQpCg==