145128 2015-05-18 04:47:47 -0700 Fix the libusrsctp build with clang 2015-06-12 03:03:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy commit-queue ossy oldest_to_newest 1095607 0 ossy 2015-05-18 04:47:47 -0700 libusrsctp isn't buildable with clang: netinet/sctp_timer.c:685:46: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if (((&stcb->asoc.send_queue)->tqh_first == ((void*)0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ netinet/sctp_timer.c:1167:50: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if (((&stcb->asoc.asconf_send_queue)->tqh_first == ((void*)0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ netinet/sctp_input.c:3421:45: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if (((&stcb->asoc.send_queue)->tqh_first == ((void*)0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ netinet/sctp_input.c:3625:51: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if (((&stcb->asoc.control_send_queue)->tqh_first == ((void*)0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ netinet/sctp_input.c:4193:48: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] { if (((&(stcb)->asoc.free_chunks)->tqh_first == ((void*)0))) { (chk) = (struct sctp_tmit_chunk *)malloc(system_base_info.sctppcbinfo.ipi_zone_chunk);; if ((chk)) { do { (void) __sync_fetch_and_add(&system_base_info.sctppcbinfo.ipi_count_chunk, 1); } while (0); (chk)->whoTo = ((void*)0); (chk)->holds_key_ref = 0; } } else { (chk) = ((&(stcb)->asoc.free_chunks)->tqh_first); do { if ((((chk))->sctp_next.tqe_next) != ((void*)0)) ((chk))->sctp_next.tqe_next->sctp_next.tqe_prev = ((chk))->sctp_next.tqe_prev; else (&(stcb)->asoc.free_chunks)->tqh_last = ((chk))->sctp_next.tqe_prev; *((chk))->sctp_next.tqe_prev = ((chk))->sctp_next.tqe_next; } while ( 0); (void) __sync_fetch_and_sub(&system_base_info.sctppcbinfo.ipi_free_chunks, 1); (chk)->holds_key_ref = 0; (void) __sync_fetch_and_add(&system_base_info.sctpstat.sctps_cached_chk, 1); (stcb)->asoc.free_chunk_cnt--; } }; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ... Of course these errors should be fixed in upstream, but we should disable parentheses-equality for this jhbuild module until the proper fix. 1100945 1 ossy 2015-06-10 01:30:56 -0700 I disabled this warning on the github repository: https://github.com/ossy-szeged/sctp-refimpl/commit/05b66a4f9b09fa841128073e1a248918d11118d3 Let's bump to this new tag. 1100946 2 254635 ossy 2015-06-10 01:31:33 -0700 Created attachment 254635 Patch 1100950 3 254635 ossy 2015-06-10 01:51:35 -0700 Comment on attachment 254635 Patch removing r?, unfortunately this change isn't enough. 1100954 4 ossy 2015-06-10 02:02:55 -0700 (In reply to comment #3) > Comment on attachment 254635 [details] > Patch > > removing r?, unfortunately this change isn't enough. netinet/sctp_output.c:4411:9: error: explicitly assigning value of variable of type 'struct mbuf *' to itself [-Werror,-Wself-assign] o_pak=o_pak; ~~~~~^~~~~~ netinet/sctp_output.c:11638:9: error: explicitly assigning value of variable of type 'struct mbuf *' to itself [-Werror,-Wself-assign] o_pak=o_pak; ~~~~~^~~~~~ sctp_os_userspace.h: #define SCTP_ENABLE_UDP_CSUM(m) m=m This self assignment is ridiculous and doesn't add anything to the project, only a build failure. I'll remove it. 1100956 5 ossy 2015-06-10 02:17:04 -0700 I removed this useless self assignment: https://github.com/ossy-szeged/sctp-refimpl/commit/acac8578ee2d9c509a7c00e422886bf12afb3968 1100958 6 254640 ossy 2015-06-10 02:21:50 -0700 Created attachment 254640 Patch 1101180 7 254640 gyuyoung.kim 2015-06-10 17:45:18 -0700 Comment on attachment 254640 Patch rs=me 1101518 8 254640 commit-queue 2015-06-12 03:03:42 -0700 Comment on attachment 254640 Patch Clearing flags on attachment: 254640 Committed r185494: <http://trac.webkit.org/changeset/185494> 1101519 9 commit-queue 2015-06-12 03:03:47 -0700 All reviewed patches have been landed. Closing bug. 254635 2015-06-10 01:31:33 -0700 2015-06-10 02:21:45 -0700 Patch bug-145128-20150610013105.patch text/plain 2306 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmIzMWU4MjY4YWRkMWM5YzQ3OTM1YTUxMzljOTExZDEz NWJiYjg5Ny4uYjhmYjRlMTNhZGZmNzc3NGI0NWIxNGQ0MjA2NjUxNzc1MDY3NTE5ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA2LTEwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHRoZSBsaWJ1c3JzY3RwIGJ1aWxkIHdpdGggY2xhbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTEyOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWZsL2poYnVpbGQubW9kdWxl czoKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOgorCiAyMDE1LTA2LTA5ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIEltcGxlbWVu dCBkdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkgZm9yIFdpbiBsYXlvdXRUZXN0Q29udHJv bGxlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9lZmwv amhidWlsZC5tb2R1bGVzCmluZGV4IDIxNjI0Njc5ZDBkYjMxMjRmYWJmOWFkNzgzYTFlYWFjYjRk NDY0YzYuLmNkZmU0Mzg1OTAwOGQ1NzNkOGQ2ZjdmMmQ4OWY1NmVmYzU1YmRmNmIgMTAwNjQ0Ci0t LSBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZWZsL2poYnVpbGQubW9k dWxlcwpAQCAtMzEzLDkgKzMxMyw5IEBACiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMg aWQ9ImxpYnVzcnNjdHAiIGF1dG9nZW4tc2g9Ii4vYm9vdHN0cmFwOyAuL2NvbmZpZ3VyZSI+Ci0g ICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9Im9zc3ktc3plZ2VkL3NjdHAtcmVm aW1wbC9hcmNoaXZlL2xpYnVzcnNjdHAtcjkxNjgudGFyLmd6IiB2ZXJzaW9uPSJyOTE2OCIgY2hl Y2tvdXRkaXI9ImxpYnVzcnNjdHAiCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6YzE5NDdlNmE2 N2ZkYzBkMTJmOWYwNzgyNjUxNDExMjVkMGRmMDE5YzcxODlkNjBlMjRmMjMzMWY0YjZhYWVjMiIK LSAgICAgICAgICAgIG1kNXN1bT0iNDY4Mzg2NzgwYzk0MzcwYjFmYjliNDQ2YWUzMDExYWQiIHNp emU9IjYyOTUyMyI+CisgICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9Im9zc3kt c3plZ2VkL3NjdHAtcmVmaW1wbC9hcmNoaXZlL2xpYnVzcnNjdHAtcjkxNjhiLnRhci5neiIgdmVy c2lvbj0icjkxNjgiIGNoZWNrb3V0ZGlyPSJsaWJ1c3JzY3RwIgorICAgICAgICAgICAgaGFzaD0i c2hhMjU2OjBmNDU1MTU5ZDUxZDA3MGVlNmY2OWM2MGY5ODRjNzFjZDAyZjAxOWExMzZlNzMwOTJm ZTRkMDE5YzRjN2QyMzciCisgICAgICAgICAgICBtZDVzdW09ImQ1NzE0MDk4MWM3ZDgyMGY3ZmY5 NzY0YzMxNGJiZTdkIiBzaXplPSI2Mjk1OTUiPgogICAgIDwvYnJhbmNoPgogICA8L2F1dG90b29s cz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9q aGJ1aWxkLm1vZHVsZXMKaW5kZXggMDBlN2YzZTk5NGQwMzc2YWY4NDVmOTE2NjNjMjk0YmI2MWU0 N2U1YS4uY2VmYmQ1ZmVjNGRiMDAyY2Q1MjRkNTM3NDY3NzJiMWM4MTY1ZjgzMSAxMDA2NDQKLS0t IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1 bGVzCkBAIC0zNjksNyArMzY5LDcgQEAKICAgPC9hdXRvdG9vbHM+CiAKICAgPGF1dG90b29scyBp ZD0ibGlidXNyc2N0cCIgYXV0b2dlbi1zaD0iLi9ib290c3RyYXA7IC4vY29uZmlndXJlIj4KLSAg ICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0ib3NzeS1zemVnZWQvc2N0cC1yZWZp bXBsLmdpdCIgY2hlY2tvdXRkaXI9ImxpYnVzcnNjdHAiIHRhZz0ibGlidXNyc2N0cC1yOTE2OCIv PgorICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxlPSJvc3N5LXN6ZWdlZC9zY3Rw LXJlZmltcGwuZ2l0IiBjaGVja291dGRpcj0ibGlidXNyc2N0cCIgdGFnPSJsaWJ1c3JzY3RwLXI5 MTY4YiIvPgogICAgPC9hdXRvdG9vbHM+CiAKICAgIDxhdXRvdG9vbHMgaWQ9ImdzdC1wbHVnaW5z LW9wZW53ZWJydGMiIHN1cHBvcnRzLXBhcmFsbGVsLWJ1aWxkcz0ibm8iIGF1dG9nZW4tc2g9Ii4v YXV0b2dlbi5zaDsgLi9jb25maWd1cmUiPgo= 254640 2015-06-10 02:21:50 -0700 2015-06-12 03:03:42 -0700 Patch bug-145128-20150610022122.patch text/plain 2306 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmIzMWU4MjY4YWRkMWM5YzQ3OTM1YTUxMzljOTExZDEz NWJiYjg5Ny4uYjhmYjRlMTNhZGZmNzc3NGI0NWIxNGQ0MjA2NjUxNzc1MDY3NTE5ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTA2LTEwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHRoZSBsaWJ1c3JzY3RwIGJ1aWxkIHdpdGggY2xhbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTEyOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWZsL2poYnVpbGQubW9kdWxl czoKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOgorCiAyMDE1LTA2LTA5ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIEltcGxlbWVu dCBkdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkgZm9yIFdpbiBsYXlvdXRUZXN0Q29udHJv bGxlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9lZmwv amhidWlsZC5tb2R1bGVzCmluZGV4IDIxNjI0Njc5ZDBkYjMxMjRmYWJmOWFkNzgzYTFlYWFjYjRk NDY0YzYuLjRjMGUzYjI2OGU4YjRhMzUyOWY0MjViMzVhZGM1YmI4ZmVmZjc0NGYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZWZsL2poYnVpbGQubW9k dWxlcwpAQCAtMzEzLDkgKzMxMyw5IEBACiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMg aWQ9ImxpYnVzcnNjdHAiIGF1dG9nZW4tc2g9Ii4vYm9vdHN0cmFwOyAuL2NvbmZpZ3VyZSI+Ci0g ICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9Im9zc3ktc3plZ2VkL3NjdHAtcmVm aW1wbC9hcmNoaXZlL2xpYnVzcnNjdHAtcjkxNjgudGFyLmd6IiB2ZXJzaW9uPSJyOTE2OCIgY2hl Y2tvdXRkaXI9ImxpYnVzcnNjdHAiCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6YzE5NDdlNmE2 N2ZkYzBkMTJmOWYwNzgyNjUxNDExMjVkMGRmMDE5YzcxODlkNjBlMjRmMjMzMWY0YjZhYWVjMiIK LSAgICAgICAgICAgIG1kNXN1bT0iNDY4Mzg2NzgwYzk0MzcwYjFmYjliNDQ2YWUzMDExYWQiIHNp emU9IjYyOTUyMyI+CisgICAgPGJyYW5jaCByZXBvPSJnaXRodWIuY29tIiBtb2R1bGU9Im9zc3kt c3plZ2VkL3NjdHAtcmVmaW1wbC9hcmNoaXZlL2xpYnVzcnNjdHAtcjkxNjhjLnRhci5neiIgdmVy c2lvbj0icjkxNjgiIGNoZWNrb3V0ZGlyPSJsaWJ1c3JzY3RwIgorICAgICAgICAgICAgaGFzaD0i c2hhMjU2OjVmODkxM2UwN2RkNDhkZGVjNzFhMzhmNzY1NGIxNmExZjBjNzc2YWI5ZDQ5MWVjZTYy NGZkZGQ3Y2VmYzBlNzEiCisgICAgICAgICAgICBtZDVzdW09IjFjYmIxN2NjOGNiZTUxOGY3ZTBh OTk3NDViMjMyOTM2IiBzaXplPSI2Mjk1ODEiPgogICAgIDwvYnJhbmNoPgogICA8L2F1dG90b29s cz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9q aGJ1aWxkLm1vZHVsZXMKaW5kZXggMDBlN2YzZTk5NGQwMzc2YWY4NDVmOTE2NjNjMjk0YmI2MWU0 N2U1YS4uMmU2YmU5ODJkMjcxOTA2YTAzYWNmNjRiY2MyY2I2NmU1NDE1OWI4NyAxMDA2NDQKLS0t IGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1 bGVzCkBAIC0zNjksNyArMzY5LDcgQEAKICAgPC9hdXRvdG9vbHM+CiAKICAgPGF1dG90b29scyBp ZD0ibGlidXNyc2N0cCIgYXV0b2dlbi1zaD0iLi9ib290c3RyYXA7IC4vY29uZmlndXJlIj4KLSAg ICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0ib3NzeS1zemVnZWQvc2N0cC1yZWZp bXBsLmdpdCIgY2hlY2tvdXRkaXI9ImxpYnVzcnNjdHAiIHRhZz0ibGlidXNyc2N0cC1yOTE2OCIv PgorICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxlPSJvc3N5LXN6ZWdlZC9zY3Rw LXJlZmltcGwuZ2l0IiBjaGVja291dGRpcj0ibGlidXNyc2N0cCIgdGFnPSJsaWJ1c3JzY3RwLXI5 MTY4YyIvPgogICAgPC9hdXRvdG9vbHM+CiAKICAgIDxhdXRvdG9vbHMgaWQ9ImdzdC1wbHVnaW5z LW9wZW53ZWJydGMiIHN1cHBvcnRzLXBhcmFsbGVsLWJ1aWxkcz0ibm8iIGF1dG9nZW4tc2g9Ii4v YXV0b2dlbi5zaDsgLi9jb25maWd1cmUiPgo=