145126 2015-05-18 03:38:11 -0700 [cmake] Suppress parentheses-equality warnings 2015-06-01 02:11:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 1 ossy ossy ossy oldest_to_newest 1095599 0 ossy 2015-05-18 03:38:11 -0700 ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:450:25: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:450:25: note: remove extraneous parentheses around the comparison to silence this warning ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:452:25: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:452:25: note: remove extraneous parentheses around the comparison to silence this warning ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:454:25: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:454:25: note: remove extraneous parentheses around the comparison to silence this warning ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:546:31: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:546:31: note: remove extraneous parentheses around the comparison to silence this warning ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:862:38: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:862:38: note: remove extraneous parentheses around the comparison to silence this warning NPVARIANT_IS_* defines already contain parentheses, if we use this macro in an if, we will get something like: "if (( ... == ... ))". But unfortunately double parentheses means in the clang terminology that we explicitly want to use assignment (=) instead of comparision (==). 1095600 1 253322 ossy 2015-05-18 03:41:27 -0700 Created attachment 253322 Patch Removed extra parentheses to make clang happy ... the result is ugly, but it works ... Better fix is very welcome. 1095601 2 ossy 2015-05-18 03:43:45 -0700 and one more in TestNetscapePlugIn/main.cpp: ../../Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:420:52: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] ../../Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:420:52: note: remove extraneous parentheses around the comparison to silence this warning 1095603 3 253323 ossy 2015-05-18 03:45:11 -0700 Created attachment 253323 Patch 1095651 4 253323 ap 2015-05-18 12:07:45 -0700 Comment on attachment 253323 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253323&action=review > Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:450 > + if NPVARIANT_IS_STRING(variant) This looks worse than before. Can this warning be disabled instead? Did it catch any bugs ever? 1095659 5 ossy 2015-05-18 13:11:20 -0700 (In reply to comment #4) > Comment on attachment 253323 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253323&action=review > > > Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:450 > > + if NPVARIANT_IS_STRING(variant) > > This looks worse than before. Can this warning be disabled instead? Did it > catch any bugs ever? Yes, I told it is ugly. But I don't want to disable this useful warning, because it is responsible for the opposite and typical programming error: if (a=b). We do want to get warning for this serious bug. Any better idea how to supress this warning only here without disabling it in general? 1096215 6 253323 ossy 2015-05-20 02:32:31 -0700 Comment on attachment 253323 Patch I was wrong, fortunately Wparentheses-equality and Wparantheses are diffent warnings. Let's suppress only Wparentheses-equality. 1096574 7 253524 ossy 2015-05-21 07:15:15 -0700 Created attachment 253524 Patch 1096575 8 ossy 2015-05-21 07:16:31 -0700 It works in itself for the most part of WebKit, but will have no effect in TestNetscapePlugIn until bug145264 is fixed. 1097386 9 253524 darin 2015-05-26 13:09:03 -0700 Comment on attachment 253524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253524&action=review > Source/cmake/WebKitHelpers.cmake:18 > + # Suppress -Wparentheses-equality warning of Clang Why? 1097387 10 253524 darin 2015-05-26 13:09:38 -0700 Comment on attachment 253524 Patch Oh, I see why. 1098460 11 253524 ossy 2015-06-01 02:11:29 -0700 Comment on attachment 253524 Patch Clearing flags on attachment: 253524 Committed r185055: <http://trac.webkit.org/changeset/185055> 1098461 12 ossy 2015-06-01 02:11:38 -0700 All reviewed patches have been landed. Closing bug. 253322 2015-05-18 03:41:27 -0700 2015-05-18 03:45:05 -0700 Patch bug-145126-20150518034125.patch text/plain 2596 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWJjMmNlOWMyNTE3OTk2MjM2MzI0NzM4ODgwOTUxMTBl M2RmYWI1Mi4uNDI5ZjkxZDdlMjBhZjY4NzVlMzVhNmI0Njg3YjdlOTZkMDUxZjZjZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTA1LTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHBhcmVudGhlc2VzLWVxdWFsaXR5IHdhcm5pbmdzIGluIFBsdWdpbk9iamVj dC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 NTEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdC5jcHA6CisgICAg ICAgICh2YXJpYW50VG9JZGVudGlmaWVyKToKKyAgICAgICAgKHRlc3RDYWxsYmFja1JldHVybik6 CisgICAgICAgICh0ZXN0U2NyaXB0T2JqZWN0SW52b2tlKToKKwogMjAxNS0wNS0xNyAgRGF2aWQg S2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIGJpc2VjdC1idWlsZHM6IEFk ZCAncmV0cnknIG9wdGlvbiB3aGVuIHByb21wdGluZyB3aGV0aGVyIHRoZSBidWcgcmVwcm9kdWNl ZApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1Bs dWdpbk9iamVjdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4v UGx1Z2luT2JqZWN0LmNwcAppbmRleCA3NTYzMTg0MmZhNDBjNTEzMDJkODY0MzhjOTAzOTU3NWEx YWQ4ZThhLi5lOGMxYTlkZjBlYzUyOWRjMzU2MmQ0NTM1ZmNjN2ZmZWUyODU3ZDMyIDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0 LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2lu T2JqZWN0LmNwcApAQCAtNDQ3LDExICs0NDcsMTEgQEAgc3RhdGljIE5QSWRlbnRpZmllciBkb3Vi bGVWYXJpYW50VG9JZGVudGlmaWVyKE5QVmFyaWFudCB2YXJpYW50KQogCiBzdGF0aWMgTlBJZGVu dGlmaWVyIHZhcmlhbnRUb0lkZW50aWZpZXIoTlBWYXJpYW50IHZhcmlhbnQpCiB7Ci0gICAgaWYg KE5QVkFSSUFOVF9JU19TVFJJTkcodmFyaWFudCkpCisgICAgaWYgTlBWQVJJQU5UX0lTX1NUUklO Ryh2YXJpYW50KQogICAgICAgICByZXR1cm4gc3RyaW5nVmFyaWFudFRvSWRlbnRpZmllcih2YXJp YW50KTsKLSAgICBpZiAoTlBWQVJJQU5UX0lTX0lOVDMyKHZhcmlhbnQpKQorICAgIGlmIE5QVkFS SUFOVF9JU19JTlQzMih2YXJpYW50KQogICAgICAgICByZXR1cm4gaW50MzJWYXJpYW50VG9JZGVu dGlmaWVyKHZhcmlhbnQpOwotICAgIGlmIChOUFZBUklBTlRfSVNfRE9VQkxFKHZhcmlhbnQpKQor ICAgIGlmIE5QVkFSSUFOVF9JU19ET1VCTEUodmFyaWFudCkKICAgICAgICAgcmV0dXJuIGRvdWJs ZVZhcmlhbnRUb0lkZW50aWZpZXIodmFyaWFudCk7CiAgICAgcmV0dXJuIDA7CiB9CkBAIC01NDMs NyArNTQzLDcgQEAgc3RhdGljIGJvb2wgdGVzdENhbGxiYWNrUmV0dXJuKFBsdWdpbk9iamVjdCog b2JqLCBjb25zdCBOUFZhcmlhbnQqIGFyZ3MsIHVpbnQzMl8KICAgICBicm93c2VyLT5pbnZva2Uo b2JqLT5ucHAsIHdpbmRvd1NjcmlwdE9iamVjdCwgY2FsbGJhY2tJZGVudGlmaWVyLAogICAgICAg ICAgICAgICAgICAgICBjYWxsYmFja0FyZ3MsIDEsICZicm93c2VyUmVzdWx0KTsKIAotICAgIGlm IChOUFZBUklBTlRfSVNfT0JKRUNUKGJyb3dzZXJSZXN1bHQpKQorICAgIGlmIE5QVkFSSUFOVF9J U19PQkpFQ1QoYnJvd3NlclJlc3VsdCkKICAgICAgICAgT0JKRUNUX1RPX05QVkFSSUFOVChOUFZB UklBTlRfVE9fT0JKRUNUKGJyb3dzZXJSZXN1bHQpLCAqcmVzdWx0KTsKICAgICBlbHNlIHsKICAg ICAgICAgYnJvd3Nlci0+cmVsZWFzZXZhcmlhbnR2YWx1ZSgmYnJvd3NlclJlc3VsdCk7CkBAIC04 NTksNyArODU5LDcgQEAgc3RhdGljIGJvb2wgdGVzdFNjcmlwdE9iamVjdEludm9rZShQbHVnaW5P YmplY3QqIG9iaiwgY29uc3QgTlBWYXJpYW50KiBhcmdzLCB1aW4KIAogICAgIGJyb3dzZXItPnJl bGVhc2V2YXJpYW50dmFsdWUoJm9iamVjdF9yZXN1bHQpOwogICAgIFZPSURfVE9fTlBWQVJJQU5U KCpyZXN1bHQpOwotICAgIGlmIChOUFZBUklBTlRfSVNfT0JKRUNUKG9iamVjdF9tZXRob2RfcmVz dWx0KSkgeworICAgIGlmIE5QVkFSSUFOVF9JU19PQkpFQ1Qob2JqZWN0X21ldGhvZF9yZXN1bHQp IHsKICAgICAgICAgLy8gTm93IHJldHVybiB0aGUgY2FsbGJhY2tzIHJldHVybiB2YWx1ZSBiYWNr IHRvIG91ciBjYWxsZXIuCiAgICAgICAgIC8vIEJVRyA4OTc0NTE6IFRoaXMgc2hvdWxkIGJlIHRo ZSBzYW1lIGFzIHRoZQogICAgICAgICAvLyB3aW5kb3dTY3JpcHRPYmplY3QsIGJ1dCBpdHMgbm90 IChpbiBDaHJvbWUpIC0gb3IgYXQgbGVhc3QsIGl0Cg== 253323 2015-05-18 03:45:11 -0700 2015-05-20 02:32:31 -0700 Patch bug-145126-20150518034509.patch text/plain 3610 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWJjMmNlOWMyNTE3OTk2MjM2MzI0NzM4ODgwOTUxMTBl M2RmYWI1Mi4uNzkzYzBkZmI2MWVlNWI0MmMzNDQwNjZiNWFiMDgyZDA5OGVlZDlhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA1LTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHBhcmVudGhlc2VzLWVxdWFsaXR5IHdhcm5pbmdzIGluIFRlc3ROZXRzY2Fw ZVBsdWdJbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ1MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcDoKKyAg ICAgICAgKHZhcmlhbnRUb0lkZW50aWZpZXIpOgorICAgICAgICAodGVzdENhbGxiYWNrUmV0dXJu KToKKyAgICAgICAgKHRlc3RTY3JpcHRPYmplY3RJbnZva2UpOgorICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcDoKKyAgICAgICAgKE5QUF9EZXN0cm95 U3RyZWFtKToKKwogMjAxNS0wNS0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgogCiAgICAgICAgIGJpc2VjdC1idWlsZHM6IEFkZCAncmV0cnknIG9wdGlvbiB3aGVuIHByb21w dGluZyB3aGV0aGVyIHRoZSBidWcgcmVwcm9kdWNlZApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL1BsdWdpbk9iamVjdC5jcHAgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcAppbmRleCA3NTYz MTg0MmZhNDBjNTEzMDJkODY0MzhjOTAzOTU3NWExYWQ4ZThhLi5lOGMxYTlkZjBlYzUyOWRjMzU2 MmQ0NTM1ZmNjN2ZmZWUyODU3ZDMyIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9U ZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vUGx1Z2luT2JqZWN0LmNwcApAQCAtNDQ3LDExICs0NDcs MTEgQEAgc3RhdGljIE5QSWRlbnRpZmllciBkb3VibGVWYXJpYW50VG9JZGVudGlmaWVyKE5QVmFy aWFudCB2YXJpYW50KQogCiBzdGF0aWMgTlBJZGVudGlmaWVyIHZhcmlhbnRUb0lkZW50aWZpZXIo TlBWYXJpYW50IHZhcmlhbnQpCiB7Ci0gICAgaWYgKE5QVkFSSUFOVF9JU19TVFJJTkcodmFyaWFu dCkpCisgICAgaWYgTlBWQVJJQU5UX0lTX1NUUklORyh2YXJpYW50KQogICAgICAgICByZXR1cm4g c3RyaW5nVmFyaWFudFRvSWRlbnRpZmllcih2YXJpYW50KTsKLSAgICBpZiAoTlBWQVJJQU5UX0lT X0lOVDMyKHZhcmlhbnQpKQorICAgIGlmIE5QVkFSSUFOVF9JU19JTlQzMih2YXJpYW50KQogICAg ICAgICByZXR1cm4gaW50MzJWYXJpYW50VG9JZGVudGlmaWVyKHZhcmlhbnQpOwotICAgIGlmIChO UFZBUklBTlRfSVNfRE9VQkxFKHZhcmlhbnQpKQorICAgIGlmIE5QVkFSSUFOVF9JU19ET1VCTEUo dmFyaWFudCkKICAgICAgICAgcmV0dXJuIGRvdWJsZVZhcmlhbnRUb0lkZW50aWZpZXIodmFyaWFu dCk7CiAgICAgcmV0dXJuIDA7CiB9CkBAIC01NDMsNyArNTQzLDcgQEAgc3RhdGljIGJvb2wgdGVz dENhbGxiYWNrUmV0dXJuKFBsdWdpbk9iamVjdCogb2JqLCBjb25zdCBOUFZhcmlhbnQqIGFyZ3Ms IHVpbnQzMl8KICAgICBicm93c2VyLT5pbnZva2Uob2JqLT5ucHAsIHdpbmRvd1NjcmlwdE9iamVj dCwgY2FsbGJhY2tJZGVudGlmaWVyLAogICAgICAgICAgICAgICAgICAgICBjYWxsYmFja0FyZ3Ms IDEsICZicm93c2VyUmVzdWx0KTsKIAotICAgIGlmIChOUFZBUklBTlRfSVNfT0JKRUNUKGJyb3dz ZXJSZXN1bHQpKQorICAgIGlmIE5QVkFSSUFOVF9JU19PQkpFQ1QoYnJvd3NlclJlc3VsdCkKICAg ICAgICAgT0JKRUNUX1RPX05QVkFSSUFOVChOUFZBUklBTlRfVE9fT0JKRUNUKGJyb3dzZXJSZXN1 bHQpLCAqcmVzdWx0KTsKICAgICBlbHNlIHsKICAgICAgICAgYnJvd3Nlci0+cmVsZWFzZXZhcmlh bnR2YWx1ZSgmYnJvd3NlclJlc3VsdCk7CkBAIC04NTksNyArODU5LDcgQEAgc3RhdGljIGJvb2wg dGVzdFNjcmlwdE9iamVjdEludm9rZShQbHVnaW5PYmplY3QqIG9iaiwgY29uc3QgTlBWYXJpYW50 KiBhcmdzLCB1aW4KIAogICAgIGJyb3dzZXItPnJlbGVhc2V2YXJpYW50dmFsdWUoJm9iamVjdF9y ZXN1bHQpOwogICAgIFZPSURfVE9fTlBWQVJJQU5UKCpyZXN1bHQpOwotICAgIGlmIChOUFZBUklB TlRfSVNfT0JKRUNUKG9iamVjdF9tZXRob2RfcmVzdWx0KSkgeworICAgIGlmIE5QVkFSSUFOVF9J U19PQkpFQ1Qob2JqZWN0X21ldGhvZF9yZXN1bHQpIHsKICAgICAgICAgLy8gTm93IHJldHVybiB0 aGUgY2FsbGJhY2tzIHJldHVybiB2YWx1ZSBiYWNrIHRvIG91ciBjYWxsZXIuCiAgICAgICAgIC8v IEJVRyA4OTc0NTE6IFRoaXMgc2hvdWxkIGJlIHRoZSBzYW1lIGFzIHRoZQogICAgICAgICAvLyB3 aW5kb3dTY3JpcHRPYmplY3QsIGJ1dCBpdHMgbm90IChpbiBDaHJvbWUpIC0gb3IgYXQgbGVhc3Qs IGl0CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4v bWFpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vbWFpbi5j cHAKaW5kZXggODVjZDQxZDJjNmJhMzliYjZmNzZlNDU2MTEwYTQyZmVhM2U5YmQ3NS4uYjJlYzMy NmUxYWU1MDUwZDM1Yzg4NDgxYjFjY2I3NGQ5MThlYTQ5YSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9tYWluLmNwcApAQCAtNDE3LDcgKzQxNyw3IEBA IE5QRXJyb3IgTlBQX0Rlc3Ryb3lTdHJlYW0oTlBQIGluc3RhbmNlLCBOUFN0cmVhbSAqc3RyZWFt LCBOUFJlYXNvbiByZWFzb24pCiAgICAgICAgIGlmIChlcnJvciA9PSBOUEVSUl9OT19FUlJPUikg ewogICAgICAgICAgICAgTlBWYXJpYW50IG9uU3RyZWFtRGVzdHJveVZhcmlhbnQ7CiAgICAgICAg ICAgICBpZiAoYnJvd3Nlci0+Z2V0cHJvcGVydHkoaW5zdGFuY2UsIHdpbmRvd09iamVjdCwgYnJv d3Nlci0+Z2V0c3RyaW5naWRlbnRpZmllcihvYmotPm9uU3RyZWFtRGVzdHJveSksICZvblN0cmVh bURlc3Ryb3lWYXJpYW50KSkgewotICAgICAgICAgICAgICAgIGlmIChOUFZBUklBTlRfSVNfT0JK RUNUKG9uU3RyZWFtRGVzdHJveVZhcmlhbnQpKSB7CisgICAgICAgICAgICAgICAgaWYgTlBWQVJJ QU5UX0lTX09CSkVDVChvblN0cmVhbURlc3Ryb3lWYXJpYW50KSB7CiAgICAgICAgICAgICAgICAg ICAgIE5QT2JqZWN0KiBvblN0cmVhbURlc3Ryb3lGdW5jdGlvbiA9IE5QVkFSSUFOVF9UT19PQkpF Q1Qob25TdHJlYW1EZXN0cm95VmFyaWFudCk7CiAKICAgICAgICAgICAgICAgICAgICAgTlBWYXJp YW50IHJlYXNvblZhcmlhbnQ7Cg== 253524 2015-05-21 07:15:15 -0700 2015-06-01 02:11:29 -0700 Patch bug-145126-20150521071510.patch text/plain 1455 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IDMyMGI5NGY1MTA3YjNjYmRhMjRlNDNkOWU4YjlhMDZlNjljMjE1YTEuLmExZTY1MDNkZGQyMDhm NWI3YTJiZTMyZmQyNGNjYzBjNTI2NGYyZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC0xNSw2ICsxNSwxMSBAQCBtYWNybyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90 YXJnZXQpCiAgICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIi1mUElDICR7T0xEX0NP TVBJTEVfRkxBR1N9IikKICAgICAgICAgZW5kaWYgKCkKIAorICAgICAgICAjIFN1cHByZXNzIC1X cGFyZW50aGVzZXMtZXF1YWxpdHkgd2FybmluZyBvZiBDbGFuZworICAgICAgICBpZiAoIiR7Q01B S0VfQ1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKKyAgICAgICAgICAgIHNldChP TERfQ09NUElMRV9GTEFHUyAiLVduby1wYXJlbnRoZXNlcy1lcXVhbGl0eSAke09MRF9DT01QSUxF X0ZMQUdTfSIpCisgICAgICAgIGVuZGlmICgpCisKICAgICAgICAgIyBFbmFibGUgd2FybmluZ3Mg YnkgZGVmYXVsdAogICAgICAgICBpZiAoTk9UICR7T1BUSU9OX0lHTk9SRUNYWF9XQVJOSU5HU30p CiAgICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIi1XYWxsIC1XZXh0cmEgLVdjYXN0 LWFsaWduIC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1XcG9p bnRlci1hcml0aCAtV3VuZGVmIC1Xd3JpdGUtc3RyaW5ncyAke09MRF9DT01QSUxFX0ZMQUdTfSIp CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNTg1ZGVlMWNiYTRiZjIx OWMxMjhiYWYyYThkOWYyNzc0NWMzOTFlNS4uYWE4YjRmZjViNDY3OTBiZTgyZTA5MjE0MzQwNGIx OWVjZjQ5ZDIyNiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE1LTA1LTIxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CisKKyAgICAgICAgW2NtYWtlXSBTdXBwcmVzcyBwYXJlbnRoZXNlcy1lcXVhbGl0eSB3YXJu aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1 MTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxNS0wNS0xOCAgTWljaGFlbCBD YXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBJZ25v cmUgd2FybmluZ3MgaW4gc3lzdGVtIGhlYWRlcnMK