145119 2015-05-18 02:22:34 -0700 Fix uninitialized warnings in RealtimeMediaSourceCenterOwr.cpp 2015-05-18 18:39:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 145121 142476 1 ossy ossy cgarcia commit-queue eric.carlson mrobinson ossy pnormand oldest_to_newest 1095581 0 ossy 2015-05-18 02:22:34 -0700 ./../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:94:9: warning: variable 'types' is uninitialized when used here [-Wuninitialized] ../../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:92:14: note: initialize the variable 'types' to silence this warning ../../Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:157:18: warning: variable 'sourceType' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] ( This file introduced in http://trac.webkit.org/changeset/181893 . ) 1095583 1 253315 ossy 2015-05-18 02:25:16 -0700 Created attachment 253315 Patch 1095589 2 253317 ossy 2015-05-18 02:38:46 -0700 Created attachment 253317 Patch 1095774 3 253317 gyuyoung.kim 2015-05-18 18:10:18 -0700 Comment on attachment 253317 Patch LGTM 1095781 4 253317 commit-queue 2015-05-18 18:39:35 -0700 Comment on attachment 253317 Patch Clearing flags on attachment: 253317 Committed r184537: <http://trac.webkit.org/changeset/184537> 1095782 5 commit-queue 2015-05-18 18:39:40 -0700 All reviewed patches have been landed. Closing bug. 253315 2015-05-18 02:25:16 -0700 2015-05-18 02:34:08 -0700 Patch bug-145119-20150518022514.patch text/plain 2211 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM0Nzk1ZWVjNTBlZmUw ZGE5MGJkNzAxYTBmZWQyYzZiNTc2ZTk4ZC4uMjk3YjU5MmYwMjE4ZWNiYjBmMjBiMDliOGIwMWU2 YzQwODQ2ZGEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHVuaW5pdGlh bGl6ZWQgd2FybmluZ3MgaW4gUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTExOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVk aWFzdHJlYW0vb3BlbndlYnJ0Yy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJPd3I6OnZhbGlkYXRlUmVx dWVzdENvbnN0cmFpbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXJPd3I6Om1lZGlhU291cmNlc0F2YWlsYWJsZSk6CisKIDIwMTUtMDUtMTcgIE1hbnVlbCBS ZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExh eW91dF0gQWRkIHNjcm9sbGJhciB3aWR0aCBpbiBpbnRyaW5zaWMgbG9naWNhbCB3aWR0aHMgY29t cHV0YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L29wZW53ZWJydGMvUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL1JlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXJPd3IuY3BwCmluZGV4IDBjMzdlOTllNzVhZGU2M2I2MGVlODNjM2U2MDgwMGU5NTdlNTRm YzQuLjc5ODMwYTAwMTc5MzJjMDE5OTk2ZTJkYTMwY2M0MWEyOTJkMWI5OTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvUmVhbHRpbWVN ZWRpYVNvdXJjZUNlbnRlck93ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vb3BlbndlYnJ0Yy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcApAQCAt ODksNyArODksNyBAQCB2b2lkIFJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJPd3I6OnZhbGlkYXRl UmVxdWVzdENvbnN0cmFpbnRzKFBhc3NSZWZQdHI8TWVkaWFTdAogICAgIFJlZlB0cjxNZWRpYUNv bnN0cmFpbnRzPiBhdWRpb0NvbnN0cmFpbnRzID0gcHJwQXVkaW9Db25zdHJhaW50czsKICAgICBS ZWZQdHI8TWVkaWFDb25zdHJhaW50cz4gdmlkZW9Db25zdHJhaW50cyA9IHBycFZpZGVvQ29uc3Ry YWludHM7CiAKLSAgICBpbnQgdHlwZXM7CisgICAgaW50IHR5cGVzID0gT1dSX01FRElBX1RZUEVf VU5LTk9XTjsKICAgICBpZiAoYXVkaW9Db25zdHJhaW50cykKICAgICAgICAgdHlwZXMgfD0gT1dS X01FRElBX1RZUEVfQVVESU87CiAgICAgaWYgKHZpZGVvQ29uc3RyYWludHMpCkBAIC0xNTYsOCAr MTU2LDEwIEBAIHZvaWQgUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93cjo6bWVkaWFTb3VyY2Vz QXZhaWxhYmxlKEdMaXN0KiBzb3VyY2VzKQogICAgICAgICAgICAgc291cmNlVHlwZSA9IFJlYWx0 aW1lTWVkaWFTb3VyY2U6OkF1ZGlvOwogICAgICAgICBlbHNlIGlmIChtZWRpYVR5cGUgJiBPV1Jf TUVESUFfVFlQRV9WSURFTykKICAgICAgICAgICAgIHNvdXJjZVR5cGUgPSBSZWFsdGltZU1lZGlh U291cmNlOjpWaWRlbzsKLSAgICAgICAgZWxzZQorICAgICAgICBlbHNlIHsKKyAgICAgICAgICAg IHNvdXJjZVR5cGUgPSBPV1JfTUVESUFfVFlQRV9VTktOT1dOOwogICAgICAgICAgICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7CisgICAgICAgIH0KIAogICAgICAgICBSZWZQdHI8UmVhbHRpbWVNZWRp YVNvdXJjZU93cj4gbWVkaWFTb3VyY2UgPSBhZG9wdFJlZihuZXcgUmVhbHRpbWVNZWRpYVNvdXJj ZU93cihzb3VyY2UsIGlkLCBzb3VyY2VUeXBlLCBzb3VyY2VOYW1lKSk7CiAK 253317 2015-05-18 02:38:46 -0700 2015-05-18 18:39:35 -0700 Patch bug-145119-20150518023844.patch text/plain 2214 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM0Nzk1ZWVjNTBlZmUw ZGE5MGJkNzAxYTBmZWQyYzZiNTc2ZTk4ZC4uMjk3YjU5MmYwMjE4ZWNiYjBmMjBiMDliOGIwMWU2 YzQwODQ2ZGEzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHVuaW5pdGlh bGl6ZWQgd2FybmluZ3MgaW4gUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTExOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVk aWFzdHJlYW0vb3BlbndlYnJ0Yy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJPd3I6OnZhbGlkYXRlUmVx dWVzdENvbnN0cmFpbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXJPd3I6Om1lZGlhU291cmNlc0F2YWlsYWJsZSk6CisKIDIwMTUtMDUtMTcgIE1hbnVlbCBS ZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExh eW91dF0gQWRkIHNjcm9sbGJhciB3aWR0aCBpbiBpbnRyaW5zaWMgbG9naWNhbCB3aWR0aHMgY29t cHV0YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L29wZW53ZWJydGMvUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL1JlYWx0aW1lTWVkaWFTb3VyY2VD ZW50ZXJPd3IuY3BwCmluZGV4IDBjMzdlOTllNzVhZGU2M2I2MGVlODNjM2U2MDgwMGU5NTdlNTRm YzQuLmVjMjU3MzFhZWE5ZjVjZTFjM2IxNjVmYzA0YzIxOGRmMGJlN2ExMzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvUmVhbHRpbWVN ZWRpYVNvdXJjZUNlbnRlck93ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vb3BlbndlYnJ0Yy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcApAQCAt ODksNyArODksNyBAQCB2b2lkIFJlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJPd3I6OnZhbGlkYXRl UmVxdWVzdENvbnN0cmFpbnRzKFBhc3NSZWZQdHI8TWVkaWFTdAogICAgIFJlZlB0cjxNZWRpYUNv bnN0cmFpbnRzPiBhdWRpb0NvbnN0cmFpbnRzID0gcHJwQXVkaW9Db25zdHJhaW50czsKICAgICBS ZWZQdHI8TWVkaWFDb25zdHJhaW50cz4gdmlkZW9Db25zdHJhaW50cyA9IHBycFZpZGVvQ29uc3Ry YWludHM7CiAKLSAgICBpbnQgdHlwZXM7CisgICAgaW50IHR5cGVzID0gT1dSX01FRElBX1RZUEVf VU5LTk9XTjsKICAgICBpZiAoYXVkaW9Db25zdHJhaW50cykKICAgICAgICAgdHlwZXMgfD0gT1dS X01FRElBX1RZUEVfQVVESU87CiAgICAgaWYgKHZpZGVvQ29uc3RyYWludHMpCkBAIC0xNTYsOCAr MTU2LDEwIEBAIHZvaWQgUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93cjo6bWVkaWFTb3VyY2Vz QXZhaWxhYmxlKEdMaXN0KiBzb3VyY2VzKQogICAgICAgICAgICAgc291cmNlVHlwZSA9IFJlYWx0 aW1lTWVkaWFTb3VyY2U6OkF1ZGlvOwogICAgICAgICBlbHNlIGlmIChtZWRpYVR5cGUgJiBPV1Jf TUVESUFfVFlQRV9WSURFTykKICAgICAgICAgICAgIHNvdXJjZVR5cGUgPSBSZWFsdGltZU1lZGlh U291cmNlOjpWaWRlbzsKLSAgICAgICAgZWxzZQorICAgICAgICBlbHNlIHsKKyAgICAgICAgICAg IHNvdXJjZVR5cGUgPSBSZWFsdGltZU1lZGlhU291cmNlOjpOb25lOwogICAgICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIH0KIAogICAgICAgICBSZWZQdHI8UmVhbHRpbWVN ZWRpYVNvdXJjZU93cj4gbWVkaWFTb3VyY2UgPSBhZG9wdFJlZihuZXcgUmVhbHRpbWVNZWRpYVNv dXJjZU93cihzb3VyY2UsIGlkLCBzb3VyY2VUeXBlLCBzb3VyY2VOYW1lKSk7CiAK