145116 2015-05-17 23:40:04 -0700 Rename createIterResultObject as createIteratorResultObject 2015-05-19 13:08:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin oldest_to_newest 1095557 0 youennf 2015-05-17 23:40:04 -0700 Following on bug 144790 first review, it might be good to rename createIterResultObject as createIteratorResultObject before starting using it in WebCore. 1095572 1 253311 youennf 2015-05-18 01:49:08 -0700 Created attachment 253311 Patch 1095573 2 commit-queue 2015-05-18 01:51:10 -0700 Attachment 253311 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/IteratorOperations.h:34: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/runtime/IteratorOperations.h:40: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1095615 3 253311 youennf 2015-05-18 08:09:06 -0700 Comment on attachment 253311 Patch Latest patch for bug 144790 makes uses of this renamed and newly exported method. See https://bugs.webkit.org/attachment.cgi?id=253325&action=review 1095953 4 253311 darin 2015-05-19 08:55:08 -0700 Comment on attachment 253311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253311&action=review > Source/JavaScriptCore/runtime/IteratorOperations.h:34 > -JSValue iteratorNext(ExecState*, JSValue iterator, JSValue); > +JSValue iteratorNext(ExecState*, JSValue iterator, JSValue value); I agree with the style bot, the word "value" here is not specific enough to be helpful. I’m OK with adding an argument name here, but not sure what it would be. > Source/JavaScriptCore/runtime/IteratorOperations.h:37 > JSValue iteratorValue(ExecState*, JSValue iterResult); > bool iteratorComplete(ExecState*, JSValue iterResult); Should give iterResult a better name. > Source/JavaScriptCore/runtime/IteratorOperations.h:40 > +JS_EXPORT_PRIVATE JSObject* createIteratorResultObject(ExecState*, JSValue value, bool done); I agree with the style bot, the word "value" here is not specific enough to be helpful. I’m OK with adding an argument name here, but not sure what it would be. 1095997 5 253311 youennf 2015-05-19 12:45:15 -0700 Comment on attachment 253311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253311&action=review >> Source/JavaScriptCore/runtime/IteratorOperations.h:34 >> +JSValue iteratorNext(ExecState*, JSValue iterator, JSValue value); > > I agree with the style bot, the word "value" here is not specific enough to be helpful. I’m OK with adding an argument name here, but not sure what it would be. OK, let's remove it. >> Source/JavaScriptCore/runtime/IteratorOperations.h:37 >> bool iteratorComplete(ExecState*, JSValue iterResult); > > Should give iterResult a better name. OK, renaming it to iterator. 1095998 6 253391 youennf 2015-05-19 12:46:54 -0700 Created attachment 253391 Patch for landing 1096010 7 253391 commit-queue 2015-05-19 13:08:04 -0700 Comment on attachment 253391 Patch for landing Clearing flags on attachment: 253391 Committed r184586: <http://trac.webkit.org/changeset/184586> 1096011 8 commit-queue 2015-05-19 13:08:08 -0700 All reviewed patches have been landed. Closing bug. 253311 2015-05-18 01:49:08 -0700 2015-05-19 12:46:47 -0700 Patch bug-145116-20150518104906.patch text/plain 4626 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NzYwYTIzZTdlNzAyNmJkYTBhOWQzNzZmOTE2ZDc0OGZhNTc0OWI4Li4xYjRhMDVlOTNkN2ExMmRk NGNjN2NhN2I4YWE1YTUyNzgxMWIwN2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0wNS0xNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3Jm LmNhbm9uLmZyPgorCisgICAgICAgIFJlbmFtZSBjcmVhdGVJdGVyUmVzdWx0T2JqZWN0IGFzIGNy ZWF0ZUl0ZXJhdG9yUmVzdWx0T2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDUxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW5hbWVkIGNyZWF0ZUl0ZXJSZXN1bHRPYmplY3QgYXMgY3JlYXRl SXRlcmF0b3JSZXN1bHRPYmplY3QuCisgICAgICAgIE1hZGUgdGhpcyBmdW5jdGlvbiBleHBvcnRh YmxlIGZvciBmdXR1cmUgdXNlIGJ5IHN0cmVhbXMgQVBJLgorCisgICAgICAgICogcnVudGltZS9J dGVyYXRvck9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpjcmVhdGVJdGVyYXRvclJlc3Vs dE9iamVjdCk6CisgICAgICAgICogcnVudGltZS9JdGVyYXRvck9wZXJhdGlvbnMuaDoKKyAgICAg ICAgKiBydW50aW1lL01hcEl0ZXJhdG9yUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6TWFw SXRlcmF0b3JQcm90b3R5cGVGdW5jTmV4dCk6CisgICAgICAgICogcnVudGltZS9TZXRJdGVyYXRv clByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OlNldEl0ZXJhdG9yUHJvdG90eXBlRnVuY05l eHQpOgorCiAyMDE1LTA1LTE3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBEbyBub3QgdXNlIGZhc3RNYWxsb2NHb29kU2l6ZSBhbnl3aGVyZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25z LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0l0ZXJhdG9yT3BlcmF0aW9ucy5j cHAKaW5kZXggYjAxZDMzZDYxY2U2MDE1NWNkYjI3ZjA3ODcxNDg4Y2EzZTk2M2I0Yi4uNjZhN2Q2 ODA4MTY1YWI4ZWMwYmQyMTFiODIxZmM1NDk0M2UwOGIyMCAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9JdGVyYXRvck9wZXJhdGlvbnMuY3BwCkBAIC0xMzEsNyAr MTMxLDcgQEAgdm9pZCBpdGVyYXRvckNsb3NlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBpdGVy YXRvcikKICAgICB9CiB9CiAKLUpTT2JqZWN0KiBjcmVhdGVJdGVyUmVzdWx0T2JqZWN0KEV4ZWNT dGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgYm9vbCBkb25lKQorSlNPYmplY3QqIGNyZWF0ZUl0 ZXJhdG9yUmVzdWx0T2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgYm9vbCBk b25lKQogewogICAgIEpTT2JqZWN0KiByZXN1bHRPYmplY3QgPSBjb25zdHJ1Y3RFbXB0eU9iamVj dChleGVjKTsKICAgICByZXN1bHRPYmplY3QtPnB1dERpcmVjdChleGVjLT52bSgpLCBleGVjLT5w cm9wZXJ0eU5hbWVzKCkuZG9uZSwganNCb29sZWFuKGRvbmUpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0l0ZXJhdG9yT3BlcmF0aW9ucy5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25zLmgKaW5kZXggNGJlZjM4ODM1 YWFlZWVmYWVjMTJjODBhOTVlYjEzM2I3OGRhZGQyNC4uOGY4M2VjMTE5ZWYwYjdiZTg5ODFlYTg2 MDYwMTgzZGZkNzQ3MzU0MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSXRlcmF0b3JPcGVyYXRpb25zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSXRlcmF0b3JPcGVyYXRpb25zLmgKQEAgLTMxLDEzICszMSwxMyBAQAogCiBuYW1lc3BhY2Ug SlNDIHsKIAotSlNWYWx1ZSBpdGVyYXRvck5leHQoRXhlY1N0YXRlKiwgSlNWYWx1ZSBpdGVyYXRv ciwgSlNWYWx1ZSk7CitKU1ZhbHVlIGl0ZXJhdG9yTmV4dChFeGVjU3RhdGUqLCBKU1ZhbHVlIGl0 ZXJhdG9yLCBKU1ZhbHVlIHZhbHVlKTsKIEpTVmFsdWUgaXRlcmF0b3JOZXh0KEV4ZWNTdGF0ZSos IEpTVmFsdWUgaXRlcmF0b3IpOwogSlNWYWx1ZSBpdGVyYXRvclZhbHVlKEV4ZWNTdGF0ZSosIEpT VmFsdWUgaXRlclJlc3VsdCk7CiBib29sIGl0ZXJhdG9yQ29tcGxldGUoRXhlY1N0YXRlKiwgSlNW YWx1ZSBpdGVyUmVzdWx0KTsKIEpTVmFsdWUgaXRlcmF0b3JTdGVwKEV4ZWNTdGF0ZSosIEpTVmFs dWUgaXRlcmF0b3IpOwogdm9pZCBpdGVyYXRvckNsb3NlKEV4ZWNTdGF0ZSosIEpTVmFsdWUgaXRl cmF0b3IpOwotSlNPYmplY3QqIGNyZWF0ZUl0ZXJSZXN1bHRPYmplY3QoRXhlY1N0YXRlKiwgSlNW YWx1ZSwgYm9vbCBkb25lKTsKK0pTX0VYUE9SVF9QUklWQVRFIEpTT2JqZWN0KiBjcmVhdGVJdGVy YXRvclJlc3VsdE9iamVjdChFeGVjU3RhdGUqLCBKU1ZhbHVlIHZhbHVlLCBib29sIGRvbmUpOwog CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcEl0ZXJh dG9yUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcEl0ZXJh dG9yUHJvdG90eXBlLmNwcAppbmRleCBjYTdkYzA4ZjI4ZTBmNjZmYmQ2ZWJiYWY1ZDhiNjhhYjRl OGZkNjI1Li5mYjAzYmI4ZjZmMDQ4MTQ1YmJjZmU1ZjJjNWE5ODRmMzY3MTEyNzhlIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXBJdGVyYXRvclByb3RvdHlwZS5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFwSXRlcmF0b3JQcm90b3R5 cGUuY3BwCkBAIC02Myw5ICs2Myw5IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgTWFw SXRlcmF0b3JQcm90b3R5cGVGdW5jTmV4dChDYWxsRnJhbWUqIGNhbGxGcmFtZSkKIAogICAgIEpT VmFsdWUgcmVzdWx0OwogICAgIGlmIChpdGVyYXRvci0+bmV4dChjYWxsRnJhbWUsIHJlc3VsdCkp Ci0gICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3JlYXRlSXRlclJlc3VsdE9iamVjdChj YWxsRnJhbWUsIHJlc3VsdCwgZmFsc2UpKTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShjcmVhdGVJdGVyYXRvclJlc3VsdE9iamVjdChjYWxsRnJhbWUsIHJlc3VsdCwgZmFsc2UpKTsK ICAgICBpdGVyYXRvci0+ZmluaXNoKCk7Ci0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShjcmVh dGVJdGVyUmVzdWx0T2JqZWN0KGNhbGxGcmFtZSwganNVbmRlZmluZWQoKSwgdHJ1ZSkpOworICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3JlYXRlSXRlcmF0b3JSZXN1bHRPYmplY3QoY2FsbEZy YW1lLCBqc1VuZGVmaW5lZCgpLCB0cnVlKSk7CiB9CiAKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU2V0SXRlcmF0b3JQcm90b3R5cGUuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvU2V0SXRlcmF0b3JQcm90b3R5cGUuY3BwCmluZGV4IGYxYjhi Nzk0ODExODkwOTNhMDFhNjJjNTg2MTRkZDlkZWVkOGYzNjkuLjU3ZWYzODQ0NDM2ZDQyMzViYzdl YWQ0MWFkNmQ3NTZlYzA1NjUzMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL1NldEl0ZXJhdG9yUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TZXRJdGVyYXRvclByb3RvdHlwZS5jcHAKQEAgLTYzLDkgKzYzLDkgQEAgRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBTZXRJdGVyYXRvclByb3RvdHlwZUZ1bmNOZXh0KENh bGxGcmFtZSogY2FsbEZyYW1lKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHRocm93 VHlwZUVycm9yKGNhbGxGcmFtZSwgQVNDSUlMaXRlcmFsKCJDYW5ub3QgY2FsbCBTZXRJdGVyYXRv ci5uZXh0KCkgb24gYSBub24tU2V0SXRlcmF0b3Igb2JqZWN0IikpKTsKIAogICAgIGlmIChpdGVy YXRvci0+bmV4dChjYWxsRnJhbWUsIHJlc3VsdCkpCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjpl bmNvZGUoY3JlYXRlSXRlclJlc3VsdE9iamVjdChjYWxsRnJhbWUsIHJlc3VsdCwgZmFsc2UpKTsK KyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShjcmVhdGVJdGVyYXRvclJlc3VsdE9iamVj dChjYWxsRnJhbWUsIHJlc3VsdCwgZmFsc2UpKTsKICAgICBpdGVyYXRvci0+ZmluaXNoKCk7Ci0g ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShjcmVhdGVJdGVyUmVzdWx0T2JqZWN0KGNhbGxGcmFt ZSwganNVbmRlZmluZWQoKSwgdHJ1ZSkpOworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3Jl YXRlSXRlcmF0b3JSZXN1bHRPYmplY3QoY2FsbEZyYW1lLCBqc1VuZGVmaW5lZCgpLCB0cnVlKSk7 CiB9CiAKIH0K 253391 2015-05-19 12:46:54 -0700 2015-05-19 13:08:04 -0700 Patch for landing bug-145116-20150519214650.patch text/plain 4654 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NzYwYTIzZTdlNzAyNmJkYTBhOWQzNzZmOTE2ZDc0OGZhNTc0OWI4Li40NDk4MTI4MDg0OGFlNTE5 MWIzZmUxOTJiYzFmNzg5M2IzMzA2NWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNS0wNS0xOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3Jm LmNhbm9uLmZyPgorCisgICAgICAgIFJlbmFtZSBjcmVhdGVJdGVyUmVzdWx0T2JqZWN0IGFzIGNy ZWF0ZUl0ZXJhdG9yUmVzdWx0T2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDUxMTYKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KKworICAgICAgICBSZW5hbWVkIGNyZWF0ZUl0ZXJSZXN1bHRPYmplY3QgYXMgY3JlYXRlSXRl cmF0b3JSZXN1bHRPYmplY3QuCisgICAgICAgIE1hZGUgdGhpcyBmdW5jdGlvbiBleHBvcnRhYmxl IGZvciBmdXR1cmUgdXNlIGJ5IHN0cmVhbXMgQVBJLgorCisgICAgICAgICogcnVudGltZS9JdGVy YXRvck9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpjcmVhdGVJdGVyYXRvclJlc3VsdE9i amVjdCk6CisgICAgICAgICogcnVudGltZS9JdGVyYXRvck9wZXJhdGlvbnMuaDoKKyAgICAgICAg KiBydW50aW1lL01hcEl0ZXJhdG9yUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6TWFwSXRl cmF0b3JQcm90b3R5cGVGdW5jTmV4dCk6CisgICAgICAgICogcnVudGltZS9TZXRJdGVyYXRvclBy b3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OlNldEl0ZXJhdG9yUHJvdG90eXBlRnVuY05leHQp OgorCiAyMDE1LTA1LTE3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBEbyBub3QgdXNlIGZhc3RNYWxsb2NHb29kU2l6ZSBhbnl3aGVyZQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25zLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0l0ZXJhdG9yT3BlcmF0aW9ucy5jcHAK aW5kZXggYjAxZDMzZDYxY2U2MDE1NWNkYjI3ZjA3ODcxNDg4Y2EzZTk2M2I0Yi4uNjZhN2Q2ODA4 MTY1YWI4ZWMwYmQyMTFiODIxZmM1NDk0M2UwOGIyMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9JdGVyYXRvck9wZXJhdGlvbnMuY3BwCkBAIC0xMzEsNyArMTMx LDcgQEAgdm9pZCBpdGVyYXRvckNsb3NlKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBpdGVyYXRv cikKICAgICB9CiB9CiAKLUpTT2JqZWN0KiBjcmVhdGVJdGVyUmVzdWx0T2JqZWN0KEV4ZWNTdGF0 ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgYm9vbCBkb25lKQorSlNPYmplY3QqIGNyZWF0ZUl0ZXJh dG9yUmVzdWx0T2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgYm9vbCBkb25l KQogewogICAgIEpTT2JqZWN0KiByZXN1bHRPYmplY3QgPSBjb25zdHJ1Y3RFbXB0eU9iamVjdChl eGVjKTsKICAgICByZXN1bHRPYmplY3QtPnB1dERpcmVjdChleGVjLT52bSgpLCBleGVjLT5wcm9w ZXJ0eU5hbWVzKCkuZG9uZSwganNCb29sZWFuKGRvbmUpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0l0ZXJhdG9yT3BlcmF0aW9ucy5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSXRlcmF0b3JPcGVyYXRpb25zLmgKaW5kZXggNGJlZjM4ODM1YWFl ZWVmYWVjMTJjODBhOTVlYjEzM2I3OGRhZGQyNC4uYTlhMzAwYzk0MjYyZGEyYmNkYTQ3NjAwMmUz MWZjNDU2Y2FmNzdiYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SXRlcmF0b3JPcGVyYXRpb25zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SXRlcmF0b3JPcGVyYXRpb25zLmgKQEAgLTMzLDExICszMywxMSBAQCBuYW1lc3BhY2UgSlNDIHsK IAogSlNWYWx1ZSBpdGVyYXRvck5leHQoRXhlY1N0YXRlKiwgSlNWYWx1ZSBpdGVyYXRvciwgSlNW YWx1ZSk7CiBKU1ZhbHVlIGl0ZXJhdG9yTmV4dChFeGVjU3RhdGUqLCBKU1ZhbHVlIGl0ZXJhdG9y KTsKLUpTVmFsdWUgaXRlcmF0b3JWYWx1ZShFeGVjU3RhdGUqLCBKU1ZhbHVlIGl0ZXJSZXN1bHQp OwotYm9vbCBpdGVyYXRvckNvbXBsZXRlKEV4ZWNTdGF0ZSosIEpTVmFsdWUgaXRlclJlc3VsdCk7 CitKU1ZhbHVlIGl0ZXJhdG9yVmFsdWUoRXhlY1N0YXRlKiwgSlNWYWx1ZSBpdGVyYXRvcik7Citi b29sIGl0ZXJhdG9yQ29tcGxldGUoRXhlY1N0YXRlKiwgSlNWYWx1ZSBpdGVyYXRvcik7CiBKU1Zh bHVlIGl0ZXJhdG9yU3RlcChFeGVjU3RhdGUqLCBKU1ZhbHVlIGl0ZXJhdG9yKTsKIHZvaWQgaXRl cmF0b3JDbG9zZShFeGVjU3RhdGUqLCBKU1ZhbHVlIGl0ZXJhdG9yKTsKLUpTT2JqZWN0KiBjcmVh dGVJdGVyUmVzdWx0T2JqZWN0KEV4ZWNTdGF0ZSosIEpTVmFsdWUsIGJvb2wgZG9uZSk7CitKU19F WFBPUlRfUFJJVkFURSBKU09iamVjdCogY3JlYXRlSXRlcmF0b3JSZXN1bHRPYmplY3QoRXhlY1N0 YXRlKiwgSlNWYWx1ZSwgYm9vbCBkb25lKTsKIAogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9NYXBJdGVyYXRvclByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9NYXBJdGVyYXRvclByb3RvdHlwZS5jcHAKaW5kZXggY2E3ZGMw OGYyOGUwZjY2ZmJkNmViYmFmNWQ4YjY4YWI0ZThmZDYyNS4uZmIwM2JiOGY2ZjA0ODE0NWJiY2Zl NWYyYzVhOTg0ZjM2NzExMjc4ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvTWFwSXRlcmF0b3JQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL01hcEl0ZXJhdG9yUHJvdG90eXBlLmNwcApAQCAtNjMsOSArNjMsOSBAQCBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIE1hcEl0ZXJhdG9yUHJvdG90eXBlRnVuY05leHQoQ2Fs bEZyYW1lKiBjYWxsRnJhbWUpCiAKICAgICBKU1ZhbHVlIHJlc3VsdDsKICAgICBpZiAoaXRlcmF0 b3ItPm5leHQoY2FsbEZyYW1lLCByZXN1bHQpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGNyZWF0ZUl0ZXJSZXN1bHRPYmplY3QoY2FsbEZyYW1lLCByZXN1bHQsIGZhbHNlKSk7Cisg ICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3JlYXRlSXRlcmF0b3JSZXN1bHRPYmplY3Qo Y2FsbEZyYW1lLCByZXN1bHQsIGZhbHNlKSk7CiAgICAgaXRlcmF0b3ItPmZpbmlzaCgpOwotICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3JlYXRlSXRlclJlc3VsdE9iamVjdChjYWxsRnJhbWUs IGpzVW5kZWZpbmVkKCksIHRydWUpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNyZWF0 ZUl0ZXJhdG9yUmVzdWx0T2JqZWN0KGNhbGxGcmFtZSwganNVbmRlZmluZWQoKSwgdHJ1ZSkpOwog fQogCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NldEl0ZXJh dG9yUHJvdG90eXBlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NldEl0ZXJh dG9yUHJvdG90eXBlLmNwcAppbmRleCBmMWI4Yjc5NDgxMTg5MDkzYTAxYTYyYzU4NjE0ZGQ5ZGVl ZDhmMzY5Li41N2VmMzg0NDQzNmQ0MjM1YmM3ZWFkNDFhZDZkNzU2ZWMwNTY1MzMxIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TZXRJdGVyYXRvclByb3RvdHlwZS5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2V0SXRlcmF0b3JQcm90b3R5 cGUuY3BwCkBAIC02Myw5ICs2Myw5IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgU2V0 SXRlcmF0b3JQcm90b3R5cGVGdW5jTmV4dChDYWxsRnJhbWUqIGNhbGxGcmFtZSkKICAgICAgICAg cmV0dXJuIEpTVmFsdWU6OmVuY29kZSh0aHJvd1R5cGVFcnJvcihjYWxsRnJhbWUsIEFTQ0lJTGl0 ZXJhbCgiQ2Fubm90IGNhbGwgU2V0SXRlcmF0b3IubmV4dCgpIG9uIGEgbm9uLVNldEl0ZXJhdG9y IG9iamVjdCIpKSk7CiAKICAgICBpZiAoaXRlcmF0b3ItPm5leHQoY2FsbEZyYW1lLCByZXN1bHQp KQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNyZWF0ZUl0ZXJSZXN1bHRPYmplY3Qo Y2FsbEZyYW1lLCByZXN1bHQsIGZhbHNlKSk7CisgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNv ZGUoY3JlYXRlSXRlcmF0b3JSZXN1bHRPYmplY3QoY2FsbEZyYW1lLCByZXN1bHQsIGZhbHNlKSk7 CiAgICAgaXRlcmF0b3ItPmZpbmlzaCgpOwotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoY3Jl YXRlSXRlclJlc3VsdE9iamVjdChjYWxsRnJhbWUsIGpzVW5kZWZpbmVkKCksIHRydWUpKTsKKyAg ICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNyZWF0ZUl0ZXJhdG9yUmVzdWx0T2JqZWN0KGNhbGxG cmFtZSwganNVbmRlZmluZWQoKSwgdHJ1ZSkpOwogfQogCiB9Cg==