145113 2015-05-17 19:00:02 -0700 Source/WTF/wtf/Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 for mips N64 2015-06-22 23:34:07 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 wzssyqa webkit-unassigned benjamin cgarcia cmarcelo commit-queue ossy oldest_to_newest 1095537 0 wzssyqa 2015-05-17 19:00:02 -0700 Index: webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h =================================================================== --- webkit2gtk-2.8.1+dfsg1.orig/Source/WTF/wtf/Platform.h 2015-05-03 00:05:21.000000000 +0800 +++ webkit2gtk-2.8.1+dfsg1/Source/WTF/wtf/Platform.h 2015-05-04 00:30:23.858545576 +0800 @@ -82,7 +82,7 @@ /* CPU(MIPS) - MIPS 32-bit and 64-bit */ #if (defined(mips) || defined(__mips__) || defined(MIPS) || defined(_MIPS_) || defined(__mips64)) -#if defined(_MIPS_SIM_ABI64) && (_MIPS_SIM == _MIPS_SIM_ABI64) +#if defined(_ABI64) && (_MIPS_SIM == _ABI64) #define WTF_CPU_MIPS64 1 #define WTF_MIPS_ARCH __mips64 #else Please replace _MIPS_SIM_ABI64 with _ABI64, as _ABI64 is much more widely used, and is defined by compilers, while _MIPS_SIM_ABI64 is only defined by glibc. 1103778 1 wzssyqa 2015-06-22 00:50:23 -0700 Any one worked on this ? 1103780 2 ossy 2015-06-22 00:52:35 -0700 I don't think if anyone maintains MIPS specific code paths. 1103782 3 wzssyqa 2015-06-22 00:56:43 -0700 OK. Can you help to commit this patch? We tested this patch. It works well. 1103784 4 ossy 2015-06-22 01:01:19 -0700 (In reply to comment #3) > OK. > Can you help to commit this patch? > > We tested this patch. It works well. Please upload the patch for review (for trunk WebKit) with the necessary changelog entry. And then I can review and commit it to WebKit trunk and Carlos can land it to the GTK release branch. 1103885 5 255357 wzssyqa 2015-06-22 11:44:57 -0700 Created attachment 255357 Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 1104037 6 255357 ossy 2015-06-22 23:30:57 -0700 Comment on attachment 255357 Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 r=me, but will land manually because of missing "Reviewed by nobody" line. 1104038 7 255357 ossy 2015-06-22 23:32:10 -0700 Comment on attachment 255357 Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 View in context: https://bugs.webkit.org/attachment.cgi?id=255357&action=review > ChangeLog:5 > +2015-06-22 YunQiang Su <wzssyqa@gmail.com> > + > + [WTF] Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 > + https://bugs.webkit.org/show_bug.cgi?id=145113 > + It should be in Source/WTF/ChangeLog. 1104039 8 ossy 2015-06-22 23:34:07 -0700 Committed r185863: <http://trac.webkit.org/changeset/185863> 255357 2015-06-22 11:44:57 -0700 2015-06-22 23:30:57 -0700 Use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64 mips_ABI64_145113.diff text/plain 926 wzssyqa ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkZTA2ODBlLi5hOWE5ODhi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsOCBAQAor MjAxNS0wNi0yMiAgWXVuUWlhbmcgU3UgIDx3enNzeXFhQGdtYWlsLmNvbT4KKworICAgICAgICBb V1RGXSBQbGF0Zm9ybS5oOiB1c2UgX0FCSTY0IGluc3RlYWQgb2YgX01JUFNfU0lNX0FCSTY0IHRv IGRldGVybWluZSBNSVBTIE42NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ1MTEzCisKIDIwMTUtMDYtMjIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNl a0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gQWRkIHN1cHBvcnQgZm9yIGJ1aWxkaW5n IHdpdGggdmFyaW91cyBzYW5pdGl6ZXIgdG9vbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGMyMzRmNTAuLmI1 ZTk4NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNl L1dURi93dGYvUGxhdGZvcm0uaApAQCAtODIsNyArODIsNyBAQAogCiAvKiBDUFUoTUlQUykgLSBN SVBTIDMyLWJpdCBhbmQgNjQtYml0ICovCiAjaWYgKGRlZmluZWQobWlwcykgfHwgZGVmaW5lZChf X21pcHNfXykgfHwgZGVmaW5lZChNSVBTKSB8fCBkZWZpbmVkKF9NSVBTXykgfHwgZGVmaW5lZChf X21pcHM2NCkpCi0jaWYgZGVmaW5lZChfTUlQU19TSU1fQUJJNjQpICYmIChfTUlQU19TSU0gPT0g X01JUFNfU0lNX0FCSTY0KQorI2lmIGRlZmluZWQoX0FCSTY0KSAmJiAoX01JUFNfU0lNID09IF9B Qkk2NCkKICNkZWZpbmUgV1RGX0NQVV9NSVBTNjQgMQogI2RlZmluZSBXVEZfTUlQU19BUkNIIF9f bWlwczY0CiAjZWxzZQo=