145100 2015-05-16 16:30:26 -0700 bisect-builds: Add 'retry' option when prompting whether the bug reproduced 2015-05-17 10:36:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue darin ddkilzer mitz oldest_to_newest 1095457 0 ddkilzer 2015-05-16 16:30:26 -0700 When using bisect-builds, sometimes it's useful to be able to retry a spade build to see if a bug reproduces, perhaps because you got distracted or interrupted, or because the test is flakey. 1095458 1 253279 ddkilzer 2015-05-16 16:35:32 -0700 Created attachment 253279 Patch v1 1095487 2 253279 commit-queue 2015-05-17 10:36:42 -0700 Comment on attachment 253279 Patch v1 Clearing flags on attachment: 253279 Committed r184442: <http://trac.webkit.org/changeset/184442> 1095488 3 commit-queue 2015-05-17 10:36:46 -0700 All reviewed patches have been landed. Closing bug. 253279 2015-05-16 16:35:32 -0700 2015-05-17 10:36:42 -0700 Patch v1 bug-145100-20150516163406.patch text/plain 7547 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDk4ZWQ3MDVkNTcxMGQ2YjQ1MWQzODkzYjA3NGRiYTky NjQ0ZTAzNy4uNmY2ZmU3ZTAxMjI2NmJmNDMxMGYzZDkxZWI4NjRhYmRhM2JmZWM0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE1LTA1LTE2ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgYmlzZWN0LWJ1aWxkczogQWRkICdyZXRyeScgb3B0aW9uIHdoZW4gcHJvbXB0aW5nIHdo ZXRoZXIgdGhlIGJ1ZyByZXByb2R1Y2VkCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzE0 NTEwMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvYmlzZWN0LWJ1aWxkczoKKyAgICAgICAgLSBBZGQgUFJPTVBUX0FOU1dFUl8qIGNv bnN0YW50cyBmb3IgeWVzL25vL3JldHJ5L2Jyb2tlbiBwcm9tcHQuCisgICAgICAgIC0gU3dpdGNo IHRvIHVzaW5nIFBST01QVF9SRVNQT05TRV8qIGNvbnN0YW50cyB3aGVuIHRlc3RpbmcgdGhlCisg ICAgICAgICAgdmFsdWUgb2YgJGRpZFJlcHJvZHVjZUJ1Zy4KKyAgICAgICAgLSBBZGQgZG8geyB9 IHdoaWxlIGxvb3BzIHRvIGltcGxlbWVudCAncmV0cnknIG1vZGUuCisgICAgICAgIChwcm9tcHRG b3JUZXN0KToKKyAgICAgICAgLSBTd2l0Y2ggdG8gcmV0dXJuaW5nIFBST01QVF9SRVNQT05TRV8q IGNvbnN0YW50cy4KKyAgICAgICAgLSBBZGQgc3VwcG9ydCBmb3IgJ3JldHJ5JyByZXNwb25zZS4K KwogMjAxNS0wNS0xMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFN3aXRjaCB0byBsYXVuY2hpbmcgaU9TIFNpbXVsYXRvciB1c2luZyBidW5kbGUgSUQKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcyBiL1Rvb2xzL1NjcmlwdHMvYmlz ZWN0LWJ1aWxkcwppbmRleCBkNDE3MGVkOWViZDU0ODE2MTk1ZThmY2U1N2M0ZTcwYzk4NDY0ZTVj Li44OTAyOTI0NTE0NGI5MjVmZDFhNWJkNWM4YWExMjM2M2U0OGU3MmE2IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKKysrIGIvVG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVp bGRzCkBAIC0xLDYgKzEsNiBAQAogIyEvdXNyL2Jpbi9wZXJsIC13CiAKLSMgQ29weXJpZ2h0IChD KSAyMDA3LTIwMDksIDIwMTEtMjAxNCBBcHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgor IyBDb3B5cmlnaHQgKEMpIDIwMDctMjAwOSwgMjAxMS0yMDE1IEFwcGxlIEluYy4gIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTExLDkgKzExLDYg QEAKICMgMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0 aGUgYWJvdmUgY29weXJpZ2h0CiAjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCiAjICAgICBkb2N1bWVudGF0aW9u IGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLiAK LSMgMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgSW5jLiAoIkFwcGxlIikgbm9yIHRoZSBu YW1lcyBvZgotIyAgICAgaXRzIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9y IHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZAotIyAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhv dXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLiAKICMKICMgVEhJUyBTT0ZUV0FS RSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBB TlkKICMgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLCBUSEUgSU1QTElFRApAQCAtNTAsNiArNDcsMTMgQEAgdXNlIFRpbWU6OkhpUmVz IHF3KHVzbGVlcCk7CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2Ugd2Via2l0ZGlycyBxdyhz YWZhcmlQYXRoRnJvbVNhZmFyaUJ1bmRsZSk7CiAKK3VzZSBjb25zdGFudCB7CisgICAgUFJPTVBU X1JFU1BPTlNFX0JST0tFTiA9PiAtMSwKKyAgICBQUk9NUFRfUkVTUE9OU0VfTk8gPT4gMCwKKyAg ICBQUk9NUFRfUkVTUE9OU0VfUkVUUlkgPT4gMiwKKyAgICBQUk9NUFRfUkVTUE9OU0VfWUVTID0+ IDEsCit9OworCiBzdWIgY3JlYXRlVGVtcEZpbGUoJCk7CiBzdWIgZG93bmxvYWROaWdodGx5KCQk JCk7CiBzdWIgZmluZE1hY09TWFZlcnNpb24oKTsKQEAgLTE1MiwyNyArMTU2LDMxIEBAIGlmICgk c2FuaXR5Q2hlY2spIHsKICAgICAgICAgcHJpbnRmICJcbkNoZWNraW5nIHN0YXJ0aW5nIHJldmlz aW9uIHIlcy4uLlxuIiwKICAgICAgICAgICAgICRuaWdodGxpZXNbJHN0YXJ0SW5kZXhdLT57cmV2 fTsKICAgICAgICAgZG93bmxvYWROaWdodGx5KCRuaWdodGxpZXNbJHN0YXJ0SW5kZXhdLT57Zmls ZX0sICRuaWdodGx5RmlsZXNVUkxCYXNlLCAkbmlnaHRseURvd25sb2FkRGlyZWN0b3J5KTsKLSAg ICAgICAgbW91bnRBbmRSdW5OaWdodGx5KCRuaWdodGxpZXNbJHN0YXJ0SW5kZXhdLT57ZmlsZX0s ICRuaWdodGx5RG93bmxvYWREaXJlY3RvcnksICRzYWZhcmlQYXRoLCAkdGVtcEZpbGUpOwotICAg ICAgICAkZGlkUmVwcm9kdWNlQnVnID0gcHJvbXB0Rm9yVGVzdCgkbmlnaHRsaWVzWyRzdGFydElu ZGV4XS0+e3Jldn0pOwotICAgICAgICAkc3RhcnRJbmRleC0tIGlmICRkaWRSZXByb2R1Y2VCdWcg PCAwOwotICAgIH0gd2hpbGUgKCRkaWRSZXByb2R1Y2VCdWcgPCAwKTsKKyAgICAgICAgZG8gewor ICAgICAgICAgICAgbW91bnRBbmRSdW5OaWdodGx5KCRuaWdodGxpZXNbJHN0YXJ0SW5kZXhdLT57 ZmlsZX0sICRuaWdodGx5RG93bmxvYWREaXJlY3RvcnksICRzYWZhcmlQYXRoLCAkdGVtcEZpbGUp OworICAgICAgICAgICAgJGRpZFJlcHJvZHVjZUJ1ZyA9IHByb21wdEZvclRlc3QoJG5pZ2h0bGll c1skc3RhcnRJbmRleF0tPntyZXZ9KTsKKyAgICAgICAgfSB3aGlsZSAoJGRpZFJlcHJvZHVjZUJ1 ZyA9PSBQUk9NUFRfUkVTUE9OU0VfUkVUUlkpOworICAgICAgICAkc3RhcnRJbmRleC0tIGlmICRk aWRSZXByb2R1Y2VCdWcgPT0gUFJPTVBUX1JFU1BPTlNFX0JST0tFTjsKKyAgICB9IHdoaWxlICgk ZGlkUmVwcm9kdWNlQnVnID09IFBST01QVF9SRVNQT05TRV9CUk9LRU4pOwogICAgIGRpZSAiRVJS T1I6IEJ1ZyByZXByb2R1Y2VkIGluIHN0YXJ0aW5nIHJldmlzaW9uISAgRG8geW91IG5lZWQgdG8g dGVzdCBhbiBlYXJsaWVyIHJldmlzaW9uIG9yIGZvciBhIHByb2dyZXNzaW9uPyIKLSAgICAgICAg aWYgJGRpZFJlcHJvZHVjZUJ1ZyAmJiAhJGlzUHJvZ3Jlc3Npb247CisgICAgICAgIGlmICRkaWRS ZXByb2R1Y2VCdWcgPT0gUFJPTVBUX1JFU1BPTlNFX1lFUyAmJiAhJGlzUHJvZ3Jlc3Npb247CiAg ICAgZGllICJFUlJPUjogQnVnIG5vdCByZXByb2R1Y2VkIGluIHN0YXJ0aW5nIHJldmlzaW9uISAg RG8geW91IG5lZWQgdG8gdGVzdCBhbiBlYXJsaWVyIHJldmlzaW9uIG9yIGZvciBhIHJlZ3Jlc3Np b24/IgotICAgICAgICBpZiAhJGRpZFJlcHJvZHVjZUJ1ZyAmJiAkaXNQcm9ncmVzc2lvbjsKKyAg ICAgICAgaWYgJGRpZFJlcHJvZHVjZUJ1ZyA9PSBQUk9NUFRfUkVTUE9OU0VfTk8gJiYgJGlzUHJv Z3Jlc3Npb247CiAKICAgICBkbyB7CiAgICAgICAgIHByaW50ZiAiXG5DaGVja2luZyBlbmRpbmcg cmV2aXNpb24gciVzLi4uXG4iLAogICAgICAgICAgICAgJG5pZ2h0bGllc1skZW5kSW5kZXhdLT57 cmV2fTsKICAgICAgICAgZG93bmxvYWROaWdodGx5KCRuaWdodGxpZXNbJGVuZEluZGV4XS0+e2Zp bGV9LCAkbmlnaHRseUZpbGVzVVJMQmFzZSwgJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSk7Ci0g ICAgICAgIG1vdW50QW5kUnVuTmlnaHRseSgkbmlnaHRsaWVzWyRlbmRJbmRleF0tPntmaWxlfSwg JG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSwgJHNhZmFyaVBhdGgsICR0ZW1wRmlsZSk7Ci0gICAg ICAgICRkaWRSZXByb2R1Y2VCdWcgPSBwcm9tcHRGb3JUZXN0KCRuaWdodGxpZXNbJGVuZEluZGV4 XS0+e3Jldn0pOwotICAgICAgICAkZW5kSW5kZXgrKyBpZiAkZGlkUmVwcm9kdWNlQnVnIDwgMDsK LSAgICB9IHdoaWxlICgkZGlkUmVwcm9kdWNlQnVnIDwgMCk7CisgICAgICAgIGRvIHsKKyAgICAg ICAgICAgIG1vdW50QW5kUnVuTmlnaHRseSgkbmlnaHRsaWVzWyRlbmRJbmRleF0tPntmaWxlfSwg JG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSwgJHNhZmFyaVBhdGgsICR0ZW1wRmlsZSk7CisgICAg ICAgICAgICAkZGlkUmVwcm9kdWNlQnVnID0gcHJvbXB0Rm9yVGVzdCgkbmlnaHRsaWVzWyRlbmRJ bmRleF0tPntyZXZ9KTsKKyAgICAgICAgfSB3aGlsZSAoJGRpZFJlcHJvZHVjZUJ1ZyA9PSBQUk9N UFRfUkVTUE9OU0VfUkVUUlkpOworICAgICAgICAkZW5kSW5kZXgrKyBpZiAkZGlkUmVwcm9kdWNl QnVnID09IFBST01QVF9SRVNQT05TRV9CUk9LRU47CisgICAgfSB3aGlsZSAoJGRpZFJlcHJvZHVj ZUJ1ZyA9PSBQUk9NUFRfUkVTUE9OU0VfQlJPS0VOKTsKICAgICBkaWUgIkVSUk9SOiBCdWcgTk9U IHJlcHJvZHVjZWQgaW4gZW5kaW5nIHJldmlzaW9uISAgRG8geW91IG5lZWQgdG8gdGVzdCBhIGxh dGVyIHJldmlzaW9uIG9yIGZvciBhIHByb2dyZXNzaW9uPyIKLSAgICAgICAgaWYgISRkaWRSZXBy b2R1Y2VCdWcgJiYgISRpc1Byb2dyZXNzaW9uOworICAgICAgICBpZiAkZGlkUmVwcm9kdWNlQnVn ID09IFBST01QVF9SRVNQT05TRV9OTyAmJiAhJGlzUHJvZ3Jlc3Npb247CiAgICAgZGllICJFUlJP UjogQnVnIHJlcHJvZHVjZWQgaW4gZW5kaW5nIHJldmlzaW9uISAgRG8geW91IG5lZWQgdG8gdGVz dCBhIGxhdGVyIHJldmlzaW9uIG9yIGZvciBhIHJlZ3Jlc3Npb24/IgotICAgICAgICBpZiAkZGlk UmVwcm9kdWNlQnVnICYmICRpc1Byb2dyZXNzaW9uOworICAgICAgICBpZiAkZGlkUmVwcm9kdWNl QnVnID09IFBST01QVF9SRVNQT05TRV9ZRVMgJiYgJGlzUHJvZ3Jlc3Npb247CiB9CiAKIHByaW50 U3RhdHVzKCRuaWdodGxpZXNbJHN0YXJ0SW5kZXhdLT57cmV2fSwgJG5pZ2h0bGllc1skZW5kSW5k ZXhdLT57cmV2fSwgJGlzUHJvZ3Jlc3Npb24pOwpAQCAtMTg4LDEwICsxOTYsMTIgQEAgd2hpbGUg KGFicygkZW5kSW5kZXggLSAkc3RhcnRJbmRleCkgPiAxKSB7CiAgICAgICAgICAgICBteSAkcGx1 cmFsID0gJGJ1aWxkc0xlZnQgPT0gMSA/ICIiIDogInMiOwogICAgICAgICAgICAgcHJpbnRmICJc bkNoZWNraW5nIHJldmlzaW9uIHIlcyAoJWQgYnVpbGQlcyBsZWZ0IHRvIHRlc3QgYWZ0ZXIgdGhp cykuLi5cbiIsICRuaWdodGxpZXNbJGluZGV4XS0+e3Jldn0sICRidWlsZHNMZWZ0LCAkcGx1cmFs OwogICAgICAgICAgICAgZG93bmxvYWROaWdodGx5KCRuaWdodGxpZXNbJGluZGV4XS0+e2ZpbGV9 LCAkbmlnaHRseUZpbGVzVVJMQmFzZSwgJG5pZ2h0bHlEb3dubG9hZERpcmVjdG9yeSk7Ci0gICAg ICAgICAgICBtb3VudEFuZFJ1bk5pZ2h0bHkoJG5pZ2h0bGllc1skaW5kZXhdLT57ZmlsZX0sICRu aWdodGx5RG93bmxvYWREaXJlY3RvcnksICRzYWZhcmlQYXRoLCAkdGVtcEZpbGUpOwotICAgICAg ICAgICAgJGRpZFJlcHJvZHVjZUJ1ZyA9IHByb21wdEZvclRlc3QoJG5pZ2h0bGllc1skaW5kZXhd LT57cmV2fSk7CisgICAgICAgICAgICBkbyB7CisgICAgICAgICAgICAgICAgbW91bnRBbmRSdW5O aWdodGx5KCRuaWdodGxpZXNbJGluZGV4XS0+e2ZpbGV9LCAkbmlnaHRseURvd25sb2FkRGlyZWN0 b3J5LCAkc2FmYXJpUGF0aCwgJHRlbXBGaWxlKTsKKyAgICAgICAgICAgICAgICAkZGlkUmVwcm9k dWNlQnVnID0gcHJvbXB0Rm9yVGVzdCgkbmlnaHRsaWVzWyRpbmRleF0tPntyZXZ9KTsKKyAgICAg ICAgICAgIH0gd2hpbGUgKCRkaWRSZXByb2R1Y2VCdWcgPT0gUFJPTVBUX1JFU1BPTlNFX1JFVFJZ KTsKICAgICAgICAgfQotICAgICAgICBpZiAoJGRpZFJlcHJvZHVjZUJ1ZyA8IDApIHsKKyAgICAg ICAgaWYgKCRkaWRSZXByb2R1Y2VCdWcgPT0gUFJPTVBUX1JFU1BPTlNFX0JST0tFTikgewogICAg ICAgICAgICAgJGJyb2tlblJldmlzaW9uc3skbmlnaHRsaWVzWyRpbmRleF0tPntyZXZ9fSA9ICRu aWdodGxpZXNbJGluZGV4XS0+e2ZpbGV9OwogICAgICAgICAgICAgZGVsZXRlICRuaWdodGxpZXNb JGluZGV4XTsKICAgICAgICAgICAgICRlbmRJbmRleC0tOwpAQCAtMjAzLDkgKzIxMyw5IEBAIHdo aWxlIChhYnMoJGVuZEluZGV4IC0gJHN0YXJ0SW5kZXgpID4gMSkgewogICAgICAgICAgICAgICAg ICRpbmRleCA9IGludCgoJGluZGV4ICsgJGVuZEluZGV4KSAvIDIpOwogICAgICAgICAgICAgfQog ICAgICAgICB9Ci0gICAgfSB3aGlsZSAoJGRpZFJlcHJvZHVjZUJ1ZyA8IDApOworICAgIH0gd2hp bGUgKCRkaWRSZXByb2R1Y2VCdWcgPT0gUFJPTVBUX1JFU1BPTlNFX0JST0tFTik7CiAKLSAgICBp ZiAoJGRpZFJlcHJvZHVjZUJ1ZyAmJiAhJGlzUHJvZ3Jlc3Npb24gfHwgISRkaWRSZXByb2R1Y2VC dWcgJiYgJGlzUHJvZ3Jlc3Npb24pIHsKKyAgICBpZiAoJGRpZFJlcHJvZHVjZUJ1ZyA9PSBQUk9N UFRfUkVTUE9OU0VfWUVTICYmICEkaXNQcm9ncmVzc2lvbiB8fCAkZGlkUmVwcm9kdWNlQnVnID09 IFBST01QVF9SRVNQT05TRV9OTyAmJiAkaXNQcm9ncmVzc2lvbikgewogICAgICAgICAkZW5kSW5k ZXggPSAkaW5kZXg7CiAgICAgfSBlbHNlIHsKICAgICAgICAgJHN0YXJ0SW5kZXggPSAkaW5kZXg7 CkBAIC00ODIsMTAgKzQ5MiwxMSBAQCBzdWIgcHJpbnRUcmFjTGluaygkJCkKIHN1YiBwcm9tcHRG b3JUZXN0KCQpCiB7CiAgICAgbXkgKCRyZXZpc2lvbikgPSBAXzsKLSAgICBwcmludCAiRGlkIHRo ZSBidWcgcmVwcm9kdWNlIGluIHIkcmV2aXNpb24gKHllcy9uby9icm9rZW4pPyAiOworICAgIHBy aW50ICJEaWQgdGhlIGJ1ZyByZXByb2R1Y2UgaW4gciRyZXZpc2lvbiAoeWVzL25vL3JldHJ5L2Jy b2tlbik/ICI7CiAgICAgbXkgJGFuc3dlciA9IDxTVERJTj47Ci0gICAgcmV0dXJuIDEgaWYgJGFu c3dlciA9fiAvXigxfHkuKikkL2k7Ci0gICAgcmV0dXJuIC0xIGlmICRhbnN3ZXIgPX4gL14oLTF8 Yi4qKSQvaTsgIyBCcm9rZW4KLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gUFJPTVBUX1JFU1BP TlNFX1lFUyBpZiAkYW5zd2VyID1+IC9eKDF8eS4qKSQvaTsKKyAgICByZXR1cm4gUFJPTVBUX1JF U1BPTlNFX1JFVFJZIGlmICRhbnN3ZXIgPX4gL15yLiovaTsKKyAgICByZXR1cm4gUFJPTVBUX1JF U1BPTlNFX0JST0tFTiBpZiAkYW5zd2VyID1+IC9eKC0xfGIuKikkL2k7CisgICAgcmV0dXJuIFBS T01QVF9SRVNQT05TRV9OTzsKIH0KIAo=