145095 2015-05-16 10:27:12 -0700 Remove MessageType variant of addMessageToConsole() from ChromeClient 2015-05-16 12:59:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue mkwst oldest_to_newest 1095426 0 sungmann.cho 2015-05-16 10:27:12 -0700 All addMessageToConsole() in ChromeClient are exactly the same thing. So there is no reason to keep all this methods. 1095427 1 253271 sungmann.cho 2015-05-16 10:29:24 -0700 Created attachment 253271 Patch 1095433 2 253271 commit-queue 2015-05-16 12:58:57 -0700 Comment on attachment 253271 Patch Clearing flags on attachment: 253271 Committed r184436: <http://trac.webkit.org/changeset/184436> 1095434 3 commit-queue 2015-05-16 12:59:01 -0700 All reviewed patches have been landed. Closing bug. 253271 2015-05-16 10:29:24 -0700 2015-05-16 12:58:57 -0700 Patch bug-145095-20150517022759.patch text/plain 2913 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzgyNjIzMTlhZDhlNmMy NTUxM2QzYjNjNDMwM2ZjOWJiZjMzMDNkMy4uNzIzNGFkNmM2YzJhMzI5MmY4MzM0ZmViMTdkY2Mz OGZhNGNhNmM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTE2ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBSZW1vdmUg TWVzc2FnZVR5cGUgdmFyaWFudCBvZiBhZGRNZXNzYWdlVG9Db25zb2xlKCkgZnJvbSBDaHJvbWVD bGllbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDUwOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGwgYWRkTWVzc2FnZVRvQ29uc29sZSgpIGluIENocm9tZUNsaWVudCBhcmUgZXhhY3RseSB0aGUg c2FtZSB0aGluZy4KKyAgICAgICAgU28gdGhlcmUgaXMgbm8gcmVhc29uIHRvIGtlZXAgYWxsIHRo aXMgbWV0aG9kcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4K KworICAgICAgICAqIHBhZ2UvQ2hyb21lQ2xpZW50Lmg6CisgICAgICAgICogcGFnZS9QYWdlQ29u c29sZUNsaWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ29uc29sZUNsaWVudDo6bWVz c2FnZVdpdGhUeXBlQW5kTGV2ZWwpOgorCiAyMDE1LTA1LTE1ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXaGVuIHJlZGlyZWN0aW5nIHRvIGRhdGEgVVJMIHVz ZSBIVFRQIHJlc3BvbnNlIGZvciBzYW1lIG9yaWdpbiBwb2xpY3kgY2hlY2tzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9DaHJvbWVDbGllbnQuaAppbmRleCA0OWU2YzIxYTY2ZTM0ZmJkZjgzM2FhMjhhZTBiMTNhZTdj YzNjZmI1Li4wMzBkZDY4ZWE3ZjA4ZTFlZmVhYmY2YmZkNjAzODU5NDEwNWNhY2JkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKQEAgLTEzNiwxMSArMTM2LDYgQEAgcHVibGljOgogICAg IHZpcnR1YWwgdm9pZCBzZXRSZXNpemFibGUoYm9vbCkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lk IGFkZE1lc3NhZ2VUb0NvbnNvbGUoTWVzc2FnZVNvdXJjZSwgTWVzc2FnZUxldmVsLCBjb25zdCBT dHJpbmcmIG1lc3NhZ2UsIHVuc2lnbmVkIGxpbmVOdW1iZXIsIHVuc2lnbmVkIGNvbHVtbk51bWJl ciwgY29uc3QgU3RyaW5nJiBzb3VyY2VJRCkgPSAwOwotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhp cyBNZXNzYWdlVHlwZSB2YXJpYW50IG9uY2UgYWxsIHRoZSBjbGllbnRzIGFyZSB1cGRhdGVkLgot ICAgIHZpcnR1YWwgdm9pZCBhZGRNZXNzYWdlVG9Db25zb2xlKE1lc3NhZ2VTb3VyY2Ugc291cmNl LCBNZXNzYWdlVHlwZSwgTWVzc2FnZUxldmVsIGxldmVsLCBjb25zdCBTdHJpbmcmIG1lc3NhZ2Us IHVuc2lnbmVkIGxpbmVOdW1iZXIsIHVuc2lnbmVkIGNvbHVtbk51bWJlciwgY29uc3QgU3RyaW5n JiBzb3VyY2VJRCkKLSAgICB7Ci0gICAgICAgIGFkZE1lc3NhZ2VUb0NvbnNvbGUoc291cmNlLCBs ZXZlbCwgbWVzc2FnZSwgbGluZU51bWJlciwgY29sdW1uTnVtYmVyLCBzb3VyY2VJRCk7Ci0gICAg fQogCiAgICAgdmlydHVhbCBib29sIGNhblJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbCgpID0g MDsKICAgICB2aXJ0dWFsIGJvb2wgcnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKGNvbnN0IFN0 cmluZyYgbWVzc2FnZSwgRnJhbWUqKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2VDb25zb2xlQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZUNvbnNv bGVDbGllbnQuY3BwCmluZGV4IGI1MjZkY2RlNzE4ZTAxZTQ2NTU1MDI3NGFmNTBjMjgwODNiNWY2 ODYuLjk2NDg4YjE5MjFiMTI2MjgxN2M2NjBhMjQ3MjY3MTg5ZmUwMDI5NWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZUNvbnNvbGVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZUNvbnNvbGVDbGllbnQuY3BwCkBAIC0xNjksNyArMTY5LDcgQEAgdm9p ZCBQYWdlQ29uc29sZUNsaWVudDo6bWVzc2FnZVdpdGhUeXBlQW5kTGV2ZWwoTWVzc2FnZVR5cGUg dHlwZSwgTWVzc2FnZUxldmVsIGwKICAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKGdvdE1lc3Nh Z2UpCi0gICAgICAgIG1fcGFnZS5jaHJvbWUoKS5jbGllbnQoKS5hZGRNZXNzYWdlVG9Db25zb2xl KE1lc3NhZ2VTb3VyY2U6OkNvbnNvbGVBUEksIHR5cGUsIGxldmVsLCBtZXNzYWdlVGV4dCwgbGlu ZU51bWJlciwgY29sdW1uTnVtYmVyLCB1cmwpOworICAgICAgICBtX3BhZ2UuY2hyb21lKCkuY2xp ZW50KCkuYWRkTWVzc2FnZVRvQ29uc29sZShNZXNzYWdlU291cmNlOjpDb25zb2xlQVBJLCBsZXZl bCwgbWVzc2FnZVRleHQsIGxpbmVOdW1iZXIsIGNvbHVtbk51bWJlciwgdXJsKTsKIAogICAgIGlm IChtX3BhZ2Uuc2V0dGluZ3MoKS5sb2dzUGFnZU1lc3NhZ2VzVG9TeXN0ZW1Db25zb2xlRW5hYmxl ZCgpIHx8IFBhZ2VDb25zb2xlQ2xpZW50OjpzaG91bGRQcmludEV4Y2VwdGlvbnMoKSkKICAgICAg ICAgQ29uc29sZUNsaWVudDo6cHJpbnRDb25zb2xlTWVzc2FnZVdpdGhBcmd1bWVudHMoTWVzc2Fn ZVNvdXJjZTo6Q29uc29sZUFQSSwgdHlwZSwgbGV2ZWwsIGV4ZWMsIFdURjo6bW92ZShhcmd1bWVu dHMpKTsK