145093 2015-05-15 22:39:19 -0700 Remove styleText() and applyStyleText() from InspectorStyle 2015-05-16 13:01:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue oldest_to_newest 1095396 0 sungmann.cho 2015-05-15 22:39:19 -0700 styleText() and applyStyleText() in InspectorStyle are private aliases for the public accessors in the same class but are rarely used. I think it would be better off removing these aliases and updating all the current call sites to use the public accessors directly. 1095405 1 253267 sungmann.cho 2015-05-15 22:55:31 -0700 Created attachment 253267 Patch 1095435 2 253267 commit-queue 2015-05-16 13:01:35 -0700 Comment on attachment 253267 Patch Clearing flags on attachment: 253267 Committed r184437: <http://trac.webkit.org/changeset/184437> 1095436 3 commit-queue 2015-05-16 13:01:38 -0700 All reviewed patches have been landed. Closing bug. 253267 2015-05-15 22:55:31 -0700 2015-05-16 13:01:35 -0700 Patch bug-145093-20150516145405.patch text/plain 3104 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU2ODc4NTUxYWM5ZjIz YjA0NzAzMGRiOWY1ZjczMzQ3ZjYyZjAwNi4uMDE1NDc4Yjc4N2ExNTc5YWM4ZmJiMjA1NTBjNzA0 MmYzNWU0MGJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTE1ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBSZW1vdmUg c3R5bGVUZXh0KCkgYW5kIGFwcGx5U3R5bGVUZXh0KCkgZnJvbSBJbnNwZWN0b3JTdHlsZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTA5MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0eWxlVGV4dCgp IGFuZCBhcHBseVN0eWxlVGV4dCgpIGluIEluc3BlY3RvclN0eWxlIGFyZSBwcml2YXRlIGFsaWFz ZXMgZm9yIHRoZSBwdWJsaWMKKyAgICAgICAgYWNjZXNzb3JzIGluIHRoZSBzYW1lIGNsYXNzIGJ1 dCBhcmUgcmFyZWx5IHVzZWQuIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIG9mZiByZW1vdmlu ZworICAgICAgICB0aGVzZSBhbGlhc2VzIGFuZCB1cGRhdGluZyBhbGwgdGhlIGN1cnJlbnQgY2Fs bCBzaXRlcyB0byB1c2UgdGhlIHB1YmxpYyBhY2Nlc3NvcnMgZGlyZWN0bHkKKyAgICAgICAgYXMg bm90ZWQgaW4gSW5zcGVjdG9yU3R5bGVTaGVldC5oLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxl U2hlZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3R5bGU6OnBvcHVsYXRlQWxs UHJvcGVydGllcyk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuaDoK KwogMjAxNS0wNS0xNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyMTgzMzAwKTogQmFja2dyb3VuZCBtaXNzaW5nIG9uIHRvcCBs aW5rcyBvbiBhcHBsZS5jb20KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JTdHlsZVNoZWV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JTdHlsZVNoZWV0LmNwcAppbmRleCA2ZDk3MjMzZDFkYzk5ZDQxNzNkZmZmNTU3NzAzZmNmNzQ2 ZjIwYmYzLi5jYmYwYmFiM2E1NGJlOTZlM2JmMDY5ZmYzNTM3NDhkZDNmOWNiMmQwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCkBAIC0z NTYsNyArMzU2LDcgQEAgYm9vbCBJbnNwZWN0b3JTdHlsZTo6cG9wdWxhdGVBbGxQcm9wZXJ0aWVz KFZlY3RvcjxJbnNwZWN0b3JTdHlsZVByb3BlcnR5PiogcmVzdWwKICAgICBWZWN0b3I8Q1NTUHJv cGVydHlTb3VyY2VEYXRhPiogc291cmNlUHJvcGVydHlEYXRhID0gc291cmNlRGF0YSA/ICYoc291 cmNlRGF0YS0+c3R5bGVTb3VyY2VEYXRhLT5wcm9wZXJ0eURhdGEpIDogbnVsbHB0cjsKICAgICBp ZiAoc291cmNlUHJvcGVydHlEYXRhKSB7CiAgICAgICAgIFN0cmluZyBzdHlsZURlY2xhcmF0aW9u OwotICAgICAgICBib29sIGlzU3R5bGVUZXh0S25vd24gPSBzdHlsZVRleHQoJnN0eWxlRGVjbGFy YXRpb24pOworICAgICAgICBib29sIGlzU3R5bGVUZXh0S25vd24gPSBnZXRUZXh0KCZzdHlsZURl Y2xhcmF0aW9uKTsKICAgICAgICAgQVNTRVJUX1VOVVNFRChpc1N0eWxlVGV4dEtub3duLCBpc1N0 eWxlVGV4dEtub3duKTsKICAgICAgICAgZm9yIChWZWN0b3I8Q1NTUHJvcGVydHlTb3VyY2VEYXRh Pjo6Y29uc3RfaXRlcmF0b3IgaXQgPSBzb3VyY2VQcm9wZXJ0eURhdGEtPmJlZ2luKCk7IGl0ICE9 IHNvdXJjZVByb3BlcnR5RGF0YS0+ZW5kKCk7ICsraXQpIHsKICAgICAgICAgICAgIEluc3BlY3Rv clN0eWxlUHJvcGVydHkgcCgqaXQsIHRydWUsIGZhbHNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5oCmluZGV4IDlhODIxODdiODJjYzAxNjIyNzMw NGFlYWFjODAxYTcwYmEyN2Y0MzUuLmU3NzYxN2RmMGRmYzRkZDU3MGM1MjRkMTFiNjRmOWJmYzlm MjM3ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHls ZVNoZWV0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hl ZXQuaApAQCAtMTQwLDEwICsxNDAsNiBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIEluc3BlY3Rv clN0eWxlKGNvbnN0IEluc3BlY3RvckNTU0lkJiBzdHlsZUlkLCBSZWZQdHI8Q1NTU3R5bGVEZWNs YXJhdGlvbj4mJiwgSW5zcGVjdG9yU3R5bGVTaGVldCogcGFyZW50U3R5bGVTaGVldCk7CiAKLSAg ICAvLyBGSVhNRTogUmVtb3ZlIHRoZXNlIGFsaWFzZXMgYW5kIHVwZGF0ZSBhbGwgdGhlIGN1cnJl bnQgY2FsbCBzaXRlcyB0byB1c2UgdGhlIG5ldyBwdWJsaWMgbWV0aG9kcy4KLSAgICBib29sIHN0 eWxlVGV4dChTdHJpbmcqIHJlc3VsdCkgY29uc3QgeyByZXR1cm4gZ2V0VGV4dChyZXN1bHQpOyB9 Ci0gICAgYm9vbCBhcHBseVN0eWxlVGV4dChjb25zdCBTdHJpbmcmIHRleHQpIHsgRXhjZXB0aW9u Q29kZSBlYyA9IDA7IHJldHVybiBzZXRUZXh0KHRleHQsIGVjKTsgfQotCiAgICAgYm9vbCBwb3B1 bGF0ZUFsbFByb3BlcnRpZXMoVmVjdG9yPEluc3BlY3RvclN0eWxlUHJvcGVydHk+KiByZXN1bHQp IGNvbnN0OwogICAgIFJlZjxJbnNwZWN0b3I6OlByb3RvY29sOjpDU1M6OkNTU1N0eWxlPiBzdHls ZVdpdGhQcm9wZXJ0aWVzKCkgY29uc3Q7CiAgICAgUmVmUHRyPENTU1J1bGVTb3VyY2VEYXRhPiBl eHRyYWN0U291cmNlRGF0YSgpIGNvbnN0Owo=