145084 2015-05-15 17:28:12 -0700 Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode 2015-05-15 20:01:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1095318 0 mattbaker 2015-05-15 17:28:12 -0700 * SUMMARY Timeline data grid displays wrong records after switching between Timelines/Frames mode. The selected region of the graph is correct after switching between the two view modes. It looks like the data grid is using the selection from the wrong timeline ruler. * STEPS TO REPRODUCE 1. Open Inspector, record some timeline data 2. Make a selection in the Timelines overview graph 3. Switch to the Rendering Frames view 4. Make a selection in the Rendering Frames overview graph 5. Switch back to the Timelines view => The graph selection is restored correctly, but the grid shows the wrong records (or no records). 1095319 1 webkit-bug-importer 2015-05-15 17:28:25 -0700 <rdar://problem/20985091> 1095341 2 253251 mattbaker 2015-05-15 18:19:32 -0700 Created attachment 253251 [Patch] Proposed Fix 1095365 3 253251 joepeck 2015-05-15 19:48:29 -0700 Comment on attachment 253251 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253251&action=review r=me, nice! > Source/WebInspectorUI/ChangeLog:14 > + (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if): > + (WebInspector.TimelineSidebarPanel.get else): > + (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if): > + (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject): Yikes, clean these signatures up a bit before landing if you can. I clearly made some mistake in prepare-ChangeLog's class parsing logic. 1095371 4 253251 commit-queue 2015-05-15 20:01:35 -0700 Comment on attachment 253251 [Patch] Proposed Fix Clearing flags on attachment: 253251 Committed r184427: <http://trac.webkit.org/changeset/184427> 1095372 5 commit-queue 2015-05-15 20:01:48 -0700 All reviewed patches have been landed. Closing bug. 253251 2015-05-15 18:19:32 -0700 2015-05-15 20:01:35 -0700 [Patch] Proposed Fix bug-145084-20150515181807.patch text/plain 3350 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx OWM5OWE2ODg4ZDE5ZmJlZjQ5ZmFlNWVhYTE3NzQ1ZDQ1ZDhhZDdmLi45MmYxOTQ1NjU4YmY3ZDcx YTBiMDhhYzY1NGFlMzgyZTNiMGVlM2I1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNS0wNS0xNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmUgZGF0YSBncmlkIGRpc3BsYXlzIHdy b25nIHJlY29yZHMgYWZ0ZXIgc3dpdGNoaW5nIGJldHdlZW4gVGltZWxpbmVzL0ZyYW1lcyBtb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUwODQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUg dGltZWxpbmUgc2lkZWJhciBmaWx0ZXIgd2hlbmV2ZXIgdGhlIHZpZXcgbW9kZSBjaGFuZ2VzLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5wcm90b3R5cGUudHJl ZUVsZW1lbnRGb3JSZXByZXNlbnRlZE9iamVjdC5nZXQgaWYuZ2V0IGlmKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5nZXQgZWxzZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwucHJvdG90eXBlLnRyZWVFbGVtZW50Rm9yUmVw cmVzZW50ZWRPYmplY3QuZ2V0IGlmKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVNp ZGViYXJQYW5lbC5wcm90b3R5cGUudHJlZUVsZW1lbnRGb3JSZXByZXNlbnRlZE9iamVjdCk6CisK IDIwMTUtMDUtMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgdHlwZSBhbm5vdGF0aW9uIHVwZGF0ZSBmcmVxdWVu Y3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggMjhmN2EwMWFhMzdlMzlk ZjdkY2RlYTE2ZGVmMmM0Mzc4ZmEwMmUwNy4uMWRjNjNiMDM1NGQyYmZhMmM5YmI1YzE5MTA2M2U3 Njk5YmJiNmYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAgLTc0MCwy MCArNzQwLDIxIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbCA9IGNsYXNzIFRp bWVsaW5lU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjCiAgICAgICAgICAgICB0aGlzLl9m cmFtZVNlbGVjdGlvbkNoYXJ0U2VjdGlvbi5jb2xsYXBzZWQgPSBmYWxzZTsKICAgICAgICAgfQog Ci0gICAgICAgIGlmICghc2VsZWN0ZWRCeVVzZXIpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAg ICAgICAgaWYgKHRoaXMuX3ZpZXdNb2RlID09PSBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFy UGFuZWwuVmlld01vZGUuUmVuZGVyaW5nRnJhbWVzKSB7Ci0gICAgICAgICAgICBpZiAodGhpcy5f dGltZWxpbmVzVHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCkKLSAgICAgICAgICAgICAg ICB0aGlzLl9wcmV2aW91c1RpbWVsaW5lU2VsZWN0aW9uID0gdGhpcy5fdGltZWxpbmVzVHJlZU91 dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdDsKKyAgICAgICAgaWYg KHNlbGVjdGVkQnlVc2VyKSB7CisgICAgICAgICAgICBpZiAodGhpcy5fdmlld01vZGUgPT09IFdl Ykluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5WaWV3TW9kZS5SZW5kZXJpbmdGcmFtZXMp IHsKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5fdGltZWxpbmVzVHJlZU91dGxpbmUuc2VsZWN0 ZWRUcmVlRWxlbWVudCkKKyAgICAgICAgICAgICAgICAgICAgdGhpcy5fcHJldmlvdXNUaW1lbGlu ZVNlbGVjdGlvbiA9IHRoaXMuX3RpbWVsaW5lc1RyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1l bnQucmVwcmVzZW50ZWRPYmplY3Q7CisKKyAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2VydCh0 aGlzLl9kaXNwbGF5ZWRSZWNvcmRpbmcpOworICAgICAgICAgICAgICAgIHRoaXMuc2hvd1RpbWVs aW5lVmlld0ZvclRpbWVsaW5lKHRoaXMuX2Rpc3BsYXllZFJlY29yZGluZy50aW1lbGluZXMuZ2V0 KFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZC5UeXBlLlJlbmRlcmluZ0ZyYW1lKSk7CisgICAg ICAgICAgICB9IGVsc2UgaWYgKHRoaXMuX3ByZXZpb3VzVGltZWxpbmVTZWxlY3Rpb24pIHsKKyAg ICAgICAgICAgICAgICB0aGlzLnNob3dUaW1lbGluZVZpZXdGb3JUaW1lbGluZSh0aGlzLl9wcmV2 aW91c1RpbWVsaW5lU2VsZWN0aW9uKTsKKyAgICAgICAgICAgICAgICB0aGlzLl9wcmV2aW91c1Rp bWVsaW5lU2VsZWN0aW9uID0gbnVsbDsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAg ICAgIHRoaXMuc2hvd1RpbWVsaW5lT3ZlcnZpZXcoKTsKKyAgICAgICAgfQogCi0gICAgICAgICAg ICBjb25zb2xlLmFzc2VydCh0aGlzLl9kaXNwbGF5ZWRSZWNvcmRpbmcpOwotICAgICAgICAgICAg dGhpcy5zaG93VGltZWxpbmVWaWV3Rm9yVGltZWxpbmUodGhpcy5fZGlzcGxheWVkUmVjb3JkaW5n LnRpbWVsaW5lcy5nZXQoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkLlR5cGUuUmVuZGVyaW5n RnJhbWUpKTsKLSAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9wcmV2aW91c1RpbWVsaW5lU2VsZWN0 aW9uKSB7Ci0gICAgICAgICAgICB0aGlzLnNob3dUaW1lbGluZVZpZXdGb3JUaW1lbGluZSh0aGlz Ll9wcmV2aW91c1RpbWVsaW5lU2VsZWN0aW9uKTsKLSAgICAgICAgICAgIHRoaXMuX3ByZXZpb3Vz VGltZWxpbmVTZWxlY3Rpb24gPSBudWxsOwotICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIHRo aXMuc2hvd1RpbWVsaW5lT3ZlcnZpZXcoKTsKKyAgICAgICAgdGhpcy51cGRhdGVGaWx0ZXIoKTsK ICAgICB9CiAKICAgICBfcmVmcmVzaEZyYW1lU2VsZWN0aW9uQ2hhcnQoKQo=