145081 2015-05-15 17:02:24 -0700 Don't reset the preview recognizer in [WKContentViewInteraction cleanupInteraction]. 2015-05-15 19:25:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned commit-queue mitz oldest_to_newest 1095303 0 yongjun_zhang 2015-05-15 17:02:24 -0700 See title, this recognizer will always reset when WKContentView is removed from its window. We don't need to reset here. 1095305 1 yongjun_zhang 2015-05-15 17:07:40 -0700 <rdar://problem/20736788> 1095312 2 253244 yongjun_zhang 2015-05-15 17:21:58 -0700 Created attachment 253244 Patch. 1095342 3 mitz 2015-05-15 18:21:18 -0700 No change log? 1095343 4 253252 yongjun_zhang 2015-05-15 18:23:35 -0700 Created attachment 253252 Add ChangeLog 1095355 5 253252 commit-queue 2015-05-15 19:25:49 -0700 Comment on attachment 253252 Add ChangeLog Clearing flags on attachment: 253252 Committed r184425: <http://trac.webkit.org/changeset/184425> 1095356 6 commit-queue 2015-05-15 19:25:53 -0700 All reviewed patches have been landed. Closing bug. 253244 2015-05-15 17:21:58 -0700 2015-05-15 18:23:35 -0700 Patch. webkit_dont_cleanup.patch text/plain 1030 yongjun_zhang Y29tbWl0IDVlZWYyOGEyNjBhMjljZjNlYjcwN2E2Njc4ZTRlOWNhODFiY2NjZTQKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBGcmkgTWF5IDE1 IDE3OjE1OjU5IDIwMTUgLTA3MDAKCiAgICBEb250JyByZXNldCB0aGUgcHJldmlldyByZWNvZ25p emVyIGluIFtXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24gY2xlYW51cEludGVyYWN0aW9uXQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0KaW5kZXggZjhiMTI5MC4uNjZlNzliMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAg LTM3NSw5ICszNzUsNiBAQCBzdGF0aWMgVUlXZWJTZWxlY3Rpb25Nb2RlIHRvVUlXZWJTZWxlY3Rp b25Nb2RlKFdLU2VsZWN0aW9uR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdAogICAgIFtfdHdvRmluZ2Vy RG91YmxlVGFwR2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsKICAgICBbc2VsZiBy ZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfdHdvRmluZ2VyRG91YmxlVGFwR2VzdHVyZVJlY29nbml6 ZXIuZ2V0KCldOwogCi0gICAgW19wcmV2aWV3R2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6 bmlsXTsKLSAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfcHJldmlld0dlc3R1cmVS ZWNvZ25pemVyLmdldCgpXTsKLQogICAgIF9pbnNwZWN0b3JOb2RlU2VhcmNoRW5hYmxlZCA9IE5P OwogICAgIGlmIChfaW5zcGVjdG9yTm9kZVNlYXJjaEdlc3R1cmVSZWNvZ25pemVyKSB7CiAgICAg ICAgIFtfaW5zcGVjdG9yTm9kZVNlYXJjaEdlc3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRlOm5p bF07Cg== 253252 2015-05-15 18:23:35 -0700 2015-05-15 19:25:49 -0700 Add ChangeLog webkit_dont_cleanup.patch text/plain 2002 yongjun_zhang Y29tbWl0IDllNWJlYmU0ZDJlZmY5MjI4Yzk2M2Q1Mzk4ZmU5NDNiYTNjZWY0NzYKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBGcmkgTWF5IDE1 IDE3OjE1OjU5IDIwMTUgLTA3MDAKCiAgICBEb250JyByZXNldCB0aGUgcHJldmlldyByZWNvZ25p emVyIGluIFtXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24gY2xlYW51cEludGVyYWN0aW9uXQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwppbmRleCA1MTFmMDBlLi4yYTc3M2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTUtMDUtMTUgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBEb24ndCByZXNldCB0aGUgcHJldmlldyByZWNvZ25pemVyIGluIFtXS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24gY2xlYW51cEludGVyYWN0aW9uXQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDgxCisKKyAgICAgICAgV2Ugc2hvdWxkbid0 IHJlc2V0IHRoZSByZWNvZ25pemVyIGluIFtXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24gY2xlYW51 cEludGVyYWN0aW9uXSBzaW5jZSB3ZSBkb24ndCByZS1hZGQgaXQKKyAgICAgICAgYmFjayB0byBX S0NvbnRlbnRWaWV3IHdoZW4gdGhlIHByb2Nlc3MgcmVsYXVuY2hlZC4gU2luY2Ugd2UgYWxyZWFk eSBhZGQvcmVtb3ZlIGl0IHdoZW4gdGhlIHZpZXcgaXMgbW92ZSBpbnRvLworICAgICAgICByZW1v dmVkIGZyb20gdGhlIHdpbmRvdywgd2UgZG9uJ3QgbmVlZCByZXNldCBpdCBpbiBjbGVhbnVwSW50 ZXJhY3Rpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAg KC1bV0tDb250ZW50VmlldyBjbGVhbnVwSW50ZXJhY3Rpb25dKToKKwogMjAxNS0wNS0xNSAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDb250 ZW50IEV4dGVuc2lvbnNdIEZhaWwgdG8gbG9hZCBvbGQgY29udGVudCBleHRlbnNpb24gZmlsZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggZjhiMTI5MC4uNjZlNzliMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K QEAgLTM3NSw5ICszNzUsNiBAQCBzdGF0aWMgVUlXZWJTZWxlY3Rpb25Nb2RlIHRvVUlXZWJTZWxl Y3Rpb25Nb2RlKFdLU2VsZWN0aW9uR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdAogICAgIFtfdHdvRmlu Z2VyRG91YmxlVGFwR2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdhdGU6bmlsXTsKICAgICBbc2Vs ZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfdHdvRmluZ2VyRG91YmxlVGFwR2VzdHVyZVJlY29n bml6ZXIuZ2V0KCldOwogCi0gICAgW19wcmV2aWV3R2VzdHVyZVJlY29nbml6ZXIgc2V0RGVsZWdh dGU6bmlsXTsKLSAgICBbc2VsZiByZW1vdmVHZXN0dXJlUmVjb2duaXplcjpfcHJldmlld0dlc3R1 cmVSZWNvZ25pemVyLmdldCgpXTsKLQogICAgIF9pbnNwZWN0b3JOb2RlU2VhcmNoRW5hYmxlZCA9 IE5POwogICAgIGlmIChfaW5zcGVjdG9yTm9kZVNlYXJjaEdlc3R1cmVSZWNvZ25pemVyKSB7CiAg ICAgICAgIFtfaW5zcGVjdG9yTm9kZVNlYXJjaEdlc3R1cmVSZWNvZ25pemVyIHNldERlbGVnYXRl Om5pbF07Cg==