145076 2015-05-15 15:36:10 -0700 REGRESSION (r181910): WKWebView incorrectly scales snapshot 2015-05-15 17:23:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 143023 1 james.savage webkit-unassigned adele commit-queue oldest_to_newest 1095273 0 james.savage 2015-05-15 15:36:10 -0700 We are always assuming that the ratio between snapshot rect size and snapshot size will be device scale, which is not always correct. 1095275 1 253231 james.savage 2015-05-15 15:43:59 -0700 Created attachment 253231 Correct the scale and transform used for IOSurface snapshots. 1095277 2 james.savage 2015-05-15 15:45:24 -0700 rdar://19816542 1095278 3 253232 james.savage 2015-05-15 15:56:55 -0700 Created attachment 253232 Updated change log 1095280 4 253232 thorton 2015-05-15 15:59:40 -0700 Comment on attachment 253232 Updated change log View in context: https://bugs.webkit.org/attachment.cgi?id=253232&action=review > Source/WebKit2/ChangeLog:3 > + Web view snapshots incorrectly scale transform Title should probably start with "REGRESSION (r181910):", and maybe WKWebView instead of "Web view" and "snapshot" instead of "transform"? 1095284 5 253233 james.savage 2015-05-15 16:08:18 -0700 Created attachment 253233 Updated for review feedback. 1095297 6 james.savage 2015-05-15 16:24:58 -0700 Whoops, this is actually rdar://problem/20410944. 1095300 7 253233 commit-queue 2015-05-15 16:28:42 -0700 Comment on attachment 253233 Updated for review feedback. Rejecting attachment 253233 from commit-queue. james.savage@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1095313 8 253233 commit-queue 2015-05-15 17:23:16 -0700 Comment on attachment 253233 Updated for review feedback. Clearing flags on attachment: 253233 Committed r184422: <http://trac.webkit.org/changeset/184422> 253231 2015-05-15 15:43:59 -0700 2015-05-15 15:56:55 -0700 Correct the scale and transform used for IOSurface snapshots. 0001-Web-view-snapshots-incorrectly-scale-transform.patch text/plain 3557 james.savage RnJvbSAwMTcyOTUzOTIzNDY1NTZjNDAwZDA1ZmFiMDc4ZmY3NDEyNmE3NGNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW1lcyBTYXZhZ2UgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+ CkRhdGU6IEZyaSwgMTUgTWF5IDIwMTUgMTU6NDA6MDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBX ZWIgdmlldyBzbmFwc2hvdHMgaW5jb3JyZWN0bHkgc2NhbGUgdHJhbnNmb3JtCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDc2CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CigtW1dLV2ViVmll dyBfc25hcHNob3RSZWN0OmludG9JbWFnZU9mV2lkdGg6Y29tcGxldGlvbkhhbmRsZXI6XSk6Cldo ZW4gc25hcHNob3R0aW5nIGFuIElPU3VyZmFjZSB3ZSBuZWVkIHRvIGNvbXB1dGUgb3VyIHNjYWxl IGJhc2VkIG9mZiBvZgp0aGUgcmVjdCBpbiB0aGUgV0tXZWJWaWV3IGNvb3JkaW5hdGVzLCB3ZSBh bHNvIGZhaWxlZCB0byBhY2NvdW50IGZvcgpub24temVybyBvcmlnaW5zIGluIHRoZSBzbmFwc2hv dCByZWN0LiBSZW1vdmUgYW4gdW51c2VkIHZhcmlibGUgd2hpbGUKd2UncmUgaGVyZS4KLS0tCiBT b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysr KysrKysrKysrCiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bSB8IDEyICsrKy0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA0NzU3NGRmLi5hNjY0N2M3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTUtMDUtMTUgIEphbWVzIFNhdmFnZSAgPGphbWVzLnNhdmFn ZUBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIHZpZXcgc25hcHNob3RzIGluY29ycmVjdGx5IHNj YWxlIHRyYW5zZm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ1MDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IF9zbmFwc2hvdFJlY3Q6aW50b0ltYWdlT2ZXaWR0aDpjb21wbGV0aW9uSGFuZGxlcjpd KToKKyAgICAgICAgV2hlbiBzbmFwc2hvdHRpbmcgYW4gSU9TdXJmYWNlIHdlIG5lZWQgdG8gY29t cHV0ZSBvdXIgc2NhbGUgYmFzZWQgb2ZmIG9mCisgICAgICAgIHRoZSByZWN0IGluIHRoZSBXS1dl YlZpZXcgY29vcmRpbmF0ZXMsIHdlIGFsc28gZmFpbGVkIHRvIGFjY291bnQgZm9yCisgICAgICAg IG5vbi16ZXJvIG9yaWdpbnMgaW4gdGhlIHNuYXBzaG90IHJlY3QuIFJlbW92ZSBhbiB1bnVzZWQg dmFyaWJsZSB3aGlsZQorICAgICAgICB3ZSdyZSBoZXJlLgorCiAyMDE1LTA1LTA1ICBNeWxlcyBD LiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2ZXJ0ICJJbnRy b2R1Y2luZyB0aGUgUGxhdGZvcm0gQWJzdHJhY3Rpb24gTGF5ZXIgKFBBTCkiCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGM4YjA0MGIu LmY3N2ZkMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tCkBAIC0yNzA3LDE2ICsyNzA3LDEwIEBAIHN0YXRpYyBpbmxpbmUgV2ViS2l0OjpG aW5kT3B0aW9ucyB0b0ZpbmRPcHRpb25zKF9XS0ZpbmRPcHRpb25zIHdrRmluZE9wdGlvbnMpCiAj aWYgVVNFKElPU1VSRkFDRSkKICAgICAvLyBJZiB3ZSBhcmUgcGFyZW50ZWQgYW5kIHRodXMgd29u J3QgaW5jdXIgYSBzaWduaWZpY2FudCBwZW5hbHR5IGZyb20gcGFnaW5nIGluIHRpbGVzLCBzbmFw c2hvdCB0aGUgdmlldyBoaWVyYXJjaHkgZGlyZWN0bHkuCiAgICAgaWYgKHNlbGYud2luZG93KSB7 Ci0gICAgICAgIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yID0gX3BhZ2UtPmRldmljZVNjYWxlRmFj dG9yKCk7Ci0KLSAgICAgICAgQ0dSZWN0IGltYWdlUmVjdEluUG9pbnRzOwotICAgICAgICBpbWFn ZVJlY3RJblBvaW50cy5zaXplLndpZHRoID0gaW1hZ2VXaWR0aCAvIGRldmljZVNjYWxlRmFjdG9y OwotICAgICAgICBpbWFnZVJlY3RJblBvaW50cy5zaXplLmhlaWdodCA9IGltYWdlUmVjdEluUG9p bnRzLnNpemUud2lkdGggLyByZWN0SW5WaWV3Q29vcmRpbmF0ZXMuc2l6ZS53aWR0aCAqIHJlY3RJ blZpZXdDb29yZGluYXRlcy5zaXplLmhlaWdodDsKLSAgICAgICAgaW1hZ2VSZWN0SW5Qb2ludHMu b3JpZ2luLnggPSByZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2luLnggLyBkZXZpY2VTY2FsZUZh Y3RvcjsKLSAgICAgICAgaW1hZ2VSZWN0SW5Qb2ludHMub3JpZ2luLnkgPSByZWN0SW5WaWV3Q29v cmRpbmF0ZXMub3JpZ2luLnkgLyBkZXZpY2VTY2FsZUZhY3RvcjsKLQogICAgICAgICBhdXRvIHN1 cmZhY2UgPSBXZWJDb3JlOjpJT1N1cmZhY2U6OmNyZWF0ZShXZWJDb3JlOjpleHBhbmRlZEludFNp emUoV2ViQ29yZTo6RmxvYXRTaXplKGltYWdlU2l6ZSkpLCBXZWJDb3JlOjpDb2xvclNwYWNlRGV2 aWNlUkdCKTsKLSAgICAgICAgQ0FUcmFuc2Zvcm0zRCB0cmFuc2Zvcm0gPSBDQVRyYW5zZm9ybTNE TWFrZVNjYWxlKGRldmljZVNjYWxlRmFjdG9yLCBkZXZpY2VTY2FsZUZhY3RvciwgMSk7CisgICAg ICAgIENHRmxvYXQgaW1hZ2VTY2FsZUluVmlld0Nvb3JkaW5hdGVzID0gaW1hZ2VXaWR0aCAvIHJl Y3RJblZpZXdDb29yZGluYXRlcy5zaXplLndpZHRoOworICAgICAgICBDQVRyYW5zZm9ybTNEIHRy YW5zZm9ybSA9IENBVHJhbnNmb3JtM0RNYWtlU2NhbGUoaW1hZ2VTY2FsZUluVmlld0Nvb3JkaW5h dGVzLCBpbWFnZVNjYWxlSW5WaWV3Q29vcmRpbmF0ZXMsIDEpOworICAgICAgICB0cmFuc2Zvcm0g PSBDQVRyYW5zZm9ybTNEVHJhbnNsYXRlKHRyYW5zZm9ybSwgLXJlY3RJblZpZXdDb29yZGluYXRl cy5vcmlnaW4ueCwgLXJlY3RJblZpZXdDb29yZGluYXRlcy5vcmlnaW4ueSwgMCk7CiAgICAgICAg IENBUmVuZGVyU2VydmVyUmVuZGVyTGF5ZXJXaXRoVHJhbnNmb3JtKE1BQ0hfUE9SVF9OVUxMLCBz ZWxmLmxheWVyLmNvbnRleHQuY29udGV4dElkLCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90Pihz ZWxmLmxheWVyKSwgc3VyZmFjZS0+c3VyZmFjZSgpLCAwLCAwLCAmdHJhbnNmb3JtKTsKICAgICAg ICAgY29tcGxldGlvbkhhbmRsZXIoc3VyZmFjZS0+Y3JlYXRlSW1hZ2UoKS5nZXQoKSk7CiAKLS0g CjIuMy40IChBcHBsZSBHaXQtNTYpCgo= 253232 2015-05-15 15:56:55 -0700 2015-05-15 15:59:40 -0700 Updated change log 0001-Web-view-snapshots-incorrectly-scale-transform.patch text/plain 3987 james.savage RnJvbSA4ZjRkNDFhZTUxNTZmMzQ5YzQ4YTAzOGI0MjY5NTZhZWQ2ZTdiZmM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW1lcyBTYXZhZ2UgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+ CkRhdGU6IEZyaSwgMTUgTWF5IDIwMTUgMTU6NDA6MDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBX ZWIgdmlldyBzbmFwc2hvdHMgaW5jb3JyZWN0bHkgc2NhbGUgdHJhbnNmb3JtCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDc2CgpSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCldlIGFkZGVkIGEgZmFzdCBwYXRoIHRvIHNuYXBzaG90dGluZyB1c2luZyBJT1N1 cmZhY2VzIHdpdGgKaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTgxOTEwIHdoaWNo IGluY29ycmVjdGx5IGRldGVybWluZWQKc2NhbGUgYW5kIHRyYW5zZm9ybSBhbmQgcmVzdWx0ZWQg aW4gYmFkIHNuYXBzaG90cyBpbiBzb21lIHNpdHVhdGlvbnMuCgoqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tOgooLVtXS1dlYlZpZXcgX3NuYXBzaG90UmVjdDppbnRvSW1hZ2VPZldp ZHRoOmNvbXBsZXRpb25IYW5kbGVyOl0pOgpXaGVuIHNuYXBzaG90dGluZyBhbiBJT1N1cmZhY2Ug d2UgbmVlZCB0byBjb21wdXRlIG91ciBzY2FsZSBiYXNlZCBvZmYgb2YKdGhlIHJlY3QgaW4gdGhl IFdLV2ViVmlldyBjb29yZGluYXRlcywgd2UgYWxzbyBmYWlsZWQgdG8gYWNjb3VudCBmb3IKbm9u LXplcm8gb3JpZ2lucyBpbiB0aGUgc25hcHNob3QgcmVjdC4gUmVtb3ZlIGFuIHVudXNlZCB2YXJp YmxlIHdoaWxlCndlJ3JlIGhlcmUuCi0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgfCAxOCArKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIHwgMTIgKysrLS0tLS0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDQ3NTc0ZGYuLjcyNTg3NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxNS0w NS0xNSAgSmFtZXMgU2F2YWdlICA8amFtZXMuc2F2YWdlQGFwcGxlLmNvbT4KKworICAgICAgICBX ZWIgdmlldyBzbmFwc2hvdHMgaW5jb3JyZWN0bHkgc2NhbGUgdHJhbnNmb3JtCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUwNzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhZGRlZCBhIGZhc3QgcGF0 aCB0byBzbmFwc2hvdHRpbmcgdXNpbmcgSU9TdXJmYWNlcyB3aXRoCisgICAgICAgIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE4MTkxMCB3aGljaCBpbmNvcnJlY3RseSBkZXRlcm1p bmVkCisgICAgICAgIHNjYWxlIGFuZCB0cmFuc2Zvcm0gYW5kIHJlc3VsdGVkIGluIGJhZCBzbmFw c2hvdHMgaW4gc29tZSBzaXR1YXRpb25zLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBfc25hcHNob3RSZWN0OmludG9J bWFnZU9mV2lkdGg6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisgICAgICAgIFdoZW4gc25hcHNob3R0 aW5nIGFuIElPU3VyZmFjZSB3ZSBuZWVkIHRvIGNvbXB1dGUgb3VyIHNjYWxlIGJhc2VkIG9mZiBv ZgorICAgICAgICB0aGUgcmVjdCBpbiB0aGUgV0tXZWJWaWV3IGNvb3JkaW5hdGVzLCB3ZSBhbHNv IGZhaWxlZCB0byBhY2NvdW50IGZvcgorICAgICAgICBub24temVybyBvcmlnaW5zIGluIHRoZSBz bmFwc2hvdCByZWN0LiBSZW1vdmUgYW4gdW51c2VkIHZhcmlibGUgd2hpbGUKKyAgICAgICAgd2Un cmUgaGVyZS4KKwogMjAxNS0wNS0wNSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmVydCAiSW50cm9kdWNpbmcgdGhlIFBsYXRmb3JtIEFic3Ry YWN0aW9uIExheWVyIChQQUwpIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbQppbmRleCBjOGIwNDBiLi5mNzdmZDI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtMjcwNywxNiArMjcw NywxMCBAQCBzdGF0aWMgaW5saW5lIFdlYktpdDo6RmluZE9wdGlvbnMgdG9GaW5kT3B0aW9ucyhf V0tGaW5kT3B0aW9ucyB3a0ZpbmRPcHRpb25zKQogI2lmIFVTRShJT1NVUkZBQ0UpCiAgICAgLy8g SWYgd2UgYXJlIHBhcmVudGVkIGFuZCB0aHVzIHdvbid0IGluY3VyIGEgc2lnbmlmaWNhbnQgcGVu YWx0eSBmcm9tIHBhZ2luZyBpbiB0aWxlcywgc25hcHNob3QgdGhlIHZpZXcgaGllcmFyY2h5IGRp cmVjdGx5LgogICAgIGlmIChzZWxmLndpbmRvdykgewotICAgICAgICBmbG9hdCBkZXZpY2VTY2Fs ZUZhY3RvciA9IF9wYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpOwotCi0gICAgICAgIENHUmVjdCBp bWFnZVJlY3RJblBvaW50czsKLSAgICAgICAgaW1hZ2VSZWN0SW5Qb2ludHMuc2l6ZS53aWR0aCA9 IGltYWdlV2lkdGggLyBkZXZpY2VTY2FsZUZhY3RvcjsKLSAgICAgICAgaW1hZ2VSZWN0SW5Qb2lu dHMuc2l6ZS5oZWlnaHQgPSBpbWFnZVJlY3RJblBvaW50cy5zaXplLndpZHRoIC8gcmVjdEluVmll d0Nvb3JkaW5hdGVzLnNpemUud2lkdGggKiByZWN0SW5WaWV3Q29vcmRpbmF0ZXMuc2l6ZS5oZWln aHQ7Ci0gICAgICAgIGltYWdlUmVjdEluUG9pbnRzLm9yaWdpbi54ID0gcmVjdEluVmlld0Nvb3Jk aW5hdGVzLm9yaWdpbi54IC8gZGV2aWNlU2NhbGVGYWN0b3I7Ci0gICAgICAgIGltYWdlUmVjdElu UG9pbnRzLm9yaWdpbi55ID0gcmVjdEluVmlld0Nvb3JkaW5hdGVzLm9yaWdpbi55IC8gZGV2aWNl U2NhbGVGYWN0b3I7Ci0KICAgICAgICAgYXV0byBzdXJmYWNlID0gV2ViQ29yZTo6SU9TdXJmYWNl OjpjcmVhdGUoV2ViQ29yZTo6ZXhwYW5kZWRJbnRTaXplKFdlYkNvcmU6OkZsb2F0U2l6ZShpbWFn ZVNpemUpKSwgV2ViQ29yZTo6Q29sb3JTcGFjZURldmljZVJHQik7Ci0gICAgICAgIENBVHJhbnNm b3JtM0QgdHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRE1ha2VTY2FsZShkZXZpY2VTY2FsZUZhY3Rv ciwgZGV2aWNlU2NhbGVGYWN0b3IsIDEpOworICAgICAgICBDR0Zsb2F0IGltYWdlU2NhbGVJblZp ZXdDb29yZGluYXRlcyA9IGltYWdlV2lkdGggLyByZWN0SW5WaWV3Q29vcmRpbmF0ZXMuc2l6ZS53 aWR0aDsKKyAgICAgICAgQ0FUcmFuc2Zvcm0zRCB0cmFuc2Zvcm0gPSBDQVRyYW5zZm9ybTNETWFr ZVNjYWxlKGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcywgaW1hZ2VTY2FsZUluVmlld0Nvb3Jk aW5hdGVzLCAxKTsKKyAgICAgICAgdHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRFRyYW5zbGF0ZSh0 cmFuc2Zvcm0sIC1yZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2luLngsIC1yZWN0SW5WaWV3Q29v cmRpbmF0ZXMub3JpZ2luLnksIDApOwogICAgICAgICBDQVJlbmRlclNlcnZlclJlbmRlckxheWVy V2l0aFRyYW5zZm9ybShNQUNIX1BPUlRfTlVMTCwgc2VsZi5sYXllci5jb250ZXh0LmNvbnRleHRJ ZCwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4oc2VsZi5sYXllciksIHN1cmZhY2UtPnN1cmZh Y2UoKSwgMCwgMCwgJnRyYW5zZm9ybSk7CiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKHN1cmZh Y2UtPmNyZWF0ZUltYWdlKCkuZ2V0KCkpOwogCi0tIAoyLjMuNCAoQXBwbGUgR2l0LTU2KQoK 253233 2015-05-15 16:08:18 -0700 2015-05-15 17:23:16 -0700 Updated for review feedback. 0001-REGRESSION-r181910-WKWebView-incorrectly-scales-snap.patch text/plain 4005 james.savage RnJvbSBkYTc5ODA1MTkyZjc0YjhjNmFjMjA0Y2YzMGNkN2EzY2EzMzEwOTZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYW1lcyBTYXZhZ2UgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+ CkRhdGU6IEZyaSwgMTUgTWF5IDIwMTUgMTU6NDA6MDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBS RUdSRVNTSU9OIChyMTgxOTEwKTogV0tXZWJWaWV3IGluY29ycmVjdGx5IHNjYWxlcyBzbmFwc2hv dAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTA3NgoKUmV2aWV3 ZWQgYnkgVGltIEhvcnRvbi4KCldlIGFkZGVkIGEgZmFzdCBwYXRoIHRvIHNuYXBzaG90dGluZyB1 c2luZyBJT1N1cmZhY2VzIHdpdGgKaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTgx OTEwIHdoaWNoIGluY29ycmVjdGx5IGRldGVybWluZWQKc2NhbGUgYW5kIHRyYW5zZm9ybSBhbmQg cmVzdWx0ZWQgaW4gYmFkIHNuYXBzaG90cyBpbiBzb21lIHNpdHVhdGlvbnMuCgoqIFVJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgooLVtXS1dlYlZpZXcgX3NuYXBzaG90UmVjdDppbnRv SW1hZ2VPZldpZHRoOmNvbXBsZXRpb25IYW5kbGVyOl0pOgpXaGVuIHNuYXBzaG90dGluZyBhbiBJ T1N1cmZhY2Ugd2UgbmVlZCB0byBjb21wdXRlIG91ciBzY2FsZSBiYXNlZCBvZmYgb2YKdGhlIHJl Y3QgaW4gdGhlIFdLV2ViVmlldyBjb29yZGluYXRlcywgd2UgYWxzbyBmYWlsZWQgdG8gYWNjb3Vu dCBmb3IKbm9uLXplcm8gb3JpZ2lucyBpbiB0aGUgc25hcHNob3QgcmVjdC4gUmVtb3ZlIGFuIHVu dXNlZCB2YXJpYmxlIHdoaWxlCndlJ3JlIGhlcmUuCi0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgfCAxOCArKysrKysrKysrKysrKysrKysKIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIHwgMTIgKysrLS0tLS0t LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCmluZGV4IDQ3NTc0ZGYuLjZjYjQ3MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBA QAorMjAxNS0wNS0xNSAgSmFtZXMgU2F2YWdlICA8amFtZXMuc2F2YWdlQGFwcGxlLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OIChyMTgxOTEwKTogV0tXZWJWaWV3IGluY29ycmVjdGx5IHNjYWxl cyBzbmFwc2hvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ1MDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBX ZSBhZGRlZCBhIGZhc3QgcGF0aCB0byBzbmFwc2hvdHRpbmcgdXNpbmcgSU9TdXJmYWNlcyB3aXRo CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE4MTkxMCB3aGljaCBp bmNvcnJlY3RseSBkZXRlcm1pbmVkCisgICAgICAgIHNjYWxlIGFuZCB0cmFuc2Zvcm0gYW5kIHJl c3VsdGVkIGluIGJhZCBzbmFwc2hvdHMgaW4gc29tZSBzaXR1YXRpb25zLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBf c25hcHNob3RSZWN0OmludG9JbWFnZU9mV2lkdGg6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisgICAg ICAgIFdoZW4gc25hcHNob3R0aW5nIGFuIElPU3VyZmFjZSB3ZSBuZWVkIHRvIGNvbXB1dGUgb3Vy IHNjYWxlIGJhc2VkIG9mZiBvZgorICAgICAgICB0aGUgcmVjdCBpbiB0aGUgV0tXZWJWaWV3IGNv b3JkaW5hdGVzLCB3ZSBhbHNvIGZhaWxlZCB0byBhY2NvdW50IGZvcgorICAgICAgICBub24temVy byBvcmlnaW5zIGluIHRoZSBzbmFwc2hvdCByZWN0LiBSZW1vdmUgYW4gdW51c2VkIHZhcmlibGUg d2hpbGUKKyAgICAgICAgd2UncmUgaGVyZS4KKwogMjAxNS0wNS0wNSAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydCAiSW50cm9kdWNpbmcg dGhlIFBsYXRmb3JtIEFic3RyYWN0aW9uIExheWVyIChQQUwpIgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCBjOGIwNDBiLi5mNzdmZDI2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bQpAQCAtMjcwNywxNiArMjcwNywxMCBAQCBzdGF0aWMgaW5saW5lIFdlYktpdDo6RmluZE9wdGlv bnMgdG9GaW5kT3B0aW9ucyhfV0tGaW5kT3B0aW9ucyB3a0ZpbmRPcHRpb25zKQogI2lmIFVTRShJ T1NVUkZBQ0UpCiAgICAgLy8gSWYgd2UgYXJlIHBhcmVudGVkIGFuZCB0aHVzIHdvbid0IGluY3Vy IGEgc2lnbmlmaWNhbnQgcGVuYWx0eSBmcm9tIHBhZ2luZyBpbiB0aWxlcywgc25hcHNob3QgdGhl IHZpZXcgaGllcmFyY2h5IGRpcmVjdGx5LgogICAgIGlmIChzZWxmLndpbmRvdykgewotICAgICAg ICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9IF9wYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpOwot Ci0gICAgICAgIENHUmVjdCBpbWFnZVJlY3RJblBvaW50czsKLSAgICAgICAgaW1hZ2VSZWN0SW5Q b2ludHMuc2l6ZS53aWR0aCA9IGltYWdlV2lkdGggLyBkZXZpY2VTY2FsZUZhY3RvcjsKLSAgICAg ICAgaW1hZ2VSZWN0SW5Qb2ludHMuc2l6ZS5oZWlnaHQgPSBpbWFnZVJlY3RJblBvaW50cy5zaXpl LndpZHRoIC8gcmVjdEluVmlld0Nvb3JkaW5hdGVzLnNpemUud2lkdGggKiByZWN0SW5WaWV3Q29v cmRpbmF0ZXMuc2l6ZS5oZWlnaHQ7Ci0gICAgICAgIGltYWdlUmVjdEluUG9pbnRzLm9yaWdpbi54 ID0gcmVjdEluVmlld0Nvb3JkaW5hdGVzLm9yaWdpbi54IC8gZGV2aWNlU2NhbGVGYWN0b3I7Ci0g ICAgICAgIGltYWdlUmVjdEluUG9pbnRzLm9yaWdpbi55ID0gcmVjdEluVmlld0Nvb3JkaW5hdGVz Lm9yaWdpbi55IC8gZGV2aWNlU2NhbGVGYWN0b3I7Ci0KICAgICAgICAgYXV0byBzdXJmYWNlID0g V2ViQ29yZTo6SU9TdXJmYWNlOjpjcmVhdGUoV2ViQ29yZTo6ZXhwYW5kZWRJbnRTaXplKFdlYkNv cmU6OkZsb2F0U2l6ZShpbWFnZVNpemUpKSwgV2ViQ29yZTo6Q29sb3JTcGFjZURldmljZVJHQik7 Ci0gICAgICAgIENBVHJhbnNmb3JtM0QgdHJhbnNmb3JtID0gQ0FUcmFuc2Zvcm0zRE1ha2VTY2Fs ZShkZXZpY2VTY2FsZUZhY3RvciwgZGV2aWNlU2NhbGVGYWN0b3IsIDEpOworICAgICAgICBDR0Zs b2F0IGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcyA9IGltYWdlV2lkdGggLyByZWN0SW5WaWV3 Q29vcmRpbmF0ZXMuc2l6ZS53aWR0aDsKKyAgICAgICAgQ0FUcmFuc2Zvcm0zRCB0cmFuc2Zvcm0g PSBDQVRyYW5zZm9ybTNETWFrZVNjYWxlKGltYWdlU2NhbGVJblZpZXdDb29yZGluYXRlcywgaW1h Z2VTY2FsZUluVmlld0Nvb3JkaW5hdGVzLCAxKTsKKyAgICAgICAgdHJhbnNmb3JtID0gQ0FUcmFu c2Zvcm0zRFRyYW5zbGF0ZSh0cmFuc2Zvcm0sIC1yZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2lu LngsIC1yZWN0SW5WaWV3Q29vcmRpbmF0ZXMub3JpZ2luLnksIDApOwogICAgICAgICBDQVJlbmRl clNlcnZlclJlbmRlckxheWVyV2l0aFRyYW5zZm9ybShNQUNIX1BPUlRfTlVMTCwgc2VsZi5sYXll ci5jb250ZXh0LmNvbnRleHRJZCwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4oc2VsZi5sYXll ciksIHN1cmZhY2UtPnN1cmZhY2UoKSwgMCwgMCwgJnRyYW5zZm9ybSk7CiAgICAgICAgIGNvbXBs ZXRpb25IYW5kbGVyKHN1cmZhY2UtPmNyZWF0ZUltYWdlKCkuZ2V0KCkpOwogCi0tIAoyLjMuNCAo QXBwbGUgR2l0LTU2KQoK