145073 2015-05-15 14:10:31 -0700 Web Inspector: Show/Hide sidebar buttons have inconsistent highlighted state 2015-06-17 14:34:18 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1095243 0 joepeck 2015-05-15 14:10:31 -0700 * SUMMARY Show/Hide sidebar buttons have inconsistent highlighted state. * STEPS TO REPRODUCE 1. Inspect <http://webkit.org> 2. Open Elements and Resources tabs 3. Show the Details Sidebar in each 4. Select the Resources tab 5. Close the Inspector 6. Open Inspector => should be showing Resources Tab, with Details Sidebar, and Blue Highlighted Show/Hide sidebar button 7. Switch to Elements Tab => Details sidebar is showing, but Show/Hide sidebar button is not highlighted. Expected it to be. 1095244 1 webkit-bug-importer 2015-05-15 14:11:00 -0700 <rdar://problem/20980798> 1102609 2 255027 dpino 2015-06-17 11:56:23 -0700 Created attachment 255027 Patch 1102624 3 255027 joepeck 2015-06-17 13:05:39 -0700 Comment on attachment 255027 Patch Awesome! r=me 1102647 4 255027 commit-queue 2015-06-17 14:34:14 -0700 Comment on attachment 255027 Patch Clearing flags on attachment: 255027 Committed r185669: <http://trac.webkit.org/changeset/185669> 1102648 5 commit-queue 2015-06-17 14:34:18 -0700 All reviewed patches have been landed. Closing bug. 255027 2015-06-17 11:56:23 -0700 2015-06-17 14:34:14 -0700 Patch bug-145073-20150617195546.patch text/plain 1669 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTg1NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 NDNjN2VhNjI5MDk0YTY3NjNmNDhhZTgwYzFmM2NkMzg3MjM1Zjc3Li4wNTZkMTY4NzNkYTU4NjJm NjBlNWFkYjI1OTljZTA3N2M4ZmM4ZjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wNi0xNyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNob3cvSGlkZSBzaWRlYmFyIGJ1dHRvbnMg aGF2ZSBpbmNvbnNpc3RlbnQgaGlnaGxpZ2h0ZWQgc3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTA3MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50 QnJvd3NlclRhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnRlbnRC cm93c2VyVGFiQ29udGVudFZpZXcucHJvdG90eXBlLl9kZXRhaWxzU2lkZWJhclBhbmVsU2VsZWN0 ZWQpOgorCiAyMDE1LTA2LTA4ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhcmluZyBhY3RpdmUgVGltZWxpbmUgcmVjb3JkaW5n IHNob3VsZCBzdG9wIGNhcHR1cmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRCcm93c2VyVGFi Q29udGVudFZpZXcuanMKaW5kZXggMGNkMjVlZGZlOWYwOTY0YjUyYzJhNTVkMTZmNWUzZDMwZGQ4 NDgxNi4uMTdiNjg3NDk2YmY3ZTkwOGVhNjQ1ODE2ODVjYmE5YWY5MWNjMzZlMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dz ZXJUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3LmpzCkBAIC0yMjcsNiArMjI3 LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnRlbnRCcm93c2VyVGFiQ29udGVudFZpZXcucHJvdG90eXBl ID0gewogICAgICAgICBpZiAoIXRoaXMudmlzaWJsZSkKICAgICAgICAgICAgIHJldHVybjsKIAor ICAgICAgICB0aGlzLl9zaG93RGV0YWlsc1NpZGViYXJJdGVtLmFjdGl2YXRlZCA9ICFXZWJJbnNw ZWN0b3IuZGV0YWlsc1NpZGViYXIuY29sbGFwc2VkOwogICAgICAgICB0aGlzLl9zaG93RGV0YWls c1NpZGViYXJJdGVtLmVuYWJsZWQgPSBXZWJJbnNwZWN0b3IuZGV0YWlsc1NpZGViYXIuc2lkZWJh clBhbmVscy5sZW5ndGg7CiAKICAgICAgICAgaWYgKCFXZWJJbnNwZWN0b3IuZGV0YWlsc1NpZGVi YXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwgfHwgdGhpcy5faWdub3JlRGV0YWlsc1NpZGViYXJQYW5l bFNlbGVjdGVkRXZlbnQpCg==