145067 2015-05-15 12:30:56 -0700 Web Inspector: Initiator Popovers no longer work in Layout Timeline 2015-05-15 13:47:45 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1095197 0 joepeck 2015-05-15 12:30:56 -0700 * SUMMARY Initiator Popovers no longer work in Layout Timeline. The anchor finder is returning null: callFramePopoverAnchorElement: function() { return this.selectedNode.elementWithColumnIdentifier("initiatorCallFrame"); } Because "initiatorCallFrame" changed to "location". There was a console.assert that caught this. 1095199 1 253216 joepeck 2015-05-15 12:32:20 -0700 Created attachment 253216 [PATCH] Proposed Fix 1095225 2 253216 commit-queue 2015-05-15 13:47:41 -0700 Comment on attachment 253216 [PATCH] Proposed Fix Clearing flags on attachment: 253216 Committed r184410: <http://trac.webkit.org/changeset/184410> 1095226 3 commit-queue 2015-05-15 13:47:45 -0700 All reviewed patches have been landed. Closing bug. 253216 2015-05-15 12:32:20 -0700 2015-05-15 13:47:41 -0700 [PATCH] Proposed Fix timeline-popover.patch text/plain 1437 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAyODEzNTguLjcwYWY0YWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTA1LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW5pdGlh dG9yIFBvcG92ZXJzIG5vIGxvbmdlciB3b3JrIGluIExheW91dCBUaW1lbGluZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDY3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL0xheW91dFRpbWVsaW5lRGF0YUdyaWQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTGF5 b3V0VGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUuY2FsbEZyYW1lUG9wb3ZlckFuY2hvckVsZW1l bnQpOgorICAgICAgICBVcGRhdGUgdGhlIGNvbHVtbiBuYW1lLCB3aGljaCBjaGFuZ2VkIGluIHIx ODMxMzQuCisKKzIwMTUtMDUtMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgdHlwZSBhbm5vdGF0aW9uIHVwZGF0 ZSBmcmVxdWVuY3kKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NTA2NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZC5qcwppbmRleCA1 ZmIwOTQyLi42NDM4NTQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lRGF0YUdyaWQuanMK QEAgLTM1LDcgKzM1LDcgQEAgV2ViSW5zcGVjdG9yLkxheW91dFRpbWVsaW5lRGF0YUdyaWQucHJv dG90eXBlID0gewogCiAgICAgY2FsbEZyYW1lUG9wb3ZlckFuY2hvckVsZW1lbnQ6IGZ1bmN0aW9u KCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLnNlbGVjdGVkTm9kZS5lbGVtZW50V2l0aENv bHVtbklkZW50aWZpZXIoImluaXRpYXRvckNhbGxGcmFtZSIpOworICAgICAgICByZXR1cm4gdGhp cy5zZWxlY3RlZE5vZGUuZWxlbWVudFdpdGhDb2x1bW5JZGVudGlmaWVyKCJsb2NhdGlvbiIpOwog ICAgIH0KIH07CiAK