145066 2015-05-15 12:27:50 -0700 Web Inspector: Reduce type annotation update frequency 2016-09-07 21:44:00 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1095194 0 joepeck 2015-05-15 12:27:50 -0700 * SUMMARY Reduce type annotation update frequency. I was seeing Runtime.getRuntimeTypesForVariablesAtOffsets happening every 16-24ms in the case where nothing is changing. That is unnecessarily frequent. Lets reduction this to 100ms - 2000ms (worst case). 1095195 1 253215 joepeck 2015-05-15 12:28:57 -0700 Created attachment 253215 [PATCH] Proposed Fix 1095203 2 253215 saam 2015-05-15 12:46:57 -0700 Comment on attachment 253215 [PATCH] Proposed Fix Looks good to me. At some point I work on the patch that makes it so we only update when we need to. This would have the consequence of never updating when code stops running which would be a big win. 1095205 3 saam 2015-05-15 12:49:30 -0700 (In reply to comment #0) > * SUMMARY > Reduce type annotation update frequency. > > I was seeing Runtime.getRuntimeTypesForVariablesAtOffsets happening every > 16-24ms in the case where nothing is changing. That is unnecessarily > frequent. Lets reduction this to 100ms - 2000ms (worst case). It looks like the code has the maximum at 1000, not sure if you want to make it 2000 or keep it at 1000 1095207 4 253215 timothy 2015-05-15 13:00:31 -0700 Comment on attachment 253215 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253215&action=review > Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js:71 > + var timeoutTime = Math.max(100, Math.min(1000, 8 * totalTime)); ChangeLog says 2000, code says 1000. 1095217 5 joepeck 2015-05-15 13:27:45 -0700 (In reply to comment #4) > Comment on attachment 253215 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253215&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/TypeTokenAnnotator.js:71 > > + var timeoutTime = Math.max(100, Math.min(1000, 8 * totalTime)); > > ChangeLog says 2000, code says 1000. Oops. I'll make it 2000. At one point I did see a 1.2s being possible. 1095222 6 253220 joepeck 2015-05-15 13:37:59 -0700 Created attachment 253220 [PATCH] For Landing 1095256 7 253220 commit-queue 2015-05-15 14:37:32 -0700 Comment on attachment 253220 [PATCH] For Landing Clearing flags on attachment: 253220 Committed r184418: <http://trac.webkit.org/changeset/184418> 253215 2015-05-15 12:28:57 -0700 2015-05-15 13:37:24 -0700 [PATCH] Proposed Fix frequency.patch text/plain 1598 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcwZGJjZTcuLjAyODEzNTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IHR5cGUgYW5ub3RhdGlvbiB1cGRhdGUgZnJlcXVlbmN5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVHlw ZVRva2VuQW5ub3RhdG9yLmpzOgorICAgICAgICBSZWR1Y2UgdGhlIGZyZXF1ZW5jeSB3aGljaCBj b3VsZCBjb21tb25seSBiZSAxNi0yNG1zCisgICAgICAgIHRvIGEgbWluaW11bSBvZiAxMDBtcyBh bmQgbWF4aW11bSBvZiAyMDAwbXMuCisKIDIwMTUtMDUtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVcGRhdGUgdGhlIE5l dyBUYWIgYnV0dG9uIGRpc2FibGVkIHN0YXRlIGFmdGVyIGV4dHJhIGRvbWFpbnMgYXJlIGFjdGl2 YXRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvVHlwZVRva2VuQW5ub3RhdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVHlwZVRva2VuQW5ub3RhdG9yLmpzCmluZGV4IGVkYzE0 MjMuLjQ4MThjNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbnRyb2xsZXJzL1R5cGVUb2tlbkFubm90YXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UeXBlVG9rZW5Bbm5vdGF0b3IuanMK QEAgLTY4LDcgKzY4LDcgQEAgV2ViSW5zcGVjdG9yLlR5cGVUb2tlbkFubm90YXRvciA9IGNsYXNz IFR5cGVUb2tlbkFubm90YXRvciBleHRlbmRzIFdlYkluc3BlY3Rvci4KICAgICAgICAgICAgIG5v ZGVzV2l0aFVwZGF0ZWRUeXBlcy5mb3JFYWNoKHRoaXMuX2luc2VydFR5cGVUb2tlbiwgdGhpcyk7 CiAKICAgICAgICAgICAgIHZhciB0b3RhbFRpbWUgPSBEYXRlLm5vdygpIC0gc3RhcnRUaW1lOwot ICAgICAgICAgICAgdmFyIHRpbWVvdXRUaW1lID0gTWF0aC5taW4oTWF0aC5tYXgoNzUwMCwgdG90 YWxUaW1lKSwgOCAqIHRvdGFsVGltZSk7CisgICAgICAgICAgICB2YXIgdGltZW91dFRpbWUgPSBN YXRoLm1heCgxMDAsIE1hdGgubWluKDEwMDAsIDggKiB0b3RhbFRpbWUpKTsKIAogICAgICAgICAg ICAgdGhpcy5fdGltZW91dElkZW50aWZpZXIgPSBzZXRUaW1lb3V0KGZ1bmN0aW9uIHRpbWVvdXRV cGRhdGUoKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fdGltZW91dElkZW50aWZpZXIgPSBudWxs Owo= 253220 2015-05-15 13:37:59 -0700 2015-05-15 14:37:32 -0700 [PATCH] For Landing for-landing.patch text/plain 1599 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcwZGJjZTcuLmU5ZGQ3Y2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IHR5cGUgYW5ub3RhdGlvbiB1cGRhdGUgZnJlcXVlbmN5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBU aW1vdGh5IEhhdGNoZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1R5 cGVUb2tlbkFubm90YXRvci5qczoKKyAgICAgICAgUmVkdWNlIHRoZSBmcmVxdWVuY3kgd2hpY2gg Y291bGQgY29tbW9ubHkgYmUgMTYtMjRtcworICAgICAgICB0byBhIG1pbmltdW0gb2YgMTAwbXMg YW5kIG1heGltdW0gb2YgMjAwMG1zLgorCiAyMDE1LTA1LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBkYXRlIHRoZSBO ZXcgVGFiIGJ1dHRvbiBkaXNhYmxlZCBzdGF0ZSBhZnRlciBleHRyYSBkb21haW5zIGFyZSBhY3Rp dmF0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL1R5cGVUb2tlbkFubm90YXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1R5cGVUb2tlbkFubm90YXRvci5qcwppbmRleCBlZGMx NDIzLi4xY2IyNTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9Db250cm9sbGVycy9UeXBlVG9rZW5Bbm5vdGF0b3IuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVHlwZVRva2VuQW5ub3RhdG9yLmpz CkBAIC02OCw3ICs2OCw3IEBAIFdlYkluc3BlY3Rvci5UeXBlVG9rZW5Bbm5vdGF0b3IgPSBjbGFz cyBUeXBlVG9rZW5Bbm5vdGF0b3IgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAgICAgICAgICAgICBu b2Rlc1dpdGhVcGRhdGVkVHlwZXMuZm9yRWFjaCh0aGlzLl9pbnNlcnRUeXBlVG9rZW4sIHRoaXMp OwogCiAgICAgICAgICAgICB2YXIgdG90YWxUaW1lID0gRGF0ZS5ub3coKSAtIHN0YXJ0VGltZTsK LSAgICAgICAgICAgIHZhciB0aW1lb3V0VGltZSA9IE1hdGgubWluKE1hdGgubWF4KDc1MDAsIHRv dGFsVGltZSksIDggKiB0b3RhbFRpbWUpOworICAgICAgICAgICAgdmFyIHRpbWVvdXRUaW1lID0g TWF0aC5tYXgoMTAwLCBNYXRoLm1pbigyMDAwLCA4ICogdG90YWxUaW1lKSk7CiAKICAgICAgICAg ICAgIHRoaXMuX3RpbWVvdXRJZGVudGlmaWVyID0gc2V0VGltZW91dChmdW5jdGlvbiB0aW1lb3V0 VXBkYXRlKCkgewogICAgICAgICAgICAgICAgIHRoaXMuX3RpbWVvdXRJZGVudGlmaWVyID0gbnVs bDsK