145065 2015-05-15 11:54:38 -0700 Prefix force on MouseEvent and add constants for click and force click values 2015-05-15 14:33:34 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue dino sam simon.fraser thorton oldest_to_newest 1095182 0 bdakin 2015-05-15 11:54:38 -0700 Prefix force on MouseEvent and add constants for click and force click values rdar://problem/20770052 1095183 1 253211 bdakin 2015-05-15 11:58:21 -0700 Created attachment 253211 Patch 1095185 2 commit-queue 2015-05-15 12:01:11 -0700 Attachment 253211 did not pass style-queue: ERROR: Source/WebCore/dom/MouseEvent.h:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/dom/MouseEvent.h:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1095186 3 253211 thorton 2015-05-15 12:04:21 -0700 Comment on attachment 253211 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253211&action=review > Source/WebCore/dom/MouseEvent.h:95 > double force() const { return m_force; } > + double webkitForce() const { return m_force; } Isn't there a way in the IDL to have an alias like this without having to have the function twice? 1095187 4 thorton 2015-05-15 12:06:13 -0700 (In reply to comment #3) > Comment on attachment 253211 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253211&action=review > > > Source/WebCore/dom/MouseEvent.h:95 > > double force() const { return m_force; } > > + double webkitForce() const { return m_force; } > > Isn't there a way in the IDL to have an alias like this without having to > have the function twice? Yes! I think you want something like this: [Conditional=MOUSE_FORCE_EVENTS, ImplementedAs=force] readonly attribute double webkitForce; 1095255 5 bdakin 2015-05-15 14:33:34 -0700 Thanks, Tim! http://trac.webkit.org/changeset/184417 253211 2015-05-15 11:58:21 -0700 2015-05-15 12:08:07 -0700 Patch for-review.txt text/plain 3247 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDQwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTE1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBQcmVmaXggZm9yY2Ugb24gTW91c2VF dmVudCBhbmQgYWRkIGNvbnN0YW50cyBmb3IgY2xpY2sgYW5kIGZvcmNlIGNsaWNrIHZhbHVlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDY1Cisg ICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjA3NzAw NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRv bS9Nb3VzZUV2ZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpNb3VzZUV2ZW50Ojp3ZWJraXRGb3Jj ZSk6CisgICAgICAgICogZG9tL01vdXNlRXZlbnQuaWRsOgorCiAyMDE1LTA1LTE1ICBTdW5nbWFu biBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBGaXggdHJpdmlh bCB0eXBvIGluIFRleHRFbmNvZGluZ0RldGVjdG9ySUNVLmNwcC4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2RvbS9Nb3VzZUV2ZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL01v dXNlRXZlbnQuaAkocmV2aXNpb24gMTg0MzA2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL01vdXNl RXZlbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDgsNiArNDgsMTEgQEAgc3RydWN0IE1vdXNlRXZl bnRJbml0IDogcHVibGljIFVJRXZlbnRJbgogCiBjbGFzcyBNb3VzZUV2ZW50IDogcHVibGljIE1v dXNlUmVsYXRlZEV2ZW50IHsKIHB1YmxpYzoKKyAgICBlbnVtIEZvcmNlVmFsdWVzIHsKKyAgICAg ICAgV0VCS0lUX0ZPUkNFX0FUX01PVVNFX0RPV04gICAgICAgID0gMSwKKyAgICAgICAgV0VCS0lU X0ZPUkNFX0FUX0ZPUkNFX01PVVNFX0RPV04gID0gMgorICAgIH07CisKICAgICBzdGF0aWMgUmVm PE1vdXNlRXZlbnQ+IGNyZWF0ZSgpCiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5l dyBNb3VzZUV2ZW50KTsKQEAgLTg3LDYgKzkyLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgRXZl bnRUYXJnZXQqIHJlbGF0ZWRUYXJnZXQoKSBjb25zdCBvdmVycmlkZSBmaW5hbCB7IHJldHVybiBt X3JlbGF0ZWRUYXJnZXQuZ2V0KCk7IH0KICAgICB2b2lkIHNldFJlbGF0ZWRUYXJnZXQoUGFzc1Jl ZlB0cjxFdmVudFRhcmdldD4gcmVsYXRlZFRhcmdldCkgeyBtX3JlbGF0ZWRUYXJnZXQgPSByZWxh dGVkVGFyZ2V0OyB9CiAgICAgZG91YmxlIGZvcmNlKCkgY29uc3QgeyByZXR1cm4gbV9mb3JjZTsg fQorICAgIGRvdWJsZSB3ZWJraXRGb3JjZSgpIGNvbnN0IHsgcmV0dXJuIG1fZm9yY2U7IH0KICAg ICB2b2lkIHNldEZvcmNlKGRvdWJsZSBmb3JjZSkgeyBtX2ZvcmNlID0gZm9yY2U7IH0KIAogICAg IE5vZGUqIHRvRWxlbWVudCgpIGNvbnN0OwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL01vdXNl RXZlbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50Lmlk bAkocmV2aXNpb24gMTg0MzA2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL01vdXNlRXZlbnQuaWRs CSh3b3JraW5nIGNvcHkpCkBAIC0yMSw2ICsyMSwxMSBAQAogICAgIENvbnN0cnVjdG9yQ29uZGl0 aW9uYWw9RE9NNF9FVkVOVFNfQ09OU1RSVUNUT1IsCiAgICAgQ29uc3RydWN0b3JUZW1wbGF0ZT1F dmVudCwKIF0gaW50ZXJmYWNlIE1vdXNlRXZlbnQgOiBVSUV2ZW50IHsKKyNpZiBkZWZpbmVkKExB TkdVQUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKKyAgICBbQ29uZGl0aW9u YWw9TU9VU0VfRk9SQ0VfRVZFTlRTXSBjb25zdCB1bnNpZ25lZCBzaG9ydCBXRUJLSVRfRk9SQ0Vf QVRfTU9VU0VfRE9XTiAgICAgICAgPSAxOworICAgIFtDb25kaXRpb25hbD1NT1VTRV9GT1JDRV9F VkVOVFNdIGNvbnN0IHVuc2lnbmVkIHNob3J0IFdFQktJVF9GT1JDRV9BVF9GT1JDRV9NT1VTRV9E T1dOICA9IDI7CisjZW5kaWYKKwogICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rvcl0g cmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgICAgICAgICAgICAgc2NyZWVuWDsKICAgICBbSW5pdGlh bGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nICAgICAgICAg ICAgIHNjcmVlblk7CiAgICAgW0luaXRpYWxpemVkQnlFdmVudENvbnN0cnVjdG9yXSByZWFkb25s eSBhdHRyaWJ1dGUgbG9uZyAgICAgICAgICAgICBjbGllbnRYOwpAQCAtMzMsNyArMzgsOSBAQAog ICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rvcl0gcmVhZG9ubHkgYXR0cmlidXRlIEV2 ZW50VGFyZ2V0ICAgICAgcmVsYXRlZFRhcmdldDsKICAgICBbQ29uZGl0aW9uYWw9UE9JTlRFUl9M T0NLXSAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nICAgICAgICAgICAgIG1vdmVtZW50WDsK ICAgICBbQ29uZGl0aW9uYWw9UE9JTlRFUl9MT0NLXSAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBs b25nICAgICAgICAgICAgIG1vdmVtZW50WTsKLSAgICBbQ29uZGl0aW9uYWw9TU9VU0VfRk9SQ0Vf RVZFTlRTXXJlYWRvbmx5IGF0dHJpYnV0ZSBkb3VibGUgICAgICAgICAgIGZvcmNlOworI2lmIGRl ZmluZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVAorICAgIFtD b25kaXRpb25hbD1NT1VTRV9GT1JDRV9FVkVOVFNdcmVhZG9ubHkgYXR0cmlidXRlIGRvdWJsZSAg ICAgICAgICAgd2Via2l0Rm9yY2U7CisjZW5kaWYKICAgICAKICAgICBbT2JqQ0xlZ2FjeVVubmFt ZWRQYXJhbWV0ZXJzXSB2b2lkIGluaXRNb3VzZUV2ZW50KFtEZWZhdWx0PVVuZGVmaW5lZF0gb3B0 aW9uYWwgRE9NU3RyaW5nIHR5cGUsIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgW0RlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBib29sZWFuIGNhbkJ1YmJsZSwgCg==