145063 2015-05-15 11:35:14 -0700 AudioContext should resolve promises with jsUndefined() and not jsNull() 2015-05-19 14:12:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf ap commit-queue darin jer.noble sam oldest_to_newest 1095174 0 youennf 2015-05-15 11:35:14 -0700 AudioContext resume, suspend and close are all returning promises. Resolving these promises is done by passing a null value, while there should be no value passed at all, therefore passing undefined. 1095184 1 253212 youennf 2015-05-15 12:01:01 -0700 Created attachment 253212 Patch 1095214 2 jer.noble 2015-05-15 13:21:47 -0700 What do other browsers do for Promise<void>? 1095223 3 youennf 2015-05-15 13:45:30 -0700 Chromium is going the undefined way. Not sure about Mozilla and IE. 1095224 4 youennf 2015-05-15 13:46:31 -0700 (In reply to comment #3) > Chromium is going the undefined way. > Not sure about Mozilla and IE. Also, in the streams API, we are going with undefined as well when resolving the close promise. 1095943 5 darin 2015-05-19 08:39:06 -0700 Sam, can you make the call on this? 1096005 6 253212 sam 2015-05-19 12:58:26 -0700 Comment on attachment 253212 Patch Seems fine. r=me. 1096040 7 253212 commit-queue 2015-05-19 14:12:28 -0700 Comment on attachment 253212 Patch Clearing flags on attachment: 253212 Committed r184588: <http://trac.webkit.org/changeset/184588> 1096041 8 commit-queue 2015-05-19 14:12:34 -0700 All reviewed patches have been landed. Closing bug. 253212 2015-05-15 12:01:01 -0700 2015-05-19 14:12:28 -0700 Patch bug-145063-20150515205927.patch text/plain 3637 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRiODlhNGNmZTZkODJi NmUxM2ZlZTE4MmQ1NDBkODNlYWFiMjAwYS4uOTU4YjhjNjA4YmViZmFkZWJhNWNjZDhjNDA3NDI2 MDUyZGUyM2ZjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgQXVkaW9D b250ZXh0IHNob3VsZCByZXNvbHZlIHByb21pc2VzIHdpdGgganNVbmRlZmluZWQoKSBhbmQgbm90 IGpzTnVsbCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDUwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IHVwZGF0ZWQgdGVzdC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9N UHJvbWlzZS5oOgorICAgICAgICAoV2ViQ29yZTo6RGVmZXJyZWRXcmFwcGVyOjpyZXNvbHZlKTog cmVzb2x2aW5nIHN0ZDo6bnVsbHB0cl90IGFzIGpzVW5kZWZpbmVkKCkgYW5kIG5vdCBqc051bGwo KQorCiAyMDE1LTA1LTEyICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxp YS5jb20+IGFuZCBZb3Vlbm4gRmFibGV0IDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAog ICAgICAgICBbU3RyZWFtcyBBUEldIFJlYWRhYmxlU3RyZWFtIHJlYWRlciBzaG91bGQgbm90IGJl IGRpc3Bvc2FibGUgd2hlbiBoYXZpbmcgcGVuZGluZyBwcm9taXNlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Qcm9taXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0RPTVByb21pc2UuaAppbmRleCA5ZDQwODk5Yzg0YTg3ZDkyN2NhMjg4MGYw MmQ5OTFmZWU3N2E0NTc1Li40NTk0OGZjMmNhMjBmMTBmNzA0NGI4MjIxMDQxZjQ0ZmExNDk5MzVl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVByb21pc2UuaApAQCAtMTI2LDcg KzEyNiw3IEBAIGlubGluZSB2b2lkIERlZmVycmVkV3JhcHBlcjo6cmVzb2x2ZShjb25zdCBzdGQ6 Om51bGxwdHJfdCYpCiB7CiAgICAgSlNDOjpFeGVjU3RhdGUqIGV4ZWMgPSBtX2dsb2JhbE9iamVj dC0+Z2xvYmFsRXhlYygpOwogICAgIEpTQzo6SlNMb2NrSG9sZGVyIGxvY2tlcihleGVjKTsKLSAg ICByZXNvbHZlKGV4ZWMsIEpTQzo6anNOdWxsKCkpOworICAgIHJlc29sdmUoZXhlYywgSlNDOjpq c1VuZGVmaW5lZCgpKTsKIH0KIAogdGVtcGxhdGU8PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQzOWVjNmIwNGI2ZDU5ZDkz MDdlMDMzMGUzNTI3ZmVlZGNkNTQ0YTcuLmU5ZjI3OGQyYTNjNjIzMzU4NWQ0ZGU0YmU2NzQ0Y2E2 ODQwNjMyYzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0wNS0xNSAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgorCisgICAgICAgIEF1ZGlvQ29udGV4dCBz aG91bGQgcmVzb2x2ZSBwcm9taXNlcyB3aXRoIGpzVW5kZWZpbmVkKCkgYW5kIG5vdCBqc051bGwo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDYz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJh dWRpby9hdWRpb2NvbnRleHQtc3RhdGUuaHRtbDogQWRkZWQgY2hlY2sgb2YgcHJvbWlzZSByZXNv bHZlIHZhbHVlLgorCiAyMDE1LTA1LTEyICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1z dW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSZWJhc2VsaW5lIHNvbWUgZWRpdGluZyB0ZXN0cwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9jb250ZXh0LXN0YXRlLmh0bWwg Yi9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb2NvbnRleHQtc3RhdGUuaHRtbAppbmRleCA3NWZi NGM1YjFjMzNmMDk3YjgxM2RkMTZjMGYyMTU4MTg1YTk0NzcxLi5iZTdkN2YxYzAyNmQ1MjNjMTRk YTZkZmFiOTBhNTkzYThkYjM5OGU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9h dWRpb2NvbnRleHQtc3RhdGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb2Nv bnRleHQtc3RhdGUuaHRtbApAQCAtNDIsNyArNDIsMTIgQEAgZnVuY3Rpb24gc3VzcGVuZEZhaWxl ZCgpIHsKICAgICBmaW5pc2hKU1Rlc3QoKTsKIH0KIAotZnVuY3Rpb24gc3VzcGVuZFN1Y2NlZWRl ZCgpIHsKK2Z1bmN0aW9uIHN1c3BlbmRTdWNjZWVkZWQodmFsdWUpIHsKKyAgICBpZiAodHlwZW9m IHZhbHVlICE9ICd1bmRlZmluZWQnKSB7CisgICAgICAgIHRlc3RGYWlsZWQoJ2NvbnRleHQuc3Vz cGVuZCgpIHByb21pc2Ugc2hvdWxkIG5vdCByZXNvbHZlIHdpdGggYSB2YWx1ZS4nKTsKKyAgICAg ICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAgdGVzdFBhc3Nl ZCgnY29udGV4dC5zdXNwZW5kKCkgcHJvbWlzZSByZXNvbHZlZCcpOwogICAgIHNob3VsZEJlKCdj b250ZXh0LnN0YXRlJywgJyJzdXNwZW5kZWQiJyk7CiAKQEAgLTU1LDcgKzYwLDEyIEBAIGZ1bmN0 aW9uIHJlc3VtZUZhaWxlZCgpIHsKICAgICBmaW5pc2hKU1Rlc3QoKTsKIH0KIAotZnVuY3Rpb24g cmVzdW1lU3VjY2VlZGVkKCkgeworZnVuY3Rpb24gcmVzdW1lU3VjY2VlZGVkKHZhbHVlKSB7Cisg ICAgaWYgKHR5cGVvZiB2YWx1ZSAhPSAndW5kZWZpbmVkJykgeworICAgICAgICB0ZXN0RmFpbGVk KCdjb250ZXh0LnJlc3VtZSgpIHByb21pc2Ugc2hvdWxkIG5vdCByZXNvbHZlIHdpdGggYSB2YWx1 ZS4nKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAg ICAgdGVzdFBhc3NlZCgnY29udGV4dC5yZXN1bWUoKSBwcm9taXNlIHJlc29sdmVkJyk7CiAgICAg c2hvdWxkQmUoJ2NvbnRleHQuc3RhdGUnLCAnInJ1bm5pbmciJyk7CiAKQEAgLTY4LDcgKzc4LDEy IEBAIGZ1bmN0aW9uIGNsb3NlRmFpbGVkKCkgewogICAgIGZpbmlzaEpTVGVzdCgpOwogfQogCi1m dW5jdGlvbiBjbG9zZVN1Y2NlZWRlZCgpIHsKK2Z1bmN0aW9uIGNsb3NlU3VjY2VlZGVkKHZhbHVl KSB7CisgICAgaWYgKHR5cGVvZiB2YWx1ZSAhPSAndW5kZWZpbmVkJykgeworICAgICAgICB0ZXN0 RmFpbGVkKCdjb250ZXh0LmNsb3NlZCgpIHByb21pc2Ugc2hvdWxkIG5vdCByZXNvbHZlIHdpdGgg YSB2YWx1ZS4nKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgIHJldHVybjsKKyAg ICB9CiAgICAgdGVzdFBhc3NlZCgnY29udGV4dC5jbG9zZSgpIHByb21pc2UgcmVzb2x2ZWQnKTsK ICAgICBzaG91bGRCZSgnY29udGV4dC5zdGF0ZScsICciY2xvc2VkIicpOwogCg==