145060 2015-05-15 10:04:57 -0700 Checkmark on OFF option of captions sometimes does not appear 2015-05-15 11:00:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned commit-queue eric.carlson roger_fong oldest_to_newest 1095144 0 roger_fong 2015-05-15 10:04:57 -0700 <rdar://problem/19388333> Only happens when we have both audio tracks and subtitle options 1095146 1 253205 roger_fong 2015-05-15 10:12:24 -0700 Created attachment 253205 patch 1095150 2 roger_fong 2015-05-15 10:18:45 -0700 Note that the var trackMenuItemSelected = true; results in the OFF menu logic for subtitles not being trigger ever. 1095162 3 253205 commit-queue 2015-05-15 10:59:56 -0700 Comment on attachment 253205 patch Clearing flags on attachment: 253205 Committed r184396: <http://trac.webkit.org/changeset/184396> 1095164 4 commit-queue 2015-05-15 11:00:00 -0700 All reviewed patches have been landed. Closing bug. 253205 2015-05-15 10:12:24 -0700 2015-05-15 10:59:56 -0700 patch captionspatch.patch text/plain 1881 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDM5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTE1ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2ttYXJrIG9uIE9GRiBv cHRpb24gb2YgY2FwdGlvbnMgc29tZXRpbWVzIGRvZXMgbm90IGFwcGVhci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTA2MC4KKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzE5Mzg4MzMzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBs ZS5qczoKKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLmJ1aWxkQ2FwdGlvbk1lbnUpOgor ICAgICAgICBBdWRpbyB0cmFja3MgZG9u4oCZdCBoYXZlIGFuIE9GRiBvcHRpb24uCisgICAgICAg IFJlbW92ZSByZWxhdGVkIGNvZGUgdG8gYWxsb3cgT0ZGIG9wdGlvbiBmb3Igc3VidGl0bGVzIHRv IHdvcmsgcHJvcGVybHkuCisKIDIwMTUtMDUtMTUgIFBlciBBcm5lIFZvbGxhbiAgPHBlYXZvQG91 dGxvb2suY29tPgogCiAgICAgICAgIFtDdXJsXSBXZWJTb2NrZXQgcGxhdGZvcm0gcGFydCBpcyBu b3QgaW1wbGVtZW50ZWQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuanMJKHJldmlzaW9uIDE4NDM2 MSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xz QXBwbGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTE2MTIsMTggKzE2MTIsMTEgQEAgQ29udHJvbGxl ci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgbWVudUl0ZW0udHJhY2sgPSB0cmFjazsK IAogICAgICAgICAgICAgICAgIGlmICh0cmFjay5lbmFibGVkKSB7Ci0gICAgICAgICAgICAgICAg ICAgIHZhciB0cmFja01lbnVJdGVtU2VsZWN0ZWQgPSB0cnVlOwogICAgICAgICAgICAgICAgICAg ICBtZW51SXRlbS5jbGFzc0xpc3QuYWRkKHRoaXMuQ2xhc3NOYW1lcy5zZWxlY3RlZCk7CiAgICAg ICAgICAgICAgICAgICAgIG1lbnVJdGVtLnNldEF0dHJpYnV0ZSgndGFiaW5kZXgnLCAnMCcpOwog ICAgICAgICAgICAgICAgICAgICBtZW51SXRlbS5zZXRBdHRyaWJ1dGUoJ2FyaWEtY2hlY2tlZCcs ICd0cnVlJyk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQotCi0gICAgICAgICAg ICBpZiAob2ZmTWVudSAmJiBkaXNwbGF5TW9kZSA9PT0gJ2ZvcmNlZC1vbmx5JyAmJiAhdHJhY2tN ZW51SXRlbVNlbGVjdGVkKSB7Ci0gICAgICAgICAgICAgICAgb2ZmTWVudS5jbGFzc0xpc3QuYWRk KHRoaXMuQ2xhc3NOYW1lcy5zZWxlY3RlZCk7Ci0gICAgICAgICAgICAgICAgbWVudUl0ZW0uc2V0 QXR0cmlidXRlKCd0YWJpbmRleCcsICcwJyk7Ci0gICAgICAgICAgICAgICAgbWVudUl0ZW0uc2V0 QXR0cmlidXRlKCdhcmlhLWNoZWNrZWQnLCAndHJ1ZScpOwotICAgICAgICAgICAgfQogICAgICAg ICB9CiAKICAgICAgICAgaWYgKHRleHRUcmFja3MgJiYgdGV4dFRyYWNrcy5sZW5ndGggPiAyKSB7