145036 2015-05-14 20:32:18 -0700 PutGlobalVar should reference the global object it's storing into 2015-05-14 20:53:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 145015 1 fpizlo fpizlo oldest_to_newest 1095015 0 fpizlo 2015-05-14 20:32:18 -0700 This makes reasoning about barriers a whole lot easier. 1095017 1 253172 fpizlo 2015-05-14 20:39:20 -0700 Created attachment 253172 the patch 1095018 2 253172 msaboff 2015-05-14 20:43:33 -0700 Comment on attachment 253172 the patch r=me 1095022 3 fpizlo 2015-05-14 20:53:43 -0700 Landed in http://trac.webkit.org/changeset/184367 253172 2015-05-14 20:39:20 -0700 2015-05-14 20:43:33 -0700 the patch blah.patch text/plain 6052 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0MzY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE1LTA1LTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UHV0R2xvYmFsVmFyIHNob3VsZCByZWZlcmVuY2UgdGhlIGdsb2JhbCBvYmplY3QgaXQncyBzdG9y aW5nIGludG8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgVGhpcyBtYWtlcyBpdCBlYXNpZXIgdG8gcmVhc29uIGFib3V0IHN0b3JlIGJhcnJp ZXIgaW5zZXJ0aW9uIGFuZCBlbGltaW5hdGlvbi4KKworICAgICAgICAqIGRmZy9ERkdCeXRlQ29k ZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxv Y2spOgorICAgICAgICAqIGRmZy9ERkdDbG9iYmVyaXplLmg6CisgICAgICAgIChKU0M6OkRGRzo6 Y2xvYmJlcml6ZSk6CisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAo SlNDOjpERkc6OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1 bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpj b21waWxlKToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAqIGZ0bC9GVExM b3dlckRGR1RvTExWTS5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNv bXBpbGVQdXRHbG9iYWxWYXIpOgorCiAyMDE1LTA1LTE0ICBNaWNoYWVsIENhdGFuemFybyAgPG1j YXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIEVycm9yIG91dCB3aGVuIHJ1 YnkgaXMgdG9vIG9sZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29k ZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC eXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDE4NDM0NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTY0LDEw ICszMTY0LDExIEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQKIAog ICAgICAgICBjYXNlIG9wX2luaXRfZ2xvYmFsX2NvbnN0OiB7CiAgICAgICAgICAgICBOb2RlKiB2 YWx1ZSA9IGdldChWaXJ0dWFsUmVnaXN0ZXIoY3VycmVudEluc3RydWN0aW9uWzJdLnUub3BlcmFu ZCkpOworICAgICAgICAgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IG1faW5saW5l U3RhY2tUb3AtPm1fY29kZUJsb2NrLT5nbG9iYWxPYmplY3QoKTsKICAgICAgICAgICAgIGFkZFRv R3JhcGgoCiAgICAgICAgICAgICAgICAgUHV0R2xvYmFsVmFyLAotICAgICAgICAgICAgICAgIE9w SW5mbyhtX2lubGluZVN0YWNrVG9wLT5tX2NvZGVCbG9jay0+Z2xvYmFsT2JqZWN0KCktPmFzc2Vy dFZhcmlhYmxlSXNJblRoaXNPYmplY3QoY3VycmVudEluc3RydWN0aW9uWzFdLnUudmFyaWFibGVQ b2ludGVyKSksCi0gICAgICAgICAgICAgICAgdmFsdWUpOworICAgICAgICAgICAgICAgIE9wSW5m byhnbG9iYWxPYmplY3QtPmFzc2VydFZhcmlhYmxlSXNJblRoaXNPYmplY3QoY3VycmVudEluc3Ry dWN0aW9uWzFdLnUudmFyaWFibGVQb2ludGVyKSksCisgICAgICAgICAgICAgICAgd2Vha0pTQ29u c3RhbnQoZ2xvYmFsT2JqZWN0KSwgdmFsdWUpOwogICAgICAgICAgICAgTkVYVF9PUENPREUob3Bf aW5pdF9nbG9iYWxfY29uc3QpOwogICAgICAgICB9CiAKQEAgLTM2NzksNyArMzY4MCw3IEBAIGJv b2wgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQKICAgICAgICAgICAgICAgICAg ICAgQVNTRVJUX1VOVVNFRChlbnRyeSwgd2F0Y2hwb2ludHMgPT0gZW50cnkud2F0Y2hwb2ludFNl dCgpKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgTm9kZSogdmFsdWVOb2Rl ID0gZ2V0KFZpcnR1YWxSZWdpc3Rlcih2YWx1ZSkpOwotICAgICAgICAgICAgICAgIGFkZFRvR3Jh cGgoUHV0R2xvYmFsVmFyLCBPcEluZm8ob3BlcmFuZCksIHZhbHVlTm9kZSk7CisgICAgICAgICAg ICAgICAgYWRkVG9HcmFwaChQdXRHbG9iYWxWYXIsIE9wSW5mbyhvcGVyYW5kKSwgd2Vha0pTQ29u c3RhbnQoZ2xvYmFsT2JqZWN0KSwgdmFsdWVOb2RlKTsKICAgICAgICAgICAgICAgICBpZiAod2F0 Y2hwb2ludHMgJiYgd2F0Y2hwb2ludHMtPnN0YXRlKCkgIT0gSXNJbnZhbGlkYXRlZCkgewogICAg ICAgICAgICAgICAgICAgICAvLyBNdXN0IGhhcHBlbiBhZnRlciB0aGUgc3RvcmUuIFNlZSBjb21t ZW50IGZvciBHZXRHbG9iYWxWYXIuCiAgICAgICAgICAgICAgICAgICAgIGFkZFRvR3JhcGgoTm90 aWZ5V3JpdGUsIE9wSW5mbyh3YXRjaHBvaW50cykpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDbG9iYmVyaXplLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdDbG9iYmVyaXplLmgJKHJldmlzaW9uIDE4NDM0NSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04MzQsNyAr ODM0LDcgQEAgdm9pZCBjbG9iYmVyaXplKEdyYXBoJiBncmFwaCwgTm9kZSogbm9kZQogICAgICAg ICAKICAgICBjYXNlIFB1dEdsb2JhbFZhcjoKICAgICAgICAgd3JpdGUoQWJzdHJhY3RIZWFwKEFi c29sdXRlLCBub2RlLT52YXJpYWJsZVBvaW50ZXIoKSkpOwotICAgICAgICBkZWYoSGVhcExvY2F0 aW9uKEdsb2JhbFZhcmlhYmxlTG9jLCBBYnN0cmFjdEhlYXAoQWJzb2x1dGUsIG5vZGUtPnZhcmlh YmxlUG9pbnRlcigpKSksIG5vZGUtPmNoaWxkMSgpLm5vZGUoKSk7CisgICAgICAgIGRlZihIZWFw TG9jYXRpb24oR2xvYmFsVmFyaWFibGVMb2MsIEFic3RyYWN0SGVhcChBYnNvbHV0ZSwgbm9kZS0+ dmFyaWFibGVQb2ludGVyKCkpKSwgbm9kZS0+Y2hpbGQyKCkubm9kZSgpKTsKICAgICAgICAgcmV0 dXJuOwogCiAgICAgY2FzZSBOZXdBcnJheToKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHRml4dXBQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkocmV2aXNpb24gMTg0MzQ1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyMiwx MSArMTEyMiw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgCiAgICAg ICAgIGNhc2UgUHV0R2xvYmFsVmFyOiB7Ci0gICAgICAgICAgICBOb2RlKiBnbG9iYWxPYmplY3RO b2RlID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKLSAgICAgICAgICAgICAgICBtX2luZGV4 SW5CbG9jaywgU3BlY05vbmUsIEpTQ29uc3RhbnQsIG5vZGUtPm9yaWdpbiwgCi0gICAgICAgICAg ICAgICAgT3BJbmZvKG1fZ3JhcGguZnJlZXplKG1fZ3JhcGguZ2xvYmFsT2JqZWN0Rm9yKG5vZGUt Pm9yaWdpbi5zZW1hbnRpYykpKSk7CisgICAgICAgICAgICBmaXhFZGdlPENlbGxVc2U+KG5vZGUt PmNoaWxkMSgpKTsKICAgICAgICAgICAgIGluc2VydFN0b3JlQmFycmllcigKLSAgICAgICAgICAg ICAgICBtX2luZGV4SW5CbG9jaywgRWRnZShnbG9iYWxPYmplY3ROb2RlLCBLbm93bkNlbGxVc2Up LCBub2RlLT5jaGlsZDEoKSk7CisgICAgICAgICAgICAgICAgbV9pbmRleEluQmxvY2ssIG5vZGUt PmNoaWxkMSgpLCBub2RlLT5jaGlsZDIoKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJf NjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3Vs YXRpdmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDE4NDM0NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5 OTUsNyArMzk5NSw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSogbm9kZSkK ICAgICB9CiAKICAgICBjYXNlIFB1dEdsb2JhbFZhcjogewotICAgICAgICBKU1ZhbHVlT3BlcmFu ZCB2YWx1ZSh0aGlzLCBub2RlLT5jaGlsZDEoKSk7CisgICAgICAgIEpTVmFsdWVPcGVyYW5kIHZh bHVlKHRoaXMsIG5vZGUtPmNoaWxkMigpKTsKIAogICAgICAgICAvLyBGSVhNRTogaWYgd2UgaGFw cGVuIHRvIGhhdmUgYSBzcGFyZSByZWdpc3RlciAtIGFuZCBfT05MWV8gaWYgd2UgaGFwcGVuIHRv IGhhdmUKICAgICAgICAgLy8gYSBzcGFyZSByZWdpc3RlciAtIGEgZ29vZCBvcHRpbWl6YXRpb24g d291bGQgYmUgdG8gcHV0IHRoZSByZWdpc3RlciBwb2ludGVyIGludG8KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNp b24gMTg0MzQ1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAxOSw3ICs0MDE5LDcgQEAgdm9pZCBTcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgIH0KIAogICAgIGNhc2UgUHV0R2xvYmFs VmFyOiB7Ci0gICAgICAgIEpTVmFsdWVPcGVyYW5kIHZhbHVlKHRoaXMsIG5vZGUtPmNoaWxkMSgp KTsKKyAgICAgICAgSlNWYWx1ZU9wZXJhbmQgdmFsdWUodGhpcywgbm9kZS0+Y2hpbGQyKCkpOwog CiAgICAgICAgIG1faml0LnN0b3JlNjQodmFsdWUuZ3ByKCksIG5vZGUtPnZhcmlhYmxlUG9pbnRl cigpKTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExW TS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRG R1RvTExWTS5jcHAJKHJldmlzaW9uIDE4NDM0NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTAyLDcgKzM5MDIs NyBAQCBwcml2YXRlOgogICAgIHZvaWQgY29tcGlsZVB1dEdsb2JhbFZhcigpCiAgICAgewogICAg ICAgICBtX291dC5zdG9yZTY0KAotICAgICAgICAgICAgbG93SlNWYWx1ZShtX25vZGUtPmNoaWxk MSgpKSwgbV9vdXQuYWJzb2x1dGUobV9ub2RlLT52YXJpYWJsZVBvaW50ZXIoKSkpOworICAgICAg ICAgICAgbG93SlNWYWx1ZShtX25vZGUtPmNoaWxkMigpKSwgbV9vdXQuYWJzb2x1dGUobV9ub2Rl LT52YXJpYWJsZVBvaW50ZXIoKSkpOwogICAgIH0KICAgICAKICAgICB2b2lkIGNvbXBpbGVOb3Rp ZnlXcml0ZSgpCg==