145027 2015-05-14 16:12:40 -0700 [Content Extensions] Fail to load old content extension files 2015-05-15 13:51:04 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen benjamin commit-queue eric.carlson sam oldest_to_newest 1094948 0 achristensen 2015-05-14 16:12:40 -0700 Old files are causing crashes. Let's fail to load them. 1094950 1 253153 achristensen 2015-05-14 16:14:10 -0700 Created attachment 253153 Patch 1095135 2 253153 eric.carlson 2015-05-15 09:37:25 -0700 Comment on attachment 253153 Patch Thank you Alex! 1095142 3 253153 achristensen 2015-05-15 10:03:30 -0700 Comment on attachment 253153 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253153&action=review > Source/WebKit2/UIProcess/API/APIUserContentExtensionStore.cpp:157 > + if (metaData.version != UserContentExtensionStore::CurrentContentExtensionFileVersion) > + return false; Instead of returning false here, I'm going to check the metaData.version after openAndMapContentExtension returns and call the completionHandler with a new type of error (Error::VersionMismatch or something). 1095231 4 achristensen 2015-05-15 13:51:04 -0700 http://trac.webkit.org/changeset/184413 253153 2015-05-14 16:14:10 -0700 2015-05-15 10:03:30 -0700 Patch bug-145027-20150514161246.patch text/plain 3628 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDM1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA1LTE0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NvbnRlbnQg RXh0ZW5zaW9uc10gRmFpbCB0byBsb2FkIG9sZCBjb250ZW50IGV4dGVuc2lvbiBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDI3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb250ZW50ZXh0 ZW5zaW9ucy9ERkFCeXRlY29kZS5oOgorCiAyMDE1LTA1LTEzICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENyYXNoIGluIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5k OjpyZW1vdmVSZWR1bmRhbnRTdHlsZXNBbmRLZWVwU3R5bGVTcGFuSW5saW5lCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9jb250ZW50ZXh0ZW5zaW9ucy9ERkFCeXRlY29kZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQUJ5dGVjb2RlLmgJKHJldmlzaW9u IDE4NDI5MCkKKysrIFNvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQUJ5dGVjb2Rl LmgJKHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDggQEAgbmFtZXNwYWNlIENvbnRlbnRFeHRl bnNpb25zIHsKIAogdHlwZWRlZiB1aW50OF90IERGQUJ5dGVjb2RlOwogCisvLyBJbmNyZW1lbnQg VXNlckNvbnRlbnRFeHRlbnNpb25TdG9yZTo6Q3VycmVudENvbnRlbnRFeHRlbnNpb25GaWxlVmVy c2lvbgorLy8gd2hlbiBtYWtpbmcgYW55IG5vbi1iYWNrd2FyZHMtY29tcGF0aWJsZSBjaGFuZ2Vz IHRvIHRoZSBieXRlY29kZS4KIGVudW0gY2xhc3MgREZBQnl0ZWNvZGVJbnN0cnVjdGlvbiA6IHVp bnQ4X3QgewogCiAgICAgLy8gQ2hlY2tWYWx1ZSBoYXMgdHdvIGFyZ3VtZW50czoKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cJKHJldmlzaW9uIDE4NDM1OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA1LTE0ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NvbnRlbnQgRXh0ZW5zaW9u c10gRmFpbCB0byBsb2FkIG9sZCBjb250ZW50IGV4dGVuc2lvbiBmaWxlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1MDI3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSVVz ZXJDb250ZW50RXh0ZW5zaW9uU3RvcmUuY3BwOgorICAgICAgICAoQVBJOjpvcGVuQW5kTWFwQ29u dGVudEV4dGVuc2lvbik6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9BUElVc2VyQ29udGVudEV4 dGVuc2lvblN0b3JlLmg6CisKIDIwMTUtMDUtMTQgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIGxheW91dCBtb2RlIHRoYXQgc2NhbGVz IGRvd24gdGhlIHZpZXcgdG8gdHJ5IHRvIGZpdCB0aGUgZG9jdW1lbnQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQVBJVXNlckNvbnRlbnRFeHRlbnNpb25TdG9yZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElVc2VyQ29udGVudEV4 dGVuc2lvblN0b3JlLmNwcAkocmV2aXNpb24gMTg0MjkwKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9BUElVc2VyQ29udGVudEV4dGVuc2lvblN0b3JlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzYsNyArNzYsNyBAQCBzdGF0aWMgU3RyaW5nIGNvbnN0cnVjdGVkUGF0aChjb25zdCBT dHJpCiAKIGNvbnN0IHNpemVfdCBDb250ZW50RXh0ZW5zaW9uRmlsZUhlYWRlclNpemUgPSBzaXpl b2YodWludDMyX3QpICsgNCAqIHNpemVvZih1aW50NjRfdCk7CiBzdHJ1Y3QgQ29udGVudEV4dGVu c2lvbk1ldGFEYXRhIHsKLSAgICB1aW50MzJfdCB2ZXJzaW9uIHsgMiB9OworICAgIHVpbnQzMl90 IHZlcnNpb24geyBVc2VyQ29udGVudEV4dGVuc2lvblN0b3JlOjpDdXJyZW50Q29udGVudEV4dGVu c2lvbkZpbGVWZXJzaW9uIH07CiAgICAgdWludDY0X3QgYWN0aW9uc1NpemUgeyAwIH07CiAgICAg dWludDY0X3QgZmlsdGVyc1dpdGhvdXREb21haW5zQnl0ZWNvZGVTaXplIHsgMCB9OwogICAgIHVp bnQ2NF90IGZpbHRlcnNXaXRoRG9tYWluQnl0ZWNvZGVTaXplIHsgMCB9OwpAQCAtMTUzLDYgKzE1 Myw5IEBAIHN0YXRpYyBib29sIG9wZW5BbmRNYXBDb250ZW50RXh0ZW5zaW9uKGMKICAgICBpZiAo IWRlY29kZUNvbnRlbnRFeHRlbnNpb25NZXRhRGF0YShtZXRhRGF0YSwgZmlsZURhdGEpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAobWV0YURhdGEudmVyc2lvbiAhPSBVc2VyQ29u dGVudEV4dGVuc2lvblN0b3JlOjpDdXJyZW50Q29udGVudEV4dGVuc2lvbkZpbGVWZXJzaW9uKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQVBJVXNlckNvbnRlbnRFeHRlbnNpb25TdG9y ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQVBJVXNlckNv bnRlbnRFeHRlbnNpb25TdG9yZS5oCShyZXZpc2lvbiAxODQyOTApCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0FQSVVzZXJDb250ZW50RXh0ZW5zaW9uU3RvcmUuaAkod29ya2luZyBj b3B5KQpAQCAtNDcsNiArNDcsMTAgQEAgcHVibGljOgogICAgICAgICBDb21waWxlRmFpbGVkLAog ICAgICAgICBSZW1vdmVGYWlsZWQKICAgICB9OworICAgIAorICAgIC8vIFRoaXMgc2hvdWxkIGJl IGluY3JlbWVudGVkIGV2ZXJ5IHRpbWUgYSBmdW5jdGlvbmFsIGNoYW5nZSBpcyBtYWRlIHRvIHRo ZSBieXRlY29kZSwgZmlsZSBmb3JtYXQsIGV0Yy4KKyAgICAvLyB0byBwcmV2ZW50IGNyYXNoaW5n IHdoaWxlIGxvYWRpbmcgb2xkIGRhdGEuCisgICAgY29uc3Qgc3RhdGljIHVpbnQzMl90IEN1cnJl bnRDb250ZW50RXh0ZW5zaW9uRmlsZVZlcnNpb24gPSAyOwogCiAgICAgc3RhdGljIFVzZXJDb250 ZW50RXh0ZW5zaW9uU3RvcmUmIGRlZmF1bHRTdG9yZSgpOwogCg==