145021 2015-05-14 15:03:07 -0700 [CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation 2015-05-17 23:17:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego cdumez commit-queue darin esprehn+autocc glenn hyatt jfernandez kondapallykalyan svillar oldest_to_newest 1094926 0 rego 2015-05-14 15:03:07 -0700 Currently there's the following FIXME in RenderGrid::computeIntrinsicLogicalWidths(): // FIXME: This should add in the scrollbarWidth (e.g. see RenderFlexibleBox). We should add the scrollbar width when we calculate the intrinsic with of the grid container. 1094927 1 253148 rego 2015-05-14 15:04:56 -0700 Created attachment 253148 Patch 1095545 2 253148 commit-queue 2015-05-17 23:17:05 -0700 Comment on attachment 253148 Patch Clearing flags on attachment: 253148 Committed r184446: <http://trac.webkit.org/changeset/184446> 1095546 3 commit-queue 2015-05-17 23:17:12 -0700 All reviewed patches have been landed. Closing bug. 253148 2015-05-14 15:04:56 -0700 2015-05-17 23:17:05 -0700 Patch bug-145021-20150515000332.patch text/plain 5258 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQwMmRkMGQ5ZmNkMmY1 MGZkMjQ0NTdlNWRmMmUyNTk5NzJhMzYwMC4uMjBhZTE0NzhjNjhlMDk0MDhkOWUyYjE0NGM4MWM0 YjEzMDgzOGQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTE0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIEFkZCBzY3JvbGxiYXIgd2lkdGggaW4gaW50cmluc2ljIGxvZ2ljYWwgd2lkdGhz IGNvbXB1dGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDUwMjEKKworICAgICAgICBMaWtlIGZvciBmbGV4Ym94ZXMgd2UndmUgdG8gdGFrZSBp bnRvIGFjY291bnQgdGhlIHNjcm9sbGJhciBsb2dpY2FsCisgICAgICAgIHdpZHRoIHdoaWxlIGNv bXB1dGluZyB0aGUgaW50cmluc2ljIG1pbiBhbmQgbWF4IGxvZ2ljYWwgd2lkdGhzLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2NvbXB1dGUtaW50cmluc2ljLXdpZHRocy1zY3JvbGxiYXIuaHRtbAorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyR3JpZDo6Y29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMpOiBBZGQgc2Nyb2xsYmFyCisg ICAgICAgIGxvZ2ljYWwgd2lkdGguCisKIDIwMTUtMDUtMTQgIEJldGggRGFraW4gIDxiZGFraW5A YXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSByYW5nZSBvZiBwb3NzaWJsZSBmb3JjZXMgZm9y IG1vdXNlZm9yY2VjaGFuZ2VkIERPTSBldmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckdyaWQuY3BwCmluZGV4IDM4YTFhODU4ODliZjAzOWRlYWVjNTY2MmNjMWUwZTljNTc2ZTIyOTYu LjEzOTg0NjA2OTQ1NzNkMWFhODNiYmRlZDVkNjczY2NiYWY1YTdhZDcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKQEAgLTMwMSwxMCArMzAxLDEyIEBAIHZvaWQgUmVu ZGVyR3JpZDo6Y29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWluTG9n aWNhbFdpZHRoLCBMYXlvCiAKICAgICAgICAgbWluTG9naWNhbFdpZHRoICs9IG1pblRyYWNrQnJl YWR0aDsKICAgICAgICAgbWF4TG9naWNhbFdpZHRoICs9IG1heFRyYWNrQnJlYWR0aDsKLQotICAg ICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYWRkIGluIHRoZSBzY3JvbGxiYXJXaWR0aCAoZS5n LiBzZWUgUmVuZGVyRmxleGlibGVCb3gpLgogICAgIH0KIAorICAgIExheW91dFVuaXQgc2Nyb2xs YmFyV2lkdGggPSBpbnRyaW5zaWNTY3JvbGxiYXJMb2dpY2FsV2lkdGgoKTsKKyAgICBtaW5Mb2dp Y2FsV2lkdGggKz0gc2Nyb2xsYmFyV2lkdGg7CisgICAgbWF4TG9naWNhbFdpZHRoICs9IHNjcm9s bGJhcldpZHRoOworCiAgICAgaWYgKCF3YXNQb3B1bGF0ZWQpCiAgICAgICAgIGNvbnN0X2Nhc3Q8 UmVuZGVyR3JpZCo+KHRoaXMpLT5jbGVhckdyaWQoKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1YjczMTlhNjcxNjU3 ZjNiYWIzMGYxNGYzNzIyODI5MDUzMDliNzRjLi43Mjc4YjlmOTQyZjhmMjdkYWNkOWRiZTU1MTkz M2U3YWFjYzNmZmU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDUtMTQgIE1hbnVlbCBS ZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NTUyBHcmlkIExh eW91dF0gQWRkIHNjcm9sbGJhciB3aWR0aCBpbiBpbnRyaW5zaWMgbG9naWNhbCB3aWR0aHMgY29t cHV0YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTAyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvY29tcHV0ZS1pbnRyaW5zaWMtd2lkdGhzLXNjcm9sbGJh ci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2Nv bXB1dGUtaW50cmluc2ljLXdpZHRocy1zY3JvbGxiYXIuaHRtbDogQWRkZWQuCisKIDIwMTUtMDUt MTQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCBza2lwIGpzL3JlZ3Jlc3MtMTQxMDk4Lmh0bWwuIFRoZSBmaXggd2lsbCBiZSB0cmFja2VkIGlu IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDUwMDcKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2NvbXB1dGUtaW50cmluc2ljLXdp ZHRocy1zY3JvbGxiYXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1s YXlvdXQvY29tcHV0ZS1pbnRyaW5zaWMtd2lkdGhzLXNjcm9sbGJhci1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uOTBlZWQ4NDI1NjFhOWU0M2Y2OWRmMWUyMDJlYzE4MmY0NDFmMTIzNQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2NvbXB1dGUtaW50 cmluc2ljLXdpZHRocy1zY3JvbGxiYXItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjAgQEAKK1Ro aXMgdGVzdCBjaGVja3MgdGhhdCBncmlkIGNvbnRhaW5lciBzY3JvbGxiYXIgaXMgY29tcHV0ZWQg cHJvcGVybHkgZHVyaW5nIGludHJpbnNpYyB3aWR0aCBjYWxjdWxhdGlvbi4KKworaXRlbQorUEFT UworaXRlbQorUEFTUworaXRlbQorUEFTUworaXRlbQorUEFTUworaXRlbQorUEFTUworaXRlbQor UEFTUworaXRlbQorUEFTUworaXRlbQorUEFTUworaXRlbQorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvY29tcHV0ZS1pbnRyaW5zaWMtd2lkdGhzLXNj cm9sbGJhci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvY29tcHV0ZS1p bnRyaW5zaWMtd2lkdGhzLXNjcm9sbGJhci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJiMjUxMTYyNDNmZmE3 YzU2YTBiOWFkYjE1OGIyOTJmNmJlNjFmNTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9jb21wdXRlLWludHJpbnNpYy13aWR0aHMtc2Nyb2xsYmFy Lmh0bWwKQEAgLTAsMCArMSw1MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8bGluayBocmVmPSJyZXNv dXJjZXMvZ3JpZC5jc3MiIHJlbD0ic3R5bGVzaGVldCI+Cis8bGluayBocmVmPSIuLi9jc3MtaW50 cmluc2ljLWRpbWVuc2lvbnMvcmVzb3VyY2VzL3dpZHRoLWtleXdvcmQtY2xhc3Nlcy5jc3MiIHJl bD1zdHlsZXNoZWV0PgorPHN0eWxlPgorICAgIC5ncmlkIHsKKyAgICAgICAgb3ZlcmZsb3cteTog c2Nyb2xsOworICAgIH0KKworICAgIC5pdGVtIHsKKyAgICAgICAgd2lkdGg6IDIwMHB4OworICAg IH0KKworICAgIC5vbmVDb2x1bW4geworICAgICAgICAtd2Via2l0LWdyaWQtdGVtcGxhdGUtY29s dW1uczogMjAwcHg7CisgICAgfQorCisgICAgLmZvdXJDb2x1bW5zIHsKKyAgICAgICAgLXdlYmtp dC1ncmlkLXRlbXBsYXRlLWNvbHVtbnM6IHJlcGVhdCg0LCA1MHB4KTsKKyAgICB9Cis8L3N0eWxl PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMiPjwvc2NyaXB0 PgorPHA+VGhpcyB0ZXN0IGNoZWNrcyB0aGF0IGdyaWQgY29udGFpbmVyIHNjcm9sbGJhciBpcyBj b21wdXRlZCBwcm9wZXJseSBkdXJpbmcgaW50cmluc2ljIHdpZHRoIGNhbGN1bGF0aW9uLjwvcD4K Kzxib2R5IG9ubG9hZD0iY2hlY2tMYXlvdXQoJy5ncmlkJykiPgorICAgIDxkaXYgY2xhc3M9Imdy aWQgbWluLWNvbnRlbnQiIGRhdGEtZXhwZWN0ZWQtY2xpZW50LXdpZHRoPSIyMDAiPgorICAgICAg ICA8ZGl2IGNsYXNzPSJpdGVtIj5pdGVtPC9kaXY+CisgICAgPC9kaXY+CisgICAgPGRpdiBjbGFz cz0iZ3JpZCBtYXgtY29udGVudCIgZGF0YS1leHBlY3RlZC1jbGllbnQtd2lkdGg9IjIwMCI+Cisg ICAgICAgIDxkaXYgY2xhc3M9Iml0ZW0iPml0ZW08L2Rpdj4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2 IGNsYXNzPSJncmlkIGZpdC1jb250ZW50IiBkYXRhLWV4cGVjdGVkLWNsaWVudC13aWR0aD0iMjAw Ij4KKyAgICAgICAgPGRpdiBjbGFzcz0iaXRlbSI+aXRlbTwvZGl2PgorICAgIDwvZGl2PgorICAg IDxkaXYgY2xhc3M9ImdyaWQgb25lQ29sdW1uIG1pbi1jb250ZW50IiBkYXRhLWV4cGVjdGVkLWNs aWVudC13aWR0aD0iMjAwIj4KKyAgICAgICAgaXRlbQorICAgIDwvZGl2PgorICAgIDxkaXYgY2xh c3M9ImdyaWQgb25lQ29sdW1uIG1heC1jb250ZW50IiBkYXRhLWV4cGVjdGVkLWNsaWVudC13aWR0 aD0iMjAwIj4KKyAgICAgICAgaXRlbQorICAgIDwvZGl2PgorICAgIDxkaXYgY2xhc3M9ImdyaWQg b25lQ29sdW1uIGZpdC1jb250ZW50IiBkYXRhLWV4cGVjdGVkLWNsaWVudC13aWR0aD0iMjAwIj4K KyAgICAgICAgaXRlbQorICAgIDwvZGl2PgorICAgIDxkaXYgY2xhc3M9ImdyaWQgZm91ckNvbHVt bnMgbWluLWNvbnRlbnQiIGRhdGEtZXhwZWN0ZWQtY2xpZW50LXdpZHRoPSIyMDAiPgorICAgICAg ICBpdGVtCisgICAgPC9kaXY+CisgICAgPGRpdiBjbGFzcz0iZ3JpZCBmb3VyQ29sdW1ucyBtYXgt Y29udGVudCIgZGF0YS1leHBlY3RlZC1jbGllbnQtd2lkdGg9IjIwMCI+CisgICAgICAgIGl0ZW0K KyAgICA8L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJncmlkIGZvdXJDb2x1bW5zIGZpdC1jb250ZW50 IiBkYXRhLWV4cGVjdGVkLWNsaWVudC13aWR0aD0iMjAwIj4KKyAgICAgICAgaXRlbQorICAgIDwv ZGl2PgorPC9ib2R5Pgo=