145018 2015-05-14 13:49:47 -0700 [CMake] Don't read the LOCATION property of targets 2015-06-04 22:47:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 145635 1 mcatanzaro mcatanzaro commit-queue mcatanzaro mrobinson oldest_to_newest 1094893 0 mcatanzaro 2015-05-14 13:49:47 -0700 To silence the nasty warning we get when running cmake. $ cmake --help-policy CMP0026 CMP0026 ------- Disallow use of the LOCATION target property. CMake 2.8.12 and lower allowed reading the LOCATION target property (and configuration-specific variants) to determine the eventual location of build targets. This relies on the assumption that all necessary information is available at configure-time to determine the final location and filename of the target. However, this property is not fully determined until later at generate-time. At generate time, the $<TARGET_FILE> generator expression can be used to determine the eventual LOCATION of a target output. Code which reads the LOCATION target property can be ported to use the $<TARGET_FILE> generator expression together with the file(GENERATE) subcommand to generate a file containing the target location. The OLD behavior for this policy is to allow reading the LOCATION properties from build-targets. The NEW behavior for this policy is to not to allow reading the LOCATION properties from build-targets. This policy was introduced in CMake version 3.0. CMake version 3.2.2 warns when the policy is not set and uses OLD behavior. Use the cmake_policy command to set it to OLD or NEW explicitly. 1094894 1 253142 mcatanzaro 2015-05-14 13:54:38 -0700 Created attachment 253142 Patch 1094900 2 253142 mrobinson 2015-05-14 14:07:43 -0700 Comment on attachment 253142 Patch Cleaner too. Nice. 1094937 3 253142 commit-queue 2015-05-14 15:30:54 -0700 Comment on attachment 253142 Patch Clearing flags on attachment: 253142 Committed r184357: <http://trac.webkit.org/changeset/184357> 1094938 4 commit-queue 2015-05-14 15:30:57 -0700 All reviewed patches have been landed. Closing bug. 253142 2015-05-14 13:54:38 -0700 2015-05-14 15:30:54 -0700 Patch bug-145018-20150514155315.patch text/plain 1895 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MzM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDkzYTg0MWQxZjAxZjkxMzg5ZjcxMjk5MjZiYTQxZTBj MzhjZWU2My4uN2ZlZmNkMTZkNmU1MDA5NTcwNTVhZDIzMzYzZDRkOTMwZWNlZDA0OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA1LTE0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbQ01ha2VdIERvbid0IHJlYWQgdGhlIExPQ0FUSU9OIHByb3BlcnR5IG9m IHRhcmdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0NTAxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVzZSB0aGUgVEFSR0VUX0ZJTEVfRElSIGdlbmVyYXRvciBleHByZXNzaW9uIHRvIGRldGVybWlu ZSB0aGUgbG9jYXRpb24gb2YgdGhlIHRlc3QgaW5qZWN0ZWQKKyAgICAgICAgYnVuZGxlLCByYXRo ZXIgdGhhbiBhc3N1bWluZyB0aGF0IHRoZSBMT0NBVElPTiBwcm9wZXJ0eSBvZiBUZXN0V2ViS2l0 QVBJSW5qZWN0ZWRCdW5kbGUgd2lsbAorICAgICAgICBiZSB0aGUgc2FtZSBhdCBjb25maWd1cmUt dGltZSBhcyBpdCBpcyBhdCBnZW5lcmF0ZS10aW1lLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9DTWFrZUxpc3RzLnR4dDoKKwogMjAxNS0wNS0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5m YWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENv bnRlbnRzT2ZGaWxlIHNob3VsZCB1c2UgbWFwIGZpbGUgcm91dGluZXMKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0NN YWtlTGlzdHMudHh0CmluZGV4IGZjOGM1YmU3ZjE5N2FjNDVjYzc5NDliNjgxNTkxNzYxNjlkNTE1 MzguLmIxODEzNmVhN2Y4Y2Y5YmU3ZjVhOWRlMGRiZWRmOWE5MmFjY2QyNWYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9DTWFrZUxpc3RzLnR4dApAQCAtMTI5LDExICsxMjksOSBAQCBhZGRfbGlicmFyeShUZXN0 V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGUgU0hBUkVECiB0YXJnZXRfbGlua19saWJyYXJpZXMoVGVz dFdlYktpdEFQSUluamVjdGVkQnVuZGxlICR7VGVzdFdlYktpdEFQSV9MSUJSQVJJRVN9KQogYWRk X2RlcGVuZGVuY2llcyhUZXN0V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGUgJHtGb3J3YXJkaW5nSGVh ZGVyc0ZvclRlc3RXZWJLaXRBUElfTkFNRX0pCiAKLWdldF9wcm9wZXJ0eShUZXN0V2ViS2l0QVBJ SW5qZWN0ZWRCdW5kbGVfUEFUSCBUQVJHRVQgVGVzdFdlYktpdEFQSUluamVjdGVkQnVuZGxlIFBS T1BFUlRZIExPQ0FUSU9OKQotCiBhZGRfZGVmaW5pdGlvbnMoLURHVEVTVF9MSU5LRURfQVNfU0hB UkVEX0xJQlJBUlk9MSAtREdURVNUX0hBU19SVFRJPTAKICAgICAtRFRFU1RfV0VCS0lUMl9SRVNP VVJDRVNfRElSPVwiJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0MlwiCi0gICAgLURU RVNUX0lOSkVDVEVEX0JVTkRMRV9QQVRIPVwiJHtUZXN0V2ViS2l0QVBJSW5qZWN0ZWRCdW5kbGVf UEFUSH1cIgorICAgIC1EVEVTVF9JTkpFQ1RFRF9CVU5ETEVfUEFUSD1cIiQ8VEFSR0VUX0ZJTEVf RElSOlRlc3RXZWJLaXRBUElJbmplY3RlZEJ1bmRsZT5cIgogKQogCiAjIEZJWE1FOiBUaGlzIHdv cmtzIGFyb3VuZCBjb21wYXRpYmlsaXR5IHByb2JsZW1zIGluIHRoZSBvbGQgdmVyc2lvbiBvZiB0 aGUgdGhpcmQtcGFyeQo=