145017 2015-05-14 13:32:34 -0700 Local storage origins should include origins with transient local storage 2015-05-14 14:44:56 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1094885 0 andersca 2015-05-14 13:32:34 -0700 Local storage origins should include origins with transient local storage 1094887 1 253141 andersca 2015-05-14 13:33:58 -0700 Created attachment 253141 Patch 1094889 2 commit-queue 2015-05-14 13:37:04 -0700 Attachment 253141 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Storage/StorageManager.cpp:529: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1094920 3 253141 sam 2015-05-14 14:39:02 -0700 Comment on attachment 253141 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253141&action=review > Source/WebKit2/ChangeLog:5 > + Local storage origins should include origins with transient local storage > + https://bugs.webkit.org/show_bug.cgi?id=145017 > + rdar://problem/10690447 I think this needs a clearer explanation. I assume this is transient local storage that is due to portioning, rather than private browsing mode. 1094923 4 andersca 2015-05-14 14:44:56 -0700 Committed r184356: <http://trac.webkit.org/changeset/184356> 253141 2015-05-14 13:33:58 -0700 2015-05-14 14:39:02 -0700 Patch bug-145017-20150514133235.patch text/plain 6785 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZiODVjZjNiYzU0YTEy MGEwYWEzY2RkYjZkNDIzODM4YzExYmQ5MC4uNWZhOTJmZjJhNjNiMDAwZjBkMzJlMDc3NWM4NmJh MDcyMGUyNDUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgTG9jYWwgc3RvcmFn ZSBvcmlnaW5zIHNob3VsZCBpbmNsdWRlIG9yaWdpbnMgd2l0aCB0cmFuc2llbnQgbG9jYWwgc3Rv cmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ1 MDE3CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzEwNjkwNDQ3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdl TWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlN0b3JhZ2VNYW5hZ2VyOjpUcmFuc2llbnRM b2NhbFN0b3JhZ2VOYW1lc3BhY2U6Om9yaWdpbnMpOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdl TWFuYWdlcjo6Z2V0TG9jYWxTdG9yYWdlT3JpZ2lucyk6CisgICAgICAgICogVUlQcm9jZXNzL1N0 b3JhZ2UvU3RvcmFnZU1hbmFnZXIuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViS2V5VmFsdWVT dG9yYWdlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYktleVZhbHVlU3RvcmFnZU1h bmFnZXI6OmdldEtleVZhbHVlU3RvcmFnZU9yaWdpbnMpOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0 ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhKToKKwogMjAxNS0wNS0xNCAgWmFuIERvYmVyc2VrICA8emRv YmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIG1pc3NpbmcgRU5BQkxFKE5F VFNDQVBFX1BMVUdJTl9BUEkpIGJ1aWxkIGd1YXJkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwCmluZGV4IDI3NjUyZmFlNmViYzNk ZmM3NTRlZTY4YjI0YjZmNzk2NzBhMWU5Y2IuLmQwYmIxMWQ5MTc5Zjc3NmYwZjE0Y2EwNjg2NWUy MGUyYTc5ZTdjZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdl L1N0b3JhZ2VNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFn ZS9TdG9yYWdlTWFuYWdlci5jcHAKQEAgLTEyOSw2ICsxMjksMTggQEAgcHVibGljOgogICAgICAg ICByZXR1cm4gc3RvcmFnZUFyZWE7CiAgICAgfQogCisgICAgVmVjdG9yPFJlZlB0cjxTZWN1cml0 eU9yaWdpbj4+IG9yaWdpbnMoKSBjb25zdAorICAgIHsKKyAgICAgICAgVmVjdG9yPFJlZlB0cjxT ZWN1cml0eU9yaWdpbj4+IG9yaWdpbnM7CisKKyAgICAgICAgZm9yIChjb25zdCBhdXRvJiBzdG9y YWdlQXJlYSA6IG1fc3RvcmFnZUFyZWFNYXAudmFsdWVzKCkpIHsKKyAgICAgICAgICAgIGlmICgh c3RvcmFnZUFyZWEtPml0ZW1zKCkuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIG9yaWdpbnMu YXBwZW5kKHN0b3JhZ2VBcmVhLT5zZWN1cml0eU9yaWdpbigpKTsKKyAgICAgICAgfQorCisgICAg ICAgIHJldHVybiBvcmlnaW5zOworICAgIH0KKwogICAgIHZvaWQgY2xlYXJTdG9yYWdlQXJlYXNN YXRjaGluZ09yaWdpbihjb25zdCBTZWN1cml0eU9yaWdpbiYgc2VjdXJpdHlPcmlnaW4pCiAgICAg ewogICAgICAgICBmb3IgKGF1dG8mIHN0b3JhZ2VBcmVhIDogbV9zdG9yYWdlQXJlYU1hcC52YWx1 ZXMoKSkgewpAQCAtNTE0LDEyICs1MjYsMjAgQEAgdm9pZCBTdG9yYWdlTWFuYWdlcjo6cHJvY2Vz c0RpZENsb3NlQ29ubmVjdGlvbihXZWJQcm9jZXNzUHJveHkmLCBJUEM6OkNvbm5lY3Rpb24KICAg ICB9KTsKIH0KIAotdm9pZCBTdG9yYWdlTWFuYWdlcjo6Z2V0TG9jYWxTdG9yYWdlT3JpZ2lucyhz dGQ6OmZ1bmN0aW9uPHZvaWQgKFZlY3RvcjxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+ Pik+IGNvbXBsZXRpb25IYW5kbGVyKQordm9pZCBTdG9yYWdlTWFuYWdlcjo6Z2V0TG9jYWxTdG9y YWdlT3JpZ2lucyhzdGQ6OmZ1bmN0aW9uPHZvaWQgKEhhc2hTZXQ8UmVmUHRyPFdlYkNvcmU6OlNl Y3VyaXR5T3JpZ2luPj4mJik+IGNvbXBsZXRpb25IYW5kbGVyKQogewogICAgIFJlZlB0cjxTdG9y YWdlTWFuYWdlcj4gc3RvcmFnZU1hbmFnZXIodGhpcyk7CiAKICAgICBtX3F1ZXVlLT5kaXNwYXRj aChbc3RvcmFnZU1hbmFnZXIsIGNvbXBsZXRpb25IYW5kbGVyXSB7Ci0gICAgICAgIGF1dG8gb3Jp Z2lucyA9IHN0b3JhZ2VNYW5hZ2VyLT5tX2xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci0+b3Jp Z2lucygpOworICAgICAgICBIYXNoU2V0PFJlZlB0cjxTZWN1cml0eU9yaWdpbj4+IG9yaWdpbnM7 CisKKyAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBzdG9yYWdlTWFuYWdlci0+bV9sb2NhbFN0 b3JhZ2VEYXRhYmFzZVRyYWNrZXItPm9yaWdpbnMoKSkKKyAgICAgICAgICAgIG9yaWdpbnMuYWRk KFdURjo6bW92ZShvcmlnaW4pKTsKKworICAgICAgICBmb3IgKGF1dG8mIHRyYW5zaWVudExvY2Fs U3RvcmFnZU5hbWVzcGFjZSA6IHN0b3JhZ2VNYW5hZ2VyLT5tX3RyYW5zaWVudExvY2FsU3RvcmFn ZU5hbWVzcGFjZXMudmFsdWVzKCkpIHsKKyAgICAgICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDog dHJhbnNpZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlLT5vcmlnaW5zKCkpCisgICAgICAgICAgICAg ICAgb3JpZ2lucy5hZGQoV1RGOjptb3ZlKG9yaWdpbikpOworICAgICAgICB9CiAKICAgICAgICAg UnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtvcmlnaW5zLCBjb21wbGV0aW9uSGFuZGxlcl0oKSBt dXRhYmxlIHsKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKFdURjo6bW92ZShvcmlnaW5z KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdl TWFuYWdlci5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvU3RvcmFnZU1hbmFn ZXIuaAppbmRleCAwYmY2MDczMzI1YTk5ZWFkODViMzg3MTJkYjJiMDkzMmZiZjcwYWZkLi4yYWFk NGEwYzgyOWQ5Y2RjNTljZDg3MzJiYmEzMWZiZmRiNDI2Y2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmgKQEAgLTI3LDggKzI3LDEw IEBACiAjZGVmaW5lIFN0b3JhZ2VNYW5hZ2VyX2gKIAogI2luY2x1ZGUgIkNvbm5lY3Rpb24uaCIK KyNpbmNsdWRlIDxXZWJDb3JlL1NlY3VyaXR5T3JpZ2luSGFzaC5oPgogI2luY2x1ZGUgPGNocm9u bz4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgorI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAj aW5jbHVkZSA8d3RmL1RocmVhZFNhZmVSZWZDb3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQv U3RyaW5nSGFzaC5oPgogCkBAIC01Nyw3ICs1OSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHByb2Nl c3NEaWRDbG9zZUNvbm5lY3Rpb24oV2ViUHJvY2Vzc1Byb3h5JiwgSVBDOjpDb25uZWN0aW9uJik7 CiAgICAgdm9pZCBhcHBsaWNhdGlvbldpbGxUZXJtaW5hdGUoKTsKIAotICAgIHZvaWQgZ2V0TG9j YWxTdG9yYWdlT3JpZ2lucyhzdGQ6OmZ1bmN0aW9uPHZvaWQgKFZlY3RvcjxSZWZQdHI8V2ViQ29y ZTo6U2VjdXJpdHlPcmlnaW4+Pik+IGNvbXBsZXRpb25IYW5kbGVyKTsKKyAgICB2b2lkIGdldExv Y2FsU3RvcmFnZU9yaWdpbnMoc3RkOjpmdW5jdGlvbjx2b2lkIChIYXNoU2V0PFJlZlB0cjxXZWJD b3JlOjpTZWN1cml0eU9yaWdpbj4+JiYpPiBjb21wbGV0aW9uSGFuZGxlcik7CiAgICAgdm9pZCBn ZXRMb2NhbFN0b3JhZ2VEZXRhaWxzQnlPcmlnaW4oc3RkOjpmdW5jdGlvbjx2b2lkIChWZWN0b3I8 TG9jYWxTdG9yYWdlRGV0YWlscz4pPiBjb21wbGV0aW9uSGFuZGxlcik7CiAgICAgdm9pZCBkZWxl dGVMb2NhbFN0b3JhZ2VFbnRyaWVzRm9yT3JpZ2luKGNvbnN0IFdlYkNvcmU6OlNlY3VyaXR5T3Jp Z2luJik7CiAgICAgdm9pZCBkZWxldGVBbGxMb2NhbFN0b3JhZ2VFbnRyaWVzKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViS2V5VmFsdWVTdG9yYWdlTWFuYWdlci5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViS2V5VmFsdWVTdG9yYWdlTWFuYWdlci5j cHAKaW5kZXggOTJiNmIwM2FhZmNmMWIzMGI1MzYwZTc0ZDllZWY0OWM5ZmM2NGE3NC4uOTEwOGU0 NjFhZWQwMjhjOWEwZmVlMjE5ZjRhOGY2ODhkMWFlOTE2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYktleVZhbHVlU3RvcmFnZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJLZXlWYWx1ZVN0b3JhZ2VNYW5hZ2VyLmNwcApAQCAtOTgs MTEgKzk4LDExIEBAIHZvaWQgV2ViS2V5VmFsdWVTdG9yYWdlTWFuYWdlcjo6Z2V0S2V5VmFsdWVT dG9yYWdlT3JpZ2lucyhzdGQ6OmZ1bmN0aW9uPHZvaWQgKEFQCiAgICAgICAgIHJldHVybjsKICAg ICB9CiAKLSAgICBzdG9yYWdlTWFuYWdlci0+Z2V0TG9jYWxTdG9yYWdlT3JpZ2lucyhbY2FsbGJh Y2tGdW5jdGlvbl0oVmVjdG9yPFJlZlB0cjxTZWN1cml0eU9yaWdpbj4+IHNlY3VyaXR5T3JpZ2lu cykgeworICAgIHN0b3JhZ2VNYW5hZ2VyLT5nZXRMb2NhbFN0b3JhZ2VPcmlnaW5zKFtjYWxsYmFj a0Z1bmN0aW9uXShIYXNoU2V0PFJlZlB0cjxTZWN1cml0eU9yaWdpbj4+JiYgc2VjdXJpdHlPcmln aW5zKSB7CiAgICAgICAgIFZlY3RvcjxSZWZQdHI8QVBJOjpPYmplY3Q+PiB3ZWJTZWN1cml0eU9y aWdpbnM7CiAgICAgICAgIHdlYlNlY3VyaXR5T3JpZ2lucy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5 KHNlY3VyaXR5T3JpZ2lucy5zaXplKCkpOwogICAgICAgICBmb3IgKGF1dG8mIG9yaWdpbiA6IHNl Y3VyaXR5T3JpZ2lucykKLSAgICAgICAgICAgIHdlYlNlY3VyaXR5T3JpZ2lucy51bmNoZWNrZWRB cHBlbmQoQVBJOjpTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKFdURjo6bW92ZShvcmlnaW4pKSk7Cisg ICAgICAgICAgICB3ZWJTZWN1cml0eU9yaWdpbnMudW5jaGVja2VkQXBwZW5kKEFQSTo6U2VjdXJp dHlPcmlnaW46OmNyZWF0ZShvcmlnaW4pKTsKIAogICAgICAgICBjYWxsYmFja0Z1bmN0aW9uKEFQ STo6QXJyYXk6OmNyZWF0ZShXVEY6Om1vdmUod2ViU2VjdXJpdHlPcmlnaW5zKSkucHRyKCksIENh bGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpOwogICAgIH0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4 IGQ1NjkxYTM4YjRiZWNhZWUzZTU3MTBjM2VjNDA2OWZlMDFjN2U3ZmIuLjNiZjk3OGVjYWZhMTEy NDYzMmZkMGI3N2VkMDVkYjU4M2ZkZWYxMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTI2OSwx MCArMjY5LDExIEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhKFdlYnNpdGVEYXRh VHlwZXMgZGF0YVR5cGVzLCBzdGQ6OmZ1bmN0aW9uPHZvaWQKICAgICBpZiAoZGF0YVR5cGVzICYg V2Vic2l0ZURhdGFUeXBlTG9jYWxTdG9yYWdlICYmIG1fc3RvcmFnZU1hbmFnZXIpIHsKICAgICAg ICAgY2FsbGJhY2tBZ2dyZWdhdG9yLT5hZGRQZW5kaW5nQ2FsbGJhY2soKTsKIAotICAgICAgICBt X3N0b3JhZ2VNYW5hZ2VyLT5nZXRMb2NhbFN0b3JhZ2VPcmlnaW5zKFtjYWxsYmFja0FnZ3JlZ2F0 b3JdKFZlY3RvcjxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+PiBvcmlnaW5zKSB7Cisg ICAgICAgIG1fc3RvcmFnZU1hbmFnZXItPmdldExvY2FsU3RvcmFnZU9yaWdpbnMoW2NhbGxiYWNr QWdncmVnYXRvcl0oSGFzaFNldDxSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+PiYmIG9y aWdpbnMpIHsKICAgICAgICAgICAgIFdlYnNpdGVEYXRhIHdlYnNpdGVEYXRhOwotICAgICAgICAg ICAgZm9yIChhdXRvJiBvcmlnaW4gOiBvcmlnaW5zKQotICAgICAgICAgICAgICAgIHdlYnNpdGVE YXRhLmVudHJpZXMuYXBwZW5kKFdlYnNpdGVEYXRhOjpFbnRyeSB7IFdURjo6bW92ZShvcmlnaW4p LCBXZWJzaXRlRGF0YVR5cGVMb2NhbFN0b3JhZ2UgfSk7CisKKyAgICAgICAgICAgIHdoaWxlICgh b3JpZ2lucy5pc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgd2Vic2l0ZURhdGEuZW50cmllcy5h cHBlbmQoV2Vic2l0ZURhdGE6OkVudHJ5IHsgb3JpZ2lucy50YWtlQW55KCksIFdlYnNpdGVEYXRh VHlwZUxvY2FsU3RvcmFnZSB9KTsKIAogICAgICAgICAgICAgY2FsbGJhY2tBZ2dyZWdhdG9yLT5y ZW1vdmVQZW5kaW5nQ2FsbGJhY2soV1RGOjptb3ZlKHdlYnNpdGVEYXRhKSk7CiAgICAgICAgIH0p Owo=