145014 2015-05-14 12:09:25 -0700 [CMake] Error out when ruby is too old 2015-05-14 17:10:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1221810 P2 Normal --- 1 mcatanzaro mcatanzaro berto commit-queue fpizlo mcatanzaro mrobinson oldest_to_newest 1094866 0 mcatanzaro 2015-05-14 12:09:25 -0700 The build should error out when running cmake if ruby is too old, not progress all the way to trying to build LLint files. 1094904 1 mcatanzaro 2015-05-14 14:19:20 -0700 Any ideas why this isn't currently marked as REQUIRED? It looks like it might have been omitted intentionally, but it's definitely mandatory to build JSC. 1094905 2 mcatanzaro 2015-05-14 14:20:30 -0700 Answer: # We cannot check for RUBY_FOUND because it is set only when the full package is installed and # the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro # for finding the only Ruby interpreter. if (NOT RUBY_EXECUTABLE) message(FATAL_ERROR "The Ruby interpreter is needed to generate LLInt files.") endif () 1094918 3 253146 mcatanzaro 2015-05-14 14:37:27 -0700 Created attachment 253146 Patch 1094972 4 253146 commit-queue 2015-05-14 17:10:21 -0700 Comment on attachment 253146 Patch Clearing flags on attachment: 253146 Committed r184363: <http://trac.webkit.org/changeset/184363> 1094973 5 commit-queue 2015-05-14 17:10:25 -0700 All reviewed patches have been landed. Closing bug. 253146 2015-05-14 14:37:27 -0700 2015-05-14 17:10:21 -0700 Patch bug-145014-20150514163604.patch text/plain 3049 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy OTkyZjgwZjIwZGU2YWQ4OGNkMTUyNmVjYTE5MjNhMmUwNGRmNjg5Li4yZjIxOTMxNzMwODNiMjgz ZTk4ZWQ4OTk3OGQ0M2Y1OTkxNGM1NTM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0wNS0xNCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBFcnJvciBvdXQgd2hlbiBydWJ5IGlzIHRvbyBv bGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTAx NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0 IGVuZm9yY2UgdGhlIGNoZWNrIGZvciB0aGUgUnVieSBleGVjdXRhYmxlIGhlcmU7IGl0J3Mgbm93 IGVuZm9yY2VkIGluIHRoZSB0b3AtbGV2ZWwKKyAgICAgICAgQ01ha2VMaXN0cy50eHQgaW5zdGVh ZC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE1LTA1LTEzICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE4MDU5NSk6IHNh bWUtY2FsbGVlIHByb2ZpbGluZyBubyBsb25nZXIgd29ya3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFr ZUxpc3RzLnR4dAppbmRleCBlNTMyMTU0MTk5MjU2YmE5NDExMzAzODk4MjUzZmY4ODNhZmFmYzY2 Li44MTc4MDYyNGRhNDNhYjUzMjc1MjkyNTMzODgwMDcwM2MwNDNhYjE5IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC02NjIsMTMgKzY2Miw2IEBAIGlmIChVU0VfVURJUzg2 KQogICAgICkKIGVuZGlmICgpCiAKLSMgV2UgY2Fubm90IGNoZWNrIGZvciBSVUJZX0ZPVU5EIGJl Y2F1c2UgaXQgaXMgc2V0IG9ubHkgd2hlbiB0aGUgZnVsbCBwYWNrYWdlIGlzIGluc3RhbGxlZCBh bmQKLSMgdGhlIG9ubHkgdGhpbmcgd2UgbmVlZCBpcyB0aGUgaW50ZXJwcmV0ZXIuIFVubGlrZSBQ eXRob24sIGNtYWtlIGRvZXMgbm90IHByb3ZpZGUgYSBtYWNybwotIyBmb3IgZmluZGluZyB0aGUg b25seSBSdWJ5IGludGVycHJldGVyLgotaWYgKE5PVCBSVUJZX0VYRUNVVEFCTEUpCi0gICAgbWVz c2FnZShGQVRBTF9FUlJPUiAiVGhlIFJ1YnkgaW50ZXJwcmV0ZXIgaXMgbmVlZGVkIHRvIGdlbmVy YXRlIExMSW50IGZpbGVzLiIpCi1lbmRpZiAoKQotCiBzZXQoTExJTlRfQVNNCiAgICAgbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlci5hc20KICAgICBsbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJf NjQuYXNtCmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBiL0NNYWtlTGlzdHMudHh0CmluZGV4 IDYxNzMzYzAyMGE4NjFmMzQ5NjQxZmEyNDlkM2M4NTk2NzQ2NDE1NTUuLjhiOTM2MWZkOTY3NmZi ODA0ZTIzYTRmYmU3MzdlYzRiOTZmMGRiZGYgMTAwNjQ0Ci0tLSBhL0NNYWtlTGlzdHMudHh0Cisr KyBiL0NNYWtlTGlzdHMudHh0CkBAIC02NSw3ICs2NSwxNCBAQCBmaW5kX3BhY2thZ2UoR3BlcmYg My4wLjEgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUGVybCA1LjEwLjAgUkVRVUlSRUQpCiAKIGZp bmRfcGFja2FnZShQeXRob25JbnRlcnAgMi43LjAgUkVRVUlSRUQpCisKKyMgV2UgY2Fubm90IGNo ZWNrIGZvciBSVUJZX0ZPVU5EIGJlY2F1c2UgaXQgaXMgc2V0IG9ubHkgd2hlbiB0aGUgZnVsbCBw YWNrYWdlIGlzIGluc3RhbGxlZCBhbmQKKyMgdGhlIG9ubHkgdGhpbmcgd2UgbmVlZCBpcyB0aGUg aW50ZXJwcmV0ZXIuIFVubGlrZSBQeXRob24sIGNtYWtlIGRvZXMgbm90IHByb3ZpZGUgYSBtYWNy bworIyBmb3IgZmluZGluZyBvbmx5IHRoZSBSdWJ5IGludGVycHJldGVyLgogZmluZF9wYWNrYWdl KFJ1YnkgMS44LjcpCitpZiAoTk9UIFJVQllfRVhFQ1VUQUJMRSBPUiBSVUJZX1ZFUlNJT04gVkVS U0lPTl9MRVNTIDEuOC43KQorICAgIG1lc3NhZ2UoRkFUQUxfRVJST1IgIlJ1YnkgMS44Ljcgb3Ig aGlnaGVyIGlzIHJlcXVpcmVkLiIpCitlbmRpZiAoKQogCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t CiAjIERldGVybWluZSB0aGUgdGFyZ2V0IHByb2Nlc3NvcgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDcwMWM4MWFlOGI0MjNhZTBmYjA2N2IzMGFkNDQ0NTI2N2UzNjAy ZTkuLjcxODZjOTA3OGM1MWQzZmMzYjUwMDkzZWM2ZWMxZWIzYzdiMmQ0OWEgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0wNS0xNCAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NN YWtlXSBFcnJvciBvdXQgd2hlbiBydWJ5IGlzIHRvbyBvbGQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NTAxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVycm9yIG91dCBpbW1lZGlhdGVseSBhZnRlciBj aGVja2luZyBmb3IgUnVieSBpZiB0aGUgcnVieSBleGVjdXRhYmxlIGlzIG5vdCBmb3VuZCwgb3Ig aWYgaXQKKyAgICAgICAgaXMgdG9vIG9sZC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0Ogor CiAyMDE1LTA1LTE0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBFbmFibGUgcGx1Z2luLXJlbGF0ZWQgQ01ha2Ugb3B0aW9ucyBhbmQgdmFyaWFi bGVzIGZvciB0aGUgWDExIHRhcmdldCBvbmx5Cg==