144995 2015-05-14 01:39:41 -0700 [GTK] Enable plugin-related CMake options and variables for the X11 target only 2015-05-14 03:53:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1094772 0 zan 2015-05-14 01:39:41 -0700 [GTK] Enable plugin-related CMake options for the X11 target only 1094773 1 253113 zan 2015-05-14 01:43:27 -0700 Created attachment 253113 Patch 1094777 2 253113 cgarcia 2015-05-14 02:15:59 -0700 Comment on attachment 253113 Patch I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it doesn't really work, so let's use this for now. 1094778 3 zan 2015-05-14 02:20:42 -0700 (In reply to comment #2) > Comment on attachment 253113 [details] > Patch > > I thought WEBKIT_OPTION_DEPEND could be used for this, but Zan told me it > doesn't really work, so let's use this for now. It turns out it does work, though it doesn't affect values in CMakeCache.txt but only those in cmakeconfig.h. Plus, it only works for configurable options (like ENABLE_NETSCAPE_PLUGIN_API and ENABLE_PLUGIN_PROCESS_GTK2) and not for ordinary variables like ENABLE_PLUGIN_PROCESS. 1094781 4 253116 zan 2015-05-14 02:26:59 -0700 Created attachment 253116 Patch for landing 1094787 5 253116 zan 2015-05-14 03:53:47 -0700 Comment on attachment 253116 Patch for landing Clearing flags on attachment: 253116 Committed r184335: <http://trac.webkit.org/changeset/184335> 1094788 6 zan 2015-05-14 03:53:53 -0700 All reviewed patches have been landed. Closing bug. 253113 2015-05-14 01:43:27 -0700 2015-05-14 02:26:53 -0700 Patch bug-144995-20150514014603.patch text/plain 2897 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDMz MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1 LTE0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBFbmFibGUgcGx1Z2luLXJlbGF0ZWQgQ01ha2Ugb3B0aW9ucyBhbmQgdmFyaWFibGVzIGZvciB0 aGUgWDExIHRhcmdldCBvbmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQ5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBQbHVnaW5zIGFyZSBv bmx5IHN1cHBvcnRlZCBmb3IKKyAgICAgICAgdGhlIFgxMSB3aW5kb3dpbmcgdGFyZ2V0IGF0IHRo ZSBtb21lbnQsIHNvIHRoZSBmb2xsb3dpbmcgb3B0aW9ucworICAgICAgICBhbmQgdmFyaWFibGVz IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQgYWNjb3JkaW5nbHk6CisgICAgICAgIC0gRU5B QkxFX1BMVUdJTl9QUk9DRVNTX0dUSzIKKyAgICAgICAgLSBFTkFCTEVfTkVUU0NBUEVfUExVR0lO X0FQSQorICAgICAgICAtIEVOQUJMRV9QTFVHSU5fUFJPQ0VTUworCiAyMDE1LTA1LTEyICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCiAgICAgICAgIExpbmtlciBmYWls cyB3aXRob3V0IC1EREVWRUxPUEVSX01PREU9T04KSW5kZXg6IFNvdXJjZS9jbWFrZS9PcHRpb25z R1RLLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCShy ZXZpc2lvbiAxODQzMzIpCisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQkod29ya2lu ZyBjb3B5KQpAQCAtNDksNyArNDksNyBAQCBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfR0xF UzIgIldoZXRoCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfR1RLRE9DICJXaGV0aGVyIG9y IG5vdCB0byB1c2UgZ2VuZXJhdGUgZ3RrZG9jLiIgUFVCTElDIE9GRikKIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9JTlRST1NQRUNUSU9OICJXaGV0aGVyIHRvIGVuYWJsZSBHT2JqZWN0IGlu dHJvc3BlY3Rpb24uIiBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfT1BF TkdMICJXaGV0aGVyIHRvIHVzZSBPcGVuR0wuIiBQVUJMSUMgT04pCi1XRUJLSVRfT1BUSU9OX0RF RklORShFTkFCTEVfUExVR0lOX1BST0NFU1NfR1RLMiAiV2hldGhlciB0byBidWlsZCBXZWJLaXRQ bHVnaW5Qcm9jZXNzMiB0byBsb2FkIEdUSzIgYmFzZWQgcGx1Z2lucy4iIFBVQkxJQyBPTikKK1dF QktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyICJXaGV0aGVyIHRv IGJ1aWxkIFdlYktpdFBsdWdpblByb2Nlc3MyIHRvIGxvYWQgR1RLMiBiYXNlZCBwbHVnaW5zLiIg UFVCTElDICR7RU5BQkxFX1gxMV9UQVJHRVR9KQogV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxF X1gxMV9UQVJHRVQgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBYMTEgd2luZG93 aW5nIHRhcmdldC4iIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV9XQVlM QU5EX1RBUkdFVCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFdheWxhbmQgd2lu ZG93aW5nIHRhcmdldC4iIFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfTElC Tk9USUZZICJXaGV0aGVyIHRvIGVuYWJsZSB0aGUgZGVmYXVsdCB3ZWIgbm90aWZpY2F0aW9uIGlt cGxlbWVudGF0aW9uLiIgUFVCTElDIE9OKQpAQCAtMTYzLDcgKzE2Myw3IEBAIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV8KIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9NSFRNTCBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX05BVklHQVRPUl9DT05URU5UX1VUSUxTIFBSSVZBVEUgT0ZGKQogV0VC S0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05BVklHQVRPUl9IV0NPTkNVUlJF TkNZIFBSSVZBVEUgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf TkVUU0NBUEVfUExVR0lOX0FQSSBQUklWQVRFIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkgUFJJVkFURSAke0VOQUJMRV9YMTFf VEFSR0VUfSkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9OT1RJRklD QVRJT05TIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfUVVPVEEgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF TkFCTEVfUkVTT0xVVElPTl9NRURJQV9RVUVSWSBQUklWQVRFIE9GRikKQEAgLTIwMiw3ICsyMDIs NyBAQCBlbmRpZiAoKQogc2V0KFVTRV9VRElTODYgT04pCiBzZXQoRU5BQkxFX1dFQktJVCBPRkYp CiBzZXQoRU5BQkxFX1dFQktJVDIgT04pCi1zZXQoRU5BQkxFX1BMVUdJTl9QUk9DRVNTIE9OKQor c2V0KEVOQUJMRV9QTFVHSU5fUFJPQ0VTUyAke0VOQUJMRV9YMTFfVEFSR0VUfSkKIAogYWRkX2Rl ZmluaXRpb25zKC1EQlVJTERJTkdfR1RLX189MSkKIGFkZF9kZWZpbml0aW9ucygtREdFVFRFWFRf UEFDS0FHRT0iV2ViS2l0MkdUSy0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0iKQo= 253116 2015-05-14 02:26:59 -0700 2015-05-14 02:26:59 -0700 Patch for landing bug-144995-20150514022935.patch text/plain 1884 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDMz MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1 LTE0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBFbmFibGUgcGx1Z2luLXJlbGF0ZWQgQ01ha2Ugb3B0aW9ucyBhbmQgdmFyaWFibGVzIGZvciB0 aGUgWDExIHRhcmdldCBvbmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDQ5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENh bXBvcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBQbHVnaW5z IGFyZSBvbmx5IHN1cHBvcnRlZCBmb3IKKyAgICAgICAgdGhlIFgxMSB3aW5kb3dpbmcgdGFyZ2V0 IGF0IHRoZSBtb21lbnQsIHNvIHRoZSBmb2xsb3dpbmcgb3B0aW9ucworICAgICAgICBhbmQgdmFy aWFibGVzIHNob3VsZCBiZSBlbmFibGVkIG9yIGRpc2FibGVkIGFjY29yZGluZ2x5OgorICAgICAg ICAtIEVOQUJMRV9QTFVHSU5fUFJPQ0VTU19HVEsyCisgICAgICAgIC0gRU5BQkxFX05FVFNDQVBF X1BMVUdJTl9BUEkKKyAgICAgICAgLSBFTkFCTEVfUExVR0lOX1BST0NFU1MKKwogMjAxNS0wNS0x MiAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAbmF2ZXJjb3JwLmNvbT4KIAogICAgICAgICBMaW5r ZXIgZmFpbHMgd2l0aG91dCAtRERFVkVMT1BFUl9NT0RFPU9OCkluZGV4OiBTb3VyY2UvY21ha2Uv T3B0aW9uc0dUSy5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5j bWFrZQkocmV2aXNpb24gMTg0MzMyKQorKysgU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UJ KHdvcmtpbmcgY29weSkKQEAgLTY4LDYgKzY4LDggQEAgV0VCS0lUX09QVElPTl9DT05GTElDVChF TkFCTEVfV0FZTEFORF9UQQogV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxFXzNEX1RSQU5TRk9S TVMgRU5BQkxFX09QRU5HTCkKIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9BQ0NFTEVSQVRF RF8yRF9DQU5WQVMgRU5BQkxFX09QRU5HTCkKIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9H TEVTMiBFTkFCTEVfT1BFTkdMKQorV0VCS0lUX09QVElPTl9ERVBFTkQoRU5BQkxFX05FVFNDQVBF X1BMVUdJTl9BUEkgRU5BQkxFX1gxMV9UQVJHRVQpCitXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFC TEVfUExVR0lOX1BST0NFU1NfR1RLMiBFTkFCTEVfWDExX1RBUkdFVCkKIFdFQktJVF9PUFRJT05f REVQRU5EKEVOQUJMRV9USFJFQURFRF9DT01QT1NJVE9SIEVOQUJMRV9PUEVOR0wpCiBXRUJLSVRf T1BUSU9OX0RFUEVORChFTkFCTEVfV0VCR0wgRU5BQkxFX09QRU5HTCkKIFdFQktJVF9PUFRJT05f REVQRU5EKFVTRV9SRURJUkVDVEVEX1hDT01QT1NJVEVfV0lORE9XIEVOQUJMRV9PUEVOR0wpCkBA IC0yMDIsNyArMjA0LDcgQEAgZW5kaWYgKCkKIHNldChVU0VfVURJUzg2IE9OKQogc2V0KEVOQUJM RV9XRUJLSVQgT0ZGKQogc2V0KEVOQUJMRV9XRUJLSVQyIE9OKQotc2V0KEVOQUJMRV9QTFVHSU5f UFJPQ0VTUyBPTikKK3NldChFTkFCTEVfUExVR0lOX1BST0NFU1MgJHtFTkFCTEVfWDExX1RBUkdF VH0pCiAKIGFkZF9kZWZpbml0aW9ucygtREJVSUxESU5HX0dUS19fPTEpCiBhZGRfZGVmaW5pdGlv bnMoLURHRVRURVhUX1BBQ0tBR0U9IldlYktpdDJHVEstJHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059 IikK