144994 2015-05-14 01:31:22 -0700 [GTK] Add missing ENABLE(NETSCAPE_PLUGIN_API) build guards 2015-05-14 02:35:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan berto cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1094769 0 zan 2015-05-14 01:31:22 -0700 [GTK] Add missing ENABLE(NETSCAPE_PLUGIN_API) build guards 1094770 1 253112 zan 2015-05-14 01:32:47 -0700 Created attachment 253112 Patch 1094771 2 commit-queue 2015-05-14 01:35:50 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1094784 3 253112 zan 2015-05-14 02:35:20 -0700 Comment on attachment 253112 Patch Clearing flags on attachment: 253112 Committed r184334: <http://trac.webkit.org/changeset/184334> 1094785 4 zan 2015-05-14 02:35:27 -0700 All reviewed patches have been landed. Closing bug. 253112 2015-05-14 01:32:47 -0700 2015-05-14 02:35:20 -0700 Patch bug-144994-20150514013523.patch text/plain 3224 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDMzMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA1LTE0ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgbWlzc2lu ZyBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkgYnVpbGQgZ3VhcmRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5OTQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpeGVzIHRoZSBidWlsZCB3 aGVuIGNvbmZpZ3VyZWQgd2l0aCBOZXRzY2FwZSBwbHVnaW4gQVBJCisgICAgICAgIHN1cHBvcnQg ZGlzYWJsZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0 LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfY29udGV4dF9zZXRfYWRkaXRpb25hbF9wbHVnaW5z X2RpcmVjdG9yeSk6CisgICAgICAgICh3ZWJraXRXZWJDb250ZXh0R2V0UGx1Z2luVGhyZWFkKToK KyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6CisKIDIw MTUtMDUtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtTT1VQXSBOZXR3b3JrIENhY2hlOiBOZXR3b3JrUHJvY2VzcyBzZWdmYXVsdCB3aGVu IGZpbGUgc3lzdGVtIGRvZXNuJ3Qgc3VwcG9ydCB4YXR0cnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCShyZXZp c2lvbiAxODQzMzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjY2LDcgKzY2Niw5IEBAIHZvaWQgd2Vi a2l0X3dlYl9jb250ZXh0X3NldF9hZGRpdGlvbmFsX3AKICAgICBnX3JldHVybl9pZl9mYWlsKFdF QktJVF9JU19XRUJfQ09OVEVYVChjb250ZXh0KSk7CiAgICAgZ19yZXR1cm5faWZfZmFpbChkaXJl Y3RvcnkpOwogCisjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgY29udGV4dC0+ cHJpdi0+Y29udGV4dC0+c2V0QWRkaXRpb25hbFBsdWdpbnNEaXJlY3RvcnkoV2ViQ29yZTo6Zmls ZW5hbWVUb1N0cmluZyhkaXJlY3RvcnkpKTsKKyNlbmRpZgogfQogCiBzdGF0aWMgdm9pZCBkZXN0 cm95UGx1Z2luTGlzdChHTGlzdCogcGx1Z2lucykKQEAgLTY3NiwxMCArNjc4LDEyIEBAIHN0YXRp YyB2b2lkIGRlc3Ryb3lQbHVnaW5MaXN0KEdMaXN0KiBwbHUKIAogc3RhdGljIHZvaWQgd2Via2l0 V2ViQ29udGV4dEdldFBsdWdpblRocmVhZChHVGFzayogdGFzaywgZ3BvaW50ZXIgb2JqZWN0LCBn cG9pbnRlciAvKiB0YXNrRGF0YSAqLywgR0NhbmNlbGxhYmxlKikKIHsKLSAgICBWZWN0b3I8UGx1 Z2luTW9kdWxlSW5mbz4gcGx1Z2lucyA9IFdFQktJVF9XRUJfQ09OVEVYVChvYmplY3QpLT5wcml2 LT5jb250ZXh0LT5wbHVnaW5JbmZvU3RvcmUoKS5wbHVnaW5zKCk7CiAgICAgR0xpc3QqIHJldHVy blZhbHVlID0gMDsKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKKyAgICBWZWN0b3I8 UGx1Z2luTW9kdWxlSW5mbz4gcGx1Z2lucyA9IFdFQktJVF9XRUJfQ09OVEVYVChvYmplY3QpLT5w cml2LT5jb250ZXh0LT5wbHVnaW5JbmZvU3RvcmUoKS5wbHVnaW5zKCk7CiAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBwbHVnaW5zLnNpemUoKTsgKytpKQogICAgICAgICByZXR1cm5WYWx1ZSA9 IGdfbGlzdF9wcmVwZW5kKHJldHVyblZhbHVlLCB3ZWJraXRQbHVnaW5DcmVhdGUocGx1Z2luc1tp XSkpOworI2VuZGlmCiAgICAgZ190YXNrX3JldHVybl9wb2ludGVyKHRhc2ssIHJldHVyblZhbHVl LCByZWludGVycHJldF9jYXN0PEdEZXN0cm95Tm90aWZ5PihkZXN0cm95UGx1Z2luTGlzdCkpOwog fQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NM YXVuY2hlckd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xh dW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwCShyZXZpc2lvbiAxODQzMzIpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDcgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6 OmxhdW5jaFByb2Nlc3MoKQogICAgIGNhc2UgV2ViUHJvY2VzczoKICAgICAgICAgZXhlY3V0YWJs ZVBhdGggPSBleGVjdXRhYmxlUGF0aE9mV2ViUHJvY2VzcygpOwogICAgICAgICBicmVhazsKKyNp ZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBjYXNlIFBsdWdpblByb2Nlc3M6CiAg ICAgICAgIGV4ZWN1dGFibGVQYXRoID0gZXhlY3V0YWJsZVBhdGhPZlBsdWdpblByb2Nlc3MoKTsK ICNpZiBFTkFCTEUoUExVR0lOX1BST0NFU1NfR1RLMikKQEAgLTc0LDYgKzc1LDcgQEAgdm9pZCBQ cm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgICAgICBwbHVnaW5QYXRoID0gbV9s YXVuY2hPcHRpb25zLmV4dHJhSW5pdGlhbGl6YXRpb25EYXRhLmdldCgicGx1Z2luLXBhdGgiKTsK ICAgICAgICAgcmVhbFBsdWdpblBhdGggPSBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGx1Z2lu UGF0aCk7CiAgICAgICAgIGJyZWFrOworI2VuZGlmCiAjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VT UykKICAgICBjYXNlIE5ldHdvcmtQcm9jZXNzOgogICAgICAgICBleGVjdXRhYmxlUGF0aCA9IGV4 ZWN1dGFibGVQYXRoT2ZOZXR3b3JrUHJvY2VzcygpOwo=