14499 2007-07-02 14:50:47 -0700 DOM history object is not updated properly 2010-01-18 23:55:40 -0800 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) All All RESOLVED DUPLICATE 24472 P2 Normal --- 1 just1gb webkit-unassigned ap johneseif oldest_to_newest 5710 0 just1gb 2007-07-02 14:50:47 -0700 new URLs entered into the address bar should be part of DOM history object Repro: 1) Load attached file into Safari on Windows 2) Then enter CNN.com in the address bar 3) Navigate CNN.com and browse couple of links deep 4) navigate back to the original test page 4) Click on link "Test History length" 5) History length would still show as "1" Other browsers like IE and Firefox update properly 5707 1 15355 just1gb 2007-07-02 14:51:47 -0700 Created attachment 15355 Launch the test to see why history object is not updated properly 5286 2 ddkilzer 2007-07-07 09:19:05 -0700 Confirmed that the history length differs in the attached test case using a local debug build of WebKit r24013 with Safari 3.0 (522.12) on Mac OS X 10.4.10. Note that there is a bug in the "Go to a specific index in history" feature since the text field has name="history_index_input" instead of id="history_index_input": window.history.go(document.getElementById('history_index_input').value); // bug 5280 3 ddkilzer 2007-07-07 09:22:17 -0700 The behavior is the same in Safari 2.0.4 (419.3) with original WebKit on Mac OS X 10.4.10 (8R218), so this is not a regression. 77612 4 johneseif 2008-04-14 13:50:44 -0700 I think the problem is in FrameLoader::getHistoryLength() return page->backForwardList()->backListCount() + 1; should be return page->backForwardList()->backListCount() + 1 + page->backForwardList()->forwardListCount(); to match Firefox. Without the +1, it would match IE (which also counts pages in the forward history). 182156 5 ap 2010-01-18 23:54:46 -0800 *** This bug has been marked as a duplicate of bug 24472 *** 15355 2007-07-02 14:51:47 -0700 2007-07-02 14:51:47 -0700 Launch the test to see why history object is not updated properly history.html text/html 1766 just1gb PEhUTUw+DQo8SEVBRD4NCjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+ICBhOmFjdGl2ZSB7Y29sb3I6 Z3JlZW59PC9zdHlsZT4NCjxUSVRMRT4gVEVTVCBDQVNFUyBGT1IgSElTVE9SWSBPQkpFQ1QgPC9U SVRMRT4NCjwvSEVBRD4NCg0KPEJPRFk+DQoNCjxhIGhyZWY9ImphdmFzY3JpcHQ6aGlzdG9yeS5i YWNrKCk7Ij4gR28gQmFjayA8L2E+IDxCUj4NCjxhIGhyZWY9ImphdmFzY3JpcHQ6aGlzdG9yeS5m b3J3YXJkKCk7Ij4gR28gRm9yd2FyZCA8L2E+IDxCUj4NCjxhIGhyZWY9ImphdmFzY3JpcHQ6dGVz dEhpc3RvcnlMZW5ndGgoKTsiPiBUZXN0IEhpc3RvcnkgbGVuZ3RoIDwvYT4gPEJSPg0KDQoNCjxm b3JtICBpZD0iZm9ybUlEIiBhY3Rpb249ImphdmFzY3JpcHQ6aGlzdG9yeUdvKCk7IiA+DQpHbyB0 byBhIHNwZWNpZmljIGluZGV4IGluIGhpc3Rvcnk6IDxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJo aXN0b3J5X2luZGV4X2lucHV0Ij4NCjxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJTdWJtaXQi Pg0KPC9mb3JtPg0KDQo8Zm9ybSAgaWQ9ImZvcm1JRCIgYWN0aW9uPSJqYXZhc2NyaXB0Omhpc3Rv cnlHb0J5VXJsKCk7IiA+DQpHbyB0byBhIHNwZWNpZmljIFVSTCBpbiBoaXN0b3J5OiA8aW5wdXQg dHlwZT0idGV4dCIgbmFtZT0iaGlzdG9yeV91cmxfaW5wdXQiPg0KPGlucHV0IHR5cGU9InN1Ym1p dCIgdmFsdWU9IlN1Ym1pdCI+IDxCUj4NCjwvZm9ybT4NCg0KPEJSPg0KQUxMIEhJU1RPUlkgUFJP UEVSVElFUyA8QlI+DQo8ZGl2IGlkPSJ3aW5kb3dQcm9wRGlzcGxheURpdiIgc3R5bGU9ImJhY2tn cm91bmQ6I0FBQUFBQTsiPiBSRVNVTFQgT0YgVEVTVCBDQVNFUyA8L2Rpdj4gPEJSPg0KDQo8c2Ny aXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+DQoNCi8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8NCi8vIEtlZXAgYXBwZW5kaW5nIHRvIGdsb2JhbCBzdHJpbmcNCi8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8NCnZhciBkaXNwbGF5TWVzc2FnZSA9ICIiOw0K ZnVuY3Rpb24gYWRkVG9EaXNwbGF5TWVzc2FnZShzdHIpIHsNCglkaXNwbGF5TWVzc2FnZSArPSBz dHI7DQoJZGlzcGxheU1lc3NhZ2UgKz0gIjxCUj4iOw0KCWRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd3aW5kb3dQcm9wRGlzcGxheURpdicpLmlubmVySFRNTCA9IGRpc3BsYXlNZXNzYWdlOw0KfQ0K DQpmdW5jdGlvbiB0ZXN0SGlzdG9yeUxlbmd0aCgpIHsNCiAgdmFyIHN0ciA9ICJIaXN0b3J5IExl bmd0aCA9ICIgKyBoaXN0b3J5Lmxlbmd0aDsNCiAgYWRkVG9EaXNwbGF5TWVzc2FnZShzdHIpOw0K fQ0KDQpmdW5jdGlvbiBoaXN0b3J5R29CeVVybCgpIHsNCiAgd2luZG93Lmhpc3RvcnkuZ28oZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2hpc3RvcnlfdXJsX2lucHV0JykudmFsdWUpOw0KfQ0KDQpm dW5jdGlvbiBoaXN0b3J5R28oKSB7DQogIHdpbmRvdy5oaXN0b3J5LmdvKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdoaXN0b3J5X2luZGV4X2lucHV0JykudmFsdWUpOw0KfQ0KLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8NCi8vIExvYWQgdGhpcyBhZnRlciBsb2FkaW5nIG9m IHdlYnBhZ2UNCi8vIGluc3RlYWQgb2YgY2FsbGluZyBpbiBnbG9iYWwgc2NvcGUNCi8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vDQpvbmxvYWQ9IGZ1bmN0aW9uKCkgew0KCXRl c3RIaXN0b3J5TGVuZ3RoKCk7DQp9DQoNCjwvc2NyaXB0Pg0KDQoNCjwvQk9EWT4NCjwvSFRNTD4=