<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>144989</bug_id>
          
          <creation_ts>2015-05-13 23:15:53 -0700</creation_ts>
          <short_desc>[SOUP] Use st_birthtime on FreeBSD and NetBSD instead of setting xattr</short_desc>
          <delta_ts>2015-05-19 09:37:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ting-Wei Lan">lantw44</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ajacoutot</cc>
    
    <cc>benjamin</cc>
    
    <cc>cgarcia</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1094736</commentid>
    <comment_count>0</comment_count>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2015-05-13 23:15:53 -0700</bug_when>
    <thetext>FreeBSD and NetBSD have st_birthtime in struct stat, so we can easily get creation time of files without manually setting xattr. There is existing code for PLATFORM(COCOA), and we can just reuse it.

FreeBSD xattr API is incompatible with Linux xattr API, so GLib doesn&apos;t support it. st_birthtime works on both UFS2 and tmpfs.
NetBSD xattr has a compatible interface with Linux xattr, but it is only supported on old filesystem such as UFS1. st_birthtime works on both UFS2 and tmpfs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094737</commentid>
    <comment_count>1</comment_count>
      <attachid>253099</attachid>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2015-05-13 23:19:46 -0700</bug_when>
    <thetext>Created attachment 253099
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1094758</commentid>
    <comment_count>2</comment_count>
      <attachid>253099</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-14 00:35:49 -0700</bug_when>
    <thetext>Comment on attachment 253099
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253099&amp;action=review

&gt; Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h:80
&gt; -#if PLATFORM(COCOA)
&gt; +#if PLATFORM(COCOA) || (USE(SOUP) &amp;&amp; (OS(DARWIN) || OS(FREEBSD) || OS(NETBSD)))

Maybe we could simplify this by defining a macro for this in WTF/wtf/Platform.h, something like HAVE_STAT_BIRTHTIME or something similar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095430</commentid>
    <comment_count>3</comment_count>
      <attachid>253272</attachid>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2015-05-16 11:48:11 -0700</bug_when>
    <thetext>Created attachment 253272
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095550</commentid>
    <comment_count>4</comment_count>
      <attachid>253272</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-17 23:24:02 -0700</bug_when>
    <thetext>Comment on attachment 253272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253272&amp;action=review

&gt; Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h:80
&gt; -#if PLATFORM(COCOA)
&gt; +#if PLATFORM(COCOA) || (USE(SOUP) &amp;&amp; HAVE(STAT_BIRTHTIME))

I think we could use just #if HAVE(STAT_BIRTHTIME)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095618</commentid>
    <comment_count>5</comment_count>
      <attachid>253272</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2015-05-18 08:39:27 -0700</bug_when>
    <thetext>Comment on attachment 253272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253272&amp;action=review

&gt;&gt; Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h:80
&gt;&gt; +#if PLATFORM(COCOA) || (USE(SOUP) &amp;&amp; HAVE(STAT_BIRTHTIME))
&gt; 
&gt; I think we could use just #if HAVE(STAT_BIRTHTIME)

Yes, that’s right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095923</commentid>
    <comment_count>6</comment_count>
      <attachid>253384</attachid>
    <who name="Ting-Wei Lan">lantw44</who>
    <bug_when>2015-05-19 07:03:41 -0700</bug_when>
    <thetext>Created attachment 253384
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095929</commentid>
    <comment_count>7</comment_count>
      <attachid>253384</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 08:12:21 -0700</bug_when>
    <thetext>Comment on attachment 253384
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095972</commentid>
    <comment_count>8</comment_count>
      <attachid>253384</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-19 09:37:19 -0700</bug_when>
    <thetext>Comment on attachment 253384
Patch

Clearing flags on attachment: 253384

Committed r184567: &lt;http://trac.webkit.org/changeset/184567&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095973</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-05-19 09:37:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>253099</attachid>
            <date>2015-05-13 23:19:46 -0700</date>
            <delta_ts>2015-05-16 11:48:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-144989-20150514141745.patch</filename>
            <type>text/plain</type>
            <size>3519</size>
            <attacher name="Ting-Wei Lan">lantw44</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjg2NDkyYzJlZTMwOWIz
OGFkMjVlZTIzNDZiMjAwYTdkZTJjNDM0ZS4uZGY5NmJjZmViMzcxYWY3MWZjNzNhN2ZjZWE1NmM5
OGNhOWJhM2JmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTEzICBUaW5n
LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBbU09VUF0gVXNlIHN0X2Jp
cnRodGltZSB0byBnZXQgY3JlYXRpb24gdGltZSBvZiBmaWxlcyBvbiBzeXN0ZW1zIHN1cHBvcnQg
aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDk4
OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWVC
U0QgYW5kIE5ldEJTRCBoYXZlIGVpdGhlciBzdF9iaXJ0aHRpbWUgZmllbGQgb3IgY29tcGF0aWJs
aXR5IG1hY3JvCisgICAgICAgIHdpdGggdGhlIHNhbWUgbmFtZSBpbiBzdGF0LiBJdCBpcyBiZXR0
ZXIgdG8gdXNlIGl0IGluc3RlYWQgb2YgbWFudWFsbHkKKyAgICAgICAgc2V0dGluZyB4YXR0ciwg
d2hpY2ggaXMgdW5yZWxpYWJsZSBiZWNhdXNlIGJvdGggb3BlcmF0aW5nIHN5c3RlbXMgYW5kCisg
ICAgICAgIGZpbGUgc3lzdGVtcyBzdXBwb3J0IGFyZSByZXF1aXJlZC4KKworICAgICAgICAqIE5l
dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oOgorICAgICAg
ICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OmZpbGVUaW1lcyk6CisgICAgICAgICogTmV0d29ya1By
b2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsU291cC5jcHA6CisgICAgICAgIChXZWJL
aXQ6Ok5ldHdvcmtDYWNoZTo6SU9DaGFubmVsOjpJT0NoYW5uZWwpOgorCiAyMDE1LTA1LTEzICBD
YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09V
UF0gTmV0d29yayBDYWNoZTogTmV0d29ya1Byb2Nlc3Mgc2VnZmF1bHQgd2hlbiBmaWxlIHN5c3Rl
bSBkb2Vzbid0IHN1cHBvcnQgeGF0dHJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3
b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVGaWxlU3lzdGVtUG9zaXguaCBiL1NvdXJjZS9X
ZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5o
CmluZGV4IGJhNWU0OTg2ZTMxNGE2MDRmOWVkODFhNDBiZDJiODQ3ZWM4MzViODUuLjljMDRjYTJk
OTExNDBiYWI5MGQ4YWY4YzJkNjk4MGRlNjU5ZDM3ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oCisr
KyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVT
eXN0ZW1Qb3NpeC5oCkBAIC03NywxMyArNzcsMTIgQEAgc3RydWN0IEZpbGVUaW1lcyB7CiAKIGlu
bGluZSBGaWxlVGltZXMgZmlsZVRpbWVzKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKLSNpZiBQTEFU
Rk9STShDT0NPQSkKKyNpZiBQTEFURk9STShDT0NPQSkgfHwgKFVTRShTT1VQKSAmJiAoT1MoREFS
V0lOKSB8fCBPUyhGUkVFQlNEKSB8fCBPUyhORVRCU0QpKSkKICAgICBzdHJ1Y3Qgc3RhdCBmaWxl
SW5mbzsKICAgICBpZiAoc3RhdChXZWJDb3JlOjpmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0
aCkuZGF0YSgpLCAmZmlsZUluZm8pKQogICAgICAgICByZXR1cm4geyB9OwogICAgIHJldHVybiB7
IHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OmZyb21fdGltZV90KGZpbGVJbmZvLnN0X2JpcnRo
dGltZSksIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OmZyb21fdGltZV90KGZpbGVJbmZvLnN0
X210aW1lKSB9OwotI2VuZGlmCi0jaWYgVVNFKFNPVVApCisjZWxpZiBVU0UoU09VUCkKICAgICAv
LyBUaGVyZSdzIG5vIHN0X2JpcnRodGltZSBpbiBzb21lIG9wZXJhdGluZyBzeXN0ZW1zIGxpa2Ug
TGludXgsIHNvIHdlIHVzZSB4YXR0cnMgdG8gc2V0L2dldCB0aGUgY3JlYXRpb24gdGltZS4KICAg
ICBHUmVmUHRyPEdGaWxlPiBmaWxlID0gYWRvcHRHUmVmKGdfZmlsZV9uZXdfZm9yX3BhdGgoV2Vi
Q29yZTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKHBhdGgpLmRhdGEoKSkpOwogICAgIEdSZWZQ
dHI8R0ZpbGVJbmZvPiBmaWxlSW5mbyA9IGFkb3B0R1JlZihnX2ZpbGVfcXVlcnlfaW5mbyhmaWxl
LmdldCgpLCAieGF0dHI6OmJpcnRodGltZSx0aW1lOjptb2RpZmllZCIsIEdfRklMRV9RVUVSWV9J
TkZPX05PTkUsIG51bGxwdHIsIG51bGxwdHIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy
L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUlPQ2hhbm5lbFNvdXAuY3BwIGIvU291
cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsU291
cC5jcHAKaW5kZXggNTkxMDIyYzk3ZDAwZmU4ZDMzZGZmNGQzNzMzNmIzN2I1ZWY0NGM3Yy4uN2I2
MzU5NDE3NTgzMjIwNzhkNjA3YTIzNmYxNzZiYTE0YzM0Mzc4MSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsU291cC5j
cHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl
SU9DaGFubmVsU291cC5jcHAKQEAgLTQ5LDggKzQ5LDEwIEBAIElPQ2hhbm5lbDo6SU9DaGFubmVs
KGNvbnN0IFN0cmluZyYgZmlsZVBhdGgsIFR5cGUgdHlwZSkKICAgICAgICAgZ19maWxlX2RlbGV0
ZShmaWxlLmdldCgpLCBudWxscHRyLCBudWxscHRyKTsKICAgICAgICAgbV9vdXRwdXRTdHJlYW0g
PSBhZG9wdEdSZWYoR19PVVRQVVRfU1RSRUFNKGdfZmlsZV9jcmVhdGUoZmlsZS5nZXQoKSwgc3Rh
dGljX2Nhc3Q8R0ZpbGVDcmVhdGVGbGFncz4oR19GSUxFX0NSRUFURV9QUklWQVRFKSwgbnVsbHB0
ciwgbnVsbHB0cikpKTsKICAgICAgICAgQVNTRVJUKG1fb3V0cHV0U3RyZWFtKTsKKyNpZiAhKE9T
KERBUldJTikgfHwgT1MoRlJFRUJTRCkgfHwgT1MoTkVUQlNEKSkKICAgICAgICAgR1VuaXF1ZVB0
cjxjaGFyPiBiaXJ0aHRpbWVTdHJpbmcoZ19zdHJkdXBfcHJpbnRmKCIlIiBHX0dVSU5UNjRfRk9S
TUFULCBzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0b190aW1lX3Qoc3RkOjpjaHJvbm86OnN5
c3RlbV9jbG9jazo6bm93KCkpKSk7CiAgICAgICAgIGdfZmlsZV9zZXRfYXR0cmlidXRlX3N0cmlu
ZyhmaWxlLmdldCgpLCAieGF0dHI6OmJpcnRodGltZSIsIGJpcnRodGltZVN0cmluZy5nZXQoKSwg
R19GSUxFX1FVRVJZX0lORk9fTk9ORSwgbnVsbHB0ciwgbnVsbHB0cik7CisjZW5kaWYKICAgICAg
ICAgYnJlYWs7CiAgICAgfQogICAgIGNhc2UgVHlwZTo6V3JpdGU6IHsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>253272</attachid>
            <date>2015-05-16 11:48:11 -0700</date>
            <delta_ts>2015-05-19 07:03:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-144989-20150517024645.patch</filename>
            <type>text/plain</type>
            <size>4631</size>
            <attacher name="Ting-Wei Lan">lantw44</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM1NTI2MjcyNjUzNzk4NGRhM2JmMWM5
NTY4YjM2ZDZmZWNlMzYwMmQuLmFlMmU1NzZkOWExNjQwYmYyODEzZDE5OTE4M2YyNDNlZGQ3NzE0
MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDUtMTYgIFRpbmctV2VpIExhbiAgPGxhbnR3
NDRAZ21haWwuY29tPgorCisgICAgICAgIFtTT1VQXSBVc2Ugc3RfYmlydGh0aW1lIHRvIGdldCBj
cmVhdGlvbiB0aW1lIG9mIGZpbGVzIG9uIHN5c3RlbXMgc3VwcG9ydCBpdAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTg5CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVmaW5lIEhBVkUoU1RBVF9CSVJU
SFRJTUUpIGFzIDEgb24gb3BlcmF0aW5nIHN5c3RlbXMgc3VwcG9ydGluZworICAgICAgICBnZXR0
aW5nIGNyZWF0aW9uIHRpbWUgb2YgZmlsZXMgdXNpbmcgc3RfYmlydGh0aW1lIGluIHN0YXQuCisK
KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNS0wNS0xNSAgRGFuIEJlcm5zdGVpbiAg
PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3Igc29tZSB2ZXJzaW9ucyBv
ZiBjbGFuZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9X
ZWJLaXQyL0NoYW5nZUxvZwppbmRleCAzMTcyZGY4YzY5NWY1ZDhmZjdhN2RjMTMzZTUzMWFmZjY2
MWRmZTM3Li5jNjRkMzVlOWJmNzJmZjQ3ZjcxZjBjMWZiYTIyMzdkN2Q2MzMyY2FmIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTUtMDUtMTYgIFRpbmctV2VpIExhbiAgPGxhbnR3NDRA
Z21haWwuY29tPgorCisgICAgICAgIFtTT1VQXSBVc2Ugc3RfYmlydGh0aW1lIHRvIGdldCBjcmVh
dGlvbiB0aW1lIG9mIGZpbGVzIG9uIHN5c3RlbXMgc3VwcG9ydCBpdAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTg5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJlZUJTRCBhbmQgTmV0QlNEIGhhdmUg
ZWl0aGVyIHN0X2JpcnRodGltZSBmaWVsZCBvciBjb21wYXRpYmxpdHkgbWFjcm8KKyAgICAgICAg
d2l0aCB0aGUgc2FtZSBuYW1lIGluIHN0YXQuIEl0IGlzIGJldHRlciB0byB1c2UgaXQgaW5zdGVh
ZCBvZiBtYW51YWxseQorICAgICAgICBzZXR0aW5nIHhhdHRyLCB3aGljaCBpcyB1bnJlbGlhYmxl
IGJlY2F1c2UgYm90aCBvcGVyYXRpbmcgc3lzdGVtcyBhbmQKKyAgICAgICAgZmlsZSBzeXN0ZW1z
IHN1cHBvcnQgYXJlIHJlcXVpcmVkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUv
TmV0d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4Lmg6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtD
YWNoZTo6ZmlsZVRpbWVzKToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3Jr
Q2FjaGVJT0NoYW5uZWxTb3VwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjpJ
T0NoYW5uZWw6OklPQ2hhbm5lbCk6CisKIDIwMTUtMDUtMTUgIFlvbmdqdW4gWmhhbmcgIDx5b25n
anVuX3poYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCByZXNldCB0aGUgcHJldmlldyBy
ZWNvZ25pemVyIGluIFtXS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24gY2xlYW51cEludGVyYWN0aW9u
XQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3Rm
L1BsYXRmb3JtLmgKaW5kZXggODc1OTRjYjZkMDllOGRkZWFiODU2ZjBlNWM4MDM1MDNmZWMxNDM3
NS4uYTU5ODQ3NGJmYTllNTBhMWNhMWRkZTVmYTJlMTkxMTU3MDU3MTI0MiAxMDA2NDQKLS0tIGEv
U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o
CkBAIC02MDUsNiArNjA1LDEwIEBACiAjZW5kaWYKICNlbmRpZgogCisjaWYgT1MoREFSV0lOKSB8
fCBPUyhGUkVFQlNEKSB8fCBPUyhORVRCU0QpCisjZGVmaW5lIEhBVkVfU1RBVF9CSVJUSFRJTUUg
MQorI2VuZGlmCisKICNpZiAhT1MoV0lORE9XUykgJiYgIU9TKFNPTEFSSVMpCiAjZGVmaW5lIEhB
VkVfVE1fR01UT0ZGIDEKICNkZWZpbmUgSEFWRV9UTV9aT05FIDEKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3Np
eC5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlRmls
ZVN5c3RlbVBvc2l4LmgKaW5kZXggYmE1ZTQ5ODZlMzE0YTYwNGY5ZWQ4MWE0MGJkMmI4NDdlYzgz
NWI4NS4uNzAwNmIyNjI5ZTllYWQ1MzQyYzViNGVlMWE4Mzk3NDFkOWJiNjYzNyAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlRmlsZVN5
c3RlbVBvc2l4LmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0
d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4LmgKQEAgLTc3LDEzICs3NywxMiBAQCBzdHJ1Y3QgRmls
ZVRpbWVzIHsKIAogaW5saW5lIEZpbGVUaW1lcyBmaWxlVGltZXMoY29uc3QgU3RyaW5nJiBwYXRo
KQogewotI2lmIFBMQVRGT1JNKENPQ09BKQorI2lmIFBMQVRGT1JNKENPQ09BKSB8fCAoVVNFKFNP
VVApICYmIEhBVkUoU1RBVF9CSVJUSFRJTUUpKQogICAgIHN0cnVjdCBzdGF0IGZpbGVJbmZvOwog
ICAgIGlmIChzdGF0KFdlYkNvcmU6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihwYXRoKS5kYXRh
KCksICZmaWxlSW5mbykpCiAgICAgICAgIHJldHVybiB7IH07CiAgICAgcmV0dXJuIHsgc3RkOjpj
aHJvbm86OnN5c3RlbV9jbG9jazo6ZnJvbV90aW1lX3QoZmlsZUluZm8uc3RfYmlydGh0aW1lKSwg
c3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6ZnJvbV90aW1lX3QoZmlsZUluZm8uc3RfbXRpbWUp
IH07Ci0jZW5kaWYKLSNpZiBVU0UoU09VUCkKKyNlbGlmIFVTRShTT1VQKQogICAgIC8vIFRoZXJl
J3Mgbm8gc3RfYmlydGh0aW1lIGluIHNvbWUgb3BlcmF0aW5nIHN5c3RlbXMgbGlrZSBMaW51eCwg
c28gd2UgdXNlIHhhdHRycyB0byBzZXQvZ2V0IHRoZSBjcmVhdGlvbiB0aW1lLgogICAgIEdSZWZQ
dHI8R0ZpbGU+IGZpbGUgPSBhZG9wdEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChXZWJDb3JlOjpm
aWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCkuZGF0YSgpKSk7CiAgICAgR1JlZlB0cjxHRmls
ZUluZm8+IGZpbGVJbmZvID0gYWRvcHRHUmVmKGdfZmlsZV9xdWVyeV9pbmZvKGZpbGUuZ2V0KCks
ICJ4YXR0cjo6YmlydGh0aW1lLHRpbWU6Om1vZGlmaWVkIiwgR19GSUxFX1FVRVJZX0lORk9fTk9O
RSwgbnVsbHB0ciwgbnVsbHB0cikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29y
a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlSU9DaGFubmVsU291cC5jcHAgYi9Tb3VyY2UvV2Vi
S2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxTb3VwLmNwcApp
bmRleCA1OTEwMjJjOTdkMDBmZThkMzNkZmY0ZDM3MzM2YjM3YjVlZjQ0YzdjLi44M2M3OTdhN2Ey
YjBiNmZlYjE5OTBiZTc0MzAxNzhjY2RiZjMyZmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxTb3VwLmNwcAorKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5u
ZWxTb3VwLmNwcApAQCAtNDksOCArNDksMTAgQEAgSU9DaGFubmVsOjpJT0NoYW5uZWwoY29uc3Qg
U3RyaW5nJiBmaWxlUGF0aCwgVHlwZSB0eXBlKQogICAgICAgICBnX2ZpbGVfZGVsZXRlKGZpbGUu
Z2V0KCksIG51bGxwdHIsIG51bGxwdHIpOwogICAgICAgICBtX291dHB1dFN0cmVhbSA9IGFkb3B0
R1JlZihHX09VVFBVVF9TVFJFQU0oZ19maWxlX2NyZWF0ZShmaWxlLmdldCgpLCBzdGF0aWNfY2Fz
dDxHRmlsZUNyZWF0ZUZsYWdzPihHX0ZJTEVfQ1JFQVRFX1BSSVZBVEUpLCBudWxscHRyLCBudWxs
cHRyKSkpOwogICAgICAgICBBU1NFUlQobV9vdXRwdXRTdHJlYW0pOworI2lmICFIQVZFKFNUQVRf
QklSVEhUSU1FKQogICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IGJpcnRodGltZVN0cmluZyhnX3N0
cmR1cF9wcmludGYoIiUiIEdfR1VJTlQ2NF9GT1JNQVQsIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xv
Y2s6OnRvX3RpbWVfdChzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjpub3coKSkpKTsKICAgICAg
ICAgZ19maWxlX3NldF9hdHRyaWJ1dGVfc3RyaW5nKGZpbGUuZ2V0KCksICJ4YXR0cjo6YmlydGh0
aW1lIiwgYmlydGh0aW1lU3RyaW5nLmdldCgpLCBHX0ZJTEVfUVVFUllfSU5GT19OT05FLCBudWxs
cHRyLCBudWxscHRyKTsKKyNlbmRpZgogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBU
eXBlOjpXcml0ZTogewo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>253384</attachid>
            <date>2015-05-19 07:03:41 -0700</date>
            <delta_ts>2015-05-19 09:37:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-144989-20150519220337.patch</filename>
            <type>text/plain</type>
            <size>4556</size>
            <attacher name="Ting-Wei Lan">lantw44</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0NTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIyMTQwZTgxYWE2ZTA2Y2FhOTcyZGI5
MTY1MjJhNDYyNzA4YzZhZTUuLjRhYjk4M2YzYjFjMDZhMTk4MmEzZDhiY2YzZDMxYTY0YTM1NDc5
OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDUtMTkgIFRpbmctV2VpIExhbiAgPGxhbnR3
NDRAZ21haWwuY29tPgorCisgICAgICAgIFtTT1VQXSBVc2Ugc3RfYmlydGh0aW1lIHRvIGdldCBj
cmVhdGlvbiB0aW1lIG9mIGZpbGVzIG9uIHN5c3RlbXMgc3VwcG9ydCBpdAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTg5CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVmaW5lIEhBVkUoU1RBVF9CSVJU
SFRJTUUpIGFzIDEgb24gb3BlcmF0aW5nIHN5c3RlbXMgc3VwcG9ydGluZworICAgICAgICBnZXR0
aW5nIGNyZWF0aW9uIHRpbWUgb2YgZmlsZXMgdXNpbmcgc3RfYmlydGh0aW1lIGluIHN0YXQuCisK
KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNS0wNS0xOSAgQ2hyaXMgRHVtZXogIDxj
ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1hcmsgc3RhdGljIHZhcmlhYmxlcyBhcyBjb25z
dCB3aGVuIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T
b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGQ4Y2U0NjlhZTQzYzVhZGUxMWUyODJjNjFi
Y2YxNGI4MzRhNTc1Yy4uMjE3ODE5YmU4ZDNhYmVhNjlhYWZiZmI3YjYwODE3ODQ2YzkxMWYzYyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA1LTE5ICBUaW5nLVdlaSBMYW4gIDxs
YW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBbU09VUF0gVXNlIHN0X2JpcnRodGltZSB0byBn
ZXQgY3JlYXRpb24gdGltZSBvZiBmaWxlcyBvbiBzeXN0ZW1zIHN1cHBvcnQgaXQKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDk4OQorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWVCU0QgYW5kIE5ldEJT
RCBoYXZlIGVpdGhlciBzdF9iaXJ0aHRpbWUgZmllbGQgb3IgY29tcGF0aWJsaXR5IG1hY3JvCisg
ICAgICAgIHdpdGggdGhlIHNhbWUgbmFtZSBpbiBzdGF0LiBJdCBpcyBiZXR0ZXIgdG8gdXNlIGl0
IGluc3RlYWQgb2YgbWFudWFsbHkKKyAgICAgICAgc2V0dGluZyB4YXR0ciwgd2hpY2ggaXMgdW5y
ZWxpYWJsZSBiZWNhdXNlIGJvdGggb3BlcmF0aW5nIHN5c3RlbXMgYW5kCisgICAgICAgIGZpbGUg
c3lzdGVtcyBzdXBwb3J0IGFyZSByZXF1aXJlZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz
L2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oOgorICAgICAgICAoV2ViS2l0OjpO
ZXR3b3JrQ2FjaGU6OmZpbGVUaW1lcyk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUv
TmV0d29ya0NhY2hlSU9DaGFubmVsU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtD
YWNoZTo6SU9DaGFubmVsOjpJT0NoYW5uZWwpOgorCiAyMDE1LTA1LTE5ICBDaHJpcyBEdW1leiAg
PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBzdGF0aWMgdmFyaWFibGVzIGFzIGNv
bnN0IHdoZW4gcG9zc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgg
Yi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDg3NTk0Y2I2ZDA5ZThkZGVhYjg1NmYw
ZTVjODAzNTAzZmVjMTQzNzUuLmE1OTg0NzRiZmE5ZTUwYTFjYTFkZGU1ZmEyZTE5MTE1NzA1NzEy
NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dU
Ri93dGYvUGxhdGZvcm0uaApAQCAtNjA1LDYgKzYwNSwxMCBAQAogI2VuZGlmCiAjZW5kaWYKIAor
I2lmIE9TKERBUldJTikgfHwgT1MoRlJFRUJTRCkgfHwgT1MoTkVUQlNEKQorI2RlZmluZSBIQVZF
X1NUQVRfQklSVEhUSU1FIDEKKyNlbmRpZgorCiAjaWYgIU9TKFdJTkRPV1MpICYmICFPUyhTT0xB
UklTKQogI2RlZmluZSBIQVZFX1RNX0dNVE9GRiAxCiAjZGVmaW5lIEhBVkVfVE1fWk9ORSAxCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj
aGVGaWxlU3lzdGVtUG9zaXguaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl
L05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oCmluZGV4IGJhNWU0OTg2ZTMxNGE2MDRmOWVk
ODFhNDBiZDJiODQ3ZWM4MzViODUuLjg3NTAyMmNiZGI0MDAxZjRiYzg0ODJiNDBhYTVmNzAzZDA2
MjJkZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05l
dHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ
cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oCkBAIC03NywxMyArNzcs
MTIgQEAgc3RydWN0IEZpbGVUaW1lcyB7CiAKIGlubGluZSBGaWxlVGltZXMgZmlsZVRpbWVzKGNv
bnN0IFN0cmluZyYgcGF0aCkKIHsKLSNpZiBQTEFURk9STShDT0NPQSkKKyNpZiBIQVZFKFNUQVRf
QklSVEhUSU1FKQogICAgIHN0cnVjdCBzdGF0IGZpbGVJbmZvOwogICAgIGlmIChzdGF0KFdlYkNv
cmU6OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihwYXRoKS5kYXRhKCksICZmaWxlSW5mbykpCiAg
ICAgICAgIHJldHVybiB7IH07CiAgICAgcmV0dXJuIHsgc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9j
azo6ZnJvbV90aW1lX3QoZmlsZUluZm8uc3RfYmlydGh0aW1lKSwgc3RkOjpjaHJvbm86OnN5c3Rl
bV9jbG9jazo6ZnJvbV90aW1lX3QoZmlsZUluZm8uc3RfbXRpbWUpIH07Ci0jZW5kaWYKLSNpZiBV
U0UoU09VUCkKKyNlbGlmIFVTRShTT1VQKQogICAgIC8vIFRoZXJlJ3Mgbm8gc3RfYmlydGh0aW1l
IGluIHNvbWUgb3BlcmF0aW5nIHN5c3RlbXMgbGlrZSBMaW51eCwgc28gd2UgdXNlIHhhdHRycyB0
byBzZXQvZ2V0IHRoZSBjcmVhdGlvbiB0aW1lLgogICAgIEdSZWZQdHI8R0ZpbGU+IGZpbGUgPSBh
ZG9wdEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChXZWJDb3JlOjpmaWxlU3lzdGVtUmVwcmVzZW50
YXRpb24ocGF0aCkuZGF0YSgpKSk7CiAgICAgR1JlZlB0cjxHRmlsZUluZm8+IGZpbGVJbmZvID0g
YWRvcHRHUmVmKGdfZmlsZV9xdWVyeV9pbmZvKGZpbGUuZ2V0KCksICJ4YXR0cjo6YmlydGh0aW1l
LHRpbWU6Om1vZGlmaWVkIiwgR19GSUxFX1FVRVJZX0lORk9fTk9ORSwgbnVsbHB0ciwgbnVsbHB0
cikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0
d29ya0NhY2hlSU9DaGFubmVsU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz
cy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxTb3VwLmNwcAppbmRleCA1OTEwMjJjOTdkMDBm
ZThkMzNkZmY0ZDM3MzM2YjM3YjVlZjQ0YzdjLi44M2M3OTdhN2EyYjBiNmZlYjE5OTBiZTc0MzAx
NzhjY2RiZjMyZmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9j
YWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9O
ZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVJT0NoYW5uZWxTb3VwLmNwcApAQCAtNDks
OCArNDksMTAgQEAgSU9DaGFubmVsOjpJT0NoYW5uZWwoY29uc3QgU3RyaW5nJiBmaWxlUGF0aCwg
VHlwZSB0eXBlKQogICAgICAgICBnX2ZpbGVfZGVsZXRlKGZpbGUuZ2V0KCksIG51bGxwdHIsIG51
bGxwdHIpOwogICAgICAgICBtX291dHB1dFN0cmVhbSA9IGFkb3B0R1JlZihHX09VVFBVVF9TVFJF
QU0oZ19maWxlX2NyZWF0ZShmaWxlLmdldCgpLCBzdGF0aWNfY2FzdDxHRmlsZUNyZWF0ZUZsYWdz
PihHX0ZJTEVfQ1JFQVRFX1BSSVZBVEUpLCBudWxscHRyLCBudWxscHRyKSkpOwogICAgICAgICBB
U1NFUlQobV9vdXRwdXRTdHJlYW0pOworI2lmICFIQVZFKFNUQVRfQklSVEhUSU1FKQogICAgICAg
ICBHVW5pcXVlUHRyPGNoYXI+IGJpcnRodGltZVN0cmluZyhnX3N0cmR1cF9wcmludGYoIiUiIEdf
R1VJTlQ2NF9GT1JNQVQsIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OnRvX3RpbWVfdChzdGQ6
OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjpub3coKSkpKTsKICAgICAgICAgZ19maWxlX3NldF9hdHRy
aWJ1dGVfc3RyaW5nKGZpbGUuZ2V0KCksICJ4YXR0cjo6YmlydGh0aW1lIiwgYmlydGh0aW1lU3Ry
aW5nLmdldCgpLCBHX0ZJTEVfUVVFUllfSU5GT19OT05FLCBudWxscHRyLCBudWxscHRyKTsKKyNl
bmRpZgogICAgICAgICBicmVhazsKICAgICB9CiAgICAgY2FzZSBUeXBlOjpXcml0ZTogewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>