144987 2015-05-13 21:14:22 -0700 Change range of possible forces for mouseforcechanged DOM event 2015-05-14 11:19:43 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin jonlee sam oldest_to_newest 1094717 0 bdakin 2015-05-13 21:14:22 -0700 For the time being, let's switch to a 0-3 range: 0 = finger off the trackpad 1 = mousedown / up / click 2 = forcemousedown / forceup 3 = max possible force That way, if we ever can get force before mousedown (which we do not have access to on the Mac right now), we have a range of values reserved for them. rdar://problem/20472802 1094718 1 253093 bdakin 2015-05-13 21:16:56 -0700 Created attachment 253093 Patch 1094845 2 253093 thorton 2015-05-14 11:09:52 -0700 Comment on attachment 253093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253093&action=review > Source/WebCore/platform/PlatformMouseEvent.h:47 > +const double ForceAtClick = 1; > +const double ForceAtForceClick = 2; I don't think these should start with capital letters. 1094851 3 bdakin 2015-05-14 11:19:43 -0700 http://trac.webkit.org/changeset/184345 253093 2015-05-13 21:16:56 -0700 2015-05-14 11:09:52 -0700 Patch for-review.txt text/plain 3834 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDMyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA1LTEzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgcmFuZ2Ugb2YgcG9zc2li bGUgZm9yY2VzIGZvciBtb3VzZWZvcmNlY2hhbmdlZCBET00gZXZlbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDk4NworICAgICAgICAtYW5kIGNv cnJlc3BvbmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIwNDcyODAyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRvIGEgMC0zIHJh bmdlLgorICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oOgorICAgICAgICAq IHBsYXRmb3JtL21hYy9QbGF0Zm9ybUV2ZW50RmFjdG9yeU1hYy5tbToKKyAgICAgICAgKFdlYkNv cmU6OlBsYXRmb3JtTW91c2VFdmVudEJ1aWxkZXI6OlBsYXRmb3JtTW91c2VFdmVudEJ1aWxkZXIp OgorCiAyMDE1LTA1LTEzICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNv bT4KIAogICAgICAgICBGaXggdHJpdmlhbCB0eXBvcyBpbiBBcHBseUJsb2NrRWxlbWVudENvbW1h bmQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5o CShyZXZpc2lvbiAxODQzMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1v dXNlRXZlbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDMsOCArNDMsOCBAQCB0eXBlZGVmIHN0cnVj dCBfRXZhc19FdmVudF9Nb3VzZV9Nb3ZlIEV2CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY29u c3QgZG91YmxlIEZvcmNlQXRDbGljayA9IDA7Ci1jb25zdCBkb3VibGUgRm9yY2VBdEZvcmNlQ2xp Y2sgPSAxOworY29uc3QgZG91YmxlIEZvcmNlQXRDbGljayA9IDE7Citjb25zdCBkb3VibGUgRm9y Y2VBdEZvcmNlQ2xpY2sgPSAyOwogCiAgICAgLy8gVGhlc2UgYnV0dG9uIG51bWJlcnMgbWF0Y2gg dGhlIG9uZXMgdXNlZCBpbiB0aGUgRE9NIEFQSSwgMCB0aHJvdWdoIDIsIGV4Y2VwdCBmb3IgTm9C dXR0b24gd2hpY2ggaXNuJ3Qgc3BlY2lmaWVkLgogICAgIGVudW0gTW91c2VCdXR0b24gOiBpbnQ4 X3QgeyBOb0J1dHRvbiA9IC0xLCBMZWZ0QnV0dG9uLCBNaWRkbGVCdXR0b24sIFJpZ2h0QnV0dG9u IH07CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1FdmVudEZhY3Rv cnlNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRm b3JtRXZlbnRGYWN0b3J5TWFjLm1tCShyZXZpc2lvbiAxODQzMDYpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1FdmVudEZhY3RvcnlNYWMubW0JKHdvcmtpbmcgY29weSkK QEAgLTQ1NCw3ICs0NTQsNyBAQCBwdWJsaWM6CiAjaWYgZGVmaW5lZChfX0xQNjRfXykgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IDEwMTAwMwogICAgICAgICBpbnQgc3RhZ2Ug PSBldmVudElzUHJlc3N1cmVFdmVudCA/IGV2ZW50LnN0YWdlIDogY29ycmVzcG9uZGluZ1ByZXNz dXJlRXZlbnQuc3RhZ2U7CiAgICAgICAgIGRvdWJsZSBwcmVzc3VyZSA9IGV2ZW50SXNQcmVzc3Vy ZUV2ZW50ID8gZXZlbnQucHJlc3N1cmUgOiBjb3JyZXNwb25kaW5nUHJlc3N1cmVFdmVudC5wcmVz c3VyZTsKLSAgICAgICAgbV9mb3JjZSA9IHN0YWdlIDwgMSA/IHByZXNzdXJlIDogcHJlc3N1cmUg KyBzdGFnZSAtIDE7CisgICAgICAgIG1fZm9yY2UgPSBwcmVzc3VyZSArIHN0YWdlOwogI2VuZGlm CiAKICAgICAgICAgLy8gTWFjIHNwZWNpZmljCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODQz MjcpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNiBAQAorMjAxNS0wNS0xMyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CisKKyAg ICAgICAgQ2hhbmdlIHJhbmdlIG9mIHBvc3NpYmxlIGZvcmNlcyBmb3IgbW91c2Vmb3JjZWNoYW5n ZWQgRE9NIGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDQ5ODcKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8v cHJvYmxlbS8yMDQ3MjgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENoYW5nZSB0byBhIDAtMyByYW5nZS4KKyAgICAgICAgKiBTaGFyZWQvbWFjL1dl YkV2ZW50RmFjdG9yeS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVh dGVXZWJNb3VzZUV2ZW50KToKKwogMjAxNS0wNS0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIFByb2Nlc3NUaHJvdHRsZXJDbGllbnQ6OntzZW5k LCBjYW5jZWx9UHJvY2Vzc1dpbGxTdXNwZW5kKCkgdG8ge3NlbmQsIGNhbmNlbH1QcmVwYXJlVG9T dXNwZW5kKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvV2ViRXZlbnRGYWN0b3J5 Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvV2ViRXZlbnRGYWN0 b3J5Lm1tCShyZXZpc2lvbiAxODQzMDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1dl YkV2ZW50RmFjdG9yeS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDAwLDcgKzQwMCw3IEBAIFdlYk1v dXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWIKICNpZiBkZWZpbmVkKF9fTFA2NF9f KSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gMTAxMDAzCiAgICAgaW50IHN0 YWdlID0gW2V2ZW50IHR5cGVdID09IE5TRXZlbnRUeXBlUHJlc3N1cmUgPyBldmVudC5zdGFnZSA6 IGxhc3RQcmVzc3VyZUV2ZW50LnN0YWdlOwogICAgIGRvdWJsZSBwcmVzc3VyZSA9IFtldmVudCB0 eXBlXSA9PSBOU0V2ZW50VHlwZVByZXNzdXJlID8gZXZlbnQucHJlc3N1cmUgOiBsYXN0UHJlc3N1 cmVFdmVudC5wcmVzc3VyZTsKLSAgICBmb3JjZSA9IHN0YWdlIDwgMSA/IHByZXNzdXJlIDogcHJl c3N1cmUgKyBzdGFnZSAtIDE7CisgICAgZm9yY2UgPSBwcmVzc3VyZSArIHN0YWdlOwogI2VuZGlm CiAKICAgICByZXR1cm4gV2ViTW91c2VFdmVudCh0eXBlLCBidXR0b24sIEludFBvaW50KHBvc2l0 aW9uKSwgSW50UG9pbnQoZ2xvYmFsUG9zaXRpb24pLCBkZWx0YVgsIGRlbHRhWSwgZGVsdGFaLCBj bGlja0NvdW50LCBtb2RpZmllcnMsIHRpbWVzdGFtcCwgZm9yY2UsIGV2ZW50TnVtYmVyLCBtZW51 VHlwZUZvckV2ZW50KTsK