144985 2015-05-13 20:18:13 -0700 String.prototype.split() should create efficient substrings. 2015-05-14 12:08:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling barraclough ggaren kling oliver oldest_to_newest 1094705 0 kling 2015-05-13 20:18:13 -0700 <rdar://problem/20949344> String.prototype.split() should create JSStrings using the lazy substring optimization. 1094706 1 253088 kling 2015-05-13 20:21:33 -0700 Created attachment 253088 Patch 1094846 2 253088 ggaren 2015-05-14 11:10:03 -0700 Comment on attachment 253088 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253088&action=review r=me > Source/JavaScriptCore/runtime/StringPrototype.cpp:179 > +static inline JSString* jsSubstringWithSharing(ExecState* exec, JSValue originalValue, const String& string, unsigned offset, unsigned length) I would just call this jsSubstring. 1094865 3 kling 2015-05-14 12:08:56 -0700 Committed r184346: <http://trac.webkit.org/changeset/184346> 253088 2015-05-13 20:21:33 -0700 2015-05-14 11:10:03 -0700 Patch bug-144985.diff text/plain 7612 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQ5NmZlZjAuLjExMTVjMjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA1LTEzICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmcucHJvdG90eXBlLnNwbGl0KCkg c2hvdWxkIGNyZWF0ZSBlZmZpY2llbnQgc3Vic3RyaW5ncy4KKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE0NDk4NT4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwOTQ5MzQ0PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNoIHNwbGl0 KCkgaG93IHRvIG1ha2Ugc3Vic3RyaW5nIEpTU3RyaW5ncyBpbnN0ZWFkIG9mIHJlbHlpbmcgb24g U3RyaW5nSW1wbCdzCisgICAgICAgIHN1YnN0cmluZyBzaGFyaW5nIG1lY2hhbmlzbS4gVGhlIG9w dGltaXphdGlvbiB3b3JrcyBieSBkZWZlcnJpbmcgdGhlIGNvbnN0cnVjdGlvbgorICAgICAgICBv ZiBhIFN0cmluZ0ltcGwgdW50aWwgdGhlIHN1YnN0cmluZydzIHZhbHVlIGlzIGFjdHVhbGx5IG5l ZWRlZC4KKworICAgICAgICBUaGlzIGtub2NrcyB+Mk1CIG9mZiBvZiB0aGV2ZXJnZS5jb20gYnkg YXZvaWRpbmcgdGhlIGV4dHJhIFN0cmluZ0ltcGwgYWxsb2NhdGlvbnMuCisgICAgICAgIE91dCBv ZiB+NzAwMDAgc3Vic3RyaW5ncyBjcmVhdGVkIGJ5IHNwbGl0KCksIG9ubHkgfjUwMCBvZiB0aGVt IGdldCByZWlmaWVkLgorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwOgor ICAgICAgICAoSlNDOjpqc1N1YnN0cmluZ1dpdGhTaGFyaW5nKToKKyAgICAgICAgKEpTQzo6c3Bs aXRTdHJpbmdCeU9uZUNoYXJhY3RlckltcGwpOgorICAgICAgICAoSlNDOjpzdHJpbmdQcm90b0Z1 bmNTcGxpdCk6CisKIDIwMTUtMDUtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KIAogICAgICAgICBBdm9pZCBhbHdheXMgcnVubmluZyBzb21lIGRlYnVnIGNvZGUgaW4g dHlwZSBwcm9maWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cmluZ1Byb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJp bmdQcm90b3R5cGUuY3BwCmluZGV4IGJiODAxMmQuLmJmMjlhNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcApAQCAtMTc1LDYgKzE3 NSwxNiBAQCBzdGF0aWMgaW5saW5lIEpTU3RyaW5nKiBqc1N0cmluZ1dpdGhSZXVzZShFeGVjU3Rh dGUqIGV4ZWMsIEpTVmFsdWUgb3JpZ2luYWxWYWx1ZQogICAgIHJldHVybiBqc1N0cmluZyhleGVj LCBzdHJpbmcpOwogfQogCisvLyBIZWxwZXIgdGhhdCB0cmllcyB0byB1c2UgdGhlIEpTU3RyaW5n IHN1YnN0cmluZyBzaGFyaW5nIG1lY2hhbmlzbSBpZiAnb3JpZ2luYWxWYWx1ZScgaXMgYSBKU1N0 cmluZy4KK3N0YXRpYyBpbmxpbmUgSlNTdHJpbmcqIGpzU3Vic3RyaW5nV2l0aFNoYXJpbmcoRXhl Y1N0YXRlKiBleGVjLCBKU1ZhbHVlIG9yaWdpbmFsVmFsdWUsIGNvbnN0IFN0cmluZyYgc3RyaW5n LCB1bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkKK3sKKyAgICBpZiAob3JpZ2luYWxW YWx1ZS5pc1N0cmluZygpKSB7CisgICAgICAgIEFTU0VSVChhc1N0cmluZyhvcmlnaW5hbFZhbHVl KS0+dmFsdWUoZXhlYykgPT0gc3RyaW5nKTsKKyAgICAgICAgcmV0dXJuIGpzU3Vic3RyaW5nKGV4 ZWMsIGFzU3RyaW5nKG9yaWdpbmFsVmFsdWUpLCBvZmZzZXQsIGxlbmd0aCk7CisgICAgfQorICAg IHJldHVybiBqc1N1YnN0cmluZyhleGVjLCBzdHJpbmcsIG9mZnNldCwgbGVuZ3RoKTsKK30KKwog c3RhdGljIE5FVkVSX0lOTElORSBTdHJpbmcgc3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2VzU2xvdyhT dHJpbmdWaWV3IHJlcGxhY2VtZW50LCBTdHJpbmdWaWV3IHNvdXJjZSwgY29uc3QgaW50KiBvdmVj dG9yLCBSZWdFeHAqIHJlZywgc2l6ZV90IGkpCiB7CiAgICAgU3RyaW5nQnVpbGRlciBzdWJzdGl0 dXRlZFJlcGxhY2VtZW50OwpAQCAtMTA1Myw3ICsxMDYzLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBzdHJpbmdQcm90b0Z1bmNTbGljZShFeGVjU3RhdGUqIGV4ZWMpCiAKIC8vIFJl dHVybiB0cnVlIGluIGNhc2Ugb2YgZWFybHkgcmV0dXJuIChyZXN1bHRMZW5ndGggZ290IHRvIGxp bWl0TGVuZ3RoKS4KIHRlbXBsYXRlPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+Ci1zdGF0aWMgQUxX QVlTX0lOTElORSBib29sIHNwbGl0U3RyaW5nQnlPbmVDaGFyYWN0ZXJJbXBsKEV4ZWNTdGF0ZSog ZXhlYywgSlNBcnJheSogcmVzdWx0LCBjb25zdCBTdHJpbmcmIGlucHV0LCBTdHJpbmdJbXBsKiBz dHJpbmcsIFVDaGFyIHNlcGFyYXRvckNoYXJhY3Rlciwgc2l6ZV90JiBwb3NpdGlvbiwgdW5zaWdu ZWQmIHJlc3VsdExlbmd0aCwgdW5zaWduZWQgbGltaXRMZW5ndGgpCitzdGF0aWMgQUxXQVlTX0lO TElORSBib29sIHNwbGl0U3RyaW5nQnlPbmVDaGFyYWN0ZXJJbXBsKEV4ZWNTdGF0ZSogZXhlYywg SlNBcnJheSogcmVzdWx0LCBKU1ZhbHVlIG9yaWdpbmFsVmFsdWUsIGNvbnN0IFN0cmluZyYgaW5w dXQsIFN0cmluZ0ltcGwqIHN0cmluZywgVUNoYXIgc2VwYXJhdG9yQ2hhcmFjdGVyLCBzaXplX3Qm IHBvc2l0aW9uLCB1bnNpZ25lZCYgcmVzdWx0TGVuZ3RoLCB1bnNpZ25lZCBsaW1pdExlbmd0aCkK IHsKICAgICAvLyAxMi4gTGV0IHEgPSBwLgogICAgIHNpemVfdCBtYXRjaFBvc2l0aW9uOwpAQCAt MTA2Nyw3ICsxMDc3LDcgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBzcGxpdFN0cmluZ0J5 T25lQ2hhcmFjdGVySW1wbChFeGVjU3RhdGUqIGV4ZWMsIEpTQXJyYXkKICAgICAgICAgLy8gICAg dGhyb3VnaCBxIChleGNsdXNpdmUpLgogICAgICAgICAvLyAyLiBDYWxsIHRoZSBbW0RlZmluZU93 blByb3BlcnR5XV0gaW50ZXJuYWwgbWV0aG9kIG9mIEEgd2l0aCBhcmd1bWVudHMgVG9TdHJpbmco bGVuZ3RoQSksCiAgICAgICAgIC8vICAgIFByb3BlcnR5IERlc2NyaXB0b3Ige1tbVmFsdWVdXTog VCwgW1tXcml0YWJsZV1dOiB0cnVlLCBbW0VudW1lcmFibGVdXTogdHJ1ZSwgW1tDb25maWd1cmFi bGVdXTogdHJ1ZX0sIGFuZCBmYWxzZS4KLSAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChl eGVjLCByZXN1bHRMZW5ndGgsIGpzU3Vic3RyaW5nKGV4ZWMsIGlucHV0LCBwb3NpdGlvbiwgbWF0 Y2hQb3NpdGlvbiAtIHBvc2l0aW9uKSk7CisgICAgICAgIHJlc3VsdC0+cHV0RGlyZWN0SW5kZXgo ZXhlYywgcmVzdWx0TGVuZ3RoLCBqc1N1YnN0cmluZ1dpdGhTaGFyaW5nKGV4ZWMsIG9yaWdpbmFs VmFsdWUsIGlucHV0LCBwb3NpdGlvbiwgbWF0Y2hQb3NpdGlvbiAtIHBvc2l0aW9uKSk7CiAgICAg ICAgIC8vIDMuIEluY3JlbWVudCBsZW5ndGhBIGJ5IDEuCiAgICAgICAgIC8vIDQuIElmIGxlbmd0 aEEgPT0gbGltLCByZXR1cm4gQS4KICAgICAgICAgaWYgKCsrcmVzdWx0TGVuZ3RoID09IGxpbWl0 TGVuZ3RoKQpAQCAtMTE3Myw3ICsxMTgzLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBzdHJpbmdQcm90b0Z1bmNTcGxpdChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgICAgICAvLyAg ICB0aHJvdWdoIHEgKGV4Y2x1c2l2ZSkuCiAgICAgICAgICAgICAvLyAyLiBDYWxsIHRoZSBbW0Rl ZmluZU93blByb3BlcnR5XV0gaW50ZXJuYWwgbWV0aG9kIG9mIEEgd2l0aCBhcmd1bWVudHMgVG9T dHJpbmcobGVuZ3RoQSksCiAgICAgICAgICAgICAvLyAgICBQcm9wZXJ0eSBEZXNjcmlwdG9yIHtb W1ZhbHVlXV06IFQsIFtbV3JpdGFibGVdXTogdHJ1ZSwgW1tFbnVtZXJhYmxlXV06IHRydWUsIFtb Q29uZmlndXJhYmxlXV06IHRydWV9LCBhbmQgZmFsc2UuCi0gICAgICAgICAgICByZXN1bHQtPnB1 dERpcmVjdEluZGV4KGV4ZWMsIHJlc3VsdExlbmd0aCwganNTdWJzdHJpbmcoZXhlYywgaW5wdXQs IHBvc2l0aW9uLCBtYXRjaFBvc2l0aW9uIC0gcG9zaXRpb24pKTsKKyAgICAgICAgICAgIHJlc3Vs dC0+cHV0RGlyZWN0SW5kZXgoZXhlYywgcmVzdWx0TGVuZ3RoLCBqc1N1YnN0cmluZ1dpdGhTaGFy aW5nKGV4ZWMsIHRoaXNWYWx1ZSwgaW5wdXQsIHBvc2l0aW9uLCBtYXRjaFBvc2l0aW9uIC0gcG9z aXRpb24pKTsKIAogICAgICAgICAgICAgLy8gMy4gSW5jcmVtZW50IGxlbmd0aEEgYnkgMS4KICAg ICAgICAgICAgIC8vIDQuIElmIGxlbmd0aEEgPT0gbGltLCByZXR1cm4gQS4KQEAgLTExOTMsNyAr MTIwMyw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG9GdW5jU3Bs aXQoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICAgICAgICAgIC8vICAgVG9TdHJpbmcobGVuZ3Ro QSksIFByb3BlcnR5IERlc2NyaXB0b3Ige1tbVmFsdWVdXTogY2FwW2ldLCBbW1dyaXRhYmxlXV06 CiAgICAgICAgICAgICAgICAgLy8gICB0cnVlLCBbW0VudW1lcmFibGVdXTogdHJ1ZSwgW1tDb25m aWd1cmFibGVdXTogdHJ1ZX0sIGFuZCBmYWxzZS4KICAgICAgICAgICAgICAgICBpbnQgc3ViID0g b3ZlY3RvcltpICogMl07Ci0gICAgICAgICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChl eGVjLCByZXN1bHRMZW5ndGgsIHN1YiA8IDAgPyBqc1VuZGVmaW5lZCgpIDoganNTdWJzdHJpbmco ZXhlYywgaW5wdXQsIHN1Yiwgb3ZlY3RvcltpICogMiArIDFdIC0gc3ViKSk7CisgICAgICAgICAg ICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCByZXN1bHRMZW5ndGgsIHN1YiA8IDAg PyBqc1VuZGVmaW5lZCgpIDoganNTdWJzdHJpbmdXaXRoU2hhcmluZyhleGVjLCB0aGlzVmFsdWUs IGlucHV0LCBzdWIsIG92ZWN0b3JbaSAqIDIgKyAxXSAtIHN1YikpOwogICAgICAgICAgICAgICAg IC8vIGMgSW5jcmVtZW50IGxlbmd0aEEgYnkgMS4KICAgICAgICAgICAgICAgICAvLyBkIElmIGxl bmd0aEEgPT0gbGltLCByZXR1cm4gQS4KICAgICAgICAgICAgICAgICBpZiAoKytyZXN1bHRMZW5n dGggPT0gbGltaXQpCkBAIC0xMjU4LDEwICsxMjY4LDEwIEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgc3RyaW5nUHJvdG9GdW5jU3BsaXQoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICAg ICAgICAgIHNlcGFyYXRvckNoYXJhY3RlciA9IHNlcGFyYXRvckltcGwtPmNoYXJhY3RlcnMxNigp WzBdOwogCiAgICAgICAgICAgICBpZiAoc3RyaW5nSW1wbC0+aXM4Qml0KCkpIHsKLSAgICAgICAg ICAgICAgICBpZiAoc3BsaXRTdHJpbmdCeU9uZUNoYXJhY3RlckltcGw8TENoYXI+KGV4ZWMsIHJl c3VsdCwgaW5wdXQsIHN0cmluZ0ltcGwsIHNlcGFyYXRvckNoYXJhY3RlciwgcG9zaXRpb24sIHJl c3VsdExlbmd0aCwgbGltaXQpKQorICAgICAgICAgICAgICAgIGlmIChzcGxpdFN0cmluZ0J5T25l Q2hhcmFjdGVySW1wbDxMQ2hhcj4oZXhlYywgcmVzdWx0LCB0aGlzVmFsdWUsIGlucHV0LCBzdHJp bmdJbXBsLCBzZXBhcmF0b3JDaGFyYWN0ZXIsIHBvc2l0aW9uLCByZXN1bHRMZW5ndGgsIGxpbWl0 KSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwog ICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBpZiAoc3BsaXRTdHJpbmdCeU9u ZUNoYXJhY3RlckltcGw8VUNoYXI+KGV4ZWMsIHJlc3VsdCwgaW5wdXQsIHN0cmluZ0ltcGwsIHNl cGFyYXRvckNoYXJhY3RlciwgcG9zaXRpb24sIHJlc3VsdExlbmd0aCwgbGltaXQpKQorICAgICAg ICAgICAgICAgIGlmIChzcGxpdFN0cmluZ0J5T25lQ2hhcmFjdGVySW1wbDxVQ2hhcj4oZXhlYywg cmVzdWx0LCB0aGlzVmFsdWUsIGlucHV0LCBzdHJpbmdJbXBsLCBzZXBhcmF0b3JDaGFyYWN0ZXIs IHBvc2l0aW9uLCByZXN1bHRMZW5ndGgsIGxpbWl0KSkKICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQpOwogICAgICAgICAgICAgfQogICAgICAgICB9IGVs c2UgewpAQCAtMTI3Niw3ICsxMjg2LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBz dHJpbmdQcm90b0Z1bmNTcGxpdChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgICAgICAgICAgLy8g ICAgdGhyb3VnaCBxIChleGNsdXNpdmUpLgogICAgICAgICAgICAgICAgIC8vIDIuIENhbGwgdGhl IFtbRGVmaW5lT3duUHJvcGVydHldXSBpbnRlcm5hbCBtZXRob2Qgb2YgQSB3aXRoIGFyZ3VtZW50 cyBUb1N0cmluZyhsZW5ndGhBKSwKICAgICAgICAgICAgICAgICAvLyAgICBQcm9wZXJ0eSBEZXNj cmlwdG9yIHtbW1ZhbHVlXV06IFQsIFtbV3JpdGFibGVdXTogdHJ1ZSwgW1tFbnVtZXJhYmxlXV06 IHRydWUsIFtbQ29uZmlndXJhYmxlXV06IHRydWV9LCBhbmQgZmFsc2UuCi0gICAgICAgICAgICAg ICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCByZXN1bHRMZW5ndGgsIGpzU3Vic3RyaW5n KGV4ZWMsIGlucHV0LCBwb3NpdGlvbiwgbWF0Y2hQb3NpdGlvbiAtIHBvc2l0aW9uKSk7CisgICAg ICAgICAgICAgICAgcmVzdWx0LT5wdXREaXJlY3RJbmRleChleGVjLCByZXN1bHRMZW5ndGgsIGpz U3Vic3RyaW5nV2l0aFNoYXJpbmcoZXhlYywgdGhpc1ZhbHVlLCBpbnB1dCwgcG9zaXRpb24sIG1h dGNoUG9zaXRpb24gLSBwb3NpdGlvbikpOwogICAgICAgICAgICAgICAgIC8vIDMuIEluY3JlbWVu dCBsZW5ndGhBIGJ5IDEuCiAgICAgICAgICAgICAgICAgLy8gNC4gSWYgbGVuZ3RoQSA9PSBsaW0s IHJldHVybiBBLgogICAgICAgICAgICAgICAgIGlmICgrK3Jlc3VsdExlbmd0aCA9PSBsaW1pdCkK QEAgLTEyOTMsNyArMTMwMyw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5n UHJvdG9GdW5jU3BsaXQoRXhlY1N0YXRlKiBleGVjKQogICAgIC8vICAgICB0aHJvdWdoIHMgKGV4 Y2x1c2l2ZSkuCiAgICAgLy8gMTUuIENhbGwgdGhlIFtbRGVmaW5lT3duUHJvcGVydHldXSBpbnRl cm5hbCBtZXRob2Qgb2YgQSB3aXRoIGFyZ3VtZW50cyBUb1N0cmluZyhsZW5ndGhBKSwgUHJvcGVy dHkgRGVzY3JpcHRvcgogICAgIC8vICAgICB7W1tWYWx1ZV1dOiBULCBbW1dyaXRhYmxlXV06IHRy dWUsIFtbRW51bWVyYWJsZV1dOiB0cnVlLCBbW0NvbmZpZ3VyYWJsZV1dOiB0cnVlfSwgYW5kIGZh bHNlLgotICAgIHJlc3VsdC0+cHV0RGlyZWN0SW5kZXgoZXhlYywgcmVzdWx0TGVuZ3RoKyssIGpz U3Vic3RyaW5nKGV4ZWMsIGlucHV0LCBwb3NpdGlvbiwgaW5wdXQubGVuZ3RoKCkgLSBwb3NpdGlv bikpOworICAgIHJlc3VsdC0+cHV0RGlyZWN0SW5kZXgoZXhlYywgcmVzdWx0TGVuZ3RoKyssIGpz U3Vic3RyaW5nV2l0aFNoYXJpbmcoZXhlYywgdGhpc1ZhbHVlLCBpbnB1dCwgcG9zaXRpb24sIGlu cHV0Lmxlbmd0aCgpIC0gcG9zaXRpb24pKTsKIAogICAgIC8vIDE2LiBSZXR1cm4gQS4KICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7Cg==