144976 2015-05-13 17:38:43 -0700 [ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero 2015-05-15 14:11:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1094666 0 benjamin 2015-05-13 17:38:43 -0700 [ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero 1094667 1 253077 benjamin 2015-05-13 17:43:09 -0700 Created attachment 253077 Patch 1094669 2 253077 msaboff 2015-05-13 17:48:50 -0700 Comment on attachment 253077 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253077&action=review Needs a little more work I think > Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:1212 > + Jump valueIsNonZero = branchTest32(NonZero, dest); You don't have anything in dest yet to make this comparison. 1094997 3 253167 benjamin 2015-05-14 19:17:14 -0700 Created attachment 253167 Patch 1095023 4 253167 msaboff 2015-05-14 21:10:00 -0700 Comment on attachment 253167 Patch r=me 1095245 5 253167 benjamin 2015-05-15 14:11:38 -0700 Comment on attachment 253167 Patch Clearing flags on attachment: 253167 Committed r184414: <http://trac.webkit.org/changeset/184414> 1095246 6 benjamin 2015-05-15 14:11:45 -0700 All reviewed patches have been landed. Closing bug. 253077 2015-05-13 17:43:09 -0700 2015-05-14 19:17:11 -0700 Patch bug-144976-20150513174147.patch text/plain 2586 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NGE0NjU5Mzc5MjhjNWZkNmUzZjUxY2Q3NWZjZDIxNjRmYmRhNmQ1Li5hM2ZjY2M0YzZmMDE4NmRi YjVlZDEzYmMzOGE4Y2UwMzEwZDQyMDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wNS0xMyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbQVJNNjRdIERvIG5vdCBmYWlsIGJyYW5jaENvbnZlcnREb3VibGVU b0ludDMyIHdoZW4gdGhlIHJlc3VsdCBpcyB6ZXJvIGFuZCBub3QgbmVnYXRpdmUgemVybworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmFpbGluZyB0aGUg Y29udmVyc2lvbiBvbiB6ZXJvIGlzIHByZXR0eSBkYW5nZXJvdXMgYXMgd2UgZGlzY292ZXJlZCBv biB4ODYuCisKKyAgICAgICAgVGhpcyBwYXRjaCBkb2VzIG5vdCByZWFsbHkgaW1wYWN0IHBlcmZv cm1hbmNlIHNpZ25pZmljYW50bHkgYmVjYXVzZQorICAgICAgICByMTg0MjIwIHJlbW92ZWQgdGhl IHplcm8gY2hlY2tzIGZyb20gS3Jha2VuLiBUaGlzIHBhdGNoIGlzIGp1c3QgdG8gYmUKKyAgICAg ICAgb24gdGhlIHNhZmUgc2lkZSBmb3IgY2FzZXMgbm90IGNvdmVyZWQgYnkgZXhpc3RpbmcgYmVu Y2htYXJrcy4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OmJyYW5jaENvbnZlcnREb3VibGVUb0lu dDMyKToKKwogMjAxNS0wNS0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBNYWtlIHRoZSBOZWdaZXJvIGJhY2t3YXJkIHByb3BhZ2F0ZWQg ZmxhZ3Mgb2YgQXJpdGhNb2Qgc3RyaWN0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggOTUzNjY5NWMxYjIwNWJk NzExNGJiYjRlNjcxNWMyOWNlNGFhZDE0NS4uOWIwZGViMGUyYTYxN2M1YjY0ZGUzM2JjNjg1MGFi ZTNlZjMxMjMwOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTTY0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKQEAgLTEyMDcsMTUgKzEyMDcsMTkgQEAgcHVibGljOgog ICAgIC8vIChzcGVjaWZpY2FsbHksIGluIHRoaXMgY2FzZSwgMCkuCiAgICAgdm9pZCBicmFuY2hD b252ZXJ0RG91YmxlVG9JbnQzMihGUFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QsIEp1 bXBMaXN0JiBmYWlsdXJlQ2FzZXMsIEZQUmVnaXN0ZXJJRCwgYm9vbCBuZWdaZXJvQ2hlY2sgPSB0 cnVlKQogICAgIHsKKyAgICAgICAgLy8gVGVzdCBmb3IgbmVnYXRpdmUgemVyby4KKyAgICAgICAg aWYgKG5lZ1plcm9DaGVjaykgeworICAgICAgICAgICAgSnVtcCB2YWx1ZUlzTm9uWmVybyA9IGJy YW5jaFRlc3QzMihOb25aZXJvLCBkZXN0KTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmZtb3Y8 NjQ+KGRlc3QsIHNyYyk7CisgICAgICAgICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKG1ha2VUZXN0 Qml0QW5kQnJhbmNoKGRlc3QsIDYzLCBJc05vblplcm8pKTsKKyAgICAgICAgICAgIHZhbHVlSXNO b25aZXJvLmxpbmsodGhpcyk7CisgICAgICAgIH0KKwogICAgICAgICBtX2Fzc2VtYmxlci5mY3Z0 bnM8MzIsIDY0PihkZXN0LCBzcmMpOwogCiAgICAgICAgIC8vIENvbnZlcnQgdGhlIGludGVnZXIg cmVzdWx0IGJhY2sgdG8gZmxvYXQgJiBjb21wYXJlIHRvIHRoZSBvcmlnaW5hbCB2YWx1ZSAtIGlm IG5vdCBlcXVhbCBvciB1bm9yZGVyZWQgKE5hTikgdGhlbiBqdW1wLgogICAgICAgICBtX2Fzc2Vt Ymxlci5zY3Z0Zjw2NCwgMzI+KGZwVGVtcFJlZ2lzdGVyLCBkZXN0KTsKICAgICAgICAgZmFpbHVy ZUNhc2VzLmFwcGVuZChicmFuY2hEb3VibGUoRG91YmxlTm90RXF1YWxPclVub3JkZXJlZCwgc3Jj LCBmcFRlbXBSZWdpc3RlcikpOwotCi0gICAgICAgIC8vIElmIHRoZSByZXN1bHQgaXMgemVybywg aXQgbWlnaHQgaGF2ZSBiZWVuIC0wLjAsIGFuZCB0aGUgZG91YmxlIGNvbXBhcmlzb24gd29uJ3Qg Y2F0Y2ggdGhpcyEKLSAgICAgICAgaWYgKG5lZ1plcm9DaGVjaykKLSAgICAgICAgICAgIGZhaWx1 cmVDYXNlcy5hcHBlbmQoYnJhbmNoVGVzdDMyKFplcm8sIGRlc3QpKTsKICAgICB9CiAKICAgICBK dW1wIGJyYW5jaERvdWJsZShEb3VibGVDb25kaXRpb24gY29uZCwgRlBSZWdpc3RlcklEIGxlZnQs IEZQUmVnaXN0ZXJJRCByaWdodCkK 253167 2015-05-14 19:17:14 -0700 2015-05-15 14:11:38 -0700 Patch bug-144976-20150514191550.patch text/plain 2305 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NGE0NjU5Mzc5MjhjNWZkNmUzZjUxY2Q3NWZjZDIxNjRmYmRhNmQ1Li5hM2ZjY2M0YzZmMDE4NmRi YjVlZDEzYmMzOGE4Y2UwMzEwZDQyMDgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0wNS0xMyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbQVJNNjRdIERvIG5vdCBmYWlsIGJyYW5jaENvbnZlcnREb3VibGVU b0ludDMyIHdoZW4gdGhlIHJlc3VsdCBpcyB6ZXJvIGFuZCBub3QgbmVnYXRpdmUgemVybworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0OTc2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmFpbGluZyB0aGUg Y29udmVyc2lvbiBvbiB6ZXJvIGlzIHByZXR0eSBkYW5nZXJvdXMgYXMgd2UgZGlzY292ZXJlZCBv biB4ODYuCisKKyAgICAgICAgVGhpcyBwYXRjaCBkb2VzIG5vdCByZWFsbHkgaW1wYWN0IHBlcmZv cm1hbmNlIHNpZ25pZmljYW50bHkgYmVjYXVzZQorICAgICAgICByMTg0MjIwIHJlbW92ZWQgdGhl IHplcm8gY2hlY2tzIGZyb20gS3Jha2VuLiBUaGlzIHBhdGNoIGlzIGp1c3QgdG8gYmUKKyAgICAg ICAgb24gdGhlIHNhZmUgc2lkZSBmb3IgY2FzZXMgbm90IGNvdmVyZWQgYnkgZXhpc3RpbmcgYmVu Y2htYXJrcy4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OmJyYW5jaENvbnZlcnREb3VibGVUb0lu dDMyKToKKwogMjAxNS0wNS0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBNYWtlIHRoZSBOZWdaZXJvIGJhY2t3YXJkIHByb3BhZ2F0ZWQg ZmxhZ3Mgb2YgQXJpdGhNb2Qgc3RyaWN0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKaW5kZXggOTUzNjY5NWMxYjIwNWJk NzExNGJiYjRlNjcxNWMyOWNlNGFhZDE0NS4uNjYxZmMwYWQ4ZmQwZTdlNzYxYmIyNjhkYWJmZDRh ODRjYzg0MGNjMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlckFSTTY0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKQEAgLTEyMTMsOSArMTIxMywxNCBAQCBwdWJsaWM6CiAg ICAgICAgIG1fYXNzZW1ibGVyLnNjdnRmPDY0LCAzMj4oZnBUZW1wUmVnaXN0ZXIsIGRlc3QpOwog ICAgICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5jaERvdWJsZShEb3VibGVOb3RFcXVhbE9y VW5vcmRlcmVkLCBzcmMsIGZwVGVtcFJlZ2lzdGVyKSk7CiAKLSAgICAgICAgLy8gSWYgdGhlIHJl c3VsdCBpcyB6ZXJvLCBpdCBtaWdodCBoYXZlIGJlZW4gLTAuMCwgYW5kIHRoZSBkb3VibGUgY29t cGFyaXNvbiB3b24ndCBjYXRjaCB0aGlzIQotICAgICAgICBpZiAobmVnWmVyb0NoZWNrKQotICAg ICAgICAgICAgZmFpbHVyZUNhc2VzLmFwcGVuZChicmFuY2hUZXN0MzIoWmVybywgZGVzdCkpOwor ICAgICAgICAvLyBUZXN0IGZvciBuZWdhdGl2ZSB6ZXJvLgorICAgICAgICBpZiAobmVnWmVyb0No ZWNrKSB7CisgICAgICAgICAgICBKdW1wIHZhbHVlSXNOb25aZXJvID0gYnJhbmNoVGVzdDMyKE5v blplcm8sIGRlc3QpOworICAgICAgICAgICAgUmVnaXN0ZXJJRCBzY3JhdGNoID0gZ2V0Q2FjaGVk TWVtb3J5VGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCk7CisgICAgICAgICAgICBtX2Fzc2Vt Ymxlci5mbW92PDY0PihzY3JhdGNoLCBzcmMpOworICAgICAgICAgICAgZmFpbHVyZUNhc2VzLmFw cGVuZChtYWtlVGVzdEJpdEFuZEJyYW5jaChzY3JhdGNoLCA2MywgSXNOb25aZXJvKSk7CisgICAg ICAgICAgICB2YWx1ZUlzTm9uWmVyby5saW5rKHRoaXMpOworICAgICAgICB9CiAgICAgfQogCiAg ICAgSnVtcCBicmFuY2hEb3VibGUoRG91YmxlQ29uZGl0aW9uIGNvbmQsIEZQUmVnaXN0ZXJJRCBs ZWZ0LCBGUFJlZ2lzdGVySUQgcmlnaHQpCg==