144957 2015-05-13 11:14:31 -0700 Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page 2015-05-13 12:22:20 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1094496 0 joepeck 2015-05-13 11:14:31 -0700 * SUMMARY Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page. Reports of crashes after r183907. > Exception Type: EXC_BAD_ACCESS (SIGSEGV) > Exception Codes: KERN_INVALID_ADDRESS at 0x00000000000000c8 > > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 WebKit::WebInspectorProxy::attachAvailabilityChanged(bool) + 58 > 1 WebKit::WebInspectorProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 748 > 2 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&) + 120 > 3 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) + 24 > 4 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 102 > 5 IPC::Connection::dispatchOneMessage() + 114 > 6 WTF::RunLoop::performWork() + 850 > 7 WTF::RunLoop::performWork(void*) + 34 > 8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 > 9 __CFRunLoopDoSources0 + 269 > 10 __CFRunLoopRun + 927 New code added here was: > + if (!m_underTest) > + m_inspectorPage->process().send(Messages::WebInspectorUI::SetDockingUnavailable(!m_canAttach), m_inspectorPage->pageID()); Seems that m_inspectorPage might not be set in these cases. 1094497 1 joepeck 2015-05-13 11:14:48 -0700 <rdar://problem/20887443> 1094499 2 253038 joepeck 2015-05-13 11:15:48 -0700 Created attachment 253038 [PATCH] Proposed Fix 1094523 3 253038 commit-queue 2015-05-13 12:22:10 -0700 Comment on attachment 253038 [PATCH] Proposed Fix Clearing flags on attachment: 253038 Committed r184294: <http://trac.webkit.org/changeset/184294> 1094524 4 commit-queue 2015-05-13 12:22:20 -0700 All reviewed patches have been landed. Closing bug. 253038 2015-05-13 11:15:48 -0700 2015-05-13 12:22:10 -0700 [PATCH] Proposed Fix crash-fix.patch text/plain 1283 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNDcxMGI4Li4zNDIzYTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTUtMDUtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBDcmFzaCB1bmRlciBXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjphdHRhY2hBdmFp bGFiaWxpdHlDaGFuZ2VkIHNvbWV0aW1lcyBvcGVuaW5nIG5ldyBwYWdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5NTcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0 b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjphdHRhY2hB dmFpbGFiaWxpdHlDaGFuZ2VkKToKKwogMjAxNS0wNS0wNyAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFBhc3MgU3RyaW5nIGFzIHJlZmVyZW5jZSBpbiBt b3JlIHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3Bl Y3RvclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94 eS5jcHAKaW5kZXggYzliOTUwOC4uYzk4ZDU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCkBAIC01NzQsNyArNTc0LDcgQEAgdm9pZCBXZWJJ bnNwZWN0b3JQcm94eTo6YXR0YWNoQXZhaWxhYmlsaXR5Q2hhbmdlZChib29sIGF2YWlsYWJsZSkK ICAgICBpZiAocHJldmlvdXNDYW5BdHRhY2ggPT0gbV9jYW5BdHRhY2gpCiAgICAgICAgIHJldHVy bjsKIAotICAgIGlmICghbV91bmRlclRlc3QpCisgICAgaWYgKG1faW5zcGVjdG9yUGFnZSAmJiAh bV91bmRlclRlc3QpCiAgICAgICAgIG1faW5zcGVjdG9yUGFnZS0+cHJvY2VzcygpLnNlbmQoTWVz c2FnZXM6OldlYkluc3BlY3RvclVJOjpTZXREb2NraW5nVW5hdmFpbGFibGUoIW1fY2FuQXR0YWNo KSwgbV9pbnNwZWN0b3JQYWdlLT5wYWdlSUQoKSk7CiAKICAgICBwbGF0Zm9ybUF0dGFjaEF2YWls YWJpbGl0eUNoYW5nZWQobV9jYW5BdHRhY2gpOwo=