144953 2015-05-13 09:53:35 -0700 [SOUP] Network Cache: NetworkProcess segfault when file system doesn't support xattrs 2015-05-13 23:21:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Linux RESOLVED FIXED Gtk, Soup P2 Normal --- 1 lantw44 webkit-unassigned cgarcia oldest_to_newest 1094474 0 lantw44 2015-05-13 09:53:35 -0700 tmpfs doesn't support user_xattr on Linux. Therefore, if an user have its ~/.cache/epiphany on tmpfs, setting xattr::birthtime fails. When WebKit tries to read the value back in Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystemPosix.h, it will pass a null pointer to g_ascii_strtoull. This can cause segfault in WebKitNetworkProcess. 1094475 1 lantw44 2015-05-13 09:57:48 -0700 This problem also causes WebKitNetworkProcess to segfault on FreeBSD because it doesn't support xattr. Fortunately, FreeBSD has st_birthtime field in struct stat, so we can reuse PLATFORM(COCOA) code in NetworkCacheFileSystemPosix.h. 1094476 2 253035 cgarcia 2015-05-13 09:59:24 -0700 Created attachment 253035 Patch 1094479 3 cgarcia 2015-05-13 10:02:48 -0700 (In reply to comment #1) > This problem also causes WebKitNetworkProcess to segfault on FreeBSD because > it doesn't support xattr. Fortunately, FreeBSD has st_birthtime field in > struct stat, so we can reuse PLATFORM(COCOA) code in > NetworkCacheFileSystemPosix.h. Cool, that's a different issue, though. Could you file another bug report for that? 1094732 4 cgarcia 2015-05-13 23:00:50 -0700 Committed r184330: <http://trac.webkit.org/changeset/184330> 1094738 5 lantw44 2015-05-13 23:21:35 -0700 (In reply to comment #3) > (In reply to comment #1) > > This problem also causes WebKitNetworkProcess to segfault on FreeBSD because > > it doesn't support xattr. Fortunately, FreeBSD has st_birthtime field in > > struct stat, so we can reuse PLATFORM(COCOA) code in > > NetworkCacheFileSystemPosix.h. > > Cool, that's a different issue, though. Could you file another bug report > for that? https://bugs.webkit.org/show_bug.cgi?id=144989 253035 2015-05-13 09:59:24 -0700 2015-05-13 10:12:16 -0700 Patch wk2-xattr-crash.diff text/plain 1562 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyYTViZTIyLi42MzkwNzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTUtMDUtMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBOZXR3b3JrIENhY2hlOiBOZXR3b3JrUHJvY2VzcyBzZWdmYXVs dCB3aGVuIGZpbGUgc3lzdGVtIGRvZXNuJ3Qgc3VwcG9ydCB4YXR0cnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDk1MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldHVybiBlYXJseSBpZiB3ZSBmYWls IHRvIGdldCB0aGUgYmlydGh0aW1lIHhhdHRyLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4Lmg6CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtDYWNoZTo6ZmlsZVRpbWVzKToKKwogMjAxNS0wNS0wNSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1NPVVBdIE5ldHdvcmsgQ2FjaGU6 IEltcGxlbWVudCBTaGFyZWFibGVSZXNvdXJjZSBmb3IgU291cCBhbmQgZW5hYmxlIGl0IGZvciBH VEsgcGxhdGZvcm0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2Nh Y2hlL05ldHdvcmtDYWNoZUZpbGVTeXN0ZW1Qb3NpeC5oIGIvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4LmgKaW5kZXggNzg5NzJk Zi4uYmE1ZTQ5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2Fj aGUvTmV0d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4LmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlRmlsZVN5c3RlbVBvc2l4LmgKQEAgLTkwLDYg KzkwLDggQEAgaW5saW5lIEZpbGVUaW1lcyBmaWxlVGltZXMoY29uc3QgU3RyaW5nJiBwYXRoKQog ICAgIGlmICghZmlsZUluZm8pCiAgICAgICAgIHJldHVybiB7IH07CiAgICAgY29uc3QgY2hhciog YmlydGh0aW1lU3RyaW5nID0gZ19maWxlX2luZm9fZ2V0X2F0dHJpYnV0ZV9zdHJpbmcoZmlsZUlu Zm8uZ2V0KCksICJ4YXR0cjo6YmlydGh0aW1lIik7CisgICAgaWYgKCFiaXJ0aHRpbWVTdHJpbmcp CisgICAgICAgIHJldHVybiB7IH07CiAgICAgcmV0dXJuIHsgc3RkOjpjaHJvbm86OnN5c3RlbV9j bG9jazo6ZnJvbV90aW1lX3QoZ19hc2NpaV9zdHJ0b3VsbChiaXJ0aHRpbWVTdHJpbmcsIG51bGxw dHIsIDEwKSksCiAgICAgICAgIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OmZyb21fdGltZV90 KGdfZmlsZV9pbmZvX2dldF9hdHRyaWJ1dGVfdWludDY0KGZpbGVJbmZvLmdldCgpLCAidGltZTo6 bW9kaWZpZWQiKSkgfTsKICNlbmRpZgo=