144949 2015-05-13 01:37:13 -0700 REGRESSION(r183770): Crash inside WebEditorClient::shouldApplyStyle when applying underline 2015-05-13 15:00:07 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa darin enrica oldest_to_newest 1094437 0 rniwa 2015-05-13 01:37:13 -0700 > 1 com.apple.WebKitLegacy 0x7fff8b329185 WebEditorClient::shouldApplyStyle(WebCore::StyleProperties*, WebCore::Range*) + 0x15 2 com.apple.WebCore 0x7fff87e6864c WebCore::Editor::applyStyleToSelection(WTF::Ref<WebCore::EditingStyle>&&, WebCore::EditAction) + 0x9c 3 com.apple.WebCore 0x7fff87e77c4c WebCore::applyCommandToFrame(WebCore::Frame&, WebCore::EditorCommandSource, WebCore::EditAction, WTF::Ref<WebCore::EditingStyle>&&) + 0x5c 4 com.apple.WebCore 0x7fff87e77698 WebCore::executeUnderline(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 0x68 5 com.apple.WebCore 0x7fff87ba7d86 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const + 0xb6 6 com.apple.WebKitLegacy 0x7fff8b2cd819 -[WebHTMLView executeCoreCommandBySelector:] + 0x69 1094438 1 rniwa 2015-05-13 01:37:27 -0700 <rdar://problem/20895753> 1094442 2 253026 rniwa 2015-05-13 01:52:58 -0700 Created attachment 253026 Fixes the crash 1094584 3 253026 rniwa 2015-05-13 14:13:25 -0700 Comment on attachment 253026 Fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=253026&action=review Thanks for the review! > LayoutTests/ChangeLog:12 > + * editing/style/underline-by-user.html: Added. Oops, I forgot to add -expected.txt in svn. Will do that before landing it. 1094598 4 rniwa 2015-05-13 15:00:07 -0700 Committed r184308: <http://trac.webkit.org/changeset/184308> 253026 2015-05-13 01:52:58 -0700 2015-05-13 12:03:03 -0700 Fixes the crash bug-144949-20150513015142.patch text/plain 6180 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4NDI4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTA1LTEzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE4Mzc3MCk6 IENyYXNoIGluc2lkZSBXZWJFZGl0b3JDbGllbnQ6OnNob3VsZEFwcGx5U3R5bGUgd2hlbiBhcHBs eWluZyB1bmRlcmxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0NDk0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBjcmFzaCB3YXMgY2F1c2VkIGJ5IHRoZSB2YXJpYW50IG9mIGFwcGx5U3R5bGVU b1NlbGVjdGlvbiB0aGF0IHRha2VzIEVkaXRpbmdTdHlsZSBwYXNzaW5nCisgICAgICAgIGEgbnVs bCBwb2ludGVyIHRvIHNob3VsZEFwcGx5U3R5bGUgd2hlbiB3ZSdyZSBvbmx5IGFwcGx5aW5nIHRl eHQgZGVjb3JhdGlvbiBjaGFuZ2VzIHNvIHRoYXQKKyAgICAgICAgbV9tdXRhYmxlU3R5bGUgaW4g dGhlIGVkaXRpbmcgc3R5bGUgaXMgbnVsbC4gVGhpcyBkaWRuJ3QgcmVwcm9kdWNlIGluIGV4ZWND b21tYW5kIHNpbmNlIHdlCisgICAgICAgIHdvdWxkbid0IGNhbGwgc2hvdWxkQXBwbHlTdHlsZSBp biB0aGF0IGNhc2UuIEl0IGRpZG4ndCByZXByb2R1Y2UgaW4gbXkgbWFudWFsIHRlc3RpbmcgYmVj YXVzZQorICAgICAgICBmb250IHBhbmVsIGFsc28gc2V0cyB0ZXh0IHNoYWRvdywgd2hpY2ggZW5k cyB1cCBmaWxsaW5nIHVwIG1fbXV0YWJsZVN0eWxlLgorCisgICAgICAgIEZpeGVkIHRoZSBidWcg YnkgY3JlYXRpbmcgYSBtdXRhYmxlIHN0eWxlIHByb3BlcnRpZXMgd2hlbiBvbmUgaXMgbm90IHBy b3ZpZGVkIGJ5IEVkaXRpbmdTdHlsZS4KKyAgICAgICAgQWxzbyBmaXhlZCB0aGUgIkZJWE1FIiBp biB0aGUgZnVuY3Rpb24gYnkgY29udmVydGluZyB0ZXh0IGRlY29yYXRpb24gY2hhbmdlcyB0byBh IGNvcnJlc3BvbmRpbmcKKyAgICAgICAgdGV4dCBkZWNvcmF0aW9uIHZhbHVlLiBUaGUgdmFsdWVz IHBhc3NlZCB0byBzaG91bGRBcHBseVN0eWxlIG5vdyBtYXRjaGVzIHRoZSBvbGQgYmVoYXZpb3Ig cHJpb3IKKyAgICAgICAgdG8gcjE4Mzc3MC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL3N0eWxl L3VuZGVybGluZS1ieS11c2VyLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvRWRpdGluZ1N0eWxl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRpbmdTdHlsZTo6c3R5bGVXaXRoUmVzb2x2ZWRU ZXh0RGVjb3JhdGlvbnMpOiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL0VkaXRpbmdTdHlsZS5o OgorICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRv cjo6YXBwbHlTdHlsZVRvU2VsZWN0aW9uKTogVXNlIHN0eWxlV2l0aFJlc29sdmVkVGV4dERlY29y YXRpb25zIHRvIGF2b2lkIHRoZSBjcmFzaC4KKwogMjAxNS0wNS0xMiAgWmFuIERvYmVyc2VrICA8 emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVkdWNlIFRyYW5zZm9ybWF0aW9uTWF0 cml4IGNvcGllcyBpbiBNYXRyaXhUcmFuc2Zvcm1PcGVyYXRpb24sIE1hdHJpeDNEVHJhbnNmb3Jt T3BlcmF0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nU3R5bGUuY3BwCShy ZXZpc2lvbiAxODQyMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUyNSw2ICs1MjUsMjggQEAgYm9vbCBFZGl0aW5nU3R5bGU6 OmlzRW1wdHkoKSBjb25zdAogICAgICAgICAmJiB1bmRlcmxpbmVDaGFuZ2UoKSA9PSBUZXh0RGVj b3JhdGlvbkNoYW5nZTo6Tm9uZSAmJiBzdHJpa2VUaHJvdWdoQ2hhbmdlKCkgPT0gVGV4dERlY29y YXRpb25DaGFuZ2U6Ok5vbmU7CiB9CiAKK1JlZjxNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzPiBFZGl0 aW5nU3R5bGU6OnN0eWxlV2l0aFJlc29sdmVkVGV4dERlY29yYXRpb25zKCkgY29uc3QKK3sKKyAg ICBib29sIGhhc1RleHREZWNvcmF0aW9uQ2hhbmdlcyA9IHVuZGVybGluZUNoYW5nZSgpICE9IFRl eHREZWNvcmF0aW9uQ2hhbmdlOjpOb25lIHx8IHN0cmlrZVRocm91Z2hDaGFuZ2UoKSAhPSBUZXh0 RGVjb3JhdGlvbkNoYW5nZTo6Tm9uZTsKKyAgICBpZiAobV9tdXRhYmxlU3R5bGUgJiYgIWhhc1Rl eHREZWNvcmF0aW9uQ2hhbmdlcykKKyAgICAgICAgcmV0dXJuICptX211dGFibGVTdHlsZTsKKwor ICAgIFJlZjxNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzPiBzdHlsZSA9IG1fbXV0YWJsZVN0eWxlID8g bV9tdXRhYmxlU3R5bGUtPm11dGFibGVDb3B5KCkgOiBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjpj cmVhdGUoKTsKKworICAgIFJlZjxDU1NWYWx1ZUxpc3Q+IHZhbHVlTGlzdCA9IENTU1ZhbHVlTGlz dDo6Y3JlYXRlU3BhY2VTZXBhcmF0ZWQoKTsKKyAgICBpZiAodW5kZXJsaW5lQ2hhbmdlKCkgPT0g VGV4dERlY29yYXRpb25DaGFuZ2U6OkFkZCkKKyAgICAgICAgdmFsdWVMaXN0LT5hcHBlbmQoY3Nz VmFsdWVQb29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlVW5kZXJsaW5lKSk7Cisg ICAgaWYgKHN0cmlrZVRocm91Z2hDaGFuZ2UoKSA9PSBUZXh0RGVjb3JhdGlvbkNoYW5nZTo6QWRk KQorICAgICAgICB2YWx1ZUxpc3QtPmFwcGVuZChjc3NWYWx1ZVBvb2woKS5jcmVhdGVJZGVudGlm aWVyVmFsdWUoQ1NTVmFsdWVMaW5lVGhyb3VnaCkpOworCisgICAgaWYgKHZhbHVlTGlzdC0+bGVu Z3RoKCkpCisgICAgICAgIHN0eWxlLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eVRleHREZWNvcmF0 aW9uLCB2YWx1ZUxpc3QucHRyKCkpOworICAgIGVsc2UKKyAgICAgICAgc3R5bGUtPnNldFByb3Bl cnR5KENTU1Byb3BlcnR5VGV4dERlY29yYXRpb24sIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZUlkZW50 aWZpZXJWYWx1ZShDU1NWYWx1ZU5vbmUpKTsKKworICAgIHJldHVybiBzdHlsZTsKK30KKwogYm9v bCBFZGl0aW5nU3R5bGU6OnRleHREaXJlY3Rpb24oV3JpdGluZ0RpcmVjdGlvbiYgd3JpdGluZ0Rp cmVjdGlvbikgY29uc3QKIHsKICAgICBpZiAoIW1fbXV0YWJsZVN0eWxlKQpJbmRleDogU291cmNl L1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nU3R5bGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5oCShyZXZpc2lvbiAxODQyMjQpCisrKyBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL0VkaXRpbmdTdHlsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTIsNiAr MTEyLDcgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIH5FZGl0aW5nU3R5bGUoKTsKIAog ICAgIE11dGFibGVTdHlsZVByb3BlcnRpZXMqIHN0eWxlKCkgeyByZXR1cm4gbV9tdXRhYmxlU3R5 bGUuZ2V0KCk7IH0KKyAgICBSZWY8TXV0YWJsZVN0eWxlUHJvcGVydGllcz4gc3R5bGVXaXRoUmVz b2x2ZWRUZXh0RGVjb3JhdGlvbnMoKSBjb25zdDsKICAgICBib29sIHRleHREaXJlY3Rpb24oV3Jp dGluZ0RpcmVjdGlvbiYpIGNvbnN0OwogICAgIGJvb2wgaXNFbXB0eSgpIGNvbnN0OwogICAgIHZv aWQgc2V0U3R5bGUoUGFzc1JlZlB0cjxNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzPik7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxODQyMjQpCisrKyBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk0Nyw3ICs5NDcsNyBA QCB2b2lkIEVkaXRvcjo6YXBwbHlTdHlsZVRvU2VsZWN0aW9uKFJlZjxFCiAgICAgICAgIHJldHVy bjsKIAogICAgIC8vIEZJWE1FOiBUaGlzIGlzIHdyb25nIGZvciB0ZXh0IGRlY29yYXRpb25zIHNp bmNlIG1fbXV0YWJsZVN0eWxlIGlzIGVtcHR5LgotICAgIGlmICghY2xpZW50KCkgfHwgIWNsaWVu dCgpLT5zaG91bGRBcHBseVN0eWxlKHN0eWxlLT5zdHlsZSgpLCBtX2ZyYW1lLnNlbGVjdGlvbigp LnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpKQorICAgIGlmICghY2xpZW50KCkgfHwgIWNsaWVu dCgpLT5zaG91bGRBcHBseVN0eWxlKHN0eWxlLT5zdHlsZVdpdGhSZXNvbHZlZFRleHREZWNvcmF0 aW9ucygpLnB0cigpLCBtX2ZyYW1lLnNlbGVjdGlvbigpLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0 KCkpKQogICAgICAgICByZXR1cm47CiAKICAgICBhcHBseVN0eWxlKFdURjo6bW92ZShzdHlsZSks IGVkaXRpbmdBY3Rpb24pOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTg0MjgyKQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMDUtMTMg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTgzNzcwKTogQ3Jhc2ggaW5zaWRlIFdlYkVkaXRvckNsaWVudDo6c2hvdWxkQXBwbHlTdHlsZSB3 aGVuIGFwcGx5aW5nIHVuZGVybGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ0OTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRoYXQgZW11bGF0ZXMgdW5kZXJsaW5pbmcgb2Yg dGV4dCBieSB0aGUgdXNlci4gVW5saWtlIGRvY3VtZW50LmV4ZWNDb21tYW5kLAorICAgICAgICB0 ZXN0UnVubmVyLmV4ZWNDb21tYW5kIHNpbXVsYXRlcyBhIHVzZXIgaW5pdGlhdGVkIGVkaXRpbmcg Y29tbWFuZCBhbmQgdGhlcmVmb3JlIGludm9rZXMKKyAgICAgICAgc2hvdWxkQXBwbHlTdHlsZS4K KworICAgICAgICAqIGVkaXRpbmcvc3R5bGUvdW5kZXJsaW5lLWJ5LXVzZXIuaHRtbDogQWRkZWQu CisKIDIwMTUtMDUtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAg ICAgICAgZmFzdC90ZXh0L3NpbXBsZS1saW5lLWxheW91dC10ZXh0LXN0cm9rZS13aWR0aC5odG1s IGZhaWxzIG9uIFdpbmRvd3MKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc3R5bGUvdW5kZXJs aW5lLWJ5LXVzZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3N0eWxl L3VuZGVybGluZS1ieS11c2VyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0 aW5nL3N0eWxlL3VuZGVybGluZS1ieS11c2VyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwxMyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB1 c2VyIGluaXRpYWxpemVkIHVuZGVybGluaW5nIG9mIHRleHQuIFRvIG1hbnVhbGx5IHRlc3QsIHVu ZGVybGluZSAiaGVsbG8iIGJlbG93LiBXZWJLaXQgc2hvdWxkIG5vdCBjcmFzaC48L3A+Cis8ZGl2 IGlkPSJlZGl0b3IiIGNvbnRlbnRlZGl0YWJsZT5oZWxsbzwvZGl2PgorPHNjcmlwdD4KK2RvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdlZGl0b3InKS5mb2N1cygpOworZG9jdW1lbnQuZXhlY0NvbW1h bmQoJ3NlbGVjdEFsbCcsIGZhbHNlLCBudWxsKTsKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAg ICB0ZXN0UnVubmVyLmV4ZWNDb21tYW5kKCd1bmRlcmxpbmUnLCBmYWxzZSwgbnVsbCk7Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K