144941 2015-05-12 18:54:37 -0700 [GTK][CMake] Extra include directory when libnotify is present but disabled 2015-05-13 12:58:00 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro mrobinson oldest_to_newest 1094359 0 mcatanzaro 2015-05-12 18:54:37 -0700 if (LIBNOTIFY_FOUND) list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES ${LIBNOTIFY_INCLUDE_DIRS} ) endif () That should be if (USE_LIBNOTIFY) since we don't want to add the include directory if we're not using it. 1094509 1 253041 mcatanzaro 2015-05-13 12:03:05 -0700 Created attachment 253041 Patch 1094512 2 253041 mrobinson 2015-05-13 12:10:16 -0700 Comment on attachment 253041 Patch Ugh. Thanks. 1094553 3 253041 commit-queue 2015-05-13 12:57:58 -0700 Comment on attachment 253041 Patch Clearing flags on attachment: 253041 Committed r184298: <http://trac.webkit.org/changeset/184298> 1094554 4 commit-queue 2015-05-13 12:58:00 -0700 All reviewed patches have been landed. Closing bug. 253041 2015-05-13 12:03:05 -0700 2015-05-13 12:57:58 -0700 Patch bug-144941-20150513140142.patch text/plain 1288 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDI4OTVlMDVhOWRhOWYy M2QyNDZlZGZhNGI2OGZjMjg0ZjdkNjM2My4uOGQ3MmNjNzM2ODdkYmE3MmM2ZmQxM2NiMzQ0M2Qz OTAxNjU0N2RkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA1LTEzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtD TWFrZV0gRXh0cmEgaW5jbHVkZSBkaXJlY3Rvcnkgd2hlbiBsaWJub3RpZnkgaXMgcHJlc2VudCBi dXQgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0NDk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBMSUJOT1RJRllfSU5DTFVERV9ESVJTIHRvIFdlYktpdDJfSU5DTFVERV9ESVJFQ1RP UklFUyBvbmx5IGlmIFVTRV9MSUJOT1RJRlkgaXMgdHJ1ZSwKKyAgICAgICAgcmF0aGVyIHRoYW4g Y2hlY2tpbmcgTElCTk9USUZZX0ZPVU5ELgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6 CisKIDIwMTUtMDUtMTIgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2Uge05ldHdvcmssIFdlYn1Qcm9jZXNzUHJveHkgaW5oZXJpdCBmcm9tIFByb2Nlc3NU aHJvdHRsZUNsaWVudCBwcml2YXRlbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNzli NDJiMjIwMDdkYzcxMTBmMzA5ZWVlMWZjOTRjZjkwN2QyYzk1NC4uZDA1OTNmZDQ5Nzg0ZmIzZTEy ZTVhMTUyMTQ5MDljOGUxMDQ0ZTU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZv cm1HVEsuY21ha2UKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTQ5 NCw3ICs0OTQsNyBAQCBsaXN0KEFQUEVORCBXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVMKICAg ICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogKQogCi1pZiAoTElCTk9USUZZX0ZPVU5EKQoraWYg KFVTRV9MSUJOT1RJRlkpCiBsaXN0KEFQUEVORCBXZWJLaXQyX0lOQ0xVREVfRElSRUNUT1JJRVMK ICAgICAke0xJQk5PVElGWV9JTkNMVURFX0RJUlN9CiApCg==