144936 2015-05-12 16:25:21 -0700 AX: [Win] REGRESSION(r184213) breaks aria-menubar-menuitems.html 2015-05-12 20:43:55 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1094313 0 jdiggs 2015-05-12 16:25:21 -0700 As part of the fix for bug 144653, aria-menubar-menuitems.html was rewritten to be more cross-platform-friendly. Road to hell seems to be paved with good intentions. My guess is that for some reason accessibleElementById is failing on the win port. I'll see about modifying the test to use focusedElement again. 1094314 1 webkit-bug-importer 2015-05-12 16:25:35 -0700 <rdar://problem/20927122> 1094318 2 252998 jdiggs 2015-05-12 16:44:02 -0700 Created attachment 252998 Patch 1094319 3 jdiggs 2015-05-12 16:46:37 -0700 I'm *hoping* the attached will solve it. Note that the test will still fail because the expectations tree found here [1] looks very Mac-like and not Win-like. But if we get a tree rather than a TypeError, it will be progress. :) [1]https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r184217%20(51780)/accessibility/aria-menubar-menuitems-pretty-diff.html 1094320 4 jdiggs 2015-05-12 16:57:00 -0700 Chris: I'm playing "guess how I broke Win". This is just a change to the layout test, which works as expected for Gtk and Mac. Unless you have a better idea, r? 1094325 5 jdiggs 2015-05-12 17:09:00 -0700 See also bug 140798 which makes me suspect my hunch is correct. 1094350 6 252998 commit-queue 2015-05-12 18:44:53 -0700 Comment on attachment 252998 Patch Clearing flags on attachment: 252998 Committed r184227: <http://trac.webkit.org/changeset/184227> 1094351 7 commit-queue 2015-05-12 18:44:57 -0700 All reviewed patches have been landed. Closing bug. 1094354 8 jdiggs 2015-05-12 18:47:05 -0700 Reopening. I don't believe the changed test will automatically pass. But I need the test to run to get the tree needed for the win platform expectations. When I have that, I'll attach it here. 1094371 9 253010 jdiggs 2015-05-12 19:47:26 -0700 Created attachment 253010 Patch 1094372 10 253010 jdiggs 2015-05-12 19:49:30 -0700 Comment on attachment 253010 Patch This is gardening. As a result of the change to the test, we're now getting an accessibility tree for Windows. The tree is consistent with the other ports and the original test results wrt Windows role mapping. 1094377 11 253010 commit-queue 2015-05-12 20:43:52 -0700 Comment on attachment 253010 Patch Clearing flags on attachment: 253010 Committed r184239: <http://trac.webkit.org/changeset/184239> 1094379 12 commit-queue 2015-05-12 20:43:55 -0700 All reviewed patches have been landed. Closing bug. 252998 2015-05-12 16:44:02 -0700 2015-05-12 19:47:22 -0700 Patch bug-144936-20150512194240.patch text/plain 1638 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzUxZGNkNWQyMWZlZjMzNzk0YTMw NjhiNTUxZDZiNWNkOWE1ZjA2NC4uY2IyMTFjNDZmMzFlNmQ4ZTg2MTVmODA4MjVmNWJmNTA1OGJj NWQ4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA1LTEyICBKb2FubWFyaWUgRGlnZ3Mg IDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW1dpbl0gUkVHUkVTU0lPTihyMTg0 MjEzKSBicmVha3MgYXJpYS1tZW51YmFyLW1lbnVpdGVtcy5odG1sCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5MzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgZm9jdXNlZEVsZW1lbnQgKyBjaGls ZEF0SW5kZXggcmF0aGVyIHRoYW4gYWNjZXNzaWJsZUVsZW1lbnRCeUlkCisgICAgICAgIGFzIHRo ZSBsYXR0ZXIgc2VlbXMgdG8gYmUgZmFpbGluZywgYW5kIHRoZSBmb3JtZXIgd29ya2VkIG9uIFdp bmRvd3MKKyAgICAgICAgdG8gZ2V0IHRoZSBtZW51YmFyIGluIHRoZSBvcmlnaW5hbCB2ZXJzaW9u IG9mIHRoaXMgdGVzdC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1tZW51YmFyLW1l bnVpdGVtcy5odG1sOiBNb2RpZmllZC4KKwogMjAxNS0wNS0xMiAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE3NTYxNyk6IFNvbWUgdGV4dCBk b2Vzbid0IHJlbmRlciBvbiBpbnRlcm5hdGlvbmFsY3VsaW5hcnljZW50ZXIuY29tCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbWVudWJhci1tZW51aXRlbXMuaHRt bCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tZW51YmFyLW1lbnVpdGVtcy5odG1s CmluZGV4IGU0ZTk0N2I5ZjgzMWUyMjM0ODNmYTJhOGU5YzJhMmUxM2U4ODgxMzkuLjNmOGY2ZDBh YjBiYWUzZjUyNGY0ZWQzYTczYmNjMWE0NjQwNWEwYTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvYXJpYS1tZW51YmFyLW1lbnVpdGVtcy5odG1sCisrKyBiL0xheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tZW51YmFyLW1lbnVpdGVtcy5odG1sCkBAIC0zOCw3ICsz OCw5IEBAIGlmICh3aW5kb3cubGF5b3V0Q29udHJvbGxlcikgewogfQogCiBpZiAod2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7Ci0gICAgd2luZG93Lm1lbnVCYXIgPSBhY2Nlc3NpYmls aXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoIm1lbnViYXIiKTsKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiYm9keSIpLmZvY3VzKCk7CisgICAgdmFyIHdlYkFyZWEgPSBh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudDsKKyAgICB2YXIgbWVudUJhciA9 IHdlYkFyZWEuY2hpbGRBdEluZGV4KDApOwogICAgIGR1bXBBY2Nlc3NpYmlsaXR5VHJlZShtZW51 QmFyLCBudWxsLCAwLCBmYWxzZSwgdHJ1ZSk7CiB9CiA8L3NjcmlwdD4K 253010 2015-05-12 19:47:26 -0700 2015-05-12 20:43:52 -0700 Patch bug-144936-20150512224604.patch text/plain 2120 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTg0MjMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDk3ZWM4MTAzMGIwYTgyODU1YjUw NmM0NzU2ODAxMWViZWFkYWMzOC4uNjYzNjU0NWJlODVhMzJhZTNmZGMzM2Q0ZWRiMzkwODNjYjgw OWZlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMyw2ICszLDE4IEBACiAgICAgICAgIEFYOiBbV2luXSBSRUdSRVNTSU9O KHIxODQyMTMpIGJyZWFrcyBhcmlhLW1lbnViYXItbWVudWl0ZW1zLmh0bWwKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0NDkzNgogCisgICAgICAgIFVu cmV2aWV3ZWQgZ2FyZGVuaW5nLgorCisgICAgICAgIEFkZGluZyB0aGUgcGxhdGZvcm0tc3BlY2lm aWMgZXhwZWN0YXRpb25zIGZvciBXaW5kb3dzIG5vdyB0aGF0IHRoZQorICAgICAgICBhY2Nlc3Np YmlsaXR5IHRyZWUgaXMgYmVpbmcgY29ycmVjdGx5IGdlbmVyYXRlZCBmb3IgdGhpcyB0ZXN0Lgor CisgICAgICAgICogcGxhdGZvcm0vd2luL2FjY2Vzc2liaWxpdHkvYXJpYS1tZW51YmFyLW1lbnVp dGVtcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorCisyMDE1LTA1LTEyICBKb2FubWFyaWUgRGlnZ3Mg IDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW1dpbl0gUkVHUkVTU0lPTihyMTg0 MjEzKSBicmVha3MgYXJpYS1tZW51YmFyLW1lbnVpdGVtcy5odG1sCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQ5MzYKKwogICAgICAgICBSZXZpZXdl ZCBieSBDaHJpcyBGbGVpemFjaC4KIAogICAgICAgICBVc2UgZm9jdXNlZEVsZW1lbnQgKyBjaGls ZEF0SW5kZXggcmF0aGVyIHRoYW4gYWNjZXNzaWJsZUVsZW1lbnRCeUlkCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vYWNjZXNzaWJpbGl0eS9hcmlhLW1lbnViYXItbWVudWl0 ZW1zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9hY2Nlc3NpYmlsaXR5 L2FyaWEtbWVudWJhci1tZW51aXRlbXMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZiNGNjODFj ZjNmOGUwNzRlNDRkMzU2MGJjZGNjYzU5N2ViOGE4NGMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS93aW4vYWNjZXNzaWJpbGl0eS9hcmlhLW1lbnViYXItbWVudWl0ZW1z LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDI2IEBACitNZW51IDEKK01lbnUgaXRlbSAxLjEKK01l bnUgMgorTWVudSBpdGVtIDIuMQorTWVudSBpdGVtIDIuMgorQVhSb2xlOiBBWE1lbnVCYXIgQVhU aXRsZTogCisgICAgQVhSb2xlOiBBWFRhYiBBWFRpdGxlOiBNZW51IDEKKyAgICAgICAgQVhSb2xl OiBBWEdyb3VwIEFYVGl0bGU6IAorICAgICAgICAgICAgQVhSb2xlOiBBWFN0YXRpY1RleHQgQVhU aXRsZTogTWVudSAxCisgICAgICAgIEFYUm9sZTogcG9wdXAgbWVudSBBWFRpdGxlOiAKKyAgICAg ICAgICAgIEFYUm9sZTogQVhUYWIgQVhUaXRsZTogTWVudSBpdGVtIDEuMQorICAgIEFYUm9sZTog QVhUYWIgQVhUaXRsZTogTWVudSAyCisgICAgICAgIEFYUm9sZTogQVhHcm91cCBBWFRpdGxlOiAK KyAgICAgICAgICAgIEFYUm9sZTogQVhTdGF0aWNUZXh0IEFYVGl0bGU6IE1lbnUgMgorICAgICAg ICBBWFJvbGU6IHBvcHVwIG1lbnUgQVhUaXRsZTogCisgICAgICAgICAgICBBWFJvbGU6IEFYVGFi IEFYVGl0bGU6IE1lbnUgaXRlbSAyLjEKKyAgICAgICAgICAgIEFYUm9sZTogQVhUYWIgQVhUaXRs ZTogTWVudSBpdGVtIDIuMgorVGhpcyB0ZXN0cyB0aGF0IEFSSUEgbWVudSBpdGVtcyBhcmUgcHJv cGVybHkgZXhwb3NlZCBhcyBjaGlsZHJlbiBmb3IgbWVudSBiYXJzCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwo=